Complex classes like AbstractCsv often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use AbstractCsv, and based on these observations, apply Extract Interface, too.
1 | <?php |
||
28 | abstract class AbstractCsv implements ByteSequence |
||
29 | { |
||
30 | /** |
||
31 | * The stream filter mode (read or write) |
||
32 | * |
||
33 | * @var int |
||
34 | */ |
||
35 | protected $stream_filter_mode; |
||
36 | |||
37 | |||
38 | /** |
||
39 | * collection of stream filters |
||
40 | * |
||
41 | * @var bool[] |
||
42 | */ |
||
43 | protected $stream_filters = []; |
||
44 | |||
45 | /** |
||
46 | * The CSV document BOM sequence |
||
47 | * |
||
48 | * @var string|null |
||
49 | */ |
||
50 | protected $input_bom = null; |
||
51 | |||
52 | /** |
||
53 | * The Output file BOM character |
||
54 | * |
||
55 | * @var string |
||
56 | */ |
||
57 | protected $output_bom = ''; |
||
58 | |||
59 | /** |
||
60 | * the field delimiter (one character only) |
||
61 | * |
||
62 | * @var string |
||
63 | */ |
||
64 | protected $delimiter = ','; |
||
65 | |||
66 | /** |
||
67 | * the field enclosure character (one character only) |
||
68 | * |
||
69 | * @var string |
||
70 | */ |
||
71 | protected $enclosure = '"'; |
||
72 | |||
73 | /** |
||
74 | * the field escape character (one character only) |
||
75 | * |
||
76 | * @var string |
||
77 | */ |
||
78 | protected $escape = '\\'; |
||
79 | |||
80 | /** |
||
81 | * The CSV document |
||
82 | * |
||
83 | * @var SplFileObject|Stream |
||
84 | */ |
||
85 | protected $document; |
||
86 | |||
87 | /** |
||
88 | * New instance |
||
89 | * |
||
90 | * @param SplFileObject|Stream $document The CSV Object instance |
||
91 | */ |
||
92 | 22 | protected function __construct($document) |
|
93 | { |
||
94 | 22 | $this->document = $document; |
|
95 | 22 | list($this->delimiter, $this->enclosure, $this->escape) = $this->document->getCsvControl(); |
|
96 | 22 | } |
|
97 | |||
98 | /** |
||
99 | * {@inheritdoc} |
||
100 | */ |
||
101 | 24 | public function __destruct() |
|
102 | { |
||
103 | 24 | unset($this->document); |
|
104 | 24 | } |
|
105 | |||
106 | /** |
||
107 | * {@inheritdoc} |
||
108 | */ |
||
109 | 2 | public function __clone() |
|
110 | { |
||
111 | 2 | throw new Exception(sprintf('An object of class %s cannot be cloned', get_class($this))); |
|
112 | } |
||
113 | |||
114 | /** |
||
115 | * Return a new instance from a SplFileObject |
||
116 | * |
||
117 | * @param SplFileObject $file |
||
118 | * |
||
119 | * @return static |
||
120 | */ |
||
121 | 24 | public static function createFromFileObject(SplFileObject $file): self |
|
122 | { |
||
123 | 24 | return new static($file); |
|
124 | } |
||
125 | |||
126 | /** |
||
127 | * Return a new instance from a PHP resource stream |
||
128 | * |
||
129 | * @param resource $stream |
||
130 | * |
||
131 | * @return static |
||
132 | */ |
||
133 | 4 | public static function createFromStream($stream): self |
|
134 | { |
||
135 | 4 | return new static(new Stream($stream)); |
|
136 | } |
||
137 | |||
138 | /** |
||
139 | * Return a new instance from a string |
||
140 | * |
||
141 | * @param string $content the CSV document as a string |
||
142 | * |
||
143 | * @return static |
||
144 | */ |
||
145 | 4 | public static function createFromString(string $content): self |
|
146 | { |
||
147 | 4 | return new static(Stream::createFromString($content)); |
|
148 | } |
||
149 | |||
150 | /** |
||
151 | * Return a new instance from a file path |
||
152 | * |
||
153 | * @param string $path file path |
||
154 | * @param string $open_mode the file open mode flag |
||
155 | * @param resource|null $context the resource context |
||
156 | * |
||
157 | * @return static |
||
158 | */ |
||
159 | 2 | public static function createFromPath(string $path, string $open_mode = 'r+', $context = null): self |
|
160 | { |
||
161 | 2 | return new static(Stream::createFromPath($path, $open_mode, $context)); |
|
162 | } |
||
163 | |||
164 | /** |
||
165 | * Returns the current field delimiter |
||
166 | * |
||
167 | * @return string |
||
168 | */ |
||
169 | 10 | public function getDelimiter(): string |
|
170 | { |
||
171 | 10 | return $this->delimiter; |
|
172 | } |
||
173 | |||
174 | /** |
||
175 | * Returns the current field enclosure |
||
176 | * |
||
177 | * @return string |
||
178 | */ |
||
179 | 2 | public function getEnclosure(): string |
|
180 | { |
||
181 | 2 | return $this->enclosure; |
|
182 | } |
||
183 | |||
184 | /** |
||
185 | * Returns the current field escape character |
||
186 | * |
||
187 | * @return string |
||
188 | */ |
||
189 | 2 | public function getEscape(): string |
|
190 | { |
||
191 | 2 | return $this->escape; |
|
192 | } |
||
193 | |||
194 | /** |
||
195 | * Returns the BOM sequence in use on Output methods |
||
196 | * |
||
197 | * @return string |
||
198 | */ |
||
199 | 2 | public function getOutputBOM(): string |
|
200 | { |
||
201 | 2 | return $this->output_bom; |
|
202 | } |
||
203 | |||
204 | /** |
||
205 | * Returns the BOM sequence of the given CSV |
||
206 | * |
||
207 | * @return string |
||
208 | */ |
||
209 | 16 | public function getInputBOM(): string |
|
210 | { |
||
211 | 16 | if (null !== $this->input_bom) { |
|
212 | 2 | return $this->input_bom; |
|
213 | } |
||
214 | |||
215 | 16 | $this->document->setFlags(SplFileObject::READ_CSV); |
|
216 | 16 | $this->document->setCsvControl($this->delimiter, $this->enclosure, $this->escape); |
|
217 | 16 | $this->document->rewind(); |
|
218 | 16 | $this->input_bom = bom_match(implode(',', (array) $this->document->current())); |
|
219 | |||
220 | 16 | return $this->input_bom; |
|
221 | } |
||
222 | |||
223 | /** |
||
224 | * Returns the stream filter mode |
||
225 | * |
||
226 | * @return int |
||
227 | */ |
||
228 | 2 | public function getStreamFilterMode(): int |
|
229 | { |
||
230 | 2 | return $this->stream_filter_mode; |
|
231 | } |
||
232 | |||
233 | /** |
||
234 | * Tells whether the stream filter capabilities can be used |
||
235 | * |
||
236 | * @return bool |
||
237 | */ |
||
238 | 4 | public function supportsStreamFilter(): bool |
|
239 | { |
||
240 | 4 | return $this->document instanceof Stream; |
|
241 | } |
||
242 | |||
243 | /** |
||
244 | * Tell whether the specify stream filter is attach to the current stream |
||
245 | * |
||
246 | * @param string $filtername |
||
247 | * |
||
248 | * @return bool |
||
249 | */ |
||
250 | 2 | public function hasStreamFilter(string $filtername): bool |
|
254 | |||
255 | /** |
||
256 | * Retuns the CSV document as a Generator of string chunk |
||
257 | * |
||
258 | * @param int $length number of bytes read |
||
259 | * |
||
260 | * @throws Exception if the number of bytes is lesser than 1 |
||
261 | * |
||
262 | * @return Generator |
||
263 | */ |
||
264 | 10 | public function chunk(int $length): Generator |
|
265 | { |
||
266 | 10 | if ($length < 1) { |
|
267 | 2 | throw new Exception(sprintf('%s() expects the length to be a positive integer %d given', __METHOD__, $length)); |
|
268 | } |
||
281 | |||
282 | /** |
||
283 | * DEPRECATION WARNING! This method will be removed in the next major point release |
||
284 | * |
||
285 | * @deprecated deprecated since version 9.1.0 |
||
286 | * @see AbstractCsv::getContent |
||
287 | * |
||
288 | * Retrieves the CSV content |
||
289 | * |
||
290 | * @return string |
||
291 | */ |
||
292 | 2 | public function __toString(): string |
|
296 | |||
297 | /** |
||
298 | * Retrieves the CSV content |
||
299 | * |
||
300 | * @return string |
||
301 | */ |
||
302 | 12 | public function getContent(): string |
|
311 | |||
312 | /** |
||
313 | * Outputs all data on the CSV file |
||
314 | * |
||
315 | * @param string $filename CSV downloaded name if present adds extra headers |
||
316 | * |
||
317 | * @return int Returns the number of characters read from the handle |
||
318 | * and passed through to the output. |
||
319 | */ |
||
320 | 6 | public function output(string $filename = null): int |
|
332 | |||
333 | /** |
||
334 | * Send the CSV headers |
||
335 | * |
||
336 | * Adapted from Symfony\Component\HttpFoundation\ResponseHeaderBag::makeDisposition |
||
337 | * |
||
338 | * @param string|null $filename CSV disposition name |
||
339 | * |
||
340 | * @throws Exception if the submitted header is invalid according to RFC 6266 |
||
341 | * |
||
342 | * @see https://tools.ietf.org/html/rfc6266#section-4.3 |
||
343 | */ |
||
344 | 6 | protected function sendHeaders(string $filename) |
|
367 | |||
368 | /** |
||
369 | * Sets the field delimiter |
||
370 | * |
||
371 | * @param string $delimiter |
||
372 | * |
||
373 | * @throws Exception If the Csv control character is not one character only. |
||
374 | * |
||
375 | * @return static |
||
376 | */ |
||
377 | 12 | public function setDelimiter(string $delimiter): self |
|
392 | |||
393 | /** |
||
394 | * Reset dynamic object properties to improve performance |
||
395 | */ |
||
396 | 4 | protected function resetProperties() |
|
399 | |||
400 | /** |
||
401 | * Sets the field enclosure |
||
402 | * |
||
403 | * @param string $enclosure |
||
404 | * |
||
405 | * @throws Exception If the Csv control character is not one character only. |
||
406 | * |
||
407 | * @return static |
||
408 | */ |
||
409 | 2 | public function setEnclosure(string $enclosure): self |
|
424 | |||
425 | /** |
||
426 | * Sets the field escape character |
||
427 | * |
||
428 | * @param string $escape |
||
429 | * |
||
430 | * @throws Exception If the Csv control character is not one character only. |
||
431 | * |
||
432 | * @return static |
||
433 | */ |
||
434 | 2 | public function setEscape(string $escape): self |
|
449 | |||
450 | /** |
||
451 | * Sets the BOM sequence to prepend the CSV on output |
||
452 | * |
||
453 | * @param string $str The BOM sequence |
||
454 | * |
||
455 | * @return static |
||
456 | */ |
||
457 | 6 | public function setOutputBOM(string $str): self |
|
463 | |||
464 | /** |
||
465 | * append a stream filter |
||
466 | * |
||
467 | * @param string $filtername a string or an object that implements the '__toString' method |
||
468 | * @param mixed $params additional parameters for the filter |
||
469 | * |
||
470 | * @throws Exception If the stream filter API can not be used |
||
471 | * |
||
472 | * @return static |
||
473 | */ |
||
474 | 10 | public function addStreamFilter(string $filtername, $params = null): self |
|
487 | } |
||
488 |