Complex classes like Container often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use Container, and based on these observations, apply Extract Interface, too.
1 | <?php |
||
16 | class Container implements ContainerInterface |
||
17 | { |
||
18 | /** |
||
19 | * @var \League\Container\Definition\DefinitionFactoryInterface |
||
20 | */ |
||
21 | protected $definitionFactory; |
||
22 | |||
23 | /** |
||
24 | * @var \League\Container\Definition\DefinitionInterface[] |
||
25 | */ |
||
26 | protected $definitions = []; |
||
27 | |||
28 | /** |
||
29 | * @var \League\Container\Definition\DefinitionInterface[] |
||
30 | */ |
||
31 | protected $sharedDefinitions = []; |
||
32 | |||
33 | /** |
||
34 | * @var \League\Container\Inflector\InflectorAggregateInterface |
||
35 | */ |
||
36 | protected $inflectors; |
||
37 | |||
38 | /** |
||
39 | * @var \League\Container\ServiceProvider\ServiceProviderAggregateInterface |
||
40 | */ |
||
41 | protected $providers; |
||
42 | |||
43 | /** |
||
44 | * @var array |
||
45 | */ |
||
46 | protected $shared = []; |
||
47 | |||
48 | /** |
||
49 | * @var \Interop\Container\ContainerInterface[] |
||
50 | */ |
||
51 | protected $delegates = []; |
||
52 | |||
53 | /** |
||
54 | * @var bool |
||
55 | */ |
||
56 | protected $isProtected = false; |
||
57 | |||
58 | /** |
||
59 | 42 | * Constructor. |
|
60 | * |
||
61 | * @param \League\Container\ServiceProvider\ServiceProviderAggregateInterface|null $providers |
||
62 | * @param \League\Container\Inflector\InflectorAggregateInterface|null $inflectors |
||
63 | * @param \League\Container\Definition\DefinitionFactoryInterface|null $definitionFactory |
||
64 | */ |
||
65 | 42 | public function __construct( |
|
66 | 42 | ServiceProviderAggregateInterface $providers = null, |
|
67 | 42 | InflectorAggregateInterface $inflectors = null, |
|
68 | DefinitionFactoryInterface $definitionFactory = null |
||
69 | 42 | ) { |
|
70 | 42 | // set required dependencies |
|
71 | 42 | $this->providers = (is_null($providers)) |
|
72 | ? (new ServiceProviderAggregate)->setContainer($this) |
||
73 | 42 | : $providers->setContainer($this); |
|
74 | 42 | ||
75 | 42 | $this->inflectors = (is_null($inflectors)) |
|
76 | 42 | ? (new InflectorAggregate)->setContainer($this) |
|
77 | : $inflectors->setContainer($this); |
||
78 | |||
79 | $this->definitionFactory = (is_null($definitionFactory)) |
||
80 | ? (new DefinitionFactory)->setContainer($this) |
||
81 | 30 | : $definitionFactory->setContainer($this); |
|
82 | } |
||
83 | 30 | ||
84 | /** |
||
85 | 30 | * {@inheritdoc} |
|
86 | 12 | */ |
|
87 | 12 | public function get($alias, array $args = []) |
|
88 | 12 | { |
|
89 | $service = $this->getFromThisContainer($alias, $args); |
||
90 | 30 | ||
91 | 24 | if ($service === false && $this->providers->provides($alias)) { |
|
92 | $this->providers->register($alias); |
||
93 | $service = $this->getFromThisContainer($alias, $args); |
||
94 | 12 | } |
|
95 | 6 | ||
96 | if ($service !== false) { |
||
97 | return $service; |
||
98 | 6 | } |
|
99 | 6 | ||
100 | 6 | if ($resolved = $this->getFromDelegate($alias, $args)) { |
|
101 | return $this->inflectors->inflect($resolved); |
||
102 | } |
||
103 | |||
104 | throw new NotFoundException( |
||
105 | sprintf('Alias (%s) is not being managed by the container', $alias) |
||
106 | 18 | ); |
|
107 | } |
||
108 | 18 | ||
109 | 12 | /** |
|
110 | * {@inheritdoc} |
||
111 | */ |
||
112 | 9 | public function has($alias) |
|
113 | 3 | { |
|
114 | if (array_key_exists($alias, $this->definitions) || $this->hasShared($alias)) { |
||
115 | return true; |
||
116 | 9 | } |
|
117 | |||
118 | if ($this->providers->provides($alias)) { |
||
119 | return true; |
||
120 | } |
||
121 | |||
122 | return $this->hasInDelegate($alias); |
||
123 | } |
||
124 | |||
125 | /** |
||
126 | 36 | * Returns a boolean to determine if the container has a shared instance of an alias. |
|
127 | * |
||
128 | 36 | * @param string $alias |
|
129 | * @param boolean $resolved |
||
130 | 36 | * @return boolean |
|
131 | */ |
||
132 | public function hasShared($alias, $resolved = false) |
||
133 | { |
||
134 | $shared = ($resolved === false) ? array_merge($this->shared, $this->sharedDefinitions) : $this->shared; |
||
135 | |||
136 | 30 | return (array_key_exists($alias, $shared)); |
|
137 | } |
||
138 | 30 | ||
139 | 3 | /** |
|
140 | 3 | * {@inheritdoc} |
|
141 | */ |
||
142 | 30 | public function add($alias, $concrete = null, $share = false) |
|
143 | { |
||
144 | 30 | if (is_null($concrete)) { |
|
145 | 27 | $concrete = $alias; |
|
146 | 9 | } |
|
147 | 9 | ||
148 | 21 | if ($this->isProtected() && $this->has($alias)) { |
|
149 | throw new ProtectedException('Container has been protected, overriding services is not allowed.'); |
||
150 | } |
||
151 | 27 | ||
152 | $definition = $this->definitionFactory->getDefinition($alias, $concrete); |
||
153 | |||
154 | if ($definition instanceof DefinitionInterface) { |
||
155 | 3 | if ($share === false) { |
|
156 | 3 | $this->definitions[$alias] = $definition; |
|
157 | } else { |
||
158 | $this->sharedDefinitions[$alias] = $definition; |
||
159 | } |
||
160 | |||
161 | 21 | return $definition; |
|
162 | } |
||
163 | 21 | ||
164 | // dealing with a value that cannot build a definition |
||
165 | $this->shared[$alias] = $concrete; |
||
166 | } |
||
167 | |||
168 | /** |
||
169 | 12 | * {@inheritdoc} |
|
170 | */ |
||
171 | 12 | public function share($alias, $concrete = null) |
|
175 | |||
176 | /** |
||
177 | * {@inheritdoc} |
||
178 | */ |
||
179 | 6 | public function addServiceProvider($provider) |
|
180 | { |
||
185 | 6 | ||
186 | 3 | /** |
|
187 | * {@inheritdoc} |
||
188 | */ |
||
189 | 6 | public function extend($alias) |
|
207 | |||
208 | /** |
||
209 | * {@inheritdoc} |
||
210 | */ |
||
211 | public function inflector($type, callable $callback = null) |
||
215 | |||
216 | /** |
||
217 | * {@inheritdoc} |
||
218 | */ |
||
219 | public function call(callable $callable, array $args = []) |
||
223 | 9 | ||
224 | /** |
||
225 | 9 | * Marks the container as protected. |
|
226 | 3 | * |
|
227 | 3 | * Prevents overriding services and delegating to other containers once the container is marked as protected. |
|
228 | */ |
||
229 | 9 | public function protect() |
|
230 | { |
||
231 | $this->isProtected = true; |
||
232 | } |
||
233 | |||
234 | /** |
||
235 | * @return bool |
||
236 | */ |
||
237 | public function isProtected() |
||
241 | 3 | ||
242 | 3 | /** |
|
243 | * Delegate a backup container to be checked for services if it |
||
244 | 9 | * cannot be resolved via this container. |
|
245 | * |
||
246 | 6 | * @param \Interop\Container\ContainerInterface $container |
|
247 | * @return $this |
||
248 | */ |
||
249 | public function delegate(InteropContainerInterface $container) |
||
263 | 3 | ||
264 | 6 | /** |
|
265 | * Returns true if service is registered in one of the delegated backup containers. |
||
266 | 6 | * |
|
267 | * @param string $alias |
||
268 | * @return boolean |
||
269 | */ |
||
270 | public function hasInDelegate($alias) |
||
280 | |||
281 | /** |
||
282 | 27 | * Attempt to get a service from the stack of delegated backup containers. |
|
283 | 15 | * |
|
284 | 15 | * @param string $alias |
|
285 | 15 | * @param array $args |
|
286 | * @return mixed |
||
287 | */ |
||
288 | 24 | protected function getFromDelegate($alias, array $args = []) |
|
300 | |||
301 | /** |
||
302 | * Get a service that has been registered in this container. |
||
303 | * |
||
304 | * @param string $alias |
||
305 | * @param array $args |
||
306 | * @return mixed |
||
307 | */ |
||
308 | protected function getFromThisContainer($alias, array $args = []) |
||
328 | } |
||
329 |