ListBlockParser::getBlock() - Code Metrics - Inspection of "Refactor the parser implementation" - thephpleague/commonmark - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( b4ff9c...fbe6de )

by Colin

created 2020-05-03 14:20 UTC

ListBlockParser::getBlock() A

↳ Parent: ListBlockParser

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	2
CRAP Score	1

Importance

Changes

Metric	Value
dl	0
loc	4
ccs	2
cts	2
cp	1
rs	10
c	0
b	0
f	0
cc	1
nc	1
nop	0
crap	1

<?php

/*
 * This file is part of the league/commonmark package.
 *
 * (c) Colin O'Dell <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace League\CommonMark\Extension\CommonMark\Parser\Block;

use League\CommonMark\Extension\CommonMark\Node\Block\ListBlock;
use League\CommonMark\Extension\CommonMark\Node\Block\ListData;
use League\CommonMark\Extension\CommonMark\Node\Block\ListItem;
use League\CommonMark\Node\Block\AbstractBlock;
use League\CommonMark\Parser\Block\AbstractBlockContinueParser;
use League\CommonMark\Parser\Block\BlockContinue;
use League\CommonMark\Parser\Block\BlockContinueParserInterface;
use League\CommonMark\Parser\Cursor;

final class ListBlockParser extends AbstractBlockContinueParser
{
    /** @var ListBlock */
    private $block;

    /** @var bool */
    private $hadBlankLine = false;

    /** @var int */
    private $linesAfterBlank = 0;

    public function __construct(ListData $listData)
    {
        $this->block = new ListBlock($listData);
    }

    /**
     * @return ListBlock
     */
    public function getBlock(): AbstractBlock
    {
        return $this->block;
    }

    public function isContainer(): bool
    {
        return true;
    }

    public function canContain(AbstractBlock $childBlock): bool
    {
        if (!$childBlock instanceof ListItem) {
            return false;
        }

        // Another list item is being added to this list block.
        // If the previous line was blank, that means this list
        // block is "loose" (not tight).
        if ($this->hadBlankLine && $this->linesAfterBlank === 1) {
            $this->block->setTight(false);
            $this->hadBlankLine = false;
        }

        return true;
    }

    public function tryContinue(Cursor $cursor, BlockContinueParserInterface $activeBlockParser): ?BlockContinue
    {
        if ($cursor->isBlank()) {
            $this->hadBlankLine = true;
            $this->linesAfterBlank = 0;
        } elseif ($this->hadBlankLine) {
            $this->linesAfterBlank++;
        }

        // List blocks themselves don't have any markers, only list items. So try to stay in the list.
        // If there is a block start other than list item, canContain makes sure that this list is closed.
        return BlockContinue::at($cursor);
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
    }
}


1		<?php
2
3		/*
4		* This file is part of the league/commonmark package.
5		*
6		* (c) Colin O'Dell <[email protected]>
7		*
8		* For the full copyright and license information, please view the LICENSE
9		* file that was distributed with this source code.
10		*/
11
12		namespace League\CommonMark\Extension\CommonMark\Parser\Block;
13
14		use League\CommonMark\Extension\CommonMark\Node\Block\ListBlock;
15		use League\CommonMark\Extension\CommonMark\Node\Block\ListData;
16		use League\CommonMark\Extension\CommonMark\Node\Block\ListItem;
17		use League\CommonMark\Node\Block\AbstractBlock;
18		use League\CommonMark\Parser\Block\AbstractBlockContinueParser;
19		use League\CommonMark\Parser\Block\BlockContinue;
20		use League\CommonMark\Parser\Block\BlockContinueParserInterface;
21		use League\CommonMark\Parser\Cursor;
22
23		final class ListBlockParser extends AbstractBlockContinueParser
24		{
25		/** @var ListBlock */
26		private $block;
27
28		/** @var bool */
29		private $hadBlankLine = false;
30
31		/** @var int */
32		private $linesAfterBlank = 0;
33
34	282	public function __construct(ListData $listData)
35		{
36	282	$this->block = new ListBlock($listData);
37	282	}
38
39		/**
40		* @return ListBlock
41		*/
42	282	public function getBlock(): AbstractBlock
43		{
44	282	return $this->block;
45		}
46
47	264	public function isContainer(): bool
48		{
49	264	return true;
50		}
51
52	264	public function canContain(AbstractBlock $childBlock): bool
53		{
54	264	if (!$childBlock instanceof ListItem) {
55	57	return false;
56		}
57
58		// Another list item is being added to this list block.
59		// If the previous line was blank, that means this list
60		// block is "loose" (not tight).
61	264	if ($this->hadBlankLine && $this->linesAfterBlank === 1) {
62	21	$this->block->setTight(false);
63	21	$this->hadBlankLine = false;
64		}
65
66	264	return true;
67		}
68
69	222	public function tryContinue(Cursor $cursor, BlockContinueParserInterface $activeBlockParser): ?BlockContinue
70		{
71	222	if ($cursor->isBlank()) {
72	129	$this->hadBlankLine = true;
73	129	$this->linesAfterBlank = 0;
74	222	} elseif ($this->hadBlankLine) {
75	129	$this->linesAfterBlank++;
76		}
77
78		// List blocks themselves don't have any markers, only list items. So try to stay in the list.
79		// If there is a block start other than list item, canContain makes sure that this list is closed.
80	222	return BlockContinue::at($cursor);
		0 ignored issues – show Bug Best Practice introduced 2020-05-03 01:47 UTC by Report Bug Copy Issue Report The return type of `return \League\CommonMar...kContinue::at($cursor);` (`self`) is incompatible with the return type declared by the interface `League\CommonMark\Parser...rInterface::tryContinue` of type `League\CommonMark\Parser\Block\BlockContinue\|null`. If you return a value from a function or method, it should be a sub-type of the type that is given by the parent type f.e. an interface, or abstract method. This is more formally defined by the Lizkov substitution principle, and guarantees that classes that depend on the parent type can use any instance of a child type interchangably. This principle also belongs to the SOLID principles for object oriented design. Let’s take a look at an example: class Author { private $name; public function __construct($name) { $this->name = $name; } public function getName() { return $this->name; } } abstract class Post { public function getAuthor() { return 'Johannes'; } } class BlogPost extends Post { public function getAuthor() { return new Author('Johannes'); } } class ForumPost extends Post { /* ... */ } function my_function(Post $post) { echo strtoupper($post->getAuthor()); } Our function `my_function` expects a `Post` object, and outputs the author of the post. The base class `Post` returns a simple string and outputting a simple string will work just fine. However, the child class `BlogPost` which is a sub-type of `Post` instead decided to return an `object`, and is therefore violating the SOLID principles. If a `BlogPost` were passed to `my_function`, PHP would not complain, but ultimately fail when executing the `strtoupper` call in its body. Loading history...
81		}
82		}
83

thephpleague / commonmark

Push — master ( b4ff9c...fbe6de )

ListBlockParser::getBlock() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like