Issues in AbstractInlineContainer.php - New Issues - Inspection of "Merge pull request #360 from thephpleague/cleanup" - thephpleague/commonmark - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( d37c6d...936e33 )

by Colin

created 2019-04-21 13:01 UTC

src/Inline/Element/AbstractInlineContainer.php (1 issue)

Labels

Severity

Major 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

/*
 * This file is part of the league/commonmark package.
 *
 * (c) Colin O'Dell <[email protected]>
 *
 * Original code based on the CommonMark JS reference parser (https://bitly.com/commonmark-js)
 *  - (c) John MacFarlane
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace League\CommonMark\Inline\Element;

@trigger_error('AbstractInlineContainer is deprecated and will be removed in a future version', E_USER_DEPRECATED);
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}

/**
 * @deprecated
 */
abstract class AbstractInlineContainer extends AbstractInline
{
    /**
     * @return bool
     */
    public function isContainer(): bool
    {
        return true;
    }
}


1			<?php
2
3			/*
4			* This file is part of the league/commonmark package.
5			*
6			* (c) Colin O'Dell <[email protected]>
7			*
8			* Original code based on the CommonMark JS reference parser (https://bitly.com/commonmark-js)
9			* - (c) John MacFarlane
10			*
11			* For the full copyright and license information, please view the LICENSE
12			* file that was distributed with this source code.
13			*/
14
15			namespace League\CommonMark\Inline\Element;
16
17			@trigger_error('AbstractInlineContainer is deprecated and will be removed in a future version', E_USER_DEPRECATED);
			1 ignored issue – show Security Best Practice introduced 2019-04-20 15:19 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended. If you suppress an error, we recommend checking for the error condition explicitly: // For example instead of @mkdir($dir); // Better use if (@mkdir($dir) === false) { throw new \RuntimeException('The directory '.$dir.' could not be created.'); } Loading history...
18
19			/**
20			* @deprecated
21			*/
22			abstract class AbstractInlineContainer extends AbstractInline
23			{
24			/**
25			* @return bool
26			*/
27			public function isContainer(): bool
28			{
29			return true;
30			}
31			}
32

thephpleague / commonmark

Push — master ( d37c6d...936e33 )

src/Inline/Element/AbstractInlineContainer.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like