Issues in HtmlBlockParser.php - Filtered Issues - Inspection of "Merge pull request #623 from thephpleague/descript..." - thephpleague/commonmark - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — latest ( 6c0640...3af091 )

by Colin

created 2021-05-31 19:25 UTC

CommonMark/Parser/Block/HtmlBlockParser.php (2 issues)

Labels

Bug 2

Severity

Minor 2

<?php

declare(strict_types=1);

/*
 * This file is part of the league/commonmark package.
 *
 * (c) Colin O'Dell <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace League\CommonMark\Extension\CommonMark\Parser\Block;

use League\CommonMark\Extension\CommonMark\Node\Block\HtmlBlock;
use League\CommonMark\Node\Block\AbstractBlock;
use League\CommonMark\Parser\Block\AbstractBlockContinueParser;
use League\CommonMark\Parser\Block\BlockContinue;
use League\CommonMark\Parser\Block\BlockContinueParserInterface;
use League\CommonMark\Parser\Cursor;
use League\CommonMark\Util\RegexHelper;

final class HtmlBlockParser extends AbstractBlockContinueParser
{
    /**
     * @var HtmlBlock
     *
     * @psalm-readonly
     */
    private $block;

    /** @var string */
    private $content = '';

    /** @var bool */
    private $finished = false;

    public function __construct(int $blockType)
    {
        $this->block = new HtmlBlock($blockType);
    }

    /**
     * @return HtmlBlock
     */
    public function getBlock(): AbstractBlock
    {
        return $this->block;
    }

    public function tryContinue(Cursor $cursor, BlockContinueParserInterface $activeBlockParser): ?BlockContinue
    {
        if ($this->finished) {
            return BlockContinue::none();
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {
        }

        if ($cursor->isBlank() && \in_array($this->block->getType(), [HtmlBlock::TYPE_6_BLOCK_ELEMENT, HtmlBlock::TYPE_7_MISC_ELEMENT], true)) {
            return BlockContinue::none();
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {
        }

        return BlockContinue::at($cursor);
    }

    public function addLine(string $line): void
    {
        if ($this->content !== '') {
            $this->content .= "\n";
        }

        $this->content .= $line;

        // Check for end condition
        // phpcs:disable SlevomatCodingStandard.ControlStructures.EarlyExit.EarlyExitNotUsed
        if ($this->block->getType() >= HtmlBlock::TYPE_1_CODE_CONTAINER && $this->block->getType() <= HtmlBlock::TYPE_5_CDATA) {
            if (\preg_match(RegexHelper::getHtmlBlockCloseRegex($this->block->getType()), $line) === 1) {
                $this->finished = true;
            }
        }
    }

    public function closeBlock(): void
    {
        $this->block->setLiteral($this->content);
        $this->content = '';
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		/*
6		* This file is part of the league/commonmark package.
7		*
8		* (c) Colin O'Dell <[email protected]>
9		*
10		* For the full copyright and license information, please view the LICENSE
11		* file that was distributed with this source code.
12		*/
13
14		namespace League\CommonMark\Extension\CommonMark\Parser\Block;
15
16		use League\CommonMark\Extension\CommonMark\Node\Block\HtmlBlock;
17		use League\CommonMark\Node\Block\AbstractBlock;
18		use League\CommonMark\Parser\Block\AbstractBlockContinueParser;
19		use League\CommonMark\Parser\Block\BlockContinue;
20		use League\CommonMark\Parser\Block\BlockContinueParserInterface;
21		use League\CommonMark\Parser\Cursor;
22		use League\CommonMark\Util\RegexHelper;
23
24		final class HtmlBlockParser extends AbstractBlockContinueParser
25		{
26		/**
27		* @var HtmlBlock
28		*
29		* @psalm-readonly
30		*/
31		private $block;
32
33		/** @var string */
34		private $content = '';
35
36		/** @var bool */
37		private $finished = false;
38
39	171	public function __construct(int $blockType)
40		{
41	171	$this->block = new HtmlBlock($blockType);
42	171	}
43
44		/**
45		* @return HtmlBlock
46		*/
47	171	public function getBlock(): AbstractBlock
48		{
49	171	return $this->block;
50		}
51
52	156	public function tryContinue(Cursor $cursor, BlockContinueParserInterface $activeBlockParser): ?BlockContinue
53		{
54	156	if ($this->finished) {
55	48	return BlockContinue::none();
		1 ignored issue – show Bug introduced 2020-06-27 13:42 UTC by Report Bug Copy Issue Report Show Similar Issues like this Are you sure the usage of `League\CommonMark\Parser...k\BlockContinue::none()` targeting `League\CommonMark\Parser...k\BlockContinue::none()` seems to always return null. This check looks for function or method calls that always return null and whose return value is used. class A { function getObject() { return null; } } $a = new A(); if ($a->getObject()) { The method `getObject()` can return nothing but null, so it makes no sense to use the return value. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
56		}
57
58	141	if ($cursor->isBlank() && \in_array($this->block->getType(), [HtmlBlock::TYPE_6_BLOCK_ELEMENT, HtmlBlock::TYPE_7_MISC_ELEMENT], true)) {
59	48	return BlockContinue::none();
		1 ignored issue – show Bug introduced 2020-06-27 13:42 UTC by Report Bug Copy Issue Report Show Similar Issues like this Are you sure the usage of `League\CommonMark\Parser...k\BlockContinue::none()` targeting `League\CommonMark\Parser...k\BlockContinue::none()` seems to always return null. This check looks for function or method calls that always return null and whose return value is used. class A { function getObject() { return null; } } $a = new A(); if ($a->getObject()) { The method `getObject()` can return nothing but null, so it makes no sense to use the return value. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
60		}
61
62	120	return BlockContinue::at($cursor);
63		}
64
65	171	public function addLine(string $line): void
66		{
67	171	if ($this->content !== '') {
68	120	$this->content .= "\n";
69		}
70
71	171	$this->content .= $line;
72
73		// Check for end condition
74		// phpcs:disable SlevomatCodingStandard.ControlStructures.EarlyExit.EarlyExitNotUsed
75	171	if ($this->block->getType() >= HtmlBlock::TYPE_1_CODE_CONTAINER && $this->block->getType() <= HtmlBlock::TYPE_5_CDATA) {
76	60	if (\preg_match(RegexHelper::getHtmlBlockCloseRegex($this->block->getType()), $line) === 1) {
77	57	$this->finished = true;
78		}
79		}
80	171	}
81
82	171	public function closeBlock(): void
83		{
84	171	$this->block->setLiteral($this->content);
85	171	$this->content = '';
86	171	}
87		}
88

thephpleague / commonmark

Push — latest ( 6c0640...3af091 )

CommonMark/Parser/Block/HtmlBlockParser.php (2 issues)

Labels

Severity

Introduced By

Duplication Side-by-Side

Filter issues like