Issues in ParagraphParser.php - All Issues - Inspection of "Merge branch '1.5' into latest" - thephpleague/commonmark - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — latest ( ba39d8...ca9086 )

by Colin

created 2020-08-18 01:52 UTC

src/Parser/Block/ParagraphParser.php (1 issue)

Labels

Bug 1

Severity

Minor 1

<?php

declare(strict_types=1);

/*
 * This file is part of the league/commonmark package.
 *
 * (c) Colin O'Dell <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace League\CommonMark\Parser\Block;

use League\CommonMark\Node\Block\AbstractBlock;
use League\CommonMark\Node\Block\Paragraph;
use League\CommonMark\Parser\Cursor;
use League\CommonMark\Parser\InlineParserEngineInterface;
use League\CommonMark\Reference\ReferenceInterface;
use League\CommonMark\Reference\ReferenceParser;

final class ParagraphParser extends AbstractBlockContinueParser
{
    /**
     * @var Paragraph
     *
     * @psalm-readonly
     */
    private $block;

    /**
     * @var ReferenceParser
     *
     * @psalm-readonly
     */
    private $referenceParser;

    public function __construct()
    {
        $this->block           = new Paragraph();
        $this->referenceParser = new ReferenceParser();
    }

    public function canHaveLazyContinuationLines(): bool
    {
        return true;
    }

    /**
     * @return Paragraph
     */
    public function getBlock(): AbstractBlock
    {
        return $this->block;
    }

    public function tryContinue(Cursor $cursor, BlockContinueParserInterface $activeBlockParser): ?BlockContinue
    {
        if ($cursor->isBlank()) {
            return BlockContinue::none();
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {
        }

        return BlockContinue::at($cursor);
    }

    public function addLine(string $line): void
    {
        $this->referenceParser->parse($line);
    }

    public function closeBlock(): void
    {
        if ($this->referenceParser->hasReferences() && $this->referenceParser->getParagraphContent() === '') {
            $this->block->detach();
        }
    }

    public function parseInlines(InlineParserEngineInterface $inlineParser): void
    {
        $content = $this->getContentString();
        if ($content !== '') {
            $inlineParser->parse($content, $this->block);
        }
    }

    public function getContentString(): string
    {
        return $this->referenceParser->getParagraphContent();
    }

    /**
     * @return ReferenceInterface[]
     */
    public function getReferences(): iterable
    {
        return $this->referenceParser->getReferences();
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		/*
6		* This file is part of the league/commonmark package.
7		*
8		* (c) Colin O'Dell <[email protected]>
9		*
10		* For the full copyright and license information, please view the LICENSE
11		* file that was distributed with this source code.
12		*/
13
14		namespace League\CommonMark\Parser\Block;
15
16		use League\CommonMark\Node\Block\AbstractBlock;
17		use League\CommonMark\Node\Block\Paragraph;
18		use League\CommonMark\Parser\Cursor;
19		use League\CommonMark\Parser\InlineParserEngineInterface;
20		use League\CommonMark\Reference\ReferenceInterface;
21		use League\CommonMark\Reference\ReferenceParser;
22
23		final class ParagraphParser extends AbstractBlockContinueParser
24		{
25		/**
26		* @var Paragraph
27		*
28		* @psalm-readonly
29		*/
30		private $block;
31
32		/**
33		* @var ReferenceParser
34		*
35		* @psalm-readonly
36		*/
37		private $referenceParser;
38
39	2463	public function __construct()
40		{
41	2463	$this->block = new Paragraph();
42	2463	$this->referenceParser = new ReferenceParser();
43	2463	}
44
45	57	public function canHaveLazyContinuationLines(): bool
46		{
47	57	return true;
48		}
49
50		/**
51		* @return Paragraph
52		*/
53	2463	public function getBlock(): AbstractBlock
54		{
55	2463	return $this->block;
56		}
57
58	972	public function tryContinue(Cursor $cursor, BlockContinueParserInterface $activeBlockParser): ?BlockContinue
59		{
60	972	if ($cursor->isBlank()) {
61	582	return BlockContinue::none();
		1 ignored issue – show Bug introduced 2020-06-27 13:42 UTC by Report Bug Copy Issue Report Show Similar Issues like this Are you sure the usage of `League\CommonMark\Parser...k\BlockContinue::none()` targeting `League\CommonMark\Parser...k\BlockContinue::none()` seems to always return null. This check looks for function or method calls that always return null and whose return value is used. class A { function getObject() { return null; } } $a = new A(); if ($a->getObject()) { The method `getObject()` can return nothing but null, so it makes no sense to use the return value. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
62		}
63
64	531	return BlockContinue::at($cursor);
65		}
66
67	2463	public function addLine(string $line): void
68		{
69	2463	$this->referenceParser->parse($line);
70	2463	}
71
72	2358	public function closeBlock(): void
73		{
74	2358	if ($this->referenceParser->hasReferences() && $this->referenceParser->getParagraphContent() === '') {
75	225	$this->block->detach();
76		}
77	2358	}
78
79	2358	public function parseInlines(InlineParserEngineInterface $inlineParser): void
80		{
81	2358	$content = $this->getContentString();
82	2358	if ($content !== '') {
83	2352	$inlineParser->parse($content, $this->block);
84		}
85	2358	}
86
87	2463	public function getContentString(): string
88		{
89	2463	return $this->referenceParser->getParagraphContent();
90		}
91
92		/**
93		* @return ReferenceInterface[]
94		*/
95	2463	public function getReferences(): iterable
96		{
97	2463	return $this->referenceParser->getReferences();
98		}
99		}
100

thephpleague / commonmark

Push — latest ( ba39d8...ca9086 )

src/Parser/Block/ParagraphParser.php (1 issue)

Labels

Severity

Introduced By

Duplication Side-by-Side

Filter issues like