HeadingParser - Code Metrics - Inspection of "Merge branch '1.5' into latest" - thephpleague/commonmark - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — latest ( ba39d8...ca9086 )

by Colin

created 2020-08-18 01:52 UTC

HeadingParser A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	31
Duplicated Lines	0 %

Test Coverage

Coverage

100%

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
wmc	4
eloc	8
dl	0
loc	31
ccs	10
cts	10
cp	1
rs	10
c	1
b	0
f	0

4 Methods

Rating	Name	Size	Complexity
A	__construct()	4	1
A	getBlock()	3	1
A	tryContinue()	3	1
A	parseInlines()	3	1

<?php

declare(strict_types=1);

/*
 * This file is part of the league/commonmark package.
 *
 * (c) Colin O'Dell <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace League\CommonMark\Extension\CommonMark\Parser\Block;

use League\CommonMark\Extension\CommonMark\Node\Block\Heading;
use League\CommonMark\Node\Block\AbstractBlock;
use League\CommonMark\Parser\Block\AbstractBlockContinueParser;
use League\CommonMark\Parser\Block\BlockContinue;
use League\CommonMark\Parser\Block\BlockContinueParserInterface;
use League\CommonMark\Parser\Cursor;
use League\CommonMark\Parser\InlineParserEngineInterface;

final class HeadingParser extends AbstractBlockContinueParser
{
    /**
     * @var Heading
     *
     * @psalm-readonly
     */
    private $block;

    /** @var string */
    private $content;

    public function __construct(int $level, string $content)
    {
        $this->block   = new Heading($level);
        $this->content = $content;
    }

    public function getBlock(): AbstractBlock
    {
        return $this->block;
    }

    public function tryContinue(Cursor $cursor, BlockContinueParserInterface $activeBlockParser): ?BlockContinue
    {
        return BlockContinue::none();
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {
    }

    public function parseInlines(InlineParserEngineInterface $inlineParser): void
    {
        $inlineParser->parse($this->content, $this->block);
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		/*
6		* This file is part of the league/commonmark package.
7		*
8		* (c) Colin O'Dell <[email protected]>
9		*
10		* For the full copyright and license information, please view the LICENSE
11		* file that was distributed with this source code.
12		*/
13
14		namespace League\CommonMark\Extension\CommonMark\Parser\Block;
15
16		use League\CommonMark\Extension\CommonMark\Node\Block\Heading;
17		use League\CommonMark\Node\Block\AbstractBlock;
18		use League\CommonMark\Parser\Block\AbstractBlockContinueParser;
19		use League\CommonMark\Parser\Block\BlockContinue;
20		use League\CommonMark\Parser\Block\BlockContinueParserInterface;
21		use League\CommonMark\Parser\Cursor;
22		use League\CommonMark\Parser\InlineParserEngineInterface;
23
24		final class HeadingParser extends AbstractBlockContinueParser
25		{
26		/**
27		* @var Heading
28		*
29		* @psalm-readonly
30		*/
31		private $block;
32
33		/** @var string */
34		private $content;
35
36	207	public function __construct(int $level, string $content)
37		{
38	207	$this->block = new Heading($level);
39	207	$this->content = $content;
40	207	}
41
42	207	public function getBlock(): AbstractBlock
43		{
44	207	return $this->block;
45		}
46
47	126	public function tryContinue(Cursor $cursor, BlockContinueParserInterface $activeBlockParser): ?BlockContinue
48		{
49	126	return BlockContinue::none();
		1 ignored issue – show Bug introduced 2020-06-27 13:42 UTC by Report Bug Copy Issue Report Are you sure the usage of `League\CommonMark\Parser...k\BlockContinue::none()` targeting `League\CommonMark\Parser...k\BlockContinue::none()` seems to always return null. This check looks for function or method calls that always return null and whose return value is used. class A { function getObject() { return null; } } $a = new A(); if ($a->getObject()) { The method `getObject()` can return nothing but null, so it makes no sense to use the return value. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
50		}
51
52	207	public function parseInlines(InlineParserEngineInterface $inlineParser): void
53		{
54	207	$inlineParser->parse($this->content, $this->block);
55	207	}
56		}
57

thephpleague / commonmark

Push — latest ( ba39d8...ca9086 )

HeadingParser A

Complexity

Size/Duplication

Test Coverage

Importance

4 Methods

Duplication Side-by-Side

Filter issues like