ListBlock::finalize() - Code Metrics - Inspection of "Refactor the parser implementation" - thephpleague/commonmark - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — refactor-parsing ( adbb6b...fbe6de )

by Colin

created 2020-05-03 14:10 UTC

ListBlock::finalize() B

↳ Parent: Project

Complexity

Conditions	10
Paths	6

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	13
CRAP Score	10.0363

Importance

Changes

Metric	Value
dl	0
loc	27
ccs	13
cts	14
cp	0.9286
rs	7.6666
c	0
b	0
f	0
cc	10
nc	6
nop	2
crap	10.0363

How to fix Complexity

<?php

/*
 * This file is part of the league/commonmark package.
 *
 * (c) Colin O'Dell <[email protected]>
 *
 * Original code based on the CommonMark JS reference parser (https://bitly.com/commonmark-js)
 *  - (c) John MacFarlane
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace League\CommonMark\Extension\CommonMark\Node\Block;

use League\CommonMark\Node\Block\AbstractBlock;

/**
 * @method children() AbstractBlock[]
 */
class ListBlock extends AbstractBlock
{
    const TYPE_BULLET = 'bullet';
    const TYPE_ORDERED = 'ordered';

    /**
     * @var bool
     */
    protected $tight = false;

    /**
     * @var ListData
     */
    protected $listData;

    public function __construct(ListData $listData)
    {
        $this->listData = $listData;
    }

    /**
     * @return ListData
     */
    public function getListData(): ListData
    {
        return $this->listData;
    }

    public function isTight(): bool
    {
        return $this->tight;
    }

    public function setTight(bool $tight): self
    {
        $this->tight = $tight;

        return $this;
    }
}


1		<?php
2
3		/*
4		* This file is part of the league/commonmark package.
5		*
6		* (c) Colin O'Dell <[email protected]>
7		*
8		* Original code based on the CommonMark JS reference parser (https://bitly.com/commonmark-js)
9		* - (c) John MacFarlane
10		*
11		* For the full copyright and license information, please view the LICENSE
12		* file that was distributed with this source code.
13		*/
14
15		namespace League\CommonMark\Extension\CommonMark\Node\Block;
16
17		use League\CommonMark\Node\Block\AbstractBlock;
18
19		/**
20		* @method children() AbstractBlock[]
21		*/
22		class ListBlock extends AbstractBlock
23		{
24		const TYPE_BULLET = 'bullet';
25		const TYPE_ORDERED = 'ordered';
26
27		/**
28		* @var bool
29		*/
30		protected $tight = false;
31
32		/**
33		* @var ListData
34		*/
35		protected $listData;
36
37	339	public function __construct(ListData $listData)
38		{
39	339	$this->listData = $listData;
40	339	}
41
42		/**
43		* @return ListData
44		*/
45	333	public function getListData(): ListData
46		{
47	333	return $this->listData;
48		}
49
50	315	public function isTight(): bool
51		{
52	315	return $this->tight;
53		}
54
55	285	public function setTight(bool $tight): self
56		{
57	285	$this->tight = $tight;
58
59	285	return $this;
60		}
61		}
62

thephpleague / commonmark

Push — refactor-parsing ( adbb6b...fbe6de )

ListBlock::finalize() B

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Complexity

Long Method

Duplication Side-by-Side

Filter issues like