Issues in HtmlBlockStartParser.php - All Issues - Inspection of "Merge pull request #560 from thephpleague/refine-i..." - thephpleague/commonmark - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — latest ( 609def...dcbb7e )

by Colin

created 2020-10-03 14:58 UTC

CommonMark/Parser/Block/HtmlBlockStartParser.php (2 issues)

Labels

Bug 2

Severity

Minor 2

<?php

declare(strict_types=1);

/*
 * This file is part of the league/commonmark package.
 *
 * (c) Colin O'Dell <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace League\CommonMark\Extension\CommonMark\Parser\Block;

use League\CommonMark\Node\Block\Paragraph;
use League\CommonMark\Parser\Block\BlockStart;
use League\CommonMark\Parser\Block\BlockStartParserInterface;
use League\CommonMark\Parser\Cursor;
use League\CommonMark\Parser\MarkdownParserStateInterface;
use League\CommonMark\Util\RegexHelper;

final class HtmlBlockStartParser implements BlockStartParserInterface
{
    public function tryStart(Cursor $cursor, MarkdownParserStateInterface $parserState): ?BlockStart
    {
        if ($cursor->isIndented() || $cursor->getNextNonSpaceCharacter() !== '<') {
            return BlockStart::none();
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {
        }

        $tmpCursor = clone $cursor;
        $tmpCursor->advanceToNextNonSpaceOrTab();
        $line = $tmpCursor->getRemainder();

        for ($blockType = 1; $blockType <= 7; $blockType++) {
            $match = RegexHelper::matchAt(
                RegexHelper::getHtmlBlockOpenRegex($blockType),
                $line
            );

            if ($match !== null && ($blockType < 7 || ! ($parserState->getLastMatchedBlockParser()->getBlock() instanceof Paragraph))) {
                return BlockStart::of(new HtmlBlockParser($blockType))->at($cursor);
            }
        }

        return BlockStart::none();
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		/*
6		* This file is part of the league/commonmark package.
7		*
8		* (c) Colin O'Dell <[email protected]>
9		*
10		* For the full copyright and license information, please view the LICENSE
11		* file that was distributed with this source code.
12		*/
13
14		namespace League\CommonMark\Extension\CommonMark\Parser\Block;
15
16		use League\CommonMark\Node\Block\Paragraph;
17		use League\CommonMark\Parser\Block\BlockStart;
18		use League\CommonMark\Parser\Block\BlockStartParserInterface;
19		use League\CommonMark\Parser\Cursor;
20		use League\CommonMark\Parser\MarkdownParserStateInterface;
21		use League\CommonMark\Util\RegexHelper;
22
23		final class HtmlBlockStartParser implements BlockStartParserInterface
24		{
25	1863	public function tryStart(Cursor $cursor, MarkdownParserStateInterface $parserState): ?BlockStart
26		{
27	1863	if ($cursor->isIndented() \|\| $cursor->getNextNonSpaceCharacter() !== '<') {
28	1617	return BlockStart::none();
		1 ignored issue – show Bug introduced 2020-06-27 13:42 UTC by Report Bug Copy Issue Report Show Similar Issues like this Are you sure the usage of `League\CommonMark\Parser\Block\BlockStart::none()` targeting `League\CommonMark\Parser\Block\BlockStart::none()` seems to always return null. This check looks for function or method calls that always return null and whose return value is used. class A { function getObject() { return null; } } $a = new A(); if ($a->getObject()) { The method `getObject()` can return nothing but null, so it makes no sense to use the return value. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
29		}
30
31	303	$tmpCursor = clone $cursor;
32	303	$tmpCursor->advanceToNextNonSpaceOrTab();
33	303	$line = $tmpCursor->getRemainder();
34
35	303	for ($blockType = 1; $blockType <= 7; $blockType++) {
36	303	$match = RegexHelper::matchAt(
37	303	RegexHelper::getHtmlBlockOpenRegex($blockType),
38	101	$line
39		);
40
41	303	if ($match !== null && ($blockType < 7 \|\| ! ($parserState->getLastMatchedBlockParser()->getBlock() instanceof Paragraph))) {
42	171	return BlockStart::of(new HtmlBlockParser($blockType))->at($cursor);
43		}
44		}
45
46	144	return BlockStart::none();
		1 ignored issue – show Bug introduced 2020-06-27 13:42 UTC by Report Bug Copy Issue Report Show Similar Issues like this Are you sure the usage of `League\CommonMark\Parser\Block\BlockStart::none()` targeting `League\CommonMark\Parser\Block\BlockStart::none()` seems to always return null. This check looks for function or method calls that always return null and whose return value is used. class A { function getObject() { return null; } } $a = new A(); if ($a->getObject()) { The method `getObject()` can return nothing but null, so it makes no sense to use the return value. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
47		}
48		}
49

thephpleague / commonmark

Push — latest ( 609def...dcbb7e )

CommonMark/Parser/Block/HtmlBlockStartParser.php (2 issues)

Labels

Severity

Introduced By

Duplication Side-by-Side

Filter issues like