Issues in FencedCodeStartParser.php - All Issues - Inspection of "Merge pull request #560 from thephpleague/refine-i..." - thephpleague/commonmark - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — latest ( 609def...dcbb7e )

by Colin

created 2020-10-03 14:58 UTC

CommonMark/Parser/Block/FencedCodeStartParser.php (3 issues)

Labels

Bug 3

Severity

Minor 3

<?php

declare(strict_types=1);

/*
 * This file is part of the league/commonmark package.
 *
 * (c) Colin O'Dell <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace League\CommonMark\Extension\CommonMark\Parser\Block;

use League\CommonMark\Parser\Block\BlockStart;
use League\CommonMark\Parser\Block\BlockStartParserInterface;
use League\CommonMark\Parser\Cursor;
use League\CommonMark\Parser\MarkdownParserStateInterface;

final class FencedCodeStartParser implements BlockStartParserInterface
{
    public function tryStart(Cursor $cursor, MarkdownParserStateInterface $parserState): ?BlockStart
    {
        if ($cursor->isIndented()) {
            return BlockStart::none();
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {
        }

        $c = $cursor->getCharacter();
        if ($c !== ' ' && $c !== "\t" && $c !== '`' && $c !== '~') {
            return BlockStart::none();
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {
        }

        $indent = $cursor->getIndent();
        $fence  = $cursor->match('/^[ \t]*(?:`{3,}(?!.*`)|^~{3,})/');
        if ($fence === null) {
            return BlockStart::none();
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {
        }

        // fenced code block
        $fence       = \ltrim($fence, " \t");
        $fenceLength = \strlen($fence);

        return BlockStart::of(new FencedCodeParser($fenceLength, $fence[0], $indent))->at($cursor);
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		/*
6		* This file is part of the league/commonmark package.
7		*
8		* (c) Colin O'Dell <[email protected]>
9		*
10		* For the full copyright and license information, please view the LICENSE
11		* file that was distributed with this source code.
12		*/
13
14		namespace League\CommonMark\Extension\CommonMark\Parser\Block;
15
16		use League\CommonMark\Parser\Block\BlockStart;
17		use League\CommonMark\Parser\Block\BlockStartParserInterface;
18		use League\CommonMark\Parser\Cursor;
19		use League\CommonMark\Parser\MarkdownParserStateInterface;
20
21		final class FencedCodeStartParser implements BlockStartParserInterface
22		{
23	1950	public function tryStart(Cursor $cursor, MarkdownParserStateInterface $parserState): ?BlockStart
24		{
25	1950	if ($cursor->isIndented()) {
26	186	return BlockStart::none();
		1 ignored issue – show Bug introduced 2020-06-27 13:42 UTC by Report Bug Copy Issue Report Show Similar Issues like this Are you sure the usage of `League\CommonMark\Parser\Block\BlockStart::none()` targeting `League\CommonMark\Parser\Block\BlockStart::none()` seems to always return null. This check looks for function or method calls that always return null and whose return value is used. class A { function getObject() { return null; } } $a = new A(); if ($a->getObject()) { The method `getObject()` can return nothing but null, so it makes no sense to use the return value. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
27		}
28
29	1848	$c = $cursor->getCharacter();
30	1848	if ($c !== ' ' && $c !== "\t" && $c !== '`' && $c !== '~') {
31	1620	return BlockStart::none();
		1 ignored issue – show Bug introduced 2020-06-27 13:42 UTC by Report Bug Copy Issue Report Show Similar Issues like this Are you sure the usage of `League\CommonMark\Parser\Block\BlockStart::none()` targeting `League\CommonMark\Parser\Block\BlockStart::none()` seems to always return null. This check looks for function or method calls that always return null and whose return value is used. class A { function getObject() { return null; } } $a = new A(); if ($a->getObject()) { The method `getObject()` can return nothing but null, so it makes no sense to use the return value. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
32		}
33
34	303	$indent = $cursor->getIndent();
35	303	$fence = $cursor->match('/^[ \t](?:`{3,}(?!.`)\|^~{3,})/');
36	303	if ($fence === null) {
37	195	return BlockStart::none();
		1 ignored issue – show Bug introduced 2020-06-27 13:42 UTC by Report Bug Copy Issue Report Show Similar Issues like this Are you sure the usage of `League\CommonMark\Parser\Block\BlockStart::none()` targeting `League\CommonMark\Parser\Block\BlockStart::none()` seems to always return null. This check looks for function or method calls that always return null and whose return value is used. class A { function getObject() { return null; } } $a = new A(); if ($a->getObject()) { The method `getObject()` can return nothing but null, so it makes no sense to use the return value. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
38		}
39
40		// fenced code block
41	108	$fence = \ltrim($fence, " \t");
42	108	$fenceLength = \strlen($fence);
43
44	108	return BlockStart::of(new FencedCodeParser($fenceLength, $fence[0], $indent))->at($cursor);
45		}
46		}
47

thephpleague / commonmark

Push — latest ( 609def...dcbb7e )

CommonMark/Parser/Block/FencedCodeStartParser.php (3 issues)

Labels

Severity

Introduced By

Duplication Side-by-Side

Filter issues like