| Conditions | 14 |
| Paths | 208 |
| Total Lines | 19 |
| Code Lines | 13 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 86 | private static function determineCanOpenOrClose(string $charBefore, string $charAfter, string $character, DelimiterProcessorInterface $delimiterProcessor): array |
||
| 87 | { |
||
| 88 | $afterIsWhitespace = \preg_match(RegexHelper::REGEX_UNICODE_WHITESPACE_CHAR, $charAfter); |
||
| 89 | $afterIsPunctuation = \preg_match(RegexHelper::REGEX_PUNCTUATION, $charAfter); |
||
| 90 | $beforeIsWhitespace = \preg_match(RegexHelper::REGEX_UNICODE_WHITESPACE_CHAR, $charBefore); |
||
| 91 | $beforeIsPunctuation = \preg_match(RegexHelper::REGEX_PUNCTUATION, $charBefore); |
||
| 92 | |||
| 93 | $leftFlanking = ! $afterIsWhitespace && (! $afterIsPunctuation || $beforeIsWhitespace || $beforeIsPunctuation); |
||
| 94 | $rightFlanking = ! $beforeIsWhitespace && (! $beforeIsPunctuation || $afterIsWhitespace || $afterIsPunctuation); |
||
| 95 | |||
| 96 | if ($character === '_') { |
||
| 97 | $canOpen = $leftFlanking && (! $rightFlanking || $beforeIsPunctuation); |
||
| 98 | $canClose = $rightFlanking && (! $leftFlanking || $afterIsPunctuation); |
||
| 99 | } else { |
||
| 100 | $canOpen = $leftFlanking && $character === $delimiterProcessor->getOpeningCharacter(); |
||
| 101 | $canClose = $rightFlanking && $character === $delimiterProcessor->getClosingCharacter(); |
||
| 102 | } |
||
| 103 | |||
| 104 | return [$canOpen, $canClose]; |
||
| 105 | } |
||
| 107 |