TableCellRenderer::render() - Code Metrics - Inspection of "Include function tests in code coverage calculatio..." - thephpleague/commonmark-ext-table - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( e5585d...67bac6 )

by Colin

created 2019-07-13 01:29 UTC

TableCellRenderer::render() A

↳ Parent: TableCellRenderer

Complexity

Conditions	5
Paths	7

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	7
CRAP Score	5.2742

Importance

Changes

Metric	Value
dl	0
loc	17
ccs	7
cts	9
cp	0.7778
rs	9.3888
c	0
b	0
f	0
cc	5
nc	7
nop	3
crap	5.2742

<?php

declare(strict_types=1);

/*
 * This is part of the league/commonmark-ext-table package.
 *
 * (c) Martin Hasoň <[email protected]>
 * (c) Webuni s.r.o. <[email protected]>
 * (c) Colin O'Dell <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace League\CommonMark\Ext\Table;

use League\CommonMark\Block\Element\AbstractBlock;
use League\CommonMark\Block\Renderer\BlockRendererInterface;
use League\CommonMark\ElementRendererInterface;
use League\CommonMark\HtmlElement;
use League\CommonMark\Util\Xml;

class TableCellRenderer implements BlockRendererInterface
{
    public function render(AbstractBlock $block, ElementRendererInterface $htmlRenderer, bool $inTightList = false)
    {
        if (!$block instanceof TableCell) {
            throw new \InvalidArgumentException('Incompatible block type: '.get_class($block));
        }

        $attrs = [];
        foreach ($block->getData('attributes', []) as $key => $value) {
            $attrs[$key] = Xml::escape($value);
        }

        if ($block->align) {
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
            $attrs['style'] = (isset($attrs['style']) ? $attrs['style'].' ' : '').'text-align: '.$block->align;
        }

        return new HtmlElement($block->type, $attrs, $htmlRenderer->renderInlines($block->children()));
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		/*
6		* This is part of the league/commonmark-ext-table package.
7		*
8		* (c) Martin Hasoň <[email protected]>
9		* (c) Webuni s.r.o. <[email protected]>
10		* (c) Colin O'Dell <[email protected]>
11		*
12		* For the full copyright and license information, please view the LICENSE
13		* file that was distributed with this source code.
14		*/
15
16		namespace League\CommonMark\Ext\Table;
17
18		use League\CommonMark\Block\Element\AbstractBlock;
19		use League\CommonMark\Block\Renderer\BlockRendererInterface;
20		use League\CommonMark\ElementRendererInterface;
21		use League\CommonMark\HtmlElement;
22		use League\CommonMark\Util\Xml;
23
24		class TableCellRenderer implements BlockRendererInterface
25		{
26	34	public function render(AbstractBlock $block, ElementRendererInterface $htmlRenderer, bool $inTightList = false)
27		{
28	34	if (!$block instanceof TableCell) {
29		throw new \InvalidArgumentException('Incompatible block type: '.get_class($block));
30		}
31
32	34	$attrs = [];
33	34	foreach ($block->getData('attributes', []) as $key => $value) {
34		$attrs[$key] = Xml::escape($value);
35		}
36
37	34	if ($block->align) {
		0 ignored issues – show Bug Best Practice introduced 2019-07-11 12:18 UTC by Report Bug Copy Issue Report The expression `$block->align` of type `null\|string` is loosely compared to `true`; this is ambiguous if the string can be empty. You might want to explicitly use `!== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history...
38	8	$attrs['style'] = (isset($attrs['style']) ? $attrs['style'].' ' : '').'text-align: '.$block->align;
39		}
40
41	34	return new HtmlElement($block->type, $attrs, $htmlRenderer->renderInlines($block->children()));
42		}
43		}
44

thephpleague / commonmark-ext-table

Push — master ( e5585d...67bac6 )

TableCellRenderer::render() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like