BindingEndpointResolverTest::test__does_not_modify_when_criteria_not_present() - Code Metrics - thephplab/lightsaml - Measure and Improve Code Quality continuously with Scrutinizer

test__does_not_modify_when_criteria_not_present() A
last analyzed 2020-07-28 16:14 UTC

↳ Parent: BindingEndpointResolverTest

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	15
c	0
b	0
f	0
rs	9.7666
cc	1
nc	1
nop	0

<?php

namespace LightSaml\Tests\Resolver\Endpoint;

use LightSaml\Criteria\CriteriaSet;
use LightSaml\Model\Metadata\EndpointReference;
use LightSaml\Model\Metadata\EntityDescriptor;
use LightSaml\Model\Metadata\SingleSignOnService;
use LightSaml\Model\Metadata\SpSsoDescriptor;
use LightSaml\Resolver\Endpoint\BindingEndpointResolver;
use LightSaml\Resolver\Endpoint\Criteria\BindingCriteria;
use LightSaml\SamlConstants;
use LightSaml\Tests\BaseTestCase;

class BindingEndpointResolverTest extends BaseTestCase
{
    public function test__does_not_modify_when_criteria_not_present()
    {
        $candidates = [
            $firstEndpoint = $this->getMockBuilder(EndpointReference::class)->disableOriginalConstructor()->getMock(),
            $secondEndpoint = $this->getMockBuilder(EndpointReference::class)->disableOriginalConstructor()->getMock(),
        ];

        $resolver = new BindingEndpointResolver();

        $result = $resolver->resolve(new CriteriaSet([]), $candidates);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

        $this->assertCount(2, $result);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $this->assertSame($firstEndpoint, $result[0]);
        $this->assertSame($secondEndpoint, $result[1]);
    }

    public function test__filters_by_given_bindings()
    {
        $criteriaSet = new CriteriaSet([new BindingCriteria([
            SamlConstants::BINDING_SAML2_HTTP_POST,
            SamlConstants::BINDING_SAML2_HTTP_REDIRECT
        ])]);

        $candidates = [
            $firstEndpoint = new EndpointReference(
                new EntityDescriptor(),
                new SpSsoDescriptor(),
                (new SingleSignOnService())->setBinding(SamlConstants::BINDING_SAML2_SOAP)
            ),
            $secondEndpoint = new EndpointReference(
                new EntityDescriptor(),
                new SpSsoDescriptor(),
                (new SingleSignOnService())->setBinding(SamlConstants::BINDING_SAML2_HTTP_REDIRECT)
            ),
            $thirdEndpoint = new EndpointReference(
                new EntityDescriptor(),
                new SpSsoDescriptor(),
                (new SingleSignOnService())->setBinding(SamlConstants::BINDING_SAML2_HTTP_POST)
            ),
            $fourthEndpoint = new EndpointReference(
                new EntityDescriptor(),
                new SpSsoDescriptor(),
                (new SingleSignOnService())->setBinding(SamlConstants::BINDING_SAML2_HTTP_ARTIFACT)
            ),
        ];

        $resolver = new BindingEndpointResolver();

        $result = $resolver->resolve($criteriaSet, $candidates);

        $this->assertCount(2, $result);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $this->assertSame($thirdEndpoint, $result[0]);
        $this->assertSame($secondEndpoint, $result[1]);
    }
}


1			<?php
2
3			namespace LightSaml\Tests\Resolver\Endpoint;
4
5			use LightSaml\Criteria\CriteriaSet;
6			use LightSaml\Model\Metadata\EndpointReference;
7			use LightSaml\Model\Metadata\EntityDescriptor;
8			use LightSaml\Model\Metadata\SingleSignOnService;
9			use LightSaml\Model\Metadata\SpSsoDescriptor;
10			use LightSaml\Resolver\Endpoint\BindingEndpointResolver;
11			use LightSaml\Resolver\Endpoint\Criteria\BindingCriteria;
12			use LightSaml\SamlConstants;
13			use LightSaml\Tests\BaseTestCase;
14
15			class BindingEndpointResolverTest extends BaseTestCase
16			{
17			public function test__does_not_modify_when_criteria_not_present()
18			{
19			$candidates = [
20			$firstEndpoint = $this->getMockBuilder(EndpointReference::class)->disableOriginalConstructor()->getMock(),
21			$secondEndpoint = $this->getMockBuilder(EndpointReference::class)->disableOriginalConstructor()->getMock(),
22			];
23
24			$resolver = new BindingEndpointResolver();
25
26			$result = $resolver->resolve(new CriteriaSet([]), $candidates);
			0 ignored issues – show Documentation introduced 2020-07-28 16:14 UTC by Report Bug Copy Issue Report `$candidates` is of type `array<integer,object<PHP...kObject\\MockObject>"}>`, but the function expects a `array<integer,object<Lig...ata\EndpointReference>>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
27
28			$this->assertCount(2, $result);
			0 ignored issues – show Documentation introduced 2020-07-28 16:14 UTC by Report Bug Copy Issue Report `$result` is of type `array<integer,object<Lig...ata\EndpointReference>>`, but the function expects a `object<Countable>\|object...nit\Framework\iterable>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
29			$this->assertSame($firstEndpoint, $result[0]);
30			$this->assertSame($secondEndpoint, $result[1]);
31			}
32
33			public function test__filters_by_given_bindings()
34			{
35			$criteriaSet = new CriteriaSet([new BindingCriteria([
36			SamlConstants::BINDING_SAML2_HTTP_POST,
37			SamlConstants::BINDING_SAML2_HTTP_REDIRECT
38			])]);
39
40			$candidates = [
41			$firstEndpoint = new EndpointReference(
42			new EntityDescriptor(),
43			new SpSsoDescriptor(),
44			(new SingleSignOnService())->setBinding(SamlConstants::BINDING_SAML2_SOAP)
45			),
46			$secondEndpoint = new EndpointReference(
47			new EntityDescriptor(),
48			new SpSsoDescriptor(),
49			(new SingleSignOnService())->setBinding(SamlConstants::BINDING_SAML2_HTTP_REDIRECT)
50			),
51			$thirdEndpoint = new EndpointReference(
52			new EntityDescriptor(),
53			new SpSsoDescriptor(),
54			(new SingleSignOnService())->setBinding(SamlConstants::BINDING_SAML2_HTTP_POST)
55			),
56			$fourthEndpoint = new EndpointReference(
57			new EntityDescriptor(),
58			new SpSsoDescriptor(),
59			(new SingleSignOnService())->setBinding(SamlConstants::BINDING_SAML2_HTTP_ARTIFACT)
60			),
61			];
62
63			$resolver = new BindingEndpointResolver();
64
65			$result = $resolver->resolve($criteriaSet, $candidates);
66
67			$this->assertCount(2, $result);
			0 ignored issues – show Documentation introduced 2020-07-28 16:14 UTC by Report Bug Copy Issue Report `$result` is of type `array<integer,object<Lig...ata\EndpointReference>>`, but the function expects a `object<Countable>\|object...nit\Framework\iterable>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
68			$this->assertSame($thirdEndpoint, $result[0]);
69			$this->assertSame($secondEndpoint, $result[1]);
70			}
71			}
72

thephplab / lightsaml

test__does_not_modify_when_criteria_not_present() A last analyzed 2020-07-28 16:14 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

test__does_not_modify_when_criteria_not_present() A
last analyzed 2020-07-28 16:14 UTC