EntityDescriptorTest::test_deserialization() - Code Metrics - thephplab/lightsaml - Measure and Improve Code Quality continuously with Scrutinizer

EntityDescriptorTest::test_deserialization() B
last analyzed 2020-07-28 16:14 UTC

↳ Parent: EntityDescriptorTest

Complexity

Conditions	1
Paths	1

Size

Total Lines

103

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	103
c	0
b	0
f	0
rs	8
cc	1
nc	1
nop	0

How to fix Long Method

<?php

namespace LightSaml\Tests\Model\Metadata;

use LightSaml\ClaimTypes;
use LightSaml\Model\Context\DeserializationContext;
use LightSaml\Model\Context\SerializationContext;
use LightSaml\Model\Assertion\Attribute;
use LightSaml\Model\Metadata\AssertionConsumerService;
use LightSaml\Model\Metadata\ContactPerson;
use LightSaml\Model\Metadata\EntityDescriptor;
use LightSaml\Model\Metadata\IdpSsoDescriptor;
use LightSaml\Model\Metadata\KeyDescriptor;
use LightSaml\Model\Metadata\Organization;
use LightSaml\Model\Metadata\SingleLogoutService;
use LightSaml\Model\Metadata\SingleSignOnService;
use LightSaml\Model\Metadata\SpSsoDescriptor;
use LightSaml\SamlConstants;
use LightSaml\Credential\X509Certificate;
use LightSaml\Tests\BaseTestCase;

class EntityDescriptorTest extends BaseTestCase
{
    public function test_serialization()
    {
        $ed = new EntityDescriptor();
        $ed
            ->setEntityID($entityID = 'http://vendor.com/id')
            ->setID($edID = '_127800fe-39ac-46ad-b073-6fb6106797a0')
            ->addItem((new IdpSsoDescriptor())
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
                ->setWantAuthnRequestsSigned(false)
                ->addSingleSignOnService((new SingleSignOnService())

                    ->setBinding(SamlConstants::BINDING_SAML2_HTTP_POST)
                    ->setLocation('http://idp.example.com/sso/post'))
                ->addSingleSignOnService((new SingleSignOnService())

                    ->setBinding(SamlConstants::BINDING_SAML2_HTTP_REDIRECT)
                    ->setLocation('http://idp.example.com/slo/get'))
                ->addSingleLogoutService((new SingleLogoutService())

                    ->setBinding(SamlConstants::BINDING_SAML2_HTTP_REDIRECT)
                    ->setLocation('http://idp.example.com/slo/redirect'))
                ->addAttribute((new Attribute())
                    ->setName(ClaimTypes::COMMON_NAME)
                    ->setFriendlyName('Common Name')
                    ->addAttributeValue('common name value'))
                ->addNameIDFormat(SamlConstants::NAME_ID_FORMAT_EMAIL)
                ->addNameIDFormat(SamlConstants::NAME_ID_FORMAT_PERSISTENT)
                ->addKeyDescriptor((new KeyDescriptor())
                    ->setCertificate((new X509Certificate())
                        ->loadFromFile(__DIR__.'/../../../../../resources/sample/Certificate/saml.crt')))
                ->addOrganization((new Organization())
                    ->setOrganizationName('Organization Name')
                    ->setOrganizationDisplayName('Display Name')
                    ->setOrganizationURL('http://organization.org'))
                ->addContactPerson((new ContactPerson())
                    ->setContactType(ContactPerson::TYPE_SUPPORT)
                    ->setGivenName('Support')
                    ->setSurName('Smith')
                    ->setEmailAddress('[email protected]')))
            ->addItem((new SpSsoDescriptor())
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
                ->setAuthnRequestsSigned(false)
                ->setWantAssertionsSigned(false)
                ->addSingleLogoutService((new SingleLogoutService())

                    ->setBinding(SamlConstants::BINDING_SAML2_HTTP_POST)
                    ->setLocation('http://sp.example.com/slo/post'))
                ->addAssertionConsumerService((new AssertionConsumerService())
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
                    ->setBinding(SamlConstants::BINDING_SAML2_HTTP_POST)
                    ->setLocation('http://sp.example.com/acs/post')
                    ->setIndex(0)
                    ->setIsDefault(true))
                ->addAssertionConsumerService((new AssertionConsumerService())
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
                    ->setBinding(SamlConstants::BINDING_SAML2_HTTP_REDIRECT)
                    ->setLocation('http://sp.example.com/acs/redirect')
                    ->setIndex(1)
                    ->setIsDefault(false))
                ->addNameIDFormat(SamlConstants::NAME_ID_FORMAT_PERSISTENT)
                ->addNameIDFormat(SamlConstants::NAME_ID_FORMAT_TRANSIENT))
        ;

        $context = new SerializationContext();
        $ed->serialize($context->getDocument(), $context);

        $context->getDocument()->formatOutput = true;
        $xml = $context->getDocument()->saveXML();

        $expectedXml = <<<EOT
<?xml version="1.0"?>
<EntityDescriptor xmlns="urn:oasis:names:tc:SAML:2.0:metadata" entityID="http://vendor.com/id" ID="_127800fe-39ac-46ad-b073-6fb6106797a0">
  <IDPSSODescriptor protocolSupportEnumeration="urn:oasis:names:tc:SAML:2.0:protocol" WantAuthnRequestsSigned="false">
    <KeyDescriptor>
      <ds:KeyInfo xmlns:ds="http://www.w3.org/2000/09/xmldsig#">
        <ds:X509Data>
          <ds:X509Certificate>MIIDrDCCApSgAwIBAgIJAIxzbGLou3BjMA0GCSqGSIb3DQEBBQUAMEIxCzAJBgNVBAYTAlJTMQ8wDQYDVQQIEwZTZXJiaWExDDAKBgNVBAoTA0JPUzEUMBIGA1UEAxMLbXQuZXZvLnRlYW0wHhcNMTMxMDA4MTg1OTMyWhcNMjMxMDA4MTg1OTMyWjBCMQswCQYDVQQGEwJSUzEPMA0GA1UECBMGU2VyYmlhMQwwCgYDVQQKEwNCT1MxFDASBgNVBAMTC210LmV2by50ZWFtMIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEAws7jML47jTQbWleRwihk15wOjuspoKPcxW1aERexAMWe8BMs1MeeTOMXjnA35breGa9PwJi2KjtDz3gkhVCglZzLZGBLLO7uchZvagFhTomZa20jTqO6JQbDli3pYNP0fBIrmEbH9cfhgm91Fm+6bTVnJ4xQhT4aPWrPAVKU2FDTBFBf4QNMIb1iI1oNErt3iocsbRTbIyjjvIe8yLVrtmZXA0DnkxB/riym0GT+4gpOEKV6GUMTF1x0eQMUzw4dkxhFs7fv6YrJymtEMmHOeiA5vVPEtxEr84JAXJyZUaZfufkj/jHUlX+POFWx2JRv+428ghrXpNvqUNqv7ozfFwIDAQABo4GkMIGhMB0GA1UdDgQWBBRomf3Xyc5ck3ceIXq0n45pxUkgwjByBgNVHSMEazBpgBRomf3Xyc5ck3ceIXq0n45pxUkgwqFGpEQwQjELMAkGA1UEBhMCUlMxDzANBgNVBAgTBlNlcmJpYTEMMAoGA1UEChMDQk9TMRQwEgYDVQQDEwttdC5ldm8udGVhbYIJAIxzbGLou3BjMAwGA1UdEwQFMAMBAf8wDQYJKoZIhvcNAQEFBQADggEBAGAXc8pe6+6owl9z2iqybE6pbjXTKqjSclMGrdeooItU1xGqBhYu/b2q6hEvYZCzlqYe5euf3r8C7GAAKEYyuwu3xuLDYV4n6l6eWTIl1doug+r0Bl8Z3157A4BcgmUT64QkekI2VDHO8WAdDOWQg1UTEoqCryTOtmRaC391iGAqbz1wtZtV95boGdur8SChK9LKcPrbCDxpo64BMgtPk2HkRgE7h5YWkLHxmxwZrYi3EAfS6IucblY3wwY4GEix8DQh1lYgpv5TOD8IMVf+oUWdp81Un/IqHqLhnSupwk6rBYbUFhN/ClK5UcoDqWHcj27tGKD6aNlxTdSwcYBl3Ts=</ds:X509Certificate>
        </ds:X509Data>
      </ds:KeyInfo>
    </KeyDescriptor>
    <Organization>
      <OrganizationName xml:lang="en-US">Organization Name</OrganizationName>
      <OrganizationDisplayName xml:lang="en-US">Display Name</OrganizationDisplayName>
      <OrganizationURL xml:lang="en-US">http://organization.org</OrganizationURL>
    </Organization>
    <ContactPerson contactType="support">
      <GivenName>Support</GivenName>
      <SurName>Smith</SurName>
      <EmailAddress>[email protected]</EmailAddress>
    </ContactPerson>
    <SingleLogoutService Binding="urn:oasis:names:tc:SAML:2.0:bindings:HTTP-Redirect" Location="http://idp.example.com/slo/redirect"/>
    <NameIDFormat>urn:oasis:names:tc:SAML:1.1:nameid-format:emailAddress</NameIDFormat>
    <NameIDFormat>urn:oasis:names:tc:SAML:2.0:nameid-format:persistent</NameIDFormat>
    <SingleSignOnService Binding="urn:oasis:names:tc:SAML:2.0:bindings:HTTP-POST" Location="http://idp.example.com/sso/post"/>
    <SingleSignOnService Binding="urn:oasis:names:tc:SAML:2.0:bindings:HTTP-Redirect" Location="http://idp.example.com/slo/get"/>
    <Attribute xmlns="urn:oasis:names:tc:SAML:2.0:assertion" Name="http://schemas.xmlsoap.org/claims/CommonName" FriendlyName="Common Name">
      <AttributeValue>common name value</AttributeValue>
    </Attribute>
  </IDPSSODescriptor>
  <SPSSODescriptor protocolSupportEnumeration="urn:oasis:names:tc:SAML:2.0:protocol" AuthnRequestsSigned="false" WantAssertionsSigned="false">
    <SingleLogoutService Binding="urn:oasis:names:tc:SAML:2.0:bindings:HTTP-POST" Location="http://sp.example.com/slo/post"/>
    <NameIDFormat>urn:oasis:names:tc:SAML:2.0:nameid-format:persistent</NameIDFormat>
    <NameIDFormat>urn:oasis:names:tc:SAML:2.0:nameid-format:transient</NameIDFormat>
    <AssertionConsumerService index="0" isDefault="true" Binding="urn:oasis:names:tc:SAML:2.0:bindings:HTTP-POST" Location="http://sp.example.com/acs/post"/>
    <AssertionConsumerService index="1" isDefault="false" Binding="urn:oasis:names:tc:SAML:2.0:bindings:HTTP-Redirect" Location="http://sp.example.com/acs/redirect"/>
  </SPSSODescriptor>
</EntityDescriptor>
EOT;
        $xml = trim(str_replace("\r", '', $xml));
        $expectedXml = trim(str_replace("\r", '', $expectedXml));

        $this->assertEquals($expectedXml, $xml);
    }

    public function test_deserialization()
    {
        $xml = <<<EOT
<?xml version="1.0"?>
<EntityDescriptor xmlns="urn:oasis:names:tc:SAML:2.0:metadata" entityID="http://vendor.com/id" ID="_127800fe-39ac-46ad-b073-6fb6106797a0">
  <IDPSSODescriptor protocolSupportEnumeration="urn:oasis:names:tc:SAML:2.0:protocol" WantAuthnRequestsSigned="false">
    <KeyDescriptor>
      <ds:KeyInfo xmlns:ds="http://www.w3.org/2000/09/xmldsig#">
        <ds:X509Data>
          <ds:X509Certificate>MIIDrDCCApSgAwIBAgIJAIxzbGLou3BjMA0GCSqGSIb3DQEBBQUAMEIxCzAJBgNVBAYTAlJTMQ8wDQYDVQQIEwZTZXJiaWExDDAKBgNVBAoTA0JPUzEUMBIGA1UEAxMLbXQuZXZvLnRlYW0wHhcNMTMxMDA4MTg1OTMyWhcNMjMxMDA4MTg1OTMyWjBCMQswCQYDVQQGEwJSUzEPMA0GA1UECBMGU2VyYmlhMQwwCgYDVQQKEwNCT1MxFDASBgNVBAMTC210LmV2by50ZWFtMIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEAws7jML47jTQbWleRwihk15wOjuspoKPcxW1aERexAMWe8BMs1MeeTOMXjnA35breGa9PwJi2KjtDz3gkhVCglZzLZGBLLO7uchZvagFhTomZa20jTqO6JQbDli3pYNP0fBIrmEbH9cfhgm91Fm+6bTVnJ4xQhT4aPWrPAVKU2FDTBFBf4QNMIb1iI1oNErt3iocsbRTbIyjjvIe8yLVrtmZXA0DnkxB/riym0GT+4gpOEKV6GUMTF1x0eQMUzw4dkxhFs7fv6YrJymtEMmHOeiA5vVPEtxEr84JAXJyZUaZfufkj/jHUlX+POFWx2JRv+428ghrXpNvqUNqv7ozfFwIDAQABo4GkMIGhMB0GA1UdDgQWBBRomf3Xyc5ck3ceIXq0n45pxUkgwjByBgNVHSMEazBpgBRomf3Xyc5ck3ceIXq0n45pxUkgwqFGpEQwQjELMAkGA1UEBhMCUlMxDzANBgNVBAgTBlNlcmJpYTEMMAoGA1UEChMDQk9TMRQwEgYDVQQDEwttdC5ldm8udGVhbYIJAIxzbGLou3BjMAwGA1UdEwQFMAMBAf8wDQYJKoZIhvcNAQEFBQADggEBAGAXc8pe6+6owl9z2iqybE6pbjXTKqjSclMGrdeooItU1xGqBhYu/b2q6hEvYZCzlqYe5euf3r8C7GAAKEYyuwu3xuLDYV4n6l6eWTIl1doug+r0Bl8Z3157A4BcgmUT64QkekI2VDHO8WAdDOWQg1UTEoqCryTOtmRaC391iGAqbz1wtZtV95boGdur8SChK9LKcPrbCDxpo64BMgtPk2HkRgE7h5YWkLHxmxwZrYi3EAfS6IucblY3wwY4GEix8DQh1lYgpv5TOD8IMVf+oUWdp81Un/IqHqLhnSupwk6rBYbUFhN/ClK5UcoDqWHcj27tGKD6aNlxTdSwcYBl3Ts=</ds:X509Certificate>
        </ds:X509Data>
      </ds:KeyInfo>
    </KeyDescriptor>
    <Organization>
      <OrganizationName xml:lang="en-US">Organization Name</OrganizationName>
      <OrganizationDisplayName xml:lang="en-US">Display Name</OrganizationDisplayName>
      <OrganizationURL xml:lang="en-US">http://organization.org</OrganizationURL>
    </Organization>
    <ContactPerson contactType="support">
      <GivenName>Support</GivenName>
      <SurName>Smith</SurName>
      <EmailAddress>[email protected]</EmailAddress>
    </ContactPerson>
    <SingleLogoutService Binding="urn:oasis:names:tc:SAML:2.0:bindings:HTTP-Redirect" Location="http://idp.example.com/slo/redirect"/>
    <NameIDFormat>urn:oasis:names:tc:SAML:1.1:nameid-format:emailAddress</NameIDFormat>
    <NameIDFormat>urn:oasis:names:tc:SAML:2.0:nameid-format:persistent</NameIDFormat>
    <SingleSignOnService Binding="urn:oasis:names:tc:SAML:2.0:bindings:HTTP-POST" Location="http://idp.example.com/sso/post"/>
    <SingleSignOnService Binding="urn:oasis:names:tc:SAML:2.0:bindings:HTTP-Redirect" Location="http://idp.example.com/slo/get"/>
    <Attribute xmlns="urn:oasis:names:tc:SAML:2.0:assertion" Name="http://schemas.xmlsoap.org/claims/CommonName" FriendlyName="Common Name">
      <AttributeValue>common name value</AttributeValue>
    </Attribute>
  </IDPSSODescriptor>
  <SPSSODescriptor protocolSupportEnumeration="urn:oasis:names:tc:SAML:2.0:protocol" AuthnRequestsSigned="false" WantAssertionsSigned="false">
    <SingleLogoutService Binding="urn:oasis:names:tc:SAML:2.0:bindings:HTTP-POST" Location="http://sp.example.com/slo/post"/>
    <NameIDFormat>urn:oasis:names:tc:SAML:2.0:nameid-format:persistent</NameIDFormat>
    <NameIDFormat>urn:oasis:names:tc:SAML:2.0:nameid-format:transient</NameIDFormat>
    <AssertionConsumerService index="0" isDefault="true" Binding="urn:oasis:names:tc:SAML:2.0:bindings:HTTP-POST" Location="http://sp.example.com/acs/post"/>
    <AssertionConsumerService index="1" isDefault="false" Binding="urn:oasis:names:tc:SAML:2.0:bindings:HTTP-Redirect" Location="http://sp.example.com/acs/redirect"/>
  </SPSSODescriptor>
</EntityDescriptor>
EOT;

        $expectedEntityDescriptor = new EntityDescriptor();
        $expectedEntityDescriptor
            ->setEntityID($entityID = 'http://vendor.com/id')
            ->setID($edID = '_127800fe-39ac-46ad-b073-6fb6106797a0')
            ->addItem((new IdpSsoDescriptor())
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
                ->setWantAuthnRequestsSigned(false)
                ->addSingleSignOnService((new SingleSignOnService())

                    ->setBinding(SamlConstants::BINDING_SAML2_HTTP_POST)
                    ->setLocation('http://idp.example.com/sso/post'))
                ->addSingleSignOnService((new SingleSignOnService())

                    ->setBinding(SamlConstants::BINDING_SAML2_HTTP_REDIRECT)
                    ->setLocation('http://idp.example.com/slo/get'))
                ->addSingleLogoutService((new SingleLogoutService())

                    ->setBinding(SamlConstants::BINDING_SAML2_HTTP_REDIRECT)
                    ->setLocation('http://idp.example.com/slo/redirect'))
                ->addAttribute((new Attribute())
                    ->setName(ClaimTypes::COMMON_NAME)
                    ->setFriendlyName('Common Name')
                    ->addAttributeValue('common name value'))
                ->addNameIDFormat(SamlConstants::NAME_ID_FORMAT_EMAIL)
                ->addNameIDFormat(SamlConstants::NAME_ID_FORMAT_PERSISTENT)
                ->addKeyDescriptor((new KeyDescriptor())
                    ->setCertificate((new X509Certificate())
                        ->loadFromFile(__DIR__.'/../../../../../resources/sample/Certificate/saml.crt')))
                ->addOrganization((new Organization())
                    ->setOrganizationName('Organization Name')
                    ->setOrganizationDisplayName('Display Name')
                    ->setOrganizationURL('http://organization.org'))
                ->addContactPerson((new ContactPerson())
                    ->setContactType(ContactPerson::TYPE_SUPPORT)
                    ->setGivenName('Support')
                    ->setSurName('Smith')
                    ->setEmailAddress('[email protected]')))
            ->addItem((new SpSsoDescriptor())
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
                ->setAuthnRequestsSigned(false)
                ->setWantAssertionsSigned(false)
                ->addSingleLogoutService((new SingleLogoutService())

                    ->setBinding(SamlConstants::BINDING_SAML2_HTTP_POST)
                    ->setLocation('http://sp.example.com/slo/post'))
                ->addAssertionConsumerService((new AssertionConsumerService())
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
                    ->setBinding(SamlConstants::BINDING_SAML2_HTTP_POST)
                    ->setLocation('http://sp.example.com/acs/post')
                    ->setIndex(0)
                    ->setIsDefault(true))
                ->addAssertionConsumerService((new AssertionConsumerService())
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
                    ->setBinding(SamlConstants::BINDING_SAML2_HTTP_REDIRECT)
                    ->setLocation('http://sp.example.com/acs/redirect')
                    ->setIndex(1)
                    ->setIsDefault(false))
                ->addNameIDFormat(SamlConstants::NAME_ID_FORMAT_PERSISTENT)
                ->addNameIDFormat(SamlConstants::NAME_ID_FORMAT_TRANSIENT))
        ;

        $context = new DeserializationContext();
        $context->getDocument()->loadXML($xml);

        $entityDescriptor = new EntityDescriptor();
        $entityDescriptor->deserialize($context->getDocument()->firstChild, $context);

        $this->assertEquals($expectedEntityDescriptor, $entityDescriptor);
    }
}


EntityDescriptorTest::test_deserialization() B
last analyzed 2020-07-28 16:14 UTC

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

1			<?php
2
3			namespace LightSaml\Tests\Model\Metadata;
4
5			use LightSaml\ClaimTypes;
6			use LightSaml\Model\Context\DeserializationContext;
7			use LightSaml\Model\Context\SerializationContext;
8			use LightSaml\Model\Assertion\Attribute;
9			use LightSaml\Model\Metadata\AssertionConsumerService;
10			use LightSaml\Model\Metadata\ContactPerson;
11			use LightSaml\Model\Metadata\EntityDescriptor;
12			use LightSaml\Model\Metadata\IdpSsoDescriptor;
13			use LightSaml\Model\Metadata\KeyDescriptor;
14			use LightSaml\Model\Metadata\Organization;
15			use LightSaml\Model\Metadata\SingleLogoutService;
16			use LightSaml\Model\Metadata\SingleSignOnService;
17			use LightSaml\Model\Metadata\SpSsoDescriptor;
18			use LightSaml\SamlConstants;
19			use LightSaml\Credential\X509Certificate;
20			use LightSaml\Tests\BaseTestCase;
21
22			class EntityDescriptorTest extends BaseTestCase
23			{
24			public function test_serialization()
25			{
26			$ed = new EntityDescriptor();
27			$ed
28			->setEntityID($entityID = 'http://vendor.com/id')
29			->setID($edID = '_127800fe-39ac-46ad-b073-6fb6106797a0')
30			->addItem((new IdpSsoDescriptor())
			0 ignored issues – show Bug introduced 2020-07-28 16:14 UTC by Report Bug Copy Issue Report It seems like you code against a specific sub-type and not the parent class `LightSaml\Model\Metadata\SSODescriptor` as the method `addAttribute()` does only exist in the following sub-classes of `LightSaml\Model\Metadata\SSODescriptor`: `LightSaml\Model\Metadata\IdpSsoDescriptor`. Maybe you want to `instanceof` check for one of these explicitly? Let’s take a look at an example: abstract class User { /** @return string / abstract public function getPassword(); } class MyUser extends User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different sub-classes of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the parent class: abstract class User { /** @return string / abstract public function getPassword(); /* @return string */ abstract public function getDisplayName(); } Loading history...
31			->setWantAuthnRequestsSigned(false)
32			->addSingleSignOnService((new SingleSignOnService())
			0 ignored issues – show Compatibility introduced 2020-07-28 16:14 UTC by Report Bug Copy Issue Report `(new \LightSaml\Model\Me....example.com/sso/post')` of type `object<LightSaml\Model\Metadata\Endpoint>` is not a sub-type of `object<LightSaml\Model\M...ta\SingleSignOnService>`. It seems like you assume a child class of the class `LightSaml\Model\Metadata\Endpoint` to be always present. This check looks for parameters that are defined as one type in their type hint or doc comment but seem to be used as a narrower type, i.e an implementation of an interface or a subclass. Consider changing the type of the parameter or doing an instanceof check before assuming your parameter is of the expected type. Loading history...
33			->setBinding(SamlConstants::BINDING_SAML2_HTTP_POST)
34			->setLocation('http://idp.example.com/sso/post'))
35			->addSingleSignOnService((new SingleSignOnService())
			0 ignored issues – show Compatibility introduced 2020-07-28 16:14 UTC by Report Bug Copy Issue Report `(new \LightSaml\Model\Me...p.example.com/slo/get')` of type `object<LightSaml\Model\Metadata\Endpoint>` is not a sub-type of `object<LightSaml\Model\M...ta\SingleSignOnService>`. It seems like you assume a child class of the class `LightSaml\Model\Metadata\Endpoint` to be always present. This check looks for parameters that are defined as one type in their type hint or doc comment but seem to be used as a narrower type, i.e an implementation of an interface or a subclass. Consider changing the type of the parameter or doing an instanceof check before assuming your parameter is of the expected type. Loading history...
36			->setBinding(SamlConstants::BINDING_SAML2_HTTP_REDIRECT)
37			->setLocation('http://idp.example.com/slo/get'))

thephplab / lightsaml

EntityDescriptorTest::test_deserialization() B last analyzed 2020-07-28 16:14 UTC

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like

EntityDescriptorTest::test_deserialization() B
last analyzed 2020-07-28 16:14 UTC