CompositeActionBuilderTest::test__throws_on_priority_string() - Code Metrics - thephplab/lightsaml - Measure and Improve Code Quality continuously with Scrutinizer

test__throws_on_priority_string() A
last analyzed 2020-07-28 16:14 UTC

↳ Parent: CompositeActionBuilderTest

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	6
c	0
b	0
f	0
rs	10
cc	1
nc	1
nop	0

<?php

namespace LightSaml\Tests\Builder\Action;

use LightSaml\Action\ActionInterface;
use LightSaml\Action\CompositeAction;
use LightSaml\Builder\Action\CompositeActionBuilder;
use LightSaml\Context\ContextInterface;
use LightSaml\Tests\BaseTestCase;
use LightSaml\Tests\Mock\Action\FooAction;

class CompositeActionBuilderTest extends BaseTestCase
{
    public function test__throws_on_priority_true()
    {
        $this->expectException(\InvalidArgumentException::class);
        $compositeBuilder = new CompositeActionBuilder();
        $compositeBuilder->add(new FooAction(), true);
    }

    public function test__throws_on_priority_string()
    {
        $this->expectException(\InvalidArgumentException::class);
        $compositeBuilder = new CompositeActionBuilder();
        $compositeBuilder->add(new FooAction(), "asc");
    }

    public function test__ranked_as_added_with_out_priority_parameter()

    {
        $order = 1;
        $action1 = $this->getActionMock(1, $order);
        $action2 = $this->getActionMock(2, $order);
        $action3 = $this->getActionMock(3, $order);

        $compositeBuilder = new CompositeActionBuilder();
        $compositeBuilder->add($action1);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $compositeBuilder->add($action2);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $compositeBuilder->add($action3);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

        $compositeAction = $compositeBuilder->build();

        $this->assertInstanceOf(CompositeAction::class, $compositeAction);

        $compositeAction->execute($this->getMockBuilder(ContextInterface::class)->getMock());
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }

    public function test__ranked_as_given_priority_parameter()

    {
        $order = 1;
        $action1 = $this->getActionMock(3, $order);
        $action2 = $this->getActionMock(1, $order);
        $action3 = $this->getActionMock(2, $order);

        $compositeBuilder = new CompositeActionBuilder();
        $compositeBuilder->add($action1, 10);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $compositeBuilder->add($action2, 2);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $compositeBuilder->add($action3, 7);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

        $compositeAction = $compositeBuilder->build();

        $this->assertInstanceOf(CompositeAction::class, $compositeAction);

        $compositeAction->execute($this->getMockBuilder(ContextInterface::class)->getMock());
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }

    /**
     * @param int $expectedOrder
     * @param int $order
     *
     * @return \PHPUnit_Framework_MockObject_MockObject|ActionInterface
     */
    private function getActionMock($expectedOrder, &$order)
    {
        $action = $this->getMockBuilder(ActionInterface::class)->getMock();
        $action->expects($this->once())
            ->method('execute')
            ->willReturnCallback(function () use ($expectedOrder, &$order) {
                $this->assertEquals($expectedOrder, $order);
                $order++;
            })
        ;

        return $action;
    }
}


1		<?php
2
3		namespace LightSaml\Tests\Builder\Action;
4
5		use LightSaml\Action\ActionInterface;
6		use LightSaml\Action\CompositeAction;
7		use LightSaml\Builder\Action\CompositeActionBuilder;
8		use LightSaml\Context\ContextInterface;
9		use LightSaml\Tests\BaseTestCase;
10		use LightSaml\Tests\Mock\Action\FooAction;
11
12		class CompositeActionBuilderTest extends BaseTestCase
13		{
14		public function test__throws_on_priority_true()
15		{
16		$this->expectException(\InvalidArgumentException::class);
17		$compositeBuilder = new CompositeActionBuilder();
18		$compositeBuilder->add(new FooAction(), true);
19		}
20
21		public function test__throws_on_priority_string()
22		{
23		$this->expectException(\InvalidArgumentException::class);
24		$compositeBuilder = new CompositeActionBuilder();
25		$compositeBuilder->add(new FooAction(), "asc");
26		}
27
28	View Code Duplication	public function test__ranked_as_added_with_out_priority_parameter()
		0 ignored issues – show Duplication introduced 2020-07-28 16:14 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
29		{
30		$order = 1;
31		$action1 = $this->getActionMock(1, $order);
32		$action2 = $this->getActionMock(2, $order);
33		$action3 = $this->getActionMock(3, $order);
34
35		$compositeBuilder = new CompositeActionBuilder();
36		$compositeBuilder->add($action1);
		0 ignored issues – show Documentation introduced 2020-07-28 16:14 UTC by Report Bug Copy Issue Report `$action1` is of type `object<PHPUnit\Framework\MockObject\MockObject>`, but the function expects a `object<LightSaml\Action\ActionInterface>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
37		$compositeBuilder->add($action2);
		0 ignored issues – show Documentation introduced 2020-07-28 16:14 UTC by Report Bug Copy Issue Report `$action2` is of type `object<PHPUnit\Framework\MockObject\MockObject>`, but the function expects a `object<LightSaml\Action\ActionInterface>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
38		$compositeBuilder->add($action3);
		0 ignored issues – show Documentation introduced 2020-07-28 16:14 UTC by Report Bug Copy Issue Report `$action3` is of type `object<PHPUnit\Framework\MockObject\MockObject>`, but the function expects a `object<LightSaml\Action\ActionInterface>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
39
40		$compositeAction = $compositeBuilder->build();
41
42		$this->assertInstanceOf(CompositeAction::class, $compositeAction);
43
44		$compositeAction->execute($this->getMockBuilder(ContextInterface::class)->getMock());
		0 ignored issues – show Documentation introduced 2020-07-28 16:14 UTC by Report Bug Copy Issue Report `$this->getMockBuilder(\L...face::class)->getMock()` is of type `object<PHPUnit\Framework\MockObject\MockObject>`, but the function expects a `object<LightSaml\Context\ContextInterface>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
45		}
46
47	View Code Duplication	public function test__ranked_as_given_priority_parameter()
		0 ignored issues – show Duplication introduced 2020-07-28 16:14 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
48		{
49		$order = 1;
50		$action1 = $this->getActionMock(3, $order);
51		$action2 = $this->getActionMock(1, $order);
52		$action3 = $this->getActionMock(2, $order);
53
54		$compositeBuilder = new CompositeActionBuilder();
55		$compositeBuilder->add($action1, 10);
		0 ignored issues – show Documentation introduced 2020-07-28 16:14 UTC by Report Bug Copy Issue Report `$action1` is of type `object<PHPUnit\Framework\MockObject\MockObject>`, but the function expects a `object<LightSaml\Action\ActionInterface>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
56		$compositeBuilder->add($action2, 2);
		0 ignored issues – show Documentation introduced 2020-07-28 16:14 UTC by Report Bug Copy Issue Report `$action2` is of type `object<PHPUnit\Framework\MockObject\MockObject>`, but the function expects a `object<LightSaml\Action\ActionInterface>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
57		$compositeBuilder->add($action3, 7);
		0 ignored issues – show Documentation introduced 2020-07-28 16:14 UTC by Report Bug Copy Issue Report `$action3` is of type `object<PHPUnit\Framework\MockObject\MockObject>`, but the function expects a `object<LightSaml\Action\ActionInterface>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
58
59		$compositeAction = $compositeBuilder->build();
60
61		$this->assertInstanceOf(CompositeAction::class, $compositeAction);
62
63		$compositeAction->execute($this->getMockBuilder(ContextInterface::class)->getMock());
		0 ignored issues – show Documentation introduced 2020-07-28 16:14 UTC by Report Bug Copy Issue Report `$this->getMockBuilder(\L...face::class)->getMock()` is of type `object<PHPUnit\Framework\MockObject\MockObject>`, but the function expects a `object<LightSaml\Context\ContextInterface>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
64		}
65
66		/**
67		* @param int $expectedOrder
68		* @param int $order
69		*
70		* @return \PHPUnit_Framework_MockObject_MockObject\|ActionInterface
71		*/
72		private function getActionMock($expectedOrder, &$order)
73		{
74		$action = $this->getMockBuilder(ActionInterface::class)->getMock();
75		$action->expects($this->once())
76		->method('execute')
77		->willReturnCallback(function () use ($expectedOrder, &$order) {
78		$this->assertEquals($expectedOrder, $order);
79		$order++;
80		})
81		;
82
83		return $action;
84		}
85		}
86

thephplab / lightsaml

test__throws_on_priority_string() A last analyzed 2020-07-28 16:14 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

test__throws_on_priority_string() A
last analyzed 2020-07-28 16:14 UTC