LightSaml\Resolver\Credential\MetadataFilterResolver::resolve()

Complexity

Conditions	9
Paths	5

Size

Total Lines

23

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	11
CRAP Score	9.0468

Importance

Changes

0

<?php
    public function resolve(CriteriaSet $criteriaSet, array $arrCredentials = array())
    {
        if (false == $criteriaSet->has(MetadataCriteria::class)) {

It seems like you are loosely comparing two booleans. Considering using the strict comparison === instead.

            return $arrCredentials;
        }

        $result = array();
        foreach ($criteriaSet->get(MetadataCriteria::class) as $criteria) {
            /* @var MetadataCriteria $criteria */
            foreach ($arrCredentials as $credential) {
                /** @var MetadataCredentialContext $metadataContext */
                $metadataContext = $credential->getCredentialContext()->get(MetadataCredentialContext::class);
                if (false == $metadataContext ||
                    MetadataCriteria::TYPE_IDP == $criteria->getMetadataType() && $metadataContext->getRoleDescriptor() instanceof IdpSsoDescriptor ||
                    MetadataCriteria::TYPE_SP == $criteria->getMetadataType() && $metadataContext->getRoleDescriptor() instanceof SpSsoDescriptor
                ) {
                    $result[] = $credential;
                }
            }
        }

        return $result;
    }
}