LightSaml\Model\Metadata\Metadata::fromXML()

Complexity

Conditions	8
Paths	11

Size

Total Lines

46

Duplication

Lines	10
Ratio	21.74 %

Code Coverage

Tests	15
CRAP Score	10.6925

Importance

Changes

0

<?php
    public static function fromXML($xml, DeserializationContext $context)
    {
        if (false == is_string($xml)) {

It seems like you are loosely comparing two booleans. Considering using the strict comparison === instead.

            throw new \InvalidArgumentException('Expecting string');
        }

        $context->getDocument()->loadXML($xml);

        $node = $context->getDocument()->firstChild;
        while ($node && $node instanceof \DOMComment) {
            $node = $node->nextSibling;
        }
        if (null === $node) {
            throw new LightSamlXmlException('Empty XML');
        }

        if (SamlConstants::NS_METADATA !== $node->namespaceURI) {
            throw new LightSamlXmlException(sprintf(
                "Invalid namespace '%s' of the root XML element, expected '%s'",
                $node->namespaceURI,
                SamlConstants::NS_METADATA
            ));
        }

        $map = array(
            'EntityDescriptor' => '\LightSaml\Model\Metadata\EntityDescriptor',
            'EntitiesDescriptor' => '\LightSaml\Model\Metadata\EntitiesDescriptor',
        );

        $rootElementName = $node->localName;

        if (array_key_exists($rootElementName, $map)) {

This code seems to be duplicated across your project.

            if ($class = $map[$rootElementName]) {
                /** @var SamlElementInterface $result */
                $result = new $class();
            } else {
                throw new \LogicException('Deserialization of %s root element is not implemented');
            }
        } else {
            throw new LightSamlXmlException(sprintf("Unknown SAML metadata '%s'", $rootElementName));
        }

        $result->deserialize($node, $context);

        return $result;
    }
}