AssertionValidatorActionTest - Code Metrics - thephplab/lightsaml - Measure and Improve Code Quality continuously with Scrutinizer

AssertionValidatorActionTest A
last analyzed 2020-07-28 16:14 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	25
Duplicated Lines	64 %

Coupling/Cohesion

Components	1
Dependencies	5

Importance

Changes

Metric	Value
dl	16
loc	25
c	0
b	0
f	0
wmc	2
lcom	1
cbo	5
rs	10

2 Methods

Rating	Name	Duplication	Size	Complexity
A	test_constructs_with_logger_and_assertion_validator()	0	5	1
A	test_calls_assertion_validator_with_assertion_from_context()	16	16	1

How to fix Duplicated Code

<?php

namespace LightSaml\Tests\Action\Assertion\Inbound;

use LightSaml\Action\Assertion\Inbound\AssertionValidatorAction;
use LightSaml\Model\Assertion\Assertion;
use LightSaml\Tests\BaseTestCase;

class AssertionValidatorActionTest extends BaseTestCase
{
    public function test_constructs_with_logger_and_assertion_validator()
    {
        new AssertionValidatorAction($this->getLoggerMock(), $this->getAssertionValidatorMock());
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $this->assertTrue(true);
    }

    public function test_calls_assertion_validator_with_assertion_from_context()

    {
        $action = new AssertionValidatorAction(
            $this->getLoggerMock(),
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            $assertionValidatorMock = $this->getAssertionValidatorMock()
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        );

        $context = $this->getAssertionContext($assertion = new Assertion());

        $assertionValidatorMock->expects($this->once())
            ->method('validateAssertion')
            ->with($assertion);

        $action->execute($context);
        $this->assertTrue(true);
    }
}


1		<?php
2
3		namespace LightSaml\Tests\Action\Assertion\Inbound;
4
5		use LightSaml\Action\Assertion\Inbound\AssertionValidatorAction;
6		use LightSaml\Model\Assertion\Assertion;
7		use LightSaml\Tests\BaseTestCase;
8
9		class AssertionValidatorActionTest extends BaseTestCase
10		{
11		public function test_constructs_with_logger_and_assertion_validator()
12		{
13		new AssertionValidatorAction($this->getLoggerMock(), $this->getAssertionValidatorMock());
		0 ignored issues – show Documentation introduced 2020-07-28 16:14 UTC by Report Bug Copy Issue Report `$this->getLoggerMock()` is of type `object<PHPUnit\Framework\MockObject\MockObject>`, but the function expects a `object<Psr\Log\LoggerInterface>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history... Documentation introduced 2020-07-28 16:14 UTC by Report Bug Copy Issue Report `$this->getAssertionValidatorMock()` is of type `object<PHPUnit\Framework\MockObject\MockObject>`, but the function expects a `object<LightSaml\Validat...tionValidatorInterface>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
14		$this->assertTrue(true);
15		}
16
17	View Code Duplication	public function test_calls_assertion_validator_with_assertion_from_context()
		0 ignored issues – show Duplication introduced 2020-07-28 16:14 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
18		{
19		$action = new AssertionValidatorAction(
20		$this->getLoggerMock(),
		0 ignored issues – show Documentation introduced 2020-07-28 16:14 UTC by Report Bug Copy Issue Report `$this->getLoggerMock()` is of type `object<PHPUnit\Framework\MockObject\MockObject>`, but the function expects a `object<Psr\Log\LoggerInterface>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
21		$assertionValidatorMock = $this->getAssertionValidatorMock()
		0 ignored issues – show Documentation introduced 2020-07-28 16:14 UTC by Report Bug Copy Issue Report `$assertionValidatorMock ...ssertionValidatorMock()` is of type `object<PHPUnit\Framework\MockObject\MockObject>`, but the function expects a `object<LightSaml\Validat...tionValidatorInterface>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
22		);
23
24		$context = $this->getAssertionContext($assertion = new Assertion());
25
26		$assertionValidatorMock->expects($this->once())
27		->method('validateAssertion')
28		->with($assertion);
29
30		$action->execute($context);
31		$this->assertTrue(true);
32		}
33		}
34

thephplab / lightsaml

AssertionValidatorActionTest A last analyzed 2020-07-28 16:14 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Importance

2 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like

AssertionValidatorActionTest A
last analyzed 2020-07-28 16:14 UTC