LightSaml\Model\Metadata\IdpSsoDescriptor

Complexity

Total Complexity

24

Size/Duplication

Total Lines	184
Duplicated Lines	20.65 %

Coupling/Cohesion

Components	1
Dependencies	3

Test Coverage

Coverage

89.71%

Importance

Changes

0

11 Methods

Rating	Name	Duplication	Size	Complexity
A	setWantAuthnRequestsSigned()	0	6	1
A	getWantAuthnRequestsSigned()	0	4	1
A	addSingleSignOnService()	0	9	2
A	getAllSingleSignOnServices()	0	4	1
A	getAllSingleSignOnServicesByUrl()	0	11	3
A	getAllSingleSignOnServicesByBinding()	0	11	3
A	getFirstSingleSignOnService()	10	10	4
A	addAttribute()	0	9	2
A	getAllAttributes()	0	4	1
A	serialize()	0	19	5
A	deserialize()	28	28	1

<?php

/*
 * This file is part of the LightSAML-Core package.
 *
 * (c) Milos Tomic <tmilos@lightsaml.com>
 *
 * This source file is subject to the MIT license that is bundled
 * with this source code in the file LICENSE.
 */

namespace LightSaml\Model\Metadata;

use LightSaml\Model\Context\DeserializationContext;
use LightSaml\Model\Context\SerializationContext;
use LightSaml\Model\Assertion\Attribute;
use LightSaml\SamlConstants;

class IdpSsoDescriptor extends SSODescriptor
{
    /** @var bool|null */
    protected $wantAuthnRequestsSigned;

    /** @var SingleSignOnService[]|null */
    protected $singleSignOnServices;

    /** @var Attribute[]|null */
    protected $attributes;

    /**
     * @param bool|null $wantAuthnRequestsSigned
     *
     * @return IdpSsoDescriptor
     */
    public function setWantAuthnRequestsSigned($wantAuthnRequestsSigned)
    {
        $this->wantAuthnRequestsSigned = filter_var($wantAuthnRequestsSigned, FILTER_VALIDATE_BOOLEAN, ['flags' => FILTER_NULL_ON_FAILURE]);

        return $this;
    }

    /**
     * @return bool|null
     */
    public function getWantAuthnRequestsSigned()
    {
        return $this->wantAuthnRequestsSigned;
    }

    /**
     * @param SingleSignOnService $singleSignOnService
     *
     * @return IdpSsoDescriptor
     */
    public function addSingleSignOnService(SingleSignOnService $singleSignOnService)
    {
        if (false == is_array($this->singleSignOnServices)) {

It seems like you are loosely comparing two booleans. Considering using the strict comparison === instead.

            $this->singleSignOnServices = array();
        }
        $this->singleSignOnServices[] = $singleSignOnService;

        return $this;
    }

    /**
     * @return SingleSignOnService[]|null
     */
    public function getAllSingleSignOnServices()
    {
        return $this->singleSignOnServices;
    }

    /**
     * @param string $url
     *
     * @return SingleSignOnService[]
     */
    public function getAllSingleSignOnServicesByUrl($url)
    {
        $result = array();
        foreach ($this->getAllSingleSignOnServices() as $svc) {

The expression $this->getAllSingleSignOnServices() of type array<integer,object<LightSaml\Model\Metadata\SingleSignOnService>>|null is not guaranteed to be traversable. How about adding an additional type check?

            if ($svc->getLocation() == $url) {
                $result[] = $svc;
            }
        }

        return $result;
    }

    /**
     * @param string $binding
     *
     * @return SingleSignOnService[]
     */
    public function getAllSingleSignOnServicesByBinding($binding)
    {
        $result = array();
        foreach ($this->getAllSingleSignOnServices() as $svc) {

The expression $this->getAllSingleSignOnServices() of type array<integer,object<LightSaml\Model\Metadata\SingleSignOnService>>|null is not guaranteed to be traversable. How about adding an additional type check?

            if ($svc->getBinding() == $binding) {
                $result[] = $svc;
            }
        }

        return $result;
    }

    /**
     * @param string|null $binding
     *
     * @return SingleSignOnService|null
     */
    public function getFirstSingleSignOnService($binding = null)

This method seems to be duplicated in your project.

    {
        foreach ($this->getAllSingleSignOnServices() as $svc) {

The expression $this->getAllSingleSignOnServices() of type array<integer,object<LightSaml\Model\Metadata\SingleSignOnService>>|null is not guaranteed to be traversable. How about adding an additional type check?

            if (null == $binding || $svc->getBinding() == $binding) {

It seems like you are loosely comparing $binding of type string|null against null; this is ambiguous if the string can be empty. Consider using a strict comparison === instead.

                return $svc;
            }
        }

        return null;
    }

    /**
     * @param \LightSaml\Model\Assertion\Attribute $attribute
     *
     * @return IdpSsoDescriptor
     */
    public function addAttribute(Attribute $attribute)
    {
        if (false == is_array($this->attributes)) {

It seems like you are loosely comparing two booleans. Considering using the strict comparison === instead.

            $this->attributes = array();
        }
        $this->attributes[] = $attribute;

        return $this;
    }

    /**
     * @return \LightSaml\Model\Assertion\Attribute[]|null
     */
    public function getAllAttributes()
    {
        return $this->attributes;
    }

    /**
     * @param \DOMNode             $parent
     * @param SerializationContext $context
     */
    public function serialize(\DOMNode $parent, SerializationContext $context)
    {
        $result = $this->createElement('IDPSSODescriptor', SamlConstants::NS_METADATA, $parent, $context);

        parent::serialize($result, $context);

        $this->attributesToXml(array('WantAuthnRequestsSigned'), $result);

        if ($this->getAllSingleSignOnServices()) {
            foreach ($this->getAllSingleSignOnServices() as $object) {
                $object->serialize($result, $context);
            }
        }
        if ($this->getAllAttributes()) {
            foreach ($this->getAllAttributes() as $object) {
                $object->serialize($result, $context);
            }
        }
    }

    /**
     * @param \DOMNode               $node
     * @param DeserializationContext $context
     */
    public function deserialize(\DOMNode $node, DeserializationContext $context)

This method seems to be duplicated in your project.

    {
        $this->checkXmlNodeName($node, 'IDPSSODescriptor', SamlConstants::NS_METADATA);

        parent::deserialize($node, $context);

        $this->attributesFromXml($node, array('WantAuthnRequestsSigned'));

$node of type object<DOMNode> is not a sub-type of object<DOMElement>. It seems like you assume a child class of the class DOMNode to be always present.

        $this->singleSignOnServices = array();
        $this->manyElementsFromXml(
            $node,

$node of type object<DOMNode> is not a sub-type of object<DOMElement>. It seems like you assume a child class of the class DOMNode to be always present.

            $context,
            'SingleSignOnService',
            'md',
            'LightSaml\Model\Metadata\SingleSignOnService',
            'addSingleSignOnService'
        );

        $this->attributes = array();
        $this->manyElementsFromXml(
            $node,

$node of type object<DOMNode> is not a sub-type of object<DOMElement>. It seems like you assume a child class of the class DOMNode to be always present.

            $context,
            'Attribute',
            'saml',
            'LightSaml\Model\Assertion\Attribute',
            'addAttribute'
        );
    }
}