Issues in test_board.py (develop) - Issues in develop - theovoss/Chess - Measure and Improve Code Quality continuously with Scrutinizer

Issues (98)

chess/test/test_board.py (23 issues)

Labels

Coding Style 23

Severity

Informational 23

"""Chess Board unit test module."""

import unittest

from chess.board import ChessBoard

starting_fen_board = "rnbqkbnr/pppppppp/8/8/8/8/PPPPPPPP/RNBQKBNR w KQkq - 0 1"


class TestBoard(unittest.TestCase):

    """Chess unit test class."""

    def setUp(self):
        self.chess_board = ChessBoard()

    @staticmethod
    def convert_default_white_spaces_to_black(white_positions):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
        return [(7 - row, column) for row, column in white_positions]

    def verify_pieces_at_locations_are_correct_piece_and_color(self, white_positions, piece):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
        for location in white_positions:
            assert self.chess_board[location].kind == piece
            assert self.chess_board[location].color == "white"

        black_positions = self.convert_default_white_spaces_to_black(white_positions)
        for location in black_positions:
            assert self.chess_board[location].kind == piece
            assert self.chess_board[location].color == "black"

    def test_init(self):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
        assert len(self.chess_board) == 64

    def test_has_pawn_at_1_3(self):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
        piece = self.chess_board[(1, 3)]
        assert len(piece.moves) > 0

    def test_initial_pawn_positions(self):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
        expected_white_pawn_positions = [(1, 0), (1, 1), (1, 2), (1, 3), (1, 4), (1, 5), (1, 6), (1, 7)]
        self.verify_pieces_at_locations_are_correct_piece_and_color(expected_white_pawn_positions, "pawn")

    def test_initial_knight_positions(self):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
        self.verify_pieces_at_locations_are_correct_piece_and_color([(0, 1), (0, 6)], "knight")

    def test_initial_rook_positions(self):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
        self.verify_pieces_at_locations_are_correct_piece_and_color([(0, 0), (0, 7)], "rook")

    def test_initial_bishop_positions(self):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
        self.verify_pieces_at_locations_are_correct_piece_and_color([(0, 2), (0, 5)], 'bishop')

    def test_initial_queen_positions(self):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
        self.verify_pieces_at_locations_are_correct_piece_and_color([(0, 3)], "queen")

    def test_initial_king_positions(self):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
        self.verify_pieces_at_locations_are_correct_piece_and_color([(0, 4)], "king")

    def test_starting_board_fen_export(self):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
        assert self.chess_board.generate_fen() == starting_fen_board

    def test_one_move_fen_export(self):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
        self.chess_board[(6, 0)] = None
        expected_fen = "rnbqkbnr/1ppppppp/8/8/8/8/PPPPPPPP/RNBQKBNR w KQkq - 0 1"
        assert expected_fen == self.chess_board.generate_fen()

    def test_clear_board_removes_all_pieces(self):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
        self.chess_board.clear_board()
        for location in self.chess_board.board:
            assert self.chess_board[location] is None

    def test_starting_board_fen_import(self):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
        self.chess_board.clear_board()
        self.chess_board.import_fen_board(starting_fen_board)

        expected_white_pawn_positions = [(1, 0), (1, 1), (1, 2), (1, 3), (1, 4), (1, 5), (1, 6), (1, 7)]
        self.verify_pieces_at_locations_are_correct_piece_and_color(expected_white_pawn_positions, "pawn")
        self.verify_pieces_at_locations_are_correct_piece_and_color([(0, 1), (0, 6)], "knight")
        self.verify_pieces_at_locations_are_correct_piece_and_color([(0, 0), (0, 7)], "rook")
        self.verify_pieces_at_locations_are_correct_piece_and_color([(0, 2), (0, 5)], 'bishop')
        self.verify_pieces_at_locations_are_correct_piece_and_color([(0, 3)], "queen")
        self.verify_pieces_at_locations_are_correct_piece_and_color([(0, 4)], "king")

    def test_starting_board_custom_export(self):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
        expected_json = self.chess_board.load_json()
        exported_json = self.chess_board.export()
        self.compare_boards(exported_json['board'], expected_json['board'])
        exported_json.pop('board')
        for key, value in exported_json.items():
            assert expected_json[key] == value
        assert len(expected_json) == len(exported_json) + 1

    @staticmethod
    def compare_boards(board1, board2):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
        for player in board1:
            assert player in board2
            for piece in board1[player]:
                assert piece in board2[player]
                piece_locations1 = board1[player][piece]
                piece_locations2 = board2[player][piece]
                assert len(piece_locations1) == len(piece_locations2)
                for location in piece_locations1:
                    assert location in piece_locations2


class TestValidateKnightMoves(unittest.TestCase):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""

    def setUp(self):
        self.chess_board = ChessBoard()

    def test_move_knight(self):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
        result = self.chess_board.move((0, 1), (2, 0))

        assert result is True
        assert self.chess_board[(2, 0)].kind == 'knight'

    def test_move_knight_on_top_of_a_pawn(self):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
        result = self.chess_board.move((1, 0), (3, 1))

        assert result is False
        assert self.chess_board[(1, 3)].kind == 'pawn'


class TestValidatePawnMoves(unittest.TestCase):

    """Chess movement unit tests."""

    def setUp(self):
        self.chess_board = ChessBoard()

    def test_pawn_can_move_forward(self):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
        assert self.chess_board[(2, 3)] is None
        ends = self.chess_board.end_locations_for_piece_at_location((1, 3))
        assert ends == [(2, 3), (3, 3)]

    def test_pawn_cant_move_forward_twice_if_not_first_move(self):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
        assert self.chess_board[(2, 3)] is None
        assert self.chess_board[(3, 3)] is None
        self.chess_board[(1, 3)].move_count = 1
        ends = self.chess_board.end_locations_for_piece_at_location((1, 3))
        assert ends == [(2, 3)]

    def test_move_white_pawn(self):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
        pass

    def test_move_black_pawn(self):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
        pass


1			"""Chess Board unit test module."""
2
3			import unittest
4
5			from chess.board import ChessBoard
6
7			starting_fen_board = "rnbqkbnr/pppppppp/8/8/8/8/PPPPPPPP/RNBQKBNR w KQkq - 0 1"
8
9
10			class TestBoard(unittest.TestCase):
11
12			"""Chess unit test class."""
13
14			def setUp(self):
15			self.chess_board = ChessBoard()
16
17			@staticmethod
18			def convert_default_white_spaces_to_black(white_positions):
			0 ignored issues – show Coding Style introduced 2016-01-01 04:50 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
19			return [(7 - row, column) for row, column in white_positions]
20
21			def verify_pieces_at_locations_are_correct_piece_and_color(self, white_positions, piece):
			0 ignored issues – show Coding Style introduced 2016-01-01 04:50 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
22			for location in white_positions:
23			assert self.chess_board[location].kind == piece
24			assert self.chess_board[location].color == "white"
25
26			black_positions = self.convert_default_white_spaces_to_black(white_positions)
27			for location in black_positions:
28			assert self.chess_board[location].kind == piece
29			assert self.chess_board[location].color == "black"
30
31			def test_init(self):
			0 ignored issues – show Coding Style introduced 2016-01-01 04:50 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
32			assert len(self.chess_board) == 64
33
34			def test_has_pawn_at_1_3(self):
			0 ignored issues – show Coding Style introduced 2016-01-01 04:50 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
35			piece = self.chess_board[(1, 3)]
36			assert len(piece.moves) > 0
37
38			def test_initial_pawn_positions(self):
			0 ignored issues – show Coding Style introduced 2016-01-01 04:50 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
39			expected_white_pawn_positions = [(1, 0), (1, 1), (1, 2), (1, 3), (1, 4), (1, 5), (1, 6), (1, 7)]
40			self.verify_pieces_at_locations_are_correct_piece_and_color(expected_white_pawn_positions, "pawn")
41
42			def test_initial_knight_positions(self):
			0 ignored issues – show Coding Style introduced 2016-01-01 04:50 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
43			self.verify_pieces_at_locations_are_correct_piece_and_color([(0, 1), (0, 6)], "knight")
44
45			def test_initial_rook_positions(self):
			0 ignored issues – show Coding Style introduced 2016-01-01 04:50 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
46			self.verify_pieces_at_locations_are_correct_piece_and_color([(0, 0), (0, 7)], "rook")
47
48			def test_initial_bishop_positions(self):
			0 ignored issues – show Coding Style introduced 2016-01-01 04:50 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
49			self.verify_pieces_at_locations_are_correct_piece_and_color([(0, 2), (0, 5)], 'bishop')
50
51			def test_initial_queen_positions(self):
			0 ignored issues – show Coding Style introduced 2016-01-01 04:50 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
52			self.verify_pieces_at_locations_are_correct_piece_and_color([(0, 3)], "queen")
53
54			def test_initial_king_positions(self):
			0 ignored issues – show Coding Style introduced 2016-01-01 04:50 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
55			self.verify_pieces_at_locations_are_correct_piece_and_color([(0, 4)], "king")
56
57			def test_starting_board_fen_export(self):
			0 ignored issues – show Coding Style introduced 2016-01-01 04:50 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
58			assert self.chess_board.generate_fen() == starting_fen_board
59
60			def test_one_move_fen_export(self):
			0 ignored issues – show Coding Style introduced 2016-01-01 04:50 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
61			self.chess_board[(6, 0)] = None
62			expected_fen = "rnbqkbnr/1ppppppp/8/8/8/8/PPPPPPPP/RNBQKBNR w KQkq - 0 1"
63			assert expected_fen == self.chess_board.generate_fen()
64
65			def test_clear_board_removes_all_pieces(self):
			0 ignored issues – show Coding Style introduced 2016-01-01 04:50 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
66			self.chess_board.clear_board()
67			for location in self.chess_board.board:
68			assert self.chess_board[location] is None
69
70			def test_starting_board_fen_import(self):
			0 ignored issues – show Coding Style introduced 2016-01-01 04:50 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
71			self.chess_board.clear_board()
72			self.chess_board.import_fen_board(starting_fen_board)
73
74			expected_white_pawn_positions = [(1, 0), (1, 1), (1, 2), (1, 3), (1, 4), (1, 5), (1, 6), (1, 7)]
75			self.verify_pieces_at_locations_are_correct_piece_and_color(expected_white_pawn_positions, "pawn")
76			self.verify_pieces_at_locations_are_correct_piece_and_color([(0, 1), (0, 6)], "knight")
77			self.verify_pieces_at_locations_are_correct_piece_and_color([(0, 0), (0, 7)], "rook")
78			self.verify_pieces_at_locations_are_correct_piece_and_color([(0, 2), (0, 5)], 'bishop')
79			self.verify_pieces_at_locations_are_correct_piece_and_color([(0, 3)], "queen")
80			self.verify_pieces_at_locations_are_correct_piece_and_color([(0, 4)], "king")
81
82			def test_starting_board_custom_export(self):
			0 ignored issues – show Coding Style introduced 2016-01-01 04:50 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
83			expected_json = self.chess_board.load_json()
84			exported_json = self.chess_board.export()
85			self.compare_boards(exported_json['board'], expected_json['board'])
86			exported_json.pop('board')
87			for key, value in exported_json.items():
88			assert expected_json[key] == value
89			assert len(expected_json) == len(exported_json) + 1
90
91			@staticmethod
92			def compare_boards(board1, board2):
			0 ignored issues – show Coding Style introduced 2016-01-01 04:50 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
93			for player in board1:
94			assert player in board2
95			for piece in board1[player]:
96			assert piece in board2[player]
97			piece_locations1 = board1[player][piece]
98			piece_locations2 = board2[player][piece]
99			assert len(piece_locations1) == len(piece_locations2)
100			for location in piece_locations1:
101			assert location in piece_locations2
102
103
104			class TestValidateKnightMoves(unittest.TestCase):
			0 ignored issues – show Coding Style introduced 2016-01-01 04:50 UTC by Report Bug Copy Issue Report Show Similar Issues like this This class should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
105
106			def setUp(self):
107			self.chess_board = ChessBoard()
108
109			def test_move_knight(self):
			0 ignored issues – show Coding Style introduced 2016-01-01 04:50 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
110			result = self.chess_board.move((0, 1), (2, 0))
111
112			assert result is True
113			assert self.chess_board[(2, 0)].kind == 'knight'
114
115			def test_move_knight_on_top_of_a_pawn(self):
			0 ignored issues – show Coding Style introduced 2016-01-01 04:50 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
116			result = self.chess_board.move((1, 0), (3, 1))
117
118			assert result is False
119			assert self.chess_board[(1, 3)].kind == 'pawn'
120
121
122			class TestValidatePawnMoves(unittest.TestCase):
123
124			"""Chess movement unit tests."""
125
126			def setUp(self):
127			self.chess_board = ChessBoard()
128
129			def test_pawn_can_move_forward(self):
			0 ignored issues – show Coding Style introduced 2016-01-01 04:50 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
130			assert self.chess_board[(2, 3)] is None
131			ends = self.chess_board.end_locations_for_piece_at_location((1, 3))
132			assert ends == [(2, 3), (3, 3)]
133
134			def test_pawn_cant_move_forward_twice_if_not_first_move(self):
			0 ignored issues – show Coding Style introduced 2016-01-01 04:50 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
135			assert self.chess_board[(2, 3)] is None
136			assert self.chess_board[(3, 3)] is None
137			self.chess_board[(1, 3)].move_count = 1
138			ends = self.chess_board.end_locations_for_piece_at_location((1, 3))
139			assert ends == [(2, 3)]
140
141			def test_move_white_pawn(self):
			0 ignored issues – show Coding Style introduced 2016-01-01 04:50 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
142			pass
143
144			def test_move_black_pawn(self):
			0 ignored issues – show Coding Style introduced 2016-01-01 04:50 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
145			pass
146

GitHub Access Token became invalid

Issues (98)

chess/test/test_board.py (23 issues)

Labels

Severity

Introduced By

theovoss / Chess

GitHub Access Token became invalid

Issues (98)

chess/test/test_board.py (23 issues)

Labels

Severity

Introduced By

Duplication Side-by-Side

Filter issues like