Fidry\LaravelYaml\DependencyInjection\Resolver\BuildedParameterResolver

Complexity

Total Complexity

16

Size/Duplication

Total Lines	123
Duplicated Lines	28.46 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes	1
Bugs	0	Features	1

6 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	6	1
A	resolve()	0	4	1
B	resolveValue()	16	16	5
A	resolveArray()	9	9	2
B	resolveString()	0	24	5
A	resolveEnvironmentValue()	10	10	2

<?php

/*
 * This file is part of the LaravelYaml package.
 *
 * (c) Théo FIDRY <theo.fidry@gmail.com>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Fidry\LaravelYaml\DependencyInjection\Resolver;

use Fidry\LaravelYaml\Exception\DependencyInjection\Resolver\ParameterCircularReferenceException;
use Fidry\LaravelYaml\Exception\ParameterNotFoundException;
use Illuminate\Contracts\Config\Repository as ConfigRepository;

/**
 * @author Théo FIDRY <theo.fidry@gmail.com>
 */
final class BuildedParameterResolver implements ParameterResolverInterface
{
    /**
     * @var string
     */
    private $defaultValue;

    /**
     * @var ConfigRepository
     */
    private $config;

    /**
     * @var array
     */
    private $parameters;

    /**
     * @var array
     */
    private $resolved = [];

The property $resolved is not used and could be removed.

    public function __construct(array $parameters, ConfigRepository $config)
    {
        $this->parameters = $parameters;
        $this->config = $config;
        $this->defaultValue = spl_object_hash(new \stdClass());
    }

    /**
     * {@inheritdoc}array
     */
    public function resolve($parameter)
    {
        return $this->resolveValue($parameter, [$parameter => true]);
    }

    /**
     * @param mixed $value
     * @param array $resolving
     *
     * @return mixed
     *
     * @throws ParameterCircularReferenceException
     * @throws ParameterNotFoundException
     */
    private function resolveValue($value, $resolving = [])

This method seems to be duplicated in your project.

    {
        if (is_bool($value) || is_numeric($value)) {
            return $value;
        }

        if (is_array($value)) {
            return $this->resolveArray($value, $resolving);
        }

        if (is_string($value)) {
            return $this->resolveString($value, $resolving);
        }

        return $value;
    }

    private function resolveArray(array $arrayValue, array $resolving)

This method seems to be duplicated in your project.

    {
        $resolvedValue = [];
        foreach ($arrayValue as $key => $value) {
            $resolvedValue[$key] = $this->resolveValue($value, $resolving);
        }

        return $resolvedValue;
    }

    /**
     * @param $value
     * @param $resolving
     *
     * @return array|mixed
     * @throws ParameterCircularReferenceException
     * @throws ParameterNotFoundException
     */
    private function resolveString($value, array $resolving)
    {
        if (0 === preg_match('/^%([^%\s]+)%$/', $value, $match)) {
            if (false === array_key_exists($value, $resolving)) {
                return $value;
            }

            $key = $value;
        } else {
            $key = $match[1];
        }

        if (array_key_exists($key, $this->parameters)) {
            $resolving[$key] = true;

            return $this->resolveValue($this->parameters[$key], $resolving);
        }

        if ($this->config->has($key)) {
            return $this->config->get($key);
        }

        return $this->resolveEnvironmentValue($key);
    }

    /**
     * @param string $key
     *
     * @return string|int|bool|null
     * @throws ParameterNotFoundException
     */
    private function resolveEnvironmentValue($key)

This method seems to be duplicated in your project.

    {
        $environmentKey = strtoupper(str_replace('.', '_', $key));
        $value = env($environmentKey, $this->defaultValue);
        if ($this->defaultValue !== $value) {
            return $value;
        }

        throw new ParameterNotFoundException(sprintf('No parameter "%s" found', $key));
    }
}