Fidry\LaravelYaml\DependencyInjection\Builder\ServicesBuilder

Complexity

Total Complexity

15

Size/Duplication

Total Lines	122
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	6

6 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	11	2
B	build()	0	23	6
A	buildService()	0	18	1
A	resolveArguments()	0	18	3
A	bindAutowiringTypes()	0	6	2
A	tagService()	0	4	1

<?php

/*
 * This file is part of the LaravelYaml package.
 *
 * (c) Théo FIDRY <theo.fidry@gmail.com>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Fidry\LaravelYaml\DependencyInjection\Builder;

use Fidry\LaravelYaml\DependencyInjection\Definition\Reference;
use Fidry\LaravelYaml\DependencyInjection\Definition\Service;
use Fidry\LaravelYaml\DependencyInjection\Resolver\BaseReferenceResolver;
use Fidry\LaravelYaml\DependencyInjection\Resolver\BuildedParameterResolver;
use Fidry\LaravelYaml\DependencyInjection\Resolver\ParameterResolverInterface;
use Fidry\LaravelYaml\DependencyInjection\Resolver\ReferenceResolverInterface;
use Fidry\LaravelYaml\Exception\DependencyInjection\Exception;
use Fidry\LaravelYaml\Exception\DependencyInjection\Resolver\Exception as ResolverException;
use Fidry\LaravelYaml\Exception\ServiceNotFoundException;
use Illuminate\Contracts\Config\Repository as ConfigRepository;
use Illuminate\Contracts\Container\BindingResolutionException;
use Illuminate\Contracts\Foundation\Application;

/**
 * @author Théo FIDRY <theo.fidry@gmail.com>
 */
final class ServicesBuilder implements BuilderInterface
{
    /**
     * @var array
     */
    private $parameters;

    /**
     * @var ReferenceResolverInterface
     */
    private $referenceResolver;

    /**
     * @var Service[]
     */
    private $services;

    /**
     * @var ParameterResolverInterface|null
     */
    private $parameterResolver;

    /**
     * @param Service[]                       $services
     * @param array                           $parameters
     * @param ParameterResolverInterface|null $parameterResolver
     * @param ReferenceResolverInterface|null $referenceResolver
     */
    public function __construct(
        array $services,
        array $parameters,
        ParameterResolverInterface $parameterResolver = null,
        ReferenceResolverInterface $referenceResolver = null
    ) {
        $this->services = $services;
        $this->parameters = $parameters;
        $this->parameterResolver = $parameterResolver;
        $this->referenceResolver = (null === $referenceResolver) ? new BaseReferenceResolver() : $referenceResolver;
    }

    public function build(Application $application)
    {

        try {
            $config = $application->make(ConfigRepository::class);
            $parameterResolver = (null === $this->parameterResolver)
                ? new BuildedParameterResolver($this->parameters, $config)
                : $this->parameterResolver
            ;

            foreach ($this->services as $service) {
                $this->buildService($service, $parameterResolver, $application);

$parameterResolver of type object<Fidry\LaravelYaml\DependencyInjection\Resolver\ParameterResolverInterface> is not a sub-type of object<Fidry\LaravelYaml\DependencyInjection\Resolver\BuildedParameterResolver>. It seems like you assume a concrete implementation of the interface Fidry\LaravelYaml\DependencyInjection\Resolver\ParameterResolverInterface to be always present.

            }

            return $this->parameters;
        } catch (BindingResolutionException $exception) {
            throw new Exception(sprintf('Could not load "%s" class', ConfigRepository::class), 0, $exception);
        } catch (ResolverException $exception) {
            throw new Exception('Could not resolve the parameters', 0, $exception);
        } catch (\Exception $exception) {
            throw new Exception('Could not build the parameters', 0, $exception);
        }
    }

    private function buildService(
        Service $service,
        BuildedParameterResolver $parameterResolver,
        Application $application
    ) {
        $application->singleton(
            $service->getName(),
            function (Application $app) use ($service, $parameterResolver) {
                $constructor = $service->getClass();
                $resolvedArguments = $this->resolveArguments($service, $parameterResolver, $app);

                return new $constructor(...$resolvedArguments);
            }
        );
        $application->bind($service->getClass(), $service->getName());
        $this->bindAutowiringTypes($service, $application);
        $this->tagService($service, $application);
    }

    /**
     * @param Service                  $service
     * @param BuildedParameterResolver $parameterResolver
     * @param Application              $application
     *
     * @return array
     * @throws ServiceNotFoundException
     */
    private function resolveArguments(
        Service $service,
        BuildedParameterResolver $parameterResolver,
        Application $application
    ) {
        $resolvedArguments = [];
        foreach ($service->getArguments() as $argument) {

The expression $service->getArguments() of type array<integer,object<Fidry\LaravelYaml\DependencyInjection\Definition\Argument>>|null is not guaranteed to be traversable. How about adding an additional type check?

            if ($argument instanceof Reference) {
                $resolvedArguments[] = $this->referenceResolver->resolve($argument, $application);

                continue;
            }

            $resolvedArguments[] = $parameterResolver->resolve($argument);
        }

        return $resolvedArguments;
    }

    private function bindAutowiringTypes(Service $service, Application $application)
    {
        foreach ($service->getAutowiringTypes() as $binding) {
            $application->bind($binding, $service->getName());
        }
    }

    private function tagService(Service $service, Application $application)
    {
        $application->tag($service->getName(), array_keys($service->getTags()));
    }
}