AliceODMContext - Code Metrics - Inspection of "Always use the current services" - theofidry/AliceBundleExtension - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#20)

by Eric

created 2016-07-13 09:29 UTC

AliceODMContext A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	65
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	5

Importance

Changes	2
Bugs	0	Features	1

Metric	Value
wmc	7
c	2
b	0
f	1
lcom	1
cbo	5
dl	0
loc	65
rs	10

7 Methods

Rating	Name	Size	Complexity
A	createSchema()	7	1
A	dropSchema()	7	1
A	emptyDatabase()	5	1
A	getPersister()	4	1
A	getFixturesFinder()	4	1
A	getSchemaManager()	4	1
A	getDocumentManager()	4	1

<?php

/*
 * This file is part of the Fidry\AliceBundleExtension package.
 *
 * (c) Théo FIDRY <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Fidry\AliceBundleExtension\Context\Doctrine;

use Doctrine\ODM\MongoDB\DocumentManager;
use Doctrine\ODM\MongoDB\SchemaManager;

/**
 * Context to load fixtures files with Alice loader.
 *
 * @author Théo FIDRY <[email protected]>
 */
class AliceODMContext extends AbstractAliceContext
{
    /**
     * {@inheritdoc}
     */
    public function createSchema()
    {
        $schemaManager = $this->getSchemaManager();

        $schemaManager->createCollections();
        $schemaManager->ensureIndexes();
    }

    /**
     * {@inheritdoc}
     */
    public function dropSchema()
    {
        $schemaManager = $this->getSchemaManager();

        $schemaManager->deleteIndexes();
        $schemaManager->dropCollections();
    }

    /**
     * {@inheritdoc}
     */
    public function emptyDatabase()
    {
        $this->dropSchema();
        $this->createSchema();
    }

    /**
     * {@inheritdoc}
     */
    protected function getPersister()
    {
        return $this->resolvePersister($this->getDocumentManager());
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }

    /**
     * {@inheritdoc}
     */
    protected function getFixturesFinder()
    {
        return $this->kernel->getContainer()->get('hautelook_alice.doctrine.mongodb.fixtures_finder');
    }

    /**
     * @return SchemaManager
     */
    private function getSchemaManager()
    {
        return $this->getDocumentManager()->getSchemaManager();
    }

    /**
     * @return DocumentManager
     */
    private function getDocumentManager()
    {
        return $this->kernel->getContainer()->get('doctrine_mongodb.odm.default_document_manager');
    }
}


1			<?php
2
3			/*
4			* This file is part of the Fidry\AliceBundleExtension package.
5			*
6			* (c) Théo FIDRY <[email protected]>
7			*
8			* For the full copyright and license information, please view the LICENSE
9			* file that was distributed with this source code.
10			*/
11
12			namespace Fidry\AliceBundleExtension\Context\Doctrine;
13
14			use Doctrine\ODM\MongoDB\DocumentManager;
15			use Doctrine\ODM\MongoDB\SchemaManager;
16
17			/**
18			* Context to load fixtures files with Alice loader.
19			*
20			* @author Théo FIDRY <[email protected]>
21			*/
22			class AliceODMContext extends AbstractAliceContext
23			{
24			/**
25			* {@inheritdoc}
26			*/
27			public function createSchema()
28			{
29			$schemaManager = $this->getSchemaManager();
30
31			$schemaManager->createCollections();
32			$schemaManager->ensureIndexes();
33			}
34
35			/**
36			* {@inheritdoc}
37			*/
38			public function dropSchema()
39			{
40			$schemaManager = $this->getSchemaManager();
41
42			$schemaManager->deleteIndexes();
43			$schemaManager->dropCollections();
44			}
45
46			/**
47			* {@inheritdoc}
48			*/
49			public function emptyDatabase()
50			{
51			$this->dropSchema();
52			$this->createSchema();
53			}
54
55			/**
56			* {@inheritdoc}
57			*/
58			protected function getPersister()
59			{
60			return $this->resolvePersister($this->getDocumentManager());
			0 ignored issues – show Documentation introduced 2016-07-13 09:30 UTC by Report Bug Copy Issue Report `$this->getDocumentManager()` is of type `object<Doctrine\ODM\MongoDB\DocumentManager>`, but the function expects a `object<Nelmio\Alice\PersisterInterface>\|null`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
61			}
62
63			/**
64			* {@inheritdoc}
65			*/
66			protected function getFixturesFinder()
67			{
68			return $this->kernel->getContainer()->get('hautelook_alice.doctrine.mongodb.fixtures_finder');
69			}
70
71			/**
72			* @return SchemaManager
73			*/
74			private function getSchemaManager()
75			{
76			return $this->getDocumentManager()->getSchemaManager();
77			}
78
79			/**
80			* @return DocumentManager
81			*/
82			private function getDocumentManager()
83			{
84			return $this->kernel->getContainer()->get('doctrine_mongodb.odm.default_document_manager');
85			}
86			}
87

theofidry / AliceBundleExtension

Pull Request — master (#20)

AliceODMContext A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

7 Methods

Duplication Side-by-Side

Filter issues like