Veto\Layer\Dispatcher\DispatcherLayer::in()

Complexity

Conditions	10
Paths	20

Size

Total Lines	59
Code Lines	30

Duplication

Lines	0
Ratio	0 %

Importance

Changes	4
Bugs	0	Features	1

<?php
    public function in(Request $request)
    {
        // Get the controller
        $controllerSpec = $request->getParameter('_controller');

        if (!$controllerSpec) {
            throw DispatcherException::notTagged(
                $request->getMethod(),
                $request->getUri() ? $request->getUri()->getPath() : ''
            );
        }

        $controller = $this->container->get($controllerSpec['class']);

        if (!method_exists($controller, $controllerSpec['method'])) {
            throw DispatcherException::controllerActionDoesNotExist(
                $controllerSpec['method'],
                $controllerSpec['class']
            );
        }

        // Prepare to run the action method
        $actionMethod = new \ReflectionMethod($controller, $controllerSpec['method']);
        $parameters = $actionMethod->getParameters();
        $passedArgs = array();

        foreach ($parameters as $parameter) {

            $hintedClass = $parameter->getClass();
            $parameterName = $parameter->getName();

Consider using $parameter->name. There is an issue with getName() and APC-enabled PHP versions.

            if ($hintedClass) {
                $hintedClass = $hintedClass->getName();

Consider using $hintedClass->name. There is an issue with getName() and APC-enabled PHP versions.

            }

            // Special case - should the Request object be passed here?
            if ($parameterName == 'request' && $hintedClass == 'Veto\HTTP\Request') {
                $passedArgs[] = $request;
            }

            // Should a request parameter be passed here?
            if ($request->hasParameter($parameterName)) {
                $passedArgs[] = $request->getParameter($parameterName);
            }
        }

        $response = $actionMethod->invokeArgs($controller, $passedArgs);

        // By the end of the inbound layer list, a response should have been obtained
        if (!$response instanceof Response) {
            throw DispatcherException::controllerActionDidNotReturnResponse(
                $controllerSpec['method'],
                $controllerSpec['class'],
                gettype($response)
            );
        }

        return $response;
    }
}