Issues in RewriteUrl.php - New Issues - Inspection of "Version 1.3.1" - thelia-modules/RewriteUrl - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#11)

by Gilles

created 2016-02-26 16:59 UTC

RewriteUrl.php (5 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/*************************************************************************************/
/*      This file is part of the RewriteUrl module for Thelia.                       */
/*                                                                                   */
/*      Copyright (c) OpenStudio                                                     */
/*      email : [email protected]                                                       */
/*      web : http://www.thelia.net                                                  */
/*                                                                                   */
/*      For the full copyright and license information, please view the LICENSE.txt  */
/*      file that was distributed with this source code.                             */
/*************************************************************************************/

namespace RewriteUrl;

use Propel\Runtime\Connection\ConnectionInterface;
use Thelia\Model\ConfigQuery;
use Thelia\Model\Map\RewritingUrlTableMap;
use Thelia\Model\RewritingUrl;
use Thelia\Model\RewritingUrlQuery;
use Thelia\Module\BaseModule;

/**
 * Class RewriteUrl
 * @package RewriteUrl
 * @author Vincent Lopes <[email protected]>
 * @author Gilles Bourgeat <[email protected]>
 */
class RewriteUrl extends BaseModule
{
    /** @var string  */
    const MODULE_DOMAIN = "rewriteurl";

    /** @var string  */
    const MODULE_NAME = "rewriteurl";

    /** @static null|array */
    static $unknownSources;
class A {
    var $property;
}

    /**
     * @param string $currentVersion
     * @param string $newVersion
     * @param ConnectionInterface $con
     * @throws \Exception
     * @throws \Propel\Runtime\Exception\PropelException
     * @since 1.2.3
     */
    public function update($currentVersion, $newVersion, ConnectionInterface $con = null)
    {
        /*
         * Fix for urls that redirect on itself
         */
        $urls = RewritingUrlQuery::create()
            ->where(RewritingUrlTableMap::ID . " = " . RewritingUrlTableMap::REDIRECTED)
            ->find();

        /** @var RewritingUrl $url */
        foreach ($urls as $url) {
            $parent = RewritingUrlQuery::create()
                ->filterByView($url->getView())
                ->filterByViewId($url->getViewId())
                ->filterByViewLocale($url->getViewLocale())
                ->filterByRedirected(null)
                ->findOne();

            $url->setRedirected(($parent === null) ? null : $parent->getId())->save();
        }
    }

    /**
     * @return array|null
     */
    public static function getUnknownSources()
    {
        if (static::$unknownSources === null) {
class YourClass
{
    private static $someVariable;

    public static function getSomeVariable()
    {
        return static::$someVariable;
    }
}
            static::$unknownSources = [];
class YourClass
{
    private static $someVariable;

    public static function getSomeVariable()
    {
        return static::$someVariable;
    }
}
            if (null !== $config = ConfigQuery::read('obsolete_rewriten_url_view', null)) {
                static::$unknownSources[] = $config;
class YourClass
{
    private static $someVariable;

    public static function getSomeVariable()
    {
        return static::$someVariable;
    }
}
            }
        }
        return static::$unknownSources;
class YourClass
{
    private static $someVariable;

    public static function getSomeVariable()
    {
        return static::$someVariable;
    }
}
    }
}


1			<?php
2			/*************************************************************************************/
3			/* This file is part of the RewriteUrl module for Thelia. */
4			/* */
5			/* Copyright (c) OpenStudio */
6			/* email : [email protected] */
7			/* web : http://www.thelia.net */
8			/* */
9			/* For the full copyright and license information, please view the LICENSE.txt */
10			/* file that was distributed with this source code. */
11			/*************************************************************************************/
12
13			namespace RewriteUrl;
14
15			use Propel\Runtime\Connection\ConnectionInterface;
16			use Thelia\Model\ConfigQuery;
17			use Thelia\Model\Map\RewritingUrlTableMap;
18			use Thelia\Model\RewritingUrl;
19			use Thelia\Model\RewritingUrlQuery;
20			use Thelia\Module\BaseModule;
21
22			/**
23			* Class RewriteUrl
24			* @package RewriteUrl
25			* @author Vincent Lopes <[email protected]>
26			* @author Gilles Bourgeat <[email protected]>
27			*/
28			class RewriteUrl extends BaseModule
29			{
30			/** @var string */
31			const MODULE_DOMAIN = "rewriteurl";
32
33			/** @var string */
34			const MODULE_NAME = "rewriteurl";
35
36			/** @static null\|array */
37			static $unknownSources;
			0 ignored issues – show Coding Style introduced 2016-02-26 17:00 UTC by Report Bug Copy Issue Report Show Similar Issues like this The visibility should be declared for property `$unknownSources`. The PSR-2 coding standard requires that all properties in a class have their visibility explicitly declared. If you declare a property using class A { var $property; } the property is implicitly global. To learn more about the PSR-2, please see the PHP-FIG site on the PSR-2. Loading history...
38
39			/**
40			* @param string $currentVersion
41			* @param string $newVersion
42			* @param ConnectionInterface $con
43			* @throws \Exception
44			* @throws \Propel\Runtime\Exception\PropelException
45			* @since 1.2.3
46			*/
47			public function update($currentVersion, $newVersion, ConnectionInterface $con = null)
48			{
49			/*
50			* Fix for urls that redirect on itself
51			*/
52			$urls = RewritingUrlQuery::create()
53			->where(RewritingUrlTableMap::ID . " = " . RewritingUrlTableMap::REDIRECTED)
54			->find();
55
56			/** @var RewritingUrl $url */
57			foreach ($urls as $url) {
58			$parent = RewritingUrlQuery::create()
59			->filterByView($url->getView())
60			->filterByViewId($url->getViewId())
61			->filterByViewLocale($url->getViewLocale())
62			->filterByRedirected(null)
63			->findOne();
64
65			$url->setRedirected(($parent === null) ? null : $parent->getId())->save();
66			}
67			}
68
69			/**
70			* @return array\|null
71			*/
72			public static function getUnknownSources()
73			{
74			if (static::$unknownSources === null) {
			0 ignored issues – show Bug introduced 2016-02-26 17:00 UTC by Report Bug Copy Issue Report Show Similar Issues like this Since `$unknownSources` is declared private, accessing it with `static` will lead to errors in possible sub-classes; consider using `self`, or increasing the visibility of `$unknownSources` to at least protected. Let’s assume you have a class which uses late-static binding: class YourClass { private static $someVariable; public static function getSomeVariable() { return static::$someVariable; } } The code above will run fine in your PHP runtime. However, if you now create a sub-class and call the `getSomeVariable()` on that sub-class, you will receive a runtime error: class YourSubClass extends YourClass { } YourSubClass::getSomeVariable(); // Will cause an access error. In the case above, it makes sense to update `SomeClass` to use `self` instead: class SomeClass { private static $someVariable; public static function getSomeVariable() { return self::$someVariable; // self works fine with private. } } Loading history...
75			static::$unknownSources = [];
			0 ignored issues – show Bug introduced 2016-02-26 17:00 UTC by Report Bug Copy Issue Report Show Similar Issues like this Since `$unknownSources` is declared private, accessing it with `static` will lead to errors in possible sub-classes; consider using `self`, or increasing the visibility of `$unknownSources` to at least protected. Let’s assume you have a class which uses late-static binding: class YourClass { private static $someVariable; public static function getSomeVariable() { return static::$someVariable; } } The code above will run fine in your PHP runtime. However, if you now create a sub-class and call the `getSomeVariable()` on that sub-class, you will receive a runtime error: class YourSubClass extends YourClass { } YourSubClass::getSomeVariable(); // Will cause an access error. In the case above, it makes sense to update `SomeClass` to use `self` instead: class SomeClass { private static $someVariable; public static function getSomeVariable() { return self::$someVariable; // self works fine with private. } } Loading history...
76			if (null !== $config = ConfigQuery::read('obsolete_rewriten_url_view', null)) {
77			static::$unknownSources[] = $config;
			0 ignored issues – show Bug introduced 2016-02-26 17:00 UTC by Report Bug Copy Issue Report Show Similar Issues like this Since `$unknownSources` is declared private, accessing it with `static` will lead to errors in possible sub-classes; consider using `self`, or increasing the visibility of `$unknownSources` to at least protected. Let’s assume you have a class which uses late-static binding: class YourClass { private static $someVariable; public static function getSomeVariable() { return static::$someVariable; } } The code above will run fine in your PHP runtime. However, if you now create a sub-class and call the `getSomeVariable()` on that sub-class, you will receive a runtime error: class YourSubClass extends YourClass { } YourSubClass::getSomeVariable(); // Will cause an access error. In the case above, it makes sense to update `SomeClass` to use `self` instead: class SomeClass { private static $someVariable; public static function getSomeVariable() { return self::$someVariable; // self works fine with private. } } Loading history...
78			}
79			}
80			return static::$unknownSources;
			0 ignored issues – show Bug introduced 2016-02-26 17:00 UTC by Report Bug Copy Issue Report Show Similar Issues like this Since `$unknownSources` is declared private, accessing it with `static` will lead to errors in possible sub-classes; consider using `self`, or increasing the visibility of `$unknownSources` to at least protected. Let’s assume you have a class which uses late-static binding: class YourClass { private static $someVariable; public static function getSomeVariable() { return static::$someVariable; } } The code above will run fine in your PHP runtime. However, if you now create a sub-class and call the `getSomeVariable()` on that sub-class, you will receive a runtime error: class YourSubClass extends YourClass { } YourSubClass::getSomeVariable(); // Will cause an access error. In the case above, it makes sense to update `SomeClass` to use `self` instead: class SomeClass { private static $someVariable; public static function getSomeVariable() { return self::$someVariable; // self works fine with private. } } Loading history...
81			}
82			}
83

thelia-modules / RewriteUrl

Pull Request — master (#11)

RewriteUrl.php (5 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like