NotRewritenUrlCategoryLoop::buildModelCriteria() - Code Metrics - Inspection of "WP new feature, list of not rewritten urls" - thelia-modules/RewriteUrl - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#12)

unknown

created 2016-03-09 13:38 UTC

NotRewritenUrlCategoryLoop::buildModelCriteria() B

↳ Parent: NotRewritenUrlCategoryLoop

Complexity

Conditions	6
Paths	6

Size

Total Lines	52
Code Lines	44

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	52
rs	8.6868
cc	6
eloc	44
nc	6
nop	0

How to fix Long Method

<?php
/*************************************************************************************/
/*      This file is part of the RewriteUrl module for Thelia.                       */
/*                                                                                   */
/*      Copyright (c) OpenStudio                                                     */
/*      email : [email protected]                                                       */
/*      web : http://www.thelia.net                                                  */
/*                                                                                   */
/*      For the full copyright and license information, please view the LICENSE.txt  */
/*      file that was distributed with this source code.                             */
/*************************************************************************************/

namespace RewriteUrl\Loop;

use Propel\Runtime\ActiveQuery\Criteria;
use Propel\Runtime\ActiveQuery\Join;
use Thelia\Core\Template\Element\BaseI18nLoop;
use Thelia\Core\Template\Element\LoopResult;
use Thelia\Core\Template\Element\LoopResultRow;
use Thelia\Core\Template\Element\PropelSearchLoopInterface;
use Thelia\Core\Template\Loop\Argument\Argument;
use Thelia\Core\Template\Loop\Argument\ArgumentCollection;
use Thelia\Model\Base\BrandQuery;
use Thelia\Model\CategoryQuery;
use Thelia\Model\ContentQuery;
use Thelia\Model\FolderQuery;
use Thelia\Model\LangQuery;
use Thelia\Model\Map\BrandTableMap;
use Thelia\Model\Map\CategoryTableMap;
use Thelia\Model\Map\ContentTableMap;
use Thelia\Model\Map\FolderTableMap;
use Thelia\Model\Map\ProductTableMap;
use Thelia\Model\Map\RewritingUrlTableMap;
use Thelia\Model\ProductQuery;

/**
 * Class NotRewritenUrlCategoryLoop
 * @package RewriteUrl\Loop
 * @author Tom Pradat <[email protected]>
 */
class NotRewritenUrlCategoryLoop extends BaseI18nLoop implements PropelSearchLoopInterface
{
    protected function getArgDefinitions()
    {
        return new ArgumentCollection(
            Argument::createAnyTypeArgument('categorie')
        );
    }

    public function buildModelCriteria()
    {
        $localequery = LangQuery::create()->findOneById($this->getLang());
        $locale = $localequery->getLocale();
        $cat = ucfirst($this->getCategorie());
        $objectQuery = null;
        $urlJoin = null;

        switch ($cat) {
            case 'Product':
                $objectQuery = ProductQuery::create();
                $urlJoin = new Join(ProductTableMap::ID, RewritingUrlTableMap::VIEW_ID, Criteria::LEFT_JOIN);
                break;
            case 'Brand':
                $objectQuery = BrandQuery::create();
                $urlJoin = new Join(BrandTableMap::ID, RewritingUrlTableMap::VIEW_ID, Criteria::LEFT_JOIN);
                break;
            case 'Category':
                $objectQuery = CategoryQuery::create();
                $urlJoin = new Join(CategoryTableMap::ID, RewritingUrlTableMap::VIEW_ID, Criteria::LEFT_JOIN);
                break;
            case 'Folder':
                $objectQuery = FolderQuery::create();
                $urlJoin = new Join(FolderTableMap::ID, RewritingUrlTableMap::VIEW_ID, Criteria::LEFT_JOIN);
                break;
            case 'Content':
                $objectQuery = ContentQuery::create();
                $urlJoin = new Join(ContentTableMap::ID, RewritingUrlTableMap::VIEW_ID, Criteria::LEFT_JOIN);
                break;
        }

        $query = $objectQuery
            ->joinWithI18n($locale)
            ->addJoinObject($urlJoin, 'url_rewriting_join')
            ->addJoinCondition(
                'url_rewriting_join',
                RewritingUrlTableMap::VIEW . ' = ?',
                strtolower($cat),
                null,
                \PDO::PARAM_STR
            )
            ->addJoinCondition(
                'url_rewriting_join',
                RewritingUrlTableMap::VIEW_LOCALE . ' = ?',
                $locale,
                null,
                \PDO::PARAM_STR
            )
            ->where('ISNULL(rewriting_url.id)')
        ;
        return $query;
    }

    public function parseResults(LoopResult $loopResult)
    {
        foreach ($loopResult->getResultDataCollection() as $category) {
            $loopResultRow = (new LoopResultRow($category))
                ->set('ID', $category->getId())
                ->set('NAME', $category->getTitle());

            if (property_exists($category, 'ref')) {
                $loopResultRow->set('REF', $category->getRef());
            }
            $loopResult->addRow($loopResultRow);
        }

        return $loopResult;
    }
}

1			<?php
2			/*************************************************************************************/
3			/* This file is part of the RewriteUrl module for Thelia. */
4			/* */
5			/* Copyright (c) OpenStudio */
6			/* email : [email protected] */
7			/* web : http://www.thelia.net */
8			/* */
9			/* For the full copyright and license information, please view the LICENSE.txt */
10			/* file that was distributed with this source code. */
11			/*************************************************************************************/
12
13			namespace RewriteUrl\Loop;
14
15			use Propel\Runtime\ActiveQuery\Criteria;
16			use Propel\Runtime\ActiveQuery\Join;
17			use Thelia\Core\Template\Element\BaseI18nLoop;
18			use Thelia\Core\Template\Element\LoopResult;
19			use Thelia\Core\Template\Element\LoopResultRow;
20			use Thelia\Core\Template\Element\PropelSearchLoopInterface;
21			use Thelia\Core\Template\Loop\Argument\Argument;
22			use Thelia\Core\Template\Loop\Argument\ArgumentCollection;
23			use Thelia\Model\Base\BrandQuery;
24			use Thelia\Model\CategoryQuery;
25			use Thelia\Model\ContentQuery;
26			use Thelia\Model\FolderQuery;
27			use Thelia\Model\LangQuery;
28			use Thelia\Model\Map\BrandTableMap;
29			use Thelia\Model\Map\CategoryTableMap;
30			use Thelia\Model\Map\ContentTableMap;
31			use Thelia\Model\Map\FolderTableMap;
32			use Thelia\Model\Map\ProductTableMap;
33			use Thelia\Model\Map\RewritingUrlTableMap;
34			use Thelia\Model\ProductQuery;
35
36			/**
37			* Class NotRewritenUrlCategoryLoop
38			* @package RewriteUrl\Loop
39			* @author Tom Pradat <[email protected]>
40			*/
41			class NotRewritenUrlCategoryLoop extends BaseI18nLoop implements PropelSearchLoopInterface
42			{
43			protected function getArgDefinitions()
44			{
45			return new ArgumentCollection(
46			Argument::createAnyTypeArgument('categorie')
47			);
48			}
49
50			public function buildModelCriteria()
51			{
52			$localequery = LangQuery::create()->findOneById($this->getLang());
53			$locale = $localequery->getLocale();
54			$cat = ucfirst($this->getCategorie());
55			$objectQuery = null;
56			$urlJoin = null;
57
58			switch ($cat) {
59			case 'Product':
60			$objectQuery = ProductQuery::create();
61			$urlJoin = new Join(ProductTableMap::ID, RewritingUrlTableMap::VIEW_ID, Criteria::LEFT_JOIN);
62			break;
63			case 'Brand':
64			$objectQuery = BrandQuery::create();
65			$urlJoin = new Join(BrandTableMap::ID, RewritingUrlTableMap::VIEW_ID, Criteria::LEFT_JOIN);
66			break;
67			case 'Category':
68			$objectQuery = CategoryQuery::create();
69			$urlJoin = new Join(CategoryTableMap::ID, RewritingUrlTableMap::VIEW_ID, Criteria::LEFT_JOIN);
70			break;
71			case 'Folder':
72			$objectQuery = FolderQuery::create();
73			$urlJoin = new Join(FolderTableMap::ID, RewritingUrlTableMap::VIEW_ID, Criteria::LEFT_JOIN);
74			break;
75			case 'Content':
76			$objectQuery = ContentQuery::create();
77			$urlJoin = new Join(ContentTableMap::ID, RewritingUrlTableMap::VIEW_ID, Criteria::LEFT_JOIN);
78			break;
79			}
80
81			$query = $objectQuery
82			->joinWithI18n($locale)
83			->addJoinObject($urlJoin, 'url_rewriting_join')
84			->addJoinCondition(
85			'url_rewriting_join',
86			RewritingUrlTableMap::VIEW . ' = ?',
87			strtolower($cat),
88			null,
89			\PDO::PARAM_STR
90			)
91			->addJoinCondition(
92			'url_rewriting_join',
93			RewritingUrlTableMap::VIEW_LOCALE . ' = ?',
94			$locale,
95			null,
96			\PDO::PARAM_STR
97			)
98			->where('ISNULL(rewriting_url.id)')
99			;
100			return $query;
101			}
102
103			public function parseResults(LoopResult $loopResult)
104			{
105			foreach ($loopResult->getResultDataCollection() as $category) {
106			$loopResultRow = (new LoopResultRow($category))
107			->set('ID', $category->getId())
108			->set('NAME', $category->getTitle());
109
110			if (property_exists($category, 'ref')) {
111			$loopResultRow->set('REF', $category->getRef());
112			}
113			$loopResult->addRow($loopResultRow);
114			}
115
116			return $loopResult;
117			}
118			}

thelia-modules / RewriteUrl

Pull Request — master (#12)

NotRewritenUrlCategoryLoop::buildModelCriteria() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like