Issues in ContentLinkService.php (master) - Issues in master - thelia-modules/Dealer - Measure and Improve Code Quality continuously with Scrutinizer

Issues (36)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

Service/ContentLinkService.php (1 issue)

Labels

Unused Code 1

Severity

Minor 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/*************************************************************************************/
/*      This file is part of the Thelia package.                                     */
/*                                                                                   */
/*      Copyright (c) OpenStudio                                                     */
/*      email : [email protected]                                                       */
/*      web : http://www.thelia.net                                                  */
/*                                                                                   */
/*      For the full copyright and license information, please view the LICENSE.txt  */
/*      file that was distributed with this source code.                             */
/*************************************************************************************/
/*************************************************************************************/

namespace Dealer\Service;

use Dealer\Event\DealerContentLinkEvent;
use Dealer\Event\DealerEvents;
use Dealer\Model\DealerContent;
use Dealer\Model\DealerContentQuery;
use Dealer\Service\Base\AbstractBaseService;
use Dealer\Service\Base\BaseServiceInterface;
use Symfony\Component\EventDispatcher\Event;

/**
 * Class ContentLinkService
 * @package Dealer\Service
 */
class ContentLinkService extends AbstractBaseService implements BaseServiceInterface
{
    const EVENT_CREATE = DealerEvents::DEALER_CONTENT_LINK_CREATE;
    const EVENT_CREATE_BEFORE = DealerEvents::DEALER_CONTENT_LINK_CREATE_BEFORE;
    const EVENT_CREATE_AFTER = DealerEvents::DEALER_CONTENT_LINK_CREATE_AFTER;
    const EVENT_DELETE = DealerEvents::DEALER_CONTENT_LINK_DELETE;
    const EVENT_DELETE_BEFORE = DealerEvents::DEALER_CONTENT_LINK_DELETE_BEFORE;
    const EVENT_DELETE_AFTER = DealerEvents::DEALER_CONTENT_LINK_DELETE_AFTER;
    const EVENT_UPDATE = DealerEvents::DEALER_CONTENT_LINK_UPDATE;
    const EVENT_UPDATE_BEFORE = DealerEvents::DEALER_CONTENT_LINK_UPDATE_BEFORE;
    const EVENT_UPDATE_AFTER = DealerEvents::DEALER_CONTENT_LINK_UPDATE_AFTER;

    /**
     * @inheritDoc
     */
    protected function createProcess(Event $event)
    {
        /** @var DealerContentLinkEvent $event */
        $event->getDealerContentLink()->save();
    }

    /**
     * @inheritDoc
     */
    protected function updateProcess(Event $event)
    {
        /** @var DealerContentLinkEvent $event */
        $event->getDealerContentLink()->save();
    }

    protected function deleteProcess(Event $event)
    {
        /** @var DealerContentLinkEvent $event */
        $event->getDealerContentLink()->delete();
    }

    public function createFromArray($data, $locale = null)
    {
        $link = $this->hydrateObjectArray($data, $locale);

        $event = new DealerContentLinkEvent();
        $event->setDealerContentLink($link);

        $this->create($event);

        return $event->getDealerContentLink();
    }

    public function updateFromArray($data, $locale = null)
    {
        $link = $this->hydrateObjectArray($data, $locale);

        $event = new DealerContentLinkEvent();
        $event->setDealerContentLink($link);

        $this->update($event);

        return $event->getDealerContentLink();
    }

    public function deleteFromId($id)
    {
        $link = DealerContentQuery::create()->findOneById($id);
        if ($link) {
            $event = new DealerContentLinkEvent();
            $event->setDealerContentLink($link);

            $this->delete($event);
        }
    }

    public function deleteFromArray($data)
    {
        $link = null;

        if (isset($data["content_id"]) && isset($data["dealer_id"])) {
            $link = DealerContentQuery::create()->filterByDealerId($data["dealer_id"])->filterByContentId($data["content_id"])->findOne();
        }

        if ($link) {
            $event = new DealerContentLinkEvent();
            $event->setDealerContentLink($link);

            $this->delete($event);
        }
    }

    protected function hydrateObjectArray($data, $locale = null)

    {
        $model = new DealerContent();

        if (isset($data['id'])) {
            $link = DealerContentQuery::create()->findOneById($data['id']);
            if ($link) {
                $model = $link;
            }
        }

        if (isset($data["content_id"]) && isset($data["dealer_id"])) {
            $link = DealerContentQuery::create()->filterByDealerId($data["dealer_id"])->filterByContentId($data["content_id"])->findOne();
            if ($link) {
                throw new \Exception("A link already exist", 403);
            }

            $model->setContentId($data["content_id"]);
            $model->setDealerId($data["dealer_id"]);
        }

        return $model;
    }
}


1			<?php
2			/*************************************************************************************/
3			/* This file is part of the Thelia package. */
4			/* */
5			/* Copyright (c) OpenStudio */
6			/* email : [email protected] */
7			/* web : http://www.thelia.net */
8			/* */
9			/* For the full copyright and license information, please view the LICENSE.txt */
10			/* file that was distributed with this source code. */
11			/*************************************************************************************/
12			/*************************************************************************************/
13
14			namespace Dealer\Service;
15
16			use Dealer\Event\DealerContentLinkEvent;
17			use Dealer\Event\DealerEvents;
18			use Dealer\Model\DealerContent;
19			use Dealer\Model\DealerContentQuery;
20			use Dealer\Service\Base\AbstractBaseService;
21			use Dealer\Service\Base\BaseServiceInterface;
22			use Symfony\Component\EventDispatcher\Event;
23
24			/**
25			* Class ContentLinkService
26			* @package Dealer\Service
27			*/
28			class ContentLinkService extends AbstractBaseService implements BaseServiceInterface
29			{
30			const EVENT_CREATE = DealerEvents::DEALER_CONTENT_LINK_CREATE;
31			const EVENT_CREATE_BEFORE = DealerEvents::DEALER_CONTENT_LINK_CREATE_BEFORE;
32			const EVENT_CREATE_AFTER = DealerEvents::DEALER_CONTENT_LINK_CREATE_AFTER;
33			const EVENT_DELETE = DealerEvents::DEALER_CONTENT_LINK_DELETE;
34			const EVENT_DELETE_BEFORE = DealerEvents::DEALER_CONTENT_LINK_DELETE_BEFORE;
35			const EVENT_DELETE_AFTER = DealerEvents::DEALER_CONTENT_LINK_DELETE_AFTER;
36			const EVENT_UPDATE = DealerEvents::DEALER_CONTENT_LINK_UPDATE;
37			const EVENT_UPDATE_BEFORE = DealerEvents::DEALER_CONTENT_LINK_UPDATE_BEFORE;
38			const EVENT_UPDATE_AFTER = DealerEvents::DEALER_CONTENT_LINK_UPDATE_AFTER;
39
40			/**
41			* @inheritDoc
42			*/
43			protected function createProcess(Event $event)
44			{
45			/** @var DealerContentLinkEvent $event */
46			$event->getDealerContentLink()->save();
47			}
48
49			/**
50			* @inheritDoc
51			*/
52			protected function updateProcess(Event $event)
53			{
54			/** @var DealerContentLinkEvent $event */
55			$event->getDealerContentLink()->save();
56			}
57
58			protected function deleteProcess(Event $event)
59			{
60			/** @var DealerContentLinkEvent $event */
61			$event->getDealerContentLink()->delete();
62			}
63
64			public function createFromArray($data, $locale = null)
65			{
66			$link = $this->hydrateObjectArray($data, $locale);
67
68			$event = new DealerContentLinkEvent();
69			$event->setDealerContentLink($link);
70
71			$this->create($event);
72
73			return $event->getDealerContentLink();
74			}
75
76			public function updateFromArray($data, $locale = null)
77			{
78			$link = $this->hydrateObjectArray($data, $locale);
79
80			$event = new DealerContentLinkEvent();
81			$event->setDealerContentLink($link);
82
83			$this->update($event);
84
85			return $event->getDealerContentLink();
86			}
87
88			public function deleteFromId($id)
89			{
90			$link = DealerContentQuery::create()->findOneById($id);
91			if ($link) {
92			$event = new DealerContentLinkEvent();
93			$event->setDealerContentLink($link);
94
95			$this->delete($event);
96			}
97			}
98
99			public function deleteFromArray($data)
100			{
101			$link = null;
102
103			if (isset($data["content_id"]) && isset($data["dealer_id"])) {
104			$link = DealerContentQuery::create()->filterByDealerId($data["dealer_id"])->filterByContentId($data["content_id"])->findOne();
105			}
106
107			if ($link) {
108			$event = new DealerContentLinkEvent();
109			$event->setDealerContentLink($link);
110
111			$this->delete($event);
112			}
113			}
114
115			protected function hydrateObjectArray($data, $locale = null)
			0 ignored issues – show Unused Code introduced 2018-03-26 14:26 UTC by Report Bug Copy Issue Report Show Similar Issues like this The parameter `$locale` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
116			{
117			$model = new DealerContent();
118
119			if (isset($data['id'])) {
120			$link = DealerContentQuery::create()->findOneById($data['id']);
121			if ($link) {
122			$model = $link;
123			}
124			}
125
126			if (isset($data["content_id"]) && isset($data["dealer_id"])) {
127			$link = DealerContentQuery::create()->filterByDealerId($data["dealer_id"])->filterByContentId($data["content_id"])->findOne();
128			if ($link) {
129			throw new \Exception("A link already exist", 403);
130			}
131
132			$model->setContentId($data["content_id"]);
133			$model->setDealerId($data["dealer_id"]);
134			}
135
136			return $model;
137			}
138			}
139

thelia-modules / Dealer

Issues (36)

Security Analysis not enabled

Service/ContentLinkService.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like