Issues in BrandLinkController.php (master) - Issues in master - thelia-modules/Dealer - Measure and Improve Code Quality continuously with Scrutinizer

Issues (36)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

Controller/BrandLinkController.php (2 issues)

Labels

Severity

Major 2

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/*************************************************************************************/
/*      This file is part of the Thelia package.                                     */
/*                                                                                   */
/*      Copyright (c) OpenStudio                                                     */
/*      email : [email protected]                                                       */
/*      web : http://www.thelia.net                                                  */
/*                                                                                   */
/*      For the full copyright and license information, please view the LICENSE.txt  */
/*      file that was distributed with this source code.                             */
/*************************************************************************************/
/*************************************************************************************/

namespace Dealer\Controller;

use Dealer\Controller\Base\BaseController;
use Dealer\Dealer;
use Dealer\Model\DealerBrand;
use Propel\Runtime\Propel;
use Symfony\Component\HttpFoundation\RedirectResponse;
use Thelia\Core\Security\AccessManager;
use Thelia\Core\Security\Resource\AdminResources;
use Thelia\Tools\URL;

/**
 * Class BrandLinkController
 * @package Dealer\Controller
 */
class BrandLinkController extends BaseController
{
    const CONTROLLER_ENTITY_NAME = "dealer_brand_link";
    const CONTROLLER_CHECK_RESOURCE = Dealer::RESOURCES_ASSOCIATED;
    /**
     * @inheritDoc
     */
    protected function getListRenderTemplate()
    {
        $id = $this->getRequest()->query->get("dealer_id");

        return new RedirectResponse(URL::getInstance()->absoluteUrl("/admin/module/Dealer/dealer/edit#associated",
            ["dealer_id" => $id, ]));
    }

    /**
     * @inheritDoc
     */
    protected function redirectToListTemplate()
    {
        $id = $this->getRequest()->request->get("dealer_id");

        return new RedirectResponse(URL::getInstance()->absoluteUrl("/admin/module/Dealer/dealer/edit#associated",
            ["dealer_id" => $id, ]));
    }

    /**
     * @inheritDoc
     */
    protected function getEditRenderTemplate()
    {
        // TODO: Implement getEditRenderTemplate() method.
    }

    /**
     * @inheritDoc
     */
    protected function getCreateRenderTemplate()
    {
        // TODO: Implement getCreateRenderTemplate() method.
    }

    /**
     * @inheritDoc
     */
    protected function getObjectId($object)
    {
        /** @var DealerBrand $object */
        return $object->getId();
    }

    /**
     * @inheritDoc
     */
    protected function getExistingObject()
    {
        // TODO: Implement getExistingObject() method.
    }

    /**
     * @inheritDoc
     */
    protected function hydrateObjectForm($object)
    {
        // TODO: Implement hydrateObjectForm() method.
    }

    /**
     * Method to get current controller associated service
     * @return object
     */
    protected function getService()
    {
        if (!$this->service) {
            $this->service = $this->getContainer()->get("dealer_brand_link_service");
        }

        return $this->service;
    }

    /**
     * Method to get Base Creation Form
     * @return \Thelia\Form\BaseForm
     */
    protected function getCreationForm()
    {
        return $this->createForm(static::CONTROLLER_ENTITY_NAME . "_create");
    }

    /**
     * Delete an object
     *
     * @return \Thelia\Core\HttpFoundation\Response the response
     */
    public function deleteAction()
    {
        // Check current user authorization
        if (null !== $response = $this->checkAuth(AdminResources::MODULE, Dealer::getModuleCode(),
                AccessManager::DELETE)
        ) {
            return $response;
        }

        $con = Propel::getConnection();
        $con->beginTransaction();
        try {
            // Check token
            $this->getTokenProvider()->checkToken(
                $this->getRequest()->query->get("_token")
            );
            $data = [
                "brand_id" => $this->getRequest()->request->get(static::CONTROLLER_ENTITY_NAME . "_id"),
                "dealer_id" => $this->getRequest()->request->get("dealer_id"),
            ];
            $this->getService()->deleteFromArray($data);
            $con->commit();

            if ($this->getRequest()->request->get("success_url") == null) {
                return $this->redirectToListTemplate();
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
            } else {
                return new RedirectResponse(URL::getInstance()->absoluteUrl($this->getRequest()->request->get("success_url")));
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
            }
        } catch (\Exception $e) {
            $con->rollBack();

            return $this->renderAfterDeleteError($e);
        }
    }
}


1			<?php
2			/*************************************************************************************/
3			/* This file is part of the Thelia package. */
4			/* */
5			/* Copyright (c) OpenStudio */
6			/* email : [email protected] */
7			/* web : http://www.thelia.net */
8			/* */
9			/* For the full copyright and license information, please view the LICENSE.txt */
10			/* file that was distributed with this source code. */
11			/*************************************************************************************/
12			/*************************************************************************************/
13
14			namespace Dealer\Controller;
15
16			use Dealer\Controller\Base\BaseController;
17			use Dealer\Dealer;
18			use Dealer\Model\DealerBrand;
19			use Propel\Runtime\Propel;
20			use Symfony\Component\HttpFoundation\RedirectResponse;
21			use Thelia\Core\Security\AccessManager;
22			use Thelia\Core\Security\Resource\AdminResources;
23			use Thelia\Tools\URL;
24
25			/**
26			* Class BrandLinkController
27			* @package Dealer\Controller
28			*/
29			class BrandLinkController extends BaseController
30			{
31			const CONTROLLER_ENTITY_NAME = "dealer_brand_link";
32			const CONTROLLER_CHECK_RESOURCE = Dealer::RESOURCES_ASSOCIATED;
33			/**
34			* @inheritDoc
35			*/
36			protected function getListRenderTemplate()
37			{
38			$id = $this->getRequest()->query->get("dealer_id");
39
40			return new RedirectResponse(URL::getInstance()->absoluteUrl("/admin/module/Dealer/dealer/edit#associated",
41			["dealer_id" => $id, ]));
42			}
43
44			/**
45			* @inheritDoc
46			*/
47			protected function redirectToListTemplate()
48			{
49			$id = $this->getRequest()->request->get("dealer_id");
50
51			return new RedirectResponse(URL::getInstance()->absoluteUrl("/admin/module/Dealer/dealer/edit#associated",
52			["dealer_id" => $id, ]));
53			}
54
55			/**
56			* @inheritDoc
57			*/
58			protected function getEditRenderTemplate()
59			{
60			// TODO: Implement getEditRenderTemplate() method.
61			}
62
63			/**
64			* @inheritDoc
65			*/
66			protected function getCreateRenderTemplate()
67			{
68			// TODO: Implement getCreateRenderTemplate() method.
69			}
70
71			/**
72			* @inheritDoc
73			*/
74			protected function getObjectId($object)
75			{
76			/** @var DealerBrand $object */
77			return $object->getId();
78			}
79
80			/**
81			* @inheritDoc
82			*/
83			protected function getExistingObject()
84			{
85			// TODO: Implement getExistingObject() method.
86			}
87
88			/**
89			* @inheritDoc
90			*/
91			protected function hydrateObjectForm($object)
92			{
93			// TODO: Implement hydrateObjectForm() method.
94			}
95
96			/**
97			* Method to get current controller associated service
98			* @return object
99			*/
100			protected function getService()
101			{
102			if (!$this->service) {
103			$this->service = $this->getContainer()->get("dealer_brand_link_service");
104			}
105
106			return $this->service;
107			}
108
109			/**
110			* Method to get Base Creation Form
111			* @return \Thelia\Form\BaseForm
112			*/
113			protected function getCreationForm()
114			{
115			return $this->createForm(static::CONTROLLER_ENTITY_NAME . "_create");
116			}
117
118			/**
119			* Delete an object
120			*
121			* @return \Thelia\Core\HttpFoundation\Response the response
122			*/
123			public function deleteAction()
124			{
125			// Check current user authorization
126			if (null !== $response = $this->checkAuth(AdminResources::MODULE, Dealer::getModuleCode(),
127			AccessManager::DELETE)
128			) {
129			return $response;
130			}
131
132			$con = Propel::getConnection();
133			$con->beginTransaction();
134			try {
135			// Check token
136			$this->getTokenProvider()->checkToken(
137			$this->getRequest()->query->get("_token")
138			);
139			$data = [
140			"brand_id" => $this->getRequest()->request->get(static::CONTROLLER_ENTITY_NAME . "_id"),
141			"dealer_id" => $this->getRequest()->request->get("dealer_id"),
142			];
143			$this->getService()->deleteFromArray($data);
144			$con->commit();
145
146			if ($this->getRequest()->request->get("success_url") == null) {
147			return $this->redirectToListTemplate();
			0 ignored issues – show Bug Best Practice introduced 2016-01-08 13:25 UTC by Report Bug Copy Issue Report Show Similar Issues like this The return type of `return $this->redirectToListTemplate();` (`Symfony\Component\HttpFoundation\RedirectResponse`) is incompatible with the return type documented by `Dealer\Controller\BrandL...ontroller::deleteAction` of type `Thelia\Core\HttpFoundation\Response`. If you return a value from a function or method, it should be a sub-type of the type that is given by the parent type f.e. an interface, or abstract method. This is more formally defined by the Lizkov substitution principle, and guarantees that classes that depend on the parent type can use any instance of a child type interchangably. This principle also belongs to the SOLID principles for object oriented design. Let’s take a look at an example: class Author { private $name; public function __construct($name) { $this->name = $name; } public function getName() { return $this->name; } } abstract class Post { public function getAuthor() { return 'Johannes'; } } class BlogPost extends Post { public function getAuthor() { return new Author('Johannes'); } } class ForumPost extends Post { /* ... */ } function my_function(Post $post) { echo strtoupper($post->getAuthor()); } Our function `my_function` expects a `Post` object, and outputs the author of the post. The base class `Post` returns a simple string and outputting a simple string will work just fine. However, the child class `BlogPost` which is a sub-type of `Post` instead decided to return an `object`, and is therefore violating the SOLID principles. If a `BlogPost` were passed to `my_function`, PHP would not complain, but ultimately fail when executing the `strtoupper` call in its body. Loading history...
148			} else {
149			return new RedirectResponse(URL::getInstance()->absoluteUrl($this->getRequest()->request->get("success_url")));
			0 ignored issues – show Bug Best Practice introduced 2016-01-08 13:25 UTC by Report Bug Copy Issue Report Show Similar Issues like this The return type of `return new \Symfony\Comp...->get('success_url')));` (`Symfony\Component\HttpFoundation\RedirectResponse`) is incompatible with the return type documented by `Dealer\Controller\BrandL...ontroller::deleteAction` of type `Thelia\Core\HttpFoundation\Response`. If you return a value from a function or method, it should be a sub-type of the type that is given by the parent type f.e. an interface, or abstract method. This is more formally defined by the Lizkov substitution principle, and guarantees that classes that depend on the parent type can use any instance of a child type interchangably. This principle also belongs to the SOLID principles for object oriented design. Let’s take a look at an example: class Author { private $name; public function __construct($name) { $this->name = $name; } public function getName() { return $this->name; } } abstract class Post { public function getAuthor() { return 'Johannes'; } } class BlogPost extends Post { public function getAuthor() { return new Author('Johannes'); } } class ForumPost extends Post { /* ... */ } function my_function(Post $post) { echo strtoupper($post->getAuthor()); } Our function `my_function` expects a `Post` object, and outputs the author of the post. The base class `Post` returns a simple string and outputting a simple string will work just fine. However, the child class `BlogPost` which is a sub-type of `Post` instead decided to return an `object`, and is therefore violating the SOLID principles. If a `BlogPost` were passed to `my_function`, PHP would not complain, but ultimately fail when executing the `strtoupper` call in its body. Loading history...
150			}
151			} catch (\Exception $e) {
152			$con->rollBack();
153
154			return $this->renderAfterDeleteError($e);
155			}
156			}
157			}
158

thelia-modules / Dealer

Issues (36)

Security Analysis not enabled

Controller/BrandLinkController.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like