Dealer::getDefaultSchedules() - Code Metrics - Inspection of "Fix controller" - thelia-modules/Dealer - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 953bfd...5be2ea )

by Antony

created 2016-03-14 16:28 UTC

Dealer::getDefaultSchedules() C

↳ Parent: Dealer

Complexity

Conditions	16
Paths	12

Size

Total Lines	46
Code Lines	26

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	46
rs	5.0026
cc	16
eloc	26
nc	12
nop	2

How to fix Complexity

<?php

namespace Dealer\Model;

use Dealer\Model\Base\Dealer as BaseDealer;
use Propel\Runtime\ActiveQuery\Criteria;
use Propel\Runtime\Collection\Collection;
use Propel\Runtime\Collection\ObjectCollection;
use Propel\Runtime\Connection\ConnectionInterface;
use Dealer\Model\DealerShedulesQuery as ChildDealerShedulesQuery;
use Propel\Runtime\Exception\PropelException;
use Dealer\Model\DealerShedules as ChildDealerShedules;

class Dealer extends BaseDealer
{

    /**
     * @var        ObjectCollection|ChildDealerShedules[] Collection to store aggregation of ChildDealerShedules objects.
     */
    protected $collDealerDefaultSheduless;

    /**
     * @var        ObjectCollection|ChildDealerShedules[] Collection to store aggregation of ChildDealerShedules objects.
     */
    protected $collDealerExtraSheduless;

    /**
     * Initializes the collDealerSheduless collection.
     *
     * By default this just sets the collDealerSheduless collection to an empty array (like clearcollDealerSheduless());
     * however, you may wish to override this method in your stub class to provide setting appropriate
     * to your application -- for example, setting the initial array to the values stored in database.
     *
     * @param      boolean $overrideExisting If set to true, the method call initializes
     *                                        the collection even if it is not empty
     *
     * @return void
     */
    public function initDealerDefaultSheduless($overrideExisting = true)
    {
        if (null !== $this->collDealerDefaultSheduless && !$overrideExisting) {
            return;
        }
        $this->collDealerDefaultSheduless = new ObjectCollection();
        $this->collDealerDefaultSheduless->setModel('\Dealer\Model\DealerShedules');
    }

    /**
     * Initializes the collDealerSheduless collection.
     *
     * By default this just sets the collDealerSheduless collection to an empty array (like clearcollDealerSheduless());
     * however, you may wish to override this method in your stub class to provide setting appropriate
     * to your application -- for example, setting the initial array to the values stored in database.
     *
     * @param      boolean $overrideExisting If set to true, the method call initializes
     *                                        the collection even if it is not empty
     *
     * @return void
     */
    public function initDealerExtraSheduless($overrideExisting = true)
    {
        if (null !== $this->collDealerExtraSheduless && !$overrideExisting) {
            return;
        }
        $this->collDealerExtraSheduless = new ObjectCollection();
        $this->collDealerExtraSheduless->setModel('\Dealer\Model\DealerShedules');
    }

    /**
     * Gets an array of ChildDealerShedules objects which contain a foreign key that references this object.
     *
     * If the $criteria is not null, it is used to always fetch the results from the database.
     * Otherwise the results are fetched from the database the first time, then cached.
     * Next time the same method is called without $criteria, the cached collection is returned.
     * If this ChildDealer is new, it will return
     * an empty collection or the current collection; the criteria is ignored on a new object.
     *
     * @param      Criteria $criteria optional Criteria object to narrow the query
     * @param      ConnectionInterface $con optional connection object
     * @return Collection|ChildDealerShedules[] List of ChildDealerShedules objects
     * @throws PropelException
     */
    public function getDefaultSchedules($criteria = null, ConnectionInterface $con = null)
    {
        $partial = $this->collDealerShedulessPartial && !$this->isNew();
        if (null === $this->collDealerDefaultSheduless || null !== $criteria || $partial) {
            if ($this->isNew() && null === $this->collDealerDefaultSheduless) {
                // return empty collection
                $this->initDealerDefaultSheduless();
            } else {
                $collDealerSheduless = ChildDealerShedulesQuery::create(null, $criteria)
                    ->filterByDealer($this)
                    ->filterByPeriodNull()
                    ->find($con);

                if (null !== $criteria) {
                    if (false !== $this->collDealerShedulessPartial && count($collDealerSheduless)) {
                        $this->initDealerDefaultSheduless(false);

                        foreach ($collDealerSheduless as $obj) {
                            if (false == $this->collDealerDefaultSheduless->contains($obj)) {
                                $this->collDealerDefaultSheduless->append($obj);
                            }
                        }

                        $this->collDealerShedulessPartial = true;
                    }

                    reset($collDealerSheduless);

                    return $collDealerSheduless;
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
                }

                if ($partial && $this->collDealerDefaultSheduless) {
                    foreach ($this->collDealerDefaultSheduless as $obj) {
                        if ($obj->isNew()) {
                            $collDealerSheduless[] = $obj;
                        }
                    }
                }

                $this->collDealerDefaultSheduless = $collDealerSheduless;
                $this->collDealerShedulessPartial = false;
            }
        }

        return $this->collDealerDefaultSheduless;
    }

    /**
     * Gets an array of ChildDealerShedules objects which contain a foreign key that references this object.
     *
     * If the $criteria is not null, it is used to always fetch the results from the database.
     * Otherwise the results are fetched from the database the first time, then cached.
     * Next time the same method is called without $criteria, the cached collection is returned.
     * If this ChildDealer is new, it will return
     * an empty collection or the current collection; the criteria is ignored on a new object.
     *
     * @param      Criteria $criteria optional Criteria object to narrow the query
     * @param      ConnectionInterface $con optional connection object
     * @return Collection|ChildDealerShedules[] List of ChildDealerShedules objects
     * @throws PropelException
     */
    public function getExtraSchedules($criteria = null, ConnectionInterface $con = null)
    {
        $partial = $this->collDealerShedulessPartial && !$this->isNew();
        if (null === $this->collDealerExtraSheduless || null !== $criteria || $partial) {
            if ($this->isNew() && null === $this->collDealerSheduless) {
                // return empty collection
                $this->initDealerExtraSheduless();
            } else {
                $collDealerSheduless = ChildDealerShedulesQuery::create(null, $criteria)
                    ->filterByDealer($this)
                    ->filterByPeriodNotNull()
                    ->find($con);

                if (null !== $criteria) {
                    if (false !== $this->collDealerShedulessPartial && count($collDealerSheduless)) {
                        $this->initDealerExtraSheduless(false);

                        foreach ($collDealerSheduless as $obj) {
                            if (false == $this->collDealerExtraSheduless->contains($obj)) {
                                $this->collDealerExtraSheduless->append($obj);
                            }
                        }

                        $this->collDealerShedulessPartial = true;
                    }

                    reset($collDealerSheduless);

                    return $collDealerSheduless;
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
                }

                if ($partial && $this->collDealerSheduless) {
                    foreach ($this->collDealerExtraSheduless as $obj) {
                        if ($obj->isNew()) {
                            $collDealerSheduless[] = $obj;
                        }
                    }
                }

                $this->collDealerExtraSheduless = $collDealerSheduless;
                $this->collDealerShedulessPartial = false;
            }
        }

        return $this->collDealerExtraSheduless;
    }

}


1			<?php
2
3			namespace Dealer\Model;
4
5			use Dealer\Model\Base\Dealer as BaseDealer;
6			use Propel\Runtime\ActiveQuery\Criteria;
7			use Propel\Runtime\Collection\Collection;
8			use Propel\Runtime\Collection\ObjectCollection;
9			use Propel\Runtime\Connection\ConnectionInterface;
10			use Dealer\Model\DealerShedulesQuery as ChildDealerShedulesQuery;
11			use Propel\Runtime\Exception\PropelException;
12			use Dealer\Model\DealerShedules as ChildDealerShedules;
13
14			class Dealer extends BaseDealer
15			{
16
17			/**
18			* @var ObjectCollection\|ChildDealerShedules[] Collection to store aggregation of ChildDealerShedules objects.
19			*/
20			protected $collDealerDefaultSheduless;
21
22			/**
23			* @var ObjectCollection\|ChildDealerShedules[] Collection to store aggregation of ChildDealerShedules objects.
24			*/
25			protected $collDealerExtraSheduless;
26
27			/**
28			* Initializes the collDealerSheduless collection.
29			*
30			* By default this just sets the collDealerSheduless collection to an empty array (like clearcollDealerSheduless());
31			* however, you may wish to override this method in your stub class to provide setting appropriate
32			* to your application -- for example, setting the initial array to the values stored in database.
33			*
34			* @param boolean $overrideExisting If set to true, the method call initializes
35			* the collection even if it is not empty
36			*
37			* @return void
38			*/
39			public function initDealerDefaultSheduless($overrideExisting = true)
40			{
41			if (null !== $this->collDealerDefaultSheduless && !$overrideExisting) {
42			return;
43			}
44			$this->collDealerDefaultSheduless = new ObjectCollection();
45			$this->collDealerDefaultSheduless->setModel('\Dealer\Model\DealerShedules');
46			}
47
48			/**
49			* Initializes the collDealerSheduless collection.
50			*
51			* By default this just sets the collDealerSheduless collection to an empty array (like clearcollDealerSheduless());
52			* however, you may wish to override this method in your stub class to provide setting appropriate
53			* to your application -- for example, setting the initial array to the values stored in database.
54			*
55			* @param boolean $overrideExisting If set to true, the method call initializes
56			* the collection even if it is not empty
57			*
58			* @return void
59			*/
60			public function initDealerExtraSheduless($overrideExisting = true)
61			{
62			if (null !== $this->collDealerExtraSheduless && !$overrideExisting) {
63			return;
64			}
65			$this->collDealerExtraSheduless = new ObjectCollection();
66			$this->collDealerExtraSheduless->setModel('\Dealer\Model\DealerShedules');
67			}
68
69			/**
70			* Gets an array of ChildDealerShedules objects which contain a foreign key that references this object.
71			*
72			* If the $criteria is not null, it is used to always fetch the results from the database.
73			* Otherwise the results are fetched from the database the first time, then cached.
74			* Next time the same method is called without $criteria, the cached collection is returned.
75			* If this ChildDealer is new, it will return
76			* an empty collection or the current collection; the criteria is ignored on a new object.
77			*
78			* @param Criteria $criteria optional Criteria object to narrow the query
79			* @param ConnectionInterface $con optional connection object
80			* @return Collection\|ChildDealerShedules[] List of ChildDealerShedules objects
81			* @throws PropelException
82			*/
83			public function getDefaultSchedules($criteria = null, ConnectionInterface $con = null)
84			{
85			$partial = $this->collDealerShedulessPartial && !$this->isNew();
86			if (null === $this->collDealerDefaultSheduless \|\| null !== $criteria \|\| $partial) {
87			if ($this->isNew() && null === $this->collDealerDefaultSheduless) {
88			// return empty collection
89			$this->initDealerDefaultSheduless();
90			} else {
91			$collDealerSheduless = ChildDealerShedulesQuery::create(null, $criteria)
92			->filterByDealer($this)
93			->filterByPeriodNull()
94			->find($con);
95
96			if (null !== $criteria) {
97			if (false !== $this->collDealerShedulessPartial && count($collDealerSheduless)) {
98			$this->initDealerDefaultSheduless(false);
99
100			foreach ($collDealerSheduless as $obj) {
101			if (false == $this->collDealerDefaultSheduless->contains($obj)) {
102			$this->collDealerDefaultSheduless->append($obj);
103			}
104			}
105
106			$this->collDealerShedulessPartial = true;
107			}
108
109			reset($collDealerSheduless);
110
111			return $collDealerSheduless;
			0 ignored issues – show Bug Best Practice introduced 2016-03-14 16:30 UTC by Report Bug Copy Issue Report The return type of `return $collDealerSheduless;` (`array`) is incompatible with the return type documented by `Dealer\Model\Dealer::getDefaultSchedules` of type `Propel\Runtime\Collectio...\Model\DealerShedules[]`. If you return a value from a function or method, it should be a sub-type of the type that is given by the parent type f.e. an interface, or abstract method. This is more formally defined by the Lizkov substitution principle, and guarantees that classes that depend on the parent type can use any instance of a child type interchangably. This principle also belongs to the SOLID principles for object oriented design. Let’s take a look at an example: class Author { private $name; public function __construct($name) { $this->name = $name; } public function getName() { return $this->name; } } abstract class Post { public function getAuthor() { return 'Johannes'; } } class BlogPost extends Post { public function getAuthor() { return new Author('Johannes'); } } class ForumPost extends Post { /* ... */ } function my_function(Post $post) { echo strtoupper($post->getAuthor()); } Our function `my_function` expects a `Post` object, and outputs the author of the post. The base class `Post` returns a simple string and outputting a simple string will work just fine. However, the child class `BlogPost` which is a sub-type of `Post` instead decided to return an `object`, and is therefore violating the SOLID principles. If a `BlogPost` were passed to `my_function`, PHP would not complain, but ultimately fail when executing the `strtoupper` call in its body. Loading history...
112			}
113
114			if ($partial && $this->collDealerDefaultSheduless) {
115			foreach ($this->collDealerDefaultSheduless as $obj) {
116			if ($obj->isNew()) {
117			$collDealerSheduless[] = $obj;
118			}
119			}
120			}
121
122			$this->collDealerDefaultSheduless = $collDealerSheduless;
123			$this->collDealerShedulessPartial = false;
124			}
125			}
126
127			return $this->collDealerDefaultSheduless;
128			}
129
130			/**
131			* Gets an array of ChildDealerShedules objects which contain a foreign key that references this object.
132			*
133			* If the $criteria is not null, it is used to always fetch the results from the database.
134			* Otherwise the results are fetched from the database the first time, then cached.
135			* Next time the same method is called without $criteria, the cached collection is returned.
136			* If this ChildDealer is new, it will return
137			* an empty collection or the current collection; the criteria is ignored on a new object.
138			*
139			* @param Criteria $criteria optional Criteria object to narrow the query
140			* @param ConnectionInterface $con optional connection object
141			* @return Collection\|ChildDealerShedules[] List of ChildDealerShedules objects
142			* @throws PropelException
143			*/
144			public function getExtraSchedules($criteria = null, ConnectionInterface $con = null)
145			{
146			$partial = $this->collDealerShedulessPartial && !$this->isNew();
147			if (null === $this->collDealerExtraSheduless \|\| null !== $criteria \|\| $partial) {
148			if ($this->isNew() && null === $this->collDealerSheduless) {
149			// return empty collection
150			$this->initDealerExtraSheduless();
151			} else {
152			$collDealerSheduless = ChildDealerShedulesQuery::create(null, $criteria)
153			->filterByDealer($this)
154			->filterByPeriodNotNull()
155			->find($con);
156
157			if (null !== $criteria) {
158			if (false !== $this->collDealerShedulessPartial && count($collDealerSheduless)) {
159			$this->initDealerExtraSheduless(false);
160
161			foreach ($collDealerSheduless as $obj) {
162			if (false == $this->collDealerExtraSheduless->contains($obj)) {
163			$this->collDealerExtraSheduless->append($obj);
164			}
165			}
166
167			$this->collDealerShedulessPartial = true;
168			}
169
170			reset($collDealerSheduless);
171
172			return $collDealerSheduless;
			0 ignored issues – show Bug Best Practice introduced 2016-03-14 16:30 UTC by Report Bug Copy Issue Report The return type of `return $collDealerSheduless;` (`array`) is incompatible with the return type documented by `Dealer\Model\Dealer::getExtraSchedules` of type `Propel\Runtime\Collectio...\Model\DealerShedules[]`. If you return a value from a function or method, it should be a sub-type of the type that is given by the parent type f.e. an interface, or abstract method. This is more formally defined by the Lizkov substitution principle, and guarantees that classes that depend on the parent type can use any instance of a child type interchangably. This principle also belongs to the SOLID principles for object oriented design. Let’s take a look at an example: class Author { private $name; public function __construct($name) { $this->name = $name; } public function getName() { return $this->name; } } abstract class Post { public function getAuthor() { return 'Johannes'; } } class BlogPost extends Post { public function getAuthor() { return new Author('Johannes'); } } class ForumPost extends Post { /* ... */ } function my_function(Post $post) { echo strtoupper($post->getAuthor()); } Our function `my_function` expects a `Post` object, and outputs the author of the post. The base class `Post` returns a simple string and outputting a simple string will work just fine. However, the child class `BlogPost` which is a sub-type of `Post` instead decided to return an `object`, and is therefore violating the SOLID principles. If a `BlogPost` were passed to `my_function`, PHP would not complain, but ultimately fail when executing the `strtoupper` call in its body. Loading history...
173			}
174
175			if ($partial && $this->collDealerSheduless) {
176			foreach ($this->collDealerExtraSheduless as $obj) {
177			if ($obj->isNew()) {
178			$collDealerSheduless[] = $obj;
179			}
180			}
181			}
182
183			$this->collDealerExtraSheduless = $collDealerSheduless;
184			$this->collDealerShedulessPartial = false;
185			}
186			}
187
188			return $this->collDealerExtraSheduless;
189			}
190
191			}
192

thelia-modules / Dealer

Push — master ( 953bfd...5be2ea )

Dealer::getDefaultSchedules() C

Complexity

Size

Duplication

Importance

How to fix Complexity

Long Method

Duplication Side-by-Side

Filter issues like