ApiController::defaultAction() - Code Metrics - Inspection of "Fix controller" - thelia-modules/Dealer - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 953bfd...5be2ea )

by Antony

created 2016-03-14 16:28 UTC

ApiController::defaultAction() B

↳ Parent: ApiController

Complexity

Conditions	6
Paths	115

Size

Total Lines	52
Code Lines	31

Duplication

Lines	0
Ratio	0 %

Importance

Changes	2
Bugs	1	Features	1

Metric	Value
c	2
b	1
f	1
dl	0
loc	52
rs	8.1138
cc	6
eloc	31
nc	115
nop	0

How to fix Long Method

<?php
/**
 * Created by PhpStorm.
 * User: apenalver
 * Date: 14/03/2016
 * Time: 10:22
 */

namespace Dealer\Controller;

use Dealer\Model\Dealer;
use Dealer\Model\DealerContact;
use Dealer\Model\DealerQuery;
use Propel\Runtime\Map\TableMap;
use Symfony\Component\Config\Definition\Exception\Exception;
use Thelia\Controller\Api\BaseApiController;
use Thelia\Core\HttpFoundation\JsonResponse;



/**
 * Class ApiController
 * @package Dealer\Controller
 */
class ApiController extends BaseApiController
{

    const DEFAULT_LIMIT = 10;

    public function defaultAction()
    {
        $return = [];
        $code = 200;

        try {
            $query = DealerQuery::create()
                ->joinWithI18n($this->getLocale())
                ->filterByVisible(1);

            if (null != $id = $this->getRequest()->get("dealer_id")) {
                $query->filterById($id);
            }

            $return["total"] = $query->count();

            $query->limit($this->getLimit());
            $return["limit"] = $this->getLimit();


            if ($this->getPageOffset() != 0) {
                $query->offset($this->getPageOffset());
                $return["offset"] = $this->getPageOffset();
            }
            if ($this->getOffset() != 0) {
                $query->offset($this->getOffset());
                $return["offset"] = $this->getOffset();
            }

            $dealers = $query->find();

            $return["data"] = [];

            /** @var Dealer $dealer */
            foreach ($dealers as $dealer) {
                $dataI18n = $dealer->getDealerI18ns()->getData()[0]->toArray(TableMap::TYPE_FIELDNAME);
                $dataRow = array_merge($dealer->toArray(TableMap::TYPE_FIELDNAME), $dataI18n);
                $dataRow["contacts"] = $this->getContacts($dealer);
                $dataRow["default_schedules"] = $this->getDefaultSchedules($dealer);
                $dataRow["extra_schedules"] = $this->getExtraSchedules($dealer);

                $return["data"][] = $dataRow;
            }

        } catch (Exception $e) {

            $code = 500;
            $return["error"] = $e->getMessage();
        }


        return new JsonResponse($return, $code);
    }

    protected function getContacts(Dealer $dealer)
    {

        $return = [];
        foreach ($dealer->getDealerContacts() as $dealerContact) {
            $dataRow = $dealerContact->toArray(TableMap::TYPE_FIELDNAME);
            $dataRow = array_merge($dataRow, $dealerContact->getDealerContactI18ns()->getData()[0]->toArray(TableMap::TYPE_FIELDNAME));
            $dataRow["data"] = $this->getContactInfo($dealerContact);
            $return[] = $dataRow;
        }
        return $return;
    }

    protected function getContactInfo(DealerContact $contact)
    {
        $return = [];
        foreach ($contact->getDealerContactInfos() as $dealerContact) {
            $dataRow = $dealerContact->toArray(TableMap::TYPE_FIELDNAME);
            $dataRow = array_merge($dataRow, $dealerContact->getDealerContactInfoI18ns()->getData()[0]->toArray(TableMap::TYPE_FIELDNAME));
            $return[] = $dataRow;
        }
        return $return;
    }

    protected function getDefaultSchedules(Dealer $dealer)
    {
        $return = [];
        foreach ($dealer->getDefaultSchedules() as $schedules) {
            $return[] = $schedules->toArray(TableMap::TYPE_FIELDNAME);
        }
        return $return;
    }

    protected function getExtraSchedules(Dealer $dealer)
    {
        $return = [];
        foreach ($dealer->getExtraSchedules() as $schedules) {
            $return[] = $schedules->toArray(TableMap::TYPE_FIELDNAME);
        }
        return $return;
    }

    protected function getLimit()
    {
        $limit = $this->getRequest()->get("limit");
        return ($limit) ? $limit : static::DEFAULT_LIMIT;
    }

    protected function getOffset()
    {
        $offset = $this->getRequest()->get("offset");
        return ($offset) ? $offset : 0;
    }

    protected function getPageOffset()
    {
        $page = $this->getRequest()->get("page");
        return ($page) ? ($page - 1) * $this->getLimit() : 0;
    }

    protected function getLocale()
    {
        $locale = $this->getRequest()->get("locale");
        return ($locale) ? $locale : 'fr_FR';
    }
}

1			<?php
2			/**
3			* Created by PhpStorm.
4			* User: apenalver
5			* Date: 14/03/2016
6			* Time: 10:22
7			*/
8
9			namespace Dealer\Controller;
10
11			use Dealer\Model\Dealer;
12			use Dealer\Model\DealerContact;
13			use Dealer\Model\DealerQuery;
14			use Propel\Runtime\Map\TableMap;
15			use Symfony\Component\Config\Definition\Exception\Exception;
16			use Thelia\Controller\Api\BaseApiController;
17			use Thelia\Core\HttpFoundation\JsonResponse;
18
19
20
21			/**
22			* Class ApiController
23			* @package Dealer\Controller
24			*/
25			class ApiController extends BaseApiController
26			{
27
28			const DEFAULT_LIMIT = 10;
29
30			public function defaultAction()
31			{
32			$return = [];
33			$code = 200;
34
35			try {
36			$query = DealerQuery::create()
37			->joinWithI18n($this->getLocale())
38			->filterByVisible(1);
39
40			if (null != $id = $this->getRequest()->get("dealer_id")) {
41			$query->filterById($id);
42			}
43
44			$return["total"] = $query->count();
45
46			$query->limit($this->getLimit());
47			$return["limit"] = $this->getLimit();
48
49
50			if ($this->getPageOffset() != 0) {
51			$query->offset($this->getPageOffset());
52			$return["offset"] = $this->getPageOffset();
53			}
54			if ($this->getOffset() != 0) {
55			$query->offset($this->getOffset());
56			$return["offset"] = $this->getOffset();
57			}
58
59			$dealers = $query->find();
60
61			$return["data"] = [];
62
63			/** @var Dealer $dealer */
64			foreach ($dealers as $dealer) {
65			$dataI18n = $dealer->getDealerI18ns()->getData()[0]->toArray(TableMap::TYPE_FIELDNAME);
66			$dataRow = array_merge($dealer->toArray(TableMap::TYPE_FIELDNAME), $dataI18n);
67			$dataRow["contacts"] = $this->getContacts($dealer);
68			$dataRow["default_schedules"] = $this->getDefaultSchedules($dealer);
69			$dataRow["extra_schedules"] = $this->getExtraSchedules($dealer);
70
71			$return["data"][] = $dataRow;
72			}
73
74			} catch (Exception $e) {
			0 ignored issues – show Bug introduced 2016-03-14 16:30 UTC by Report Bug Copy Issue Report The class `Symfony\Component\Config...ion\Exception\Exception` does not exist. Did you forget a USE statement, or did you not list all dependencies? Scrutinizer analyzes your `composer.json`/`composer.lock` file if available to determine the classes, and functions that are defined by your dependencies. It seems like the listed class was neither found in your dependencies, nor was it found in the analyzed files in your repository. If you are using some other form of dependency management, you might want to disable this analysis. Loading history...
75			$code = 500;
76			$return["error"] = $e->getMessage();
77			}
78
79
80			return new JsonResponse($return, $code);
81			}
82
83			protected function getContacts(Dealer $dealer)
84			{
85
86			$return = [];
87			foreach ($dealer->getDealerContacts() as $dealerContact) {
88			$dataRow = $dealerContact->toArray(TableMap::TYPE_FIELDNAME);
89			$dataRow = array_merge($dataRow, $dealerContact->getDealerContactI18ns()->getData()[0]->toArray(TableMap::TYPE_FIELDNAME));
90			$dataRow["data"] = $this->getContactInfo($dealerContact);
91			$return[] = $dataRow;
92			}
93			return $return;
94			}
95
96			protected function getContactInfo(DealerContact $contact)
97			{
98			$return = [];
99			foreach ($contact->getDealerContactInfos() as $dealerContact) {
100			$dataRow = $dealerContact->toArray(TableMap::TYPE_FIELDNAME);
101			$dataRow = array_merge($dataRow, $dealerContact->getDealerContactInfoI18ns()->getData()[0]->toArray(TableMap::TYPE_FIELDNAME));
102			$return[] = $dataRow;
103			}
104			return $return;
105			}
106
107			protected function getDefaultSchedules(Dealer $dealer)
108			{
109			$return = [];
110			foreach ($dealer->getDefaultSchedules() as $schedules) {
111			$return[] = $schedules->toArray(TableMap::TYPE_FIELDNAME);
112			}
113			return $return;
114			}
115
116			protected function getExtraSchedules(Dealer $dealer)
117			{
118			$return = [];
119			foreach ($dealer->getExtraSchedules() as $schedules) {
120			$return[] = $schedules->toArray(TableMap::TYPE_FIELDNAME);
121			}
122			return $return;
123			}
124
125			protected function getLimit()
126			{
127			$limit = $this->getRequest()->get("limit");
128			return ($limit) ? $limit : static::DEFAULT_LIMIT;
129			}
130
131			protected function getOffset()
132			{
133			$offset = $this->getRequest()->get("offset");
134			return ($offset) ? $offset : 0;
135			}
136
137			protected function getPageOffset()
138			{
139			$page = $this->getRequest()->get("page");
140			return ($page) ? ($page - 1) * $this->getLimit() : 0;
141			}
142
143			protected function getLocale()
144			{
145			$locale = $this->getRequest()->get("locale");
146			return ($locale) ? $locale : 'fr_FR';
147			}
148			}

thelia-modules / Dealer

Push — master ( 953bfd...5be2ea )

ApiController::defaultAction() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like