DealerCustomImagesLoop::parseResults() - Code Metrics - Inspection of "Add image and meta" - thelia-modules/Dealer - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#34)

unknown

created 2021-06-24 11:17 UTC

DealerCustomImagesLoop::parseResults() F

↳ Parent: DealerCustomImagesLoop

Complexity

Conditions	16
Paths	10248

Size

Total Lines

120

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	120
rs	1.1198
c	0
b	0
f	0
cc	16
nc	10248
nop	1

How to fix Long Method Complexity

<?php

namespace Dealer\Loop;


use Dealer\Model\DealerImage;
use Dealer\Model\DealerImageQuery;
use Thelia\Core\Event\Image\ImageEvent;
use Thelia\Core\Event\TheliaEvents;
use Thelia\Core\Template\Element\LoopResult;
use Thelia\Core\Template\Element\LoopResultRow;
use Thelia\Core\Template\Element\PropelSearchLoopInterface;
use Thelia\Core\Template\Loop\Argument\Argument;
use Thelia\Core\Template\Loop\Image;
use Thelia\Log\Tlog;

class DealerCustomImagesLoop extends Image implements PropelSearchLoopInterface
{
    const ARG_IMAGE_TYPE = "image_type";

    /**
     * @var array Possible standard image sources
     */
    protected $possible_sources = array('product', 'category');

    /**
     * @return DealerImageQuery|\Propel\Runtime\ActiveQuery\ModelCriteria|\Thelia\Model\ProductDocumentQuery
     */
    public function buildModelCriteria()
    {
        $this->objectType = null;
        if (!empty($this->getProduct())) {
            $this->objectType = $this->possible_sources[0];
        }

        if (is_null($this->objectType)) {
            throw new \InvalidArgumentException("Argument type must be specified");
        }

        $type = $this->getArgValue(self::ARG_IMAGE_TYPE);

        $search = DealerImageQuery::create();
        $typeIndex = array_search($type, DealerImage::POSSIBLE_TYPE);
        $search->filterByType($typeIndex);
        $search->filterByDealerId($this->getProduct());


        $this->configureI18nProcessing($search);
        return $search;
    }

    protected function getArgDefinitions()
    {
        $args = parent::getArgDefinitions();
        $args->addArgument(Argument::createAlphaNumStringTypeArgument(self::ARG_IMAGE_TYPE));
        return $args;
    }

    /**
     * @param LoopResult $loopResult
     * @return LoopResult
     */
    public function parseResults(LoopResult $loopResult)
    {
        // Create image processing event
        $event = new ImageEvent();

        // Prepare tranformations
        $width = $this->getWidth();
        $height = $this->getHeight();
        $rotation = $this->getRotation();
        $background_color = $this->getBackgroundColor();
        $quality = $this->getQuality();
        $effects = $this->getEffects();

        $event->setAllowZoom($this->getAllowZoom());

        if (! is_null($effects)) {
            $effects = explode(',', $effects);
        }

        switch ($this->getResizeMode()) {
            case 'crop':
                $resizeMode = \Thelia\Action\Image::EXACT_RATIO_WITH_CROP;
                break;

            case 'borders':
                $resizeMode = \Thelia\Action\Image::EXACT_RATIO_WITH_BORDERS;
                break;

            case 'none':
            default:
                $resizeMode = \Thelia\Action\Image::KEEP_IMAGE_RATIO;

        }

        /** @var DealerImage $result */
        foreach ($loopResult->getResultDataCollection() as $result) {
            // Setup required transformations
            if (! is_null($width)) {
                $event->setWidth($width);
            }
            if (! is_null($height)) {
                $event->setHeight($height);
            }
            $event->setResizeMode($resizeMode);
            if (! is_null($rotation)) {
                $event->setRotation($rotation);
            }
            if (! is_null($background_color)) {
                $event->setBackgroundColor($background_color);
            }
            if (! is_null($quality)) {
                $event->setQuality($quality);
            }
            if (! is_null($effects)) {
                $event->setEffects($effects);
            }

            // Put source image file path
            $sourceFilePath = sprintf(
                '%s/%s',
                $result->getUploadDir(),
                $result->getFile()
            );

            $event->setSourceFilepath($sourceFilePath);
            $event->setCacheSubdirectory($this->objectType);

            $loopResultRow = new LoopResultRow($result);

            $loopResultRow
                ->set("ID", $result->getId())
                ->set("LOCALE", $this->locale)
                ->set("ORIGINAL_IMAGE_PATH", $sourceFilePath)
                ->set("TITLE", $result->getVirtualColumn('i18n_TITLE'))
                ->set("CHAPO", $result->getVirtualColumn('i18n_CHAPO'))
                ->set("DESCRIPTION", $result->getVirtualColumn('i18n_DESCRIPTION'))
                ->set("POSTSCRIPTUM", $result->getVirtualColumn('i18n_POSTSCRIPTUM'))
                ->set("OBJECT_TYPE", $this->objectType)
                ->set("OBJECT_ID", $this->objectId)
            ;

            $addRow = true;

            $returnErroredImages = $this->getBackendContext() || ! $this->getIgnoreProcessingErrors();

            try {
                // Dispatch image processing event
                $this->dispatcher->dispatch(TheliaEvents::IMAGE_PROCESS, $event);

                $loopResultRow
                    ->set("IMAGE_URL", $event->getFileUrl())
                    ->set("ORIGINAL_IMAGE_URL", $event->getOriginalFileUrl())
                    ->set("IMAGE_PATH", $event->getCacheFilepath())
                    ->set("PROCESSING_ERROR", false)
                ;
            } catch (\Exception $ex) {
                // Ignore the result and log an error
                Tlog::getInstance()->addError(sprintf("Failed to process image in lapelerine_product_image loop: %s", $ex->getMessage()));

                if ($returnErroredImages) {
                    $loopResultRow
                        ->set("IMAGE_URL", '')
                        ->set("ORIGINAL_IMAGE_URL", '')
                        ->set("IMAGE_PATH", '')
                        ->set("PROCESSING_ERROR", true)
                    ;
                } else {
                    $addRow = false;
                }
            }

            if ($addRow) {
                $this->addOutputFields($loopResultRow, $result);

                $loopResult->addRow($loopResultRow);
            }
        }

        return $loopResult;
    }
}

1			<?php
2
3			namespace Dealer\Loop;
4
5
6			use Dealer\Model\DealerImage;
7			use Dealer\Model\DealerImageQuery;
8			use Thelia\Core\Event\Image\ImageEvent;
9			use Thelia\Core\Event\TheliaEvents;
10			use Thelia\Core\Template\Element\LoopResult;
11			use Thelia\Core\Template\Element\LoopResultRow;
12			use Thelia\Core\Template\Element\PropelSearchLoopInterface;
13			use Thelia\Core\Template\Loop\Argument\Argument;
14			use Thelia\Core\Template\Loop\Image;
15			use Thelia\Log\Tlog;
16
17			class DealerCustomImagesLoop extends Image implements PropelSearchLoopInterface
18			{
19			const ARG_IMAGE_TYPE = "image_type";
20
21			/**
22			* @var array Possible standard image sources
23			*/
24			protected $possible_sources = array('product', 'category');
25
26			/**
27			* @return DealerImageQuery\|\Propel\Runtime\ActiveQuery\ModelCriteria\|\Thelia\Model\ProductDocumentQuery
28			*/
29			public function buildModelCriteria()
30			{
31			$this->objectType = null;
32			if (!empty($this->getProduct())) {
33			$this->objectType = $this->possible_sources[0];
34			}
35
36			if (is_null($this->objectType)) {
37			throw new \InvalidArgumentException("Argument type must be specified");
38			}
39
40			$type = $this->getArgValue(self::ARG_IMAGE_TYPE);
41
42			$search = DealerImageQuery::create();
43			$typeIndex = array_search($type, DealerImage::POSSIBLE_TYPE);
44			$search->filterByType($typeIndex);
45			$search->filterByDealerId($this->getProduct());
46
47
48			$this->configureI18nProcessing($search);
49			return $search;
50			}
51
52			protected function getArgDefinitions()
53			{
54			$args = parent::getArgDefinitions();
55			$args->addArgument(Argument::createAlphaNumStringTypeArgument(self::ARG_IMAGE_TYPE));
56			return $args;
57			}
58
59			/**
60			* @param LoopResult $loopResult
61			* @return LoopResult
62			*/
63			public function parseResults(LoopResult $loopResult)
64			{
65			// Create image processing event
66			$event = new ImageEvent();
67
68			// Prepare tranformations
69			$width = $this->getWidth();
70			$height = $this->getHeight();
71			$rotation = $this->getRotation();
72			$background_color = $this->getBackgroundColor();
73			$quality = $this->getQuality();
74			$effects = $this->getEffects();
75
76			$event->setAllowZoom($this->getAllowZoom());
77
78			if (! is_null($effects)) {
79			$effects = explode(',', $effects);
80			}
81
82			switch ($this->getResizeMode()) {
83			case 'crop':
84			$resizeMode = \Thelia\Action\Image::EXACT_RATIO_WITH_CROP;
85			break;
86
87			case 'borders':
88			$resizeMode = \Thelia\Action\Image::EXACT_RATIO_WITH_BORDERS;
89			break;
90
91			case 'none':
92			default:
93			$resizeMode = \Thelia\Action\Image::KEEP_IMAGE_RATIO;
94
95			}
96
97			/** @var DealerImage $result */
98			foreach ($loopResult->getResultDataCollection() as $result) {
99			// Setup required transformations
100			if (! is_null($width)) {
101			$event->setWidth($width);
102			}
103			if (! is_null($height)) {
104			$event->setHeight($height);
105			}
106			$event->setResizeMode($resizeMode);
107			if (! is_null($rotation)) {
108			$event->setRotation($rotation);
109			}
110			if (! is_null($background_color)) {
111			$event->setBackgroundColor($background_color);
112			}
113			if (! is_null($quality)) {
114			$event->setQuality($quality);
115			}
116			if (! is_null($effects)) {
117			$event->setEffects($effects);
118			}
119
120			// Put source image file path
121			$sourceFilePath = sprintf(
122			'%s/%s',
123			$result->getUploadDir(),
124			$result->getFile()
125			);
126
127			$event->setSourceFilepath($sourceFilePath);
128			$event->setCacheSubdirectory($this->objectType);
129
130			$loopResultRow = new LoopResultRow($result);
131
132			$loopResultRow
133			->set("ID", $result->getId())
134			->set("LOCALE", $this->locale)
135			->set("ORIGINAL_IMAGE_PATH", $sourceFilePath)
136			->set("TITLE", $result->getVirtualColumn('i18n_TITLE'))
137			->set("CHAPO", $result->getVirtualColumn('i18n_CHAPO'))
138			->set("DESCRIPTION", $result->getVirtualColumn('i18n_DESCRIPTION'))
139			->set("POSTSCRIPTUM", $result->getVirtualColumn('i18n_POSTSCRIPTUM'))
140			->set("OBJECT_TYPE", $this->objectType)
141			->set("OBJECT_ID", $this->objectId)
142			;
143
144			$addRow = true;
145
146			$returnErroredImages = $this->getBackendContext() \|\| ! $this->getIgnoreProcessingErrors();
147
148			try {
149			// Dispatch image processing event
150			$this->dispatcher->dispatch(TheliaEvents::IMAGE_PROCESS, $event);
151
152			$loopResultRow
153			->set("IMAGE_URL", $event->getFileUrl())
154			->set("ORIGINAL_IMAGE_URL", $event->getOriginalFileUrl())
155			->set("IMAGE_PATH", $event->getCacheFilepath())
156			->set("PROCESSING_ERROR", false)
157			;
158			} catch (\Exception $ex) {
159			// Ignore the result and log an error
160			Tlog::getInstance()->addError(sprintf("Failed to process image in lapelerine_product_image loop: %s", $ex->getMessage()));
161
162			if ($returnErroredImages) {
163			$loopResultRow
164			->set("IMAGE_URL", '')
165			->set("ORIGINAL_IMAGE_URL", '')
166			->set("IMAGE_PATH", '')
167			->set("PROCESSING_ERROR", true)
168			;
169			} else {
170			$addRow = false;
171			}
172			}
173
174			if ($addRow) {
175			$this->addOutputFields($loopResultRow, $result);
176
177			$loopResult->addRow($loopResultRow);
178			}
179			}
180
181			return $loopResult;
182			}
183			}

thelia-modules / Dealer

Pull Request — master (#34)

DealerCustomImagesLoop::parseResults() F

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like