Conditions | 1 |
Paths | 1 |
Total Lines | 73 |
Lines | 0 |
Ratio | 0 % |
Changes | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | <?php |
||
47 | protected function buildForm() |
||
48 | { |
||
49 | $this->formBuilder |
||
50 | ->add("day", "choice", [ |
||
51 | "choices" => $this->getDay(), |
||
52 | "label" => $this->translator->trans("Day", [], Dealer::MESSAGE_DOMAIN), |
||
53 | "label_attr" => ["for" => "attr-dealer-schedules-day"], |
||
54 | "required" => false, |
||
55 | "multiple" => true, |
||
56 | "attr" => array() |
||
57 | ]) |
||
58 | ->add("beginAM", "time", [ |
||
59 | "label" => $this->translator->trans("Begin", [], Dealer::MESSAGE_DOMAIN), |
||
60 | "label_attr" => ["for" => "attr-dealer-schedules-begin"], |
||
61 | "input" => "string", |
||
62 | "widget" => "single_text", |
||
63 | "required" => false, |
||
64 | "attr" => array() |
||
65 | ]) |
||
66 | ->add("endAM", "time", [ |
||
67 | "label" => $this->translator->trans("End", [], Dealer::MESSAGE_DOMAIN), |
||
68 | "label_attr" => ["for" => "attr-dealer-schedules-end"], |
||
69 | "input" => "string", |
||
70 | "widget" => "single_text", |
||
71 | "required" => false, |
||
72 | "attr" => array() |
||
73 | ]) |
||
74 | ->add("beginPM", "time", [ |
||
75 | "label" => $this->translator->trans("Begin", [], Dealer::MESSAGE_DOMAIN), |
||
76 | "label_attr" => ["for" => "attr-dealer-schedules-beginPM"], |
||
77 | "input" => "string", |
||
78 | "widget" => "single_text", |
||
79 | "required" => false, |
||
80 | "attr" => array() |
||
81 | ]) |
||
82 | ->add("endPM", "time", [ |
||
83 | "label" => $this->translator->trans("End", [], Dealer::MESSAGE_DOMAIN), |
||
84 | "label_attr" => ["for" => "attr-dealer-schedules-endPM"], |
||
85 | "input" => "string", |
||
86 | "widget" => "single_text", |
||
87 | "required" => false, |
||
88 | "attr" => array() |
||
89 | ]) |
||
90 | ->add("period_begin", "date", [ |
||
91 | "label" => $this->translator->trans("Period Begin", [], Dealer::MESSAGE_DOMAIN), |
||
92 | "label_attr" => ["for" => "attr-dealer-schedules-period-begin"], |
||
93 | "input" => "string", |
||
94 | "widget" => "single_text", |
||
95 | "required" => false, |
||
96 | "attr" => array() |
||
97 | ]) |
||
98 | ->add("period_end", "date", [ |
||
99 | "label" => $this->translator->trans("Period End", [], Dealer::MESSAGE_DOMAIN), |
||
100 | "label_attr" => ["for" => "attr-dealer-schedules-period-end"], |
||
101 | "input" => "string", |
||
102 | "widget" => "single_text", |
||
103 | "required" => false, |
||
104 | "attr" => array() |
||
105 | ]) |
||
106 | ->add("closed", "integer", [ |
||
107 | "label" => $this->translator->trans("Closed", [], Dealer::MESSAGE_DOMAIN), |
||
108 | "label_attr" => ["for" => "attr-dealer-schedules-closed"], |
||
109 | "required" => true, |
||
110 | "attr" => array() |
||
111 | ]) |
||
112 | ->add('dealer_id', 'integer', array( |
||
113 | "label" => $this->translator->trans("Dealer", [], Dealer::MESSAGE_DOMAIN), |
||
114 | "label_attr" => ["for" => "attr-dealer-schedules-dealer_id"], |
||
115 | "required" => true, |
||
116 | "constraints" => array(new NotBlank(), ), |
||
117 | "attr" => array() |
||
118 | )); |
||
119 | } |
||
120 | |||
139 |