TheCodingMachine\WashingMachine\Clover\DiffService

Complexity

Total Complexity

8

Size/Duplication

Total Lines	70
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	3

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	6	1
C	getMeaningfulDifferences()	0	37	7

<?php


namespace TheCodingMachine\WashingMachine\Clover;

use TheCodingMachine\WashingMachine\Clover\Analysis\Difference;

/**
 * Service in charge of analyzing the differences between 2 clover files.
 */
class DiffService
{
    /**
     * @var float
     */
    private $meaningfulCrapChange;
    /**
     * @var int
     */
    private $maxReturnedMethods;
    /**
     * @var float
     */
    private $crapScoreThreshold;

    /**
     * @param float $meaningfulCrapChange The minimum crap CHANGE that triggers a message for MODIFIED methods
     * @param float $crapScoreThreshold The minimum crap score that triggers a message for all methods
     * @param int $maxReturnedMethods
     */
    public function __construct(float $meaningfulCrapChange, float $crapScoreThreshold, int $maxReturnedMethods)
    {
        $this->meaningfulCrapChange = $meaningfulCrapChange;
        $this->maxReturnedMethods = $maxReturnedMethods;
        $this->crapScoreThreshold = $crapScoreThreshold;
    }

    /**
     * @param CrapMethodFetcherInterface $newCloverFile
     * @param CrapMethodFetcherInterface $oldCloverFile
     * @return Difference[]
     */
    public function getMeaningfulDifferences(CrapMethodFetcherInterface $newCloverFile, CrapMethodFetcherInterface $oldCloverFile)
    {
        $newMethods = $newCloverFile->getMethods();
        $oldMethods = $oldCloverFile->getMethods();

        // Let's keep only methods that are in both files:
        $inCommonMethods = array_intersect(array_keys($newMethods), array_keys($oldMethods));

        // New methods in the new file:
        $createdMethods = array_diff(array_keys($newMethods), $inCommonMethods);

        $differences = [];

        foreach ($inCommonMethods as $methodName) {
            $change = abs($newMethods[$methodName]->getCrap() - $oldMethods[$methodName]->getCrap());
            if ($change > $this->meaningfulCrapChange && ($newMethods[$methodName]->getCrap() > $this->crapScoreThreshold || $oldMethods[$methodName]->getCrap() > $this->crapScoreThreshold)) {
                $differences[] = new Difference($newMethods[$methodName], $oldMethods[$methodName]);
            }
        }

        foreach ($createdMethods as $methodName) {
            $method = $newMethods[$methodName];
            if ($method->getCrap() > $this->crapScoreThreshold) {
                $differences[] = new Difference($method, null);
            }
        }

        // Now, let's order the differences by crap order.
        usort($differences, function(Difference $d1, Difference $d2) {
           return $d2->getCrapScore() <=> $d1->getCrapScore();
        });

        // Now, let's limit the number of returned differences
        $differences = array_slice(array_values($differences), 0, $this->maxReturnedMethods);

        return $differences;
    }
}