TheCodingMachine\TDBM\TDBMServiceTest

Complexity

Total Complexity

73

Size/Duplication

Total Lines	815
Duplicated Lines	0 %

Importance

Changes	6
Bugs	0	Features	2

58 Methods

Rating	Name	Duplication	Size	Complexity
A	testGetLinkBetweenInheritedTablesExceptions()	0	4	1
A	testFindObjectsFromSqlHierarchyUp()	0	13	1
A	testFindObjectsCountWithOneToManyLink()	0	5	1
A	testBuildFilterFromFilterBagIterator()	0	7	1
A	testFindObjectFromSql()	0	9	1
A	testGetLinkBetweenInheritedTables()	0	7	1
A	testFindObjectsFromSqlBadTableName()	0	9	1
A	testFindObjects()	0	22	3
A	testLinkedTableFetch()	0	4	1
A	testInvalidSetFetchMode()	0	4	1
A	testMap()	0	18	1
A	testArrayAccess()	0	20	3
A	testFindObjectsFromRawSqlBadTableName()	0	7	1
A	testFindObjectsByBean()	0	7	1
A	testCompleteSave2()	0	6	1
A	testFindObjectOrFail()	0	4	1
A	testInsertAndUpdateAndDelete()	0	19	1
A	testUpdatePrimaryKey()	0	12	1
A	testDeleteNewObject()	0	16	2
A	testArrayAccessException2()	0	6	1
A	testFindObject()	0	4	1
A	testTableNameException()	0	4	1
A	testGetPrimaryKeysFromIndexedPrimaryKeysException()	0	4	1
A	testArrayAccessException()	0	6	1
A	testCursorMode()	0	29	4
A	testFindObjectDuplicateRow()	0	5	1
A	testBeanGetException()	0	8	1
A	testFindObjectsMethodWithoutResultIteratorClass()	0	7	1
A	testTakeInCursorMode()	0	25	2
A	testFindObjectsFromSqlHierarchyDown()	0	13	1
A	testFindObjectFromSqlException()	0	9	1
A	testSetException()	0	6	1
A	testTake()	0	25	2
A	testBeanWithoutStatus()	0	6	1
A	testCompleteSave()	0	8	1
A	testFindObjectsFromSqlCountWithOneToManyLink()	0	5	1
A	testSetFetchMode()	0	15	2
A	testRawSqlFilterCountriesByUserCount()	0	20	2
A	testGetRelatedTablesByInheritance()	0	9	1
A	testBeanSetException()	0	8	1
A	testFindObjectsFromRawSqlMethodWithoutResultIteratorClass()	0	7	1
A	testFindObjectsFromSqlGroupBy()	0	11	1
A	testCannotDeleteDetachedObjects()	0	7	1
A	testUnsetException()	0	6	1
A	testToArray()	0	8	1
A	testInsertMultipleDataAtOnceInInheritance()	0	13	1
A	testDeleteLoadedObject()	0	14	1
A	testCursorModeException()	0	4	1
A	testFindObjectsFromSql()	0	11	1
A	getCustomOrder()	0	11	2
A	testRawSqlOrderUsersByCustomRoleOrder()	0	35	3
A	testPageUnsetException()	0	6	1
A	testFindObjectByPkException()	0	5	1
A	testFindObjectsFromSqlMethodWithoutResultIteratorClass()	0	7	1
A	testRawSqlOrderCountriesByUserCount()	0	23	3
A	testLogger()	0	10	1
A	testHashPrimaryKey()	0	19	1
A	testPageSetException()	0	6	1

<?php
declare(strict_types=1);

/*
 Copyright (C) 2006-2014 David Négrier - THE CODING MACHINE

This program is free software; you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation; either version 2 of the License, or
(at your option) any later version.

This program is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
GNU General Public License for more details.

You should have received a copy of the GNU General Public License
along with this program; if not, write to the Free Software
Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301  USA
*/

namespace TheCodingMachine\TDBM;

use Psr\Log\LogLevel;
use Psr\Log\NullLogger;
use Wa72\SimpleLogger\ArrayLogger;

class TDBMServiceTest extends TDBMAbstractServiceTest
{
    public function testGetLinkBetweenInheritedTables(): void
    {
        $this->assertEquals(['users', 'contact', 'person'], $this->tdbmService->_getLinkBetweenInheritedTables(['contact', 'users']));
        $this->assertEquals(['users', 'contact', 'person'], $this->tdbmService->_getLinkBetweenInheritedTables(['users', 'contact']));
        $this->assertEquals(['contact', 'person'], $this->tdbmService->_getLinkBetweenInheritedTables(['person', 'contact']));
        $this->assertEquals(['users', 'contact', 'person'], $this->tdbmService->_getLinkBetweenInheritedTables(['users']));
        $this->assertEquals(['person'], $this->tdbmService->_getLinkBetweenInheritedTables(['person']));
    }

    public function testGetRelatedTablesByInheritance(): void
    {
        $contactRelatedTables = $this->tdbmService->_getRelatedTablesByInheritance('contact');
        $this->assertCount(3, $contactRelatedTables);
        $this->assertContains('users', $contactRelatedTables);
        $this->assertContains('contact', $contactRelatedTables);
        $this->assertContains('person', $contactRelatedTables);
        $this->assertEquals(['person', 'contact', 'users'], $this->tdbmService->_getRelatedTablesByInheritance('users'));
        $this->assertEquals(['person', 'contact', 'users'], $this->tdbmService->_getRelatedTablesByInheritance('person'));
    }

    /**
     *
     * @throws TDBMException
     */
    public function testGetPrimaryKeysFromIndexedPrimaryKeysException(): void
    {
        $this->expectException('TheCodingMachine\TDBM\TDBMException');
        $this->tdbmService->_getPrimaryKeysFromIndexedPrimaryKeys('users', [5, 4]);
    }

    /**
     *
     * @throws TDBMException
     */
    public function testGetLinkBetweenInheritedTablesExceptions(): void
    {
        $this->expectException('TheCodingMachine\TDBM\TDBMException');
        $this->tdbmService->_getLinkBetweenInheritedTables(['contact', 'country']);
    }

    public function testHashPrimaryKey(): void
    {
        $reflection = new \ReflectionClass(get_class($this->tdbmService));
        $method = $reflection->getMethod('getObjectHash');
        $method->setAccessible(true);

        $result = $method->invokeArgs($this->tdbmService, [
            ['id' => 42],
        ]);
        $this->assertEquals(42, $result);

        // Check that multiple primary keys are insensitive to column order
        $result1 = $method->invokeArgs($this->tdbmService, [
            ['id1' => 42, 'id2' => 24],
        ]);
        $result2 = $method->invokeArgs($this->tdbmService, [
            ['id2' => 24, 'id1' => 42],
        ]);
        $this->assertEquals($result1, $result2);
    }

    public function testInsertAndUpdateAndDelete(): void
    {
        $object = new TDBMObject('users');
        $object->setProperty('login', 'john.doe');
        $object->setProperty('country_id', 3);
        $object->setProperty('name', 'John Doe', 'person');
        $object->setProperty('email', 'john@doe.com', 'contact');

        $this->tdbmService->save($object);

        $this->assertNotEmpty($object->getProperty('id', 'person'));
        $this->assertNotEmpty($object->getProperty('id', 'users'));
        $this->assertEquals($object->getProperty('id', 'person'), $object->getProperty('id', 'users'));

        $object->setProperty('country_id', 2, 'users');

        $this->tdbmService->save($object);

        $this->tdbmService->delete($object);
    }

    public function testInsertMultipleDataAtOnceInInheritance(): void
    {
        $object = new TDBMObject();
        $object->setProperty('login', 'jane.doe', 'users');
        $object->setProperty('name', 'Jane Doe', 'person');
        $object->setProperty('country_id', 1, 'users');
        $object->setProperty('email', 'jane@doe.com', 'contact');

        $this->tdbmService->save($object);

        $this->assertNotEmpty($object->getProperty('id', 'person'));
        $this->assertNotEmpty($object->getProperty('id', 'users'));
        $this->assertEquals($object->getProperty('id', 'person'), $object->getProperty('id', 'users'));
    }

    public function testCompleteSave(): void
    {
        $beans = $this->tdbmService->findObjects('users', 'users.login = :login', ['login' => 'jane.doe'], null, [], null, TDBMObject::class);
        $jane = $beans[0];
        $jane->setProperty('country_id', 2, 'users');

        $this->tdbmService->completeSave();
        $this->assertNotNull($jane->getProperty('id', 'users'));
    }

    public function testCompleteSave2(): void
    {
        $beans = $this->tdbmService->findObjects('users', 'users.login = :login', ['login' => 'jane.doe'], null, [], null, TDBMObject::class);
        $jane = $beans[0];

        $this->assertEquals(2, $jane->getProperty('country_id', 'users'));
    }

    public function testUpdatePrimaryKey(): void
    {
        $object = new TDBMObject('rights');
        $object->setProperty('label', 'CAN_EDIT_BOUK');

        $this->tdbmService->save($object);

        $object->setProperty('label', 'CAN_EDIT_BOOK');

        $this->tdbmService->save($object);

        $this->assertSame('CAN_EDIT_BOOK', $object->getProperty('label'));
    }

    /**
     *
     * @throws TDBMInvalidOperationException
     */
    public function testCannotDeleteDetachedObjects(): void
    {
        $this->expectException('TheCodingMachine\TDBM\TDBMInvalidOperationException');
        $object = new TDBMObject('rights');
        $object->setProperty('label', 'CAN_DELETE');

        $this->tdbmService->delete($object);
    }

    public function testDeleteNewObject(): void
    {
        $object = new TDBMObject('rights');
        $object->setProperty('label', 'CAN_DELETE');

        $this->tdbmService->attach($object);

        $this->tdbmService->delete($object);

        $exceptionRaised = false;
        try {
            $this->tdbmService->save($object);
        } catch (TDBMInvalidOperationException $e) {
            $exceptionRaised = true;
        }
        $this->assertTrue($exceptionRaised);
    }

    public function testDeleteLoadedObject(): void
    {
        $object = new TDBMObject('rights');
        $object->setProperty('label', 'CAN_DELETE');

        $this->tdbmService->save($object);

        $object->setProperty('label', 'CAN_DELETE2');

        $this->tdbmService->delete($object);

        // Try to delete a deleted object (this should do nothing)
        $this->tdbmService->delete($object);
        $this->assertSame(TDBMObjectStateEnum::STATE_DELETED, $object->_getStatus());
    }

    public function testFindObjects(): void
    {
        /*$magicQuery = new MagicQuery($this->tdbmService->getConnection());
        $result = $magicQuery->parse("SELECT DISTINCT users.id, users.login FROM users");
        var_dump($result);*/

        $beans = $this->tdbmService->findObjects('contact', null, [], 'contact.id ASC', [], null, TDBMObject::class);
        $beans2 = $this->tdbmService->findObjects('contact', 'contact.id = :id', ['id' => 1], null, [], null, TDBMObject::class);

        foreach ($beans as $bean) {
            $bean1 = $bean;
            break;
        }

        foreach ($beans2 as $bean) {
            $bean2 = $bean;
            break;
        }

        $this->assertTrue($bean1 === $bean2);

The variable $bean1 does not seem to be defined for all execution paths leading up to this point.

The variable $bean2 does not seem to be defined for all execution paths leading up to this point.

        $this->assertEquals(5, $beans->count());
        $this->assertEquals(1, $beans2->count());

        //$this->assertTrue($beans[0] === $beans2[0]);
        //var_dump($beans);
    }

    public function testRawSqlFilterCountriesByUserCount(): void
    {
        $this->onlyMySql();

        $sql = <<<SQL
SELECT country.*, GROUP_CONCAT(users.id) AS ids
FROM country
JOIN users ON country.id= users.country_id
GROUP BY country.id
HAVING COUNT(users.id) > 1;
SQL;
        /** @var Test\Dao\Bean\CountryBean[]|\Porpaginas\Result $beans */
        $beans = $this->tdbmService->findObjectsFromRawSql('country', $sql, [], null, Test\Dao\Bean\CountryBean::class);

The type TheCodingMachine\TDBM\Test\Dao\Bean\CountryBean was not found. Maybe you did not declare it correctly or list all dependencies?

        $count = 0;
        foreach ($beans as $country) {
            $this->assertGreaterThan(1, count($country->getUsers()));
            $count++;
        }
        $this->assertEquals($count, $beans->count());
    }

    public function testRawSqlOrderCountriesByUserCount(): void
    {
        $this->onlyMySql();

        $sql = <<<SQL
SELECT country.*, GROUP_CONCAT(users.id) AS ids
FROM country
JOIN users ON country.id= users.country_id
GROUP BY country.id
ORDER BY COUNT(users.id);
SQL;

        /** @var Test\Dao\Bean\CountryBean[]|\Porpaginas\Result $beans */
        $beans = $this->tdbmService->findObjectsFromRawSql('country', $sql, [], null, Test\Dao\Bean\CountryBean::class);

        $count = 0;
        foreach ($beans as $country) {
            $count++;
        }
        $this->assertEquals($count, $beans->count());

        for ($i = 1; $i < count($beans); $i++) {

It seems like you are calling the size function count() as part of the test condition. You might want to compute the size beforehand, and not on each iteration.

            $this->assertLessThanOrEqual(count($beans[$i]->getUsers()), count($beans[$i - 1]->getUsers()));
        }
    }

    public function testRawSqlOrderUsersByCustomRoleOrder(): void
    {
        $this->onlyMySql();

        $sql = <<<SQL
SELECT `person`.*, `contact`.*, `users`.*
FROM `contact`
JOIN `users` ON `users`.`id` = `contact`.`id`
JOIN `person` ON `person`.`id` = `users`.`id`
JOIN `users_roles` ON users.id = users_roles.user_id
JOIN `roles` ON roles.id = users_roles.role_id
GROUP BY users.id
ORDER BY MAX(IF(roles.name = 'Admins', 3, IF(roles.name = 'Writers', 2, IF(roles.name = 'Singers', 1, 0)))) DESC
SQL;

        /** @var Test\Dao\Bean\UserBean[]|\Porpaginas\Result $beans */
        $beans = $this->tdbmService->findObjectsFromRawSql('contact', $sql, [], null, Test\Dao\Bean\UserBean::class);

The type TheCodingMachine\TDBM\Test\Dao\Bean\UserBean was not found. Maybe you did not declare it correctly or list all dependencies?

        function getCustomOrder(Test\Dao\Bean\UserBean $contact)
        {
            $max = 0;
            foreach ($contact->getRoles() as $role) {
                $max = max($max, [
                    'Admins' => 3,
                    'Writers' => 2,
                    'Singers' => 1,
                ][$role->getName()]);
            }
            return $max;
        }

        $this->assertCount(4, $beans);

        for ($i = 1; $i < count($beans); $i++) {

It seems like you are calling the size function count() as part of the test condition. You might want to compute the size beforehand, and not on each iteration.

            $this->assertGreaterThanOrEqual(getCustomOrder($beans[$i]), getCustomOrder($beans[$i - 1]), 'Beans order does not comply with expected result.');
        }
    }

    public function testArrayAccess(): void
    {
        $beans = $this->tdbmService->findObjects('contact', null, [], 'contact.id ASC', [], null, TDBMObject::class);

        $this->assertTrue(isset($beans[0]));
        $this->assertFalse(isset($beans[42]));
        $this->assertEquals(1, $beans[0]->getProperty('id', 'person'));

        $result1 = [];
        foreach ($beans as $bean) {
            $result1[] = $bean;
        }

        $result2 = [];
        foreach ($beans as $bean) {
            $result2[] = $bean;
        }

        $this->assertEquals($result1, $result2);
        $this->assertTrue($result1[0] === $result2[0]);
    }

    /**
     *
     * @throws TDBMInvalidOffsetException
     */
    public function testArrayAccessException(): void
    {
        $this->expectException('TheCodingMachine\TDBM\TDBMInvalidOffsetException');
        $beans = $this->tdbmService->findObjects('contact', null, [], 'contact.id ASC', [], null, TDBMObject::class);

        $beans[-1];
    }

    /**
     *
     * @throws TDBMInvalidOffsetException
     */
    public function testArrayAccessException2(): void
    {
        $this->expectException('TheCodingMachine\TDBM\TDBMInvalidOffsetException');
        $beans = $this->tdbmService->findObjects('contact', null, [], 'contact.id ASC', [], null, TDBMObject::class);

        $beans['foo'];
    }

    /**
     *
     * @throws TDBMException
     */
    public function testBeanGetException(): void
    {
        $this->expectException('TheCodingMachine\TDBM\TDBMException');
        $beans = $this->tdbmService->findObjects('contact', null, [], 'contact.id ASC', [], null, TDBMObject::class);
        $bean = $beans[0];

        // we don't specify the table on inheritance table => exception.
        $bean->getProperty('id');
    }

    /**
     *
     * @throws TDBMException
     */
    public function testBeanSetException(): void
    {
        $this->expectException('TheCodingMachine\TDBM\TDBMException');
        $beans = $this->tdbmService->findObjects('contact', null, [], 'contact.id ASC', [], null, TDBMObject::class);
        $bean = $beans[0];

        // we don't specify the table on inheritance table => exception.
        $bean->setProperty('name', 'foo');
    }

    public function testTake(): void
    {
        $beans = $this->tdbmService->findObjects('contact', null, [], 'contact.id ASC', [], null, TDBMObject::class);

        $page = $beans->take(0, 2);

        $this->assertEquals(2, $page->count());

        $results = [];
        foreach ($page as $result) {
            $results[] = $result;
        }
        $this->assertCount(2, $results);

        $this->assertEquals(5, $page->totalCount());

        $page = $beans->take(1, 1);

        $this->assertEquals(1, $page->count());

        $resultArray = $page->toArray();
        $this->assertCount(1, $resultArray);
        $this->assertTrue($resultArray[0] === $page[0]);
        // Test page isset
        $this->assertTrue(isset($page[0]));
    }

    public function testTakeInCursorMode(): void
    {
        $beans = $this->tdbmService->findObjects('contact', null, [], 'contact.id ASC', [], TDBMService::MODE_CURSOR, TDBMObject::class);

        $page = $beans->take(0, 2);

        $this->assertEquals(2, $page->count());
        $this->assertEquals(0, $page->getCurrentOffset());
        $this->assertEquals(2, $page->getCurrentLimit());
        $this->assertEquals(1, $page->getCurrentPage());

        $results = [];
        foreach ($page as $result) {
            $results[] = $result;
        }
        $this->assertCount(2, $results);

        $this->assertEquals(5, $page->totalCount());

        $page = $beans->take(1, 1);
        $this->assertEquals(1, $page->getCurrentOffset());
        $this->assertEquals(1, $page->getCurrentLimit());
        $this->assertEquals(2, $page->getCurrentPage());

        $this->assertEquals(1, $page->count());
    }

    public function testMap(): void
    {
        $beans = $this->tdbmService->findObjects('person', null, [], 'person.id ASC', [], null, TDBMObject::class);

        $results = $beans->map(function ($item) {
            return $item->getProperty('id', 'person');
        })->toArray();

        $this->assertEquals([1, 2, 3, 4, 6], $results);

        // Same test with page
        $page = $beans->take(0, 2);

        $results = $page->map(function ($item) {
            return $item->getProperty('id', 'person');
        })->toArray();

        $this->assertEquals([1, 2], $results);
    }

    /**
     *
     * @throws TDBMException
     */
    public function testUnsetException(): void
    {
        $this->expectException('TheCodingMachine\TDBM\TDBMException');
        $beans = $this->tdbmService->findObjects('contact', null, [], 'contact.id ASC', [], null, TDBMObject::class);

        unset($beans[0]);
    }

    /**
     *
     * @throws TDBMException
     */
    public function testSetException(): void
    {
        $this->expectException('TheCodingMachine\TDBM\TDBMException');
        $beans = $this->tdbmService->findObjects('contact', null, [], 'contact.id ASC', [], null, TDBMObject::class);

        $beans[0] = 'foo';
    }

    /**
     *
     * @throws TDBMException
     */
    public function testPageUnsetException(): void
    {
        $this->expectException('TheCodingMachine\TDBM\TDBMException');
        $beans = $this->tdbmService->findObjects('contact', null, [], 'contact.id ASC', [], null, TDBMObject::class);
        $page = $beans->take(0, 1);
        unset($page[0]);
    }

    /**
     *
     * @throws TDBMException
     */
    public function testPageSetException(): void
    {
        $this->expectException('TheCodingMachine\TDBM\TDBMException');
        $beans = $this->tdbmService->findObjects('contact', null, [], 'contact.id ASC', [], null, TDBMObject::class);
        $page = $beans->take(0, 1);
        $page[0] = 'foo';
    }

    public function testToArray(): void
    {
        $beans = $this->tdbmService->findObjects('contact', 'contact.id = :id', ['id' => 1], null, [], null, TDBMObject::class);

        $beanArray = $beans->toArray();

        $this->assertCount(1, $beanArray);
        $this->assertEquals(1, $beanArray[0]->getProperty('id', 'contact'));
    }

    public function testCursorMode(): void
    {
        $beans = $this->tdbmService->findObjects('contact', 'contact.id = :id', ['id' => 1], null, [], TDBMService::MODE_CURSOR, TDBMObject::class);

        $this->assertInstanceOf('\\TheCodingMachine\\TDBM\\ResultIterator', $beans);

        $result = [];
        foreach ($beans as $bean) {
            $result[] = $bean;
        }

        $this->assertCount(1, $result);

        // In cursor mode, access by array causes an exception.
        $exceptionTriggered = false;
        try {
            $beans[0];
        } catch (TDBMInvalidOperationException $e) {
            $exceptionTriggered = true;
        }
        $this->assertTrue($exceptionTriggered);

        $exceptionTriggered = false;
        try {
            isset($beans[0]);
        } catch (TDBMInvalidOperationException $e) {
            $exceptionTriggered = true;
        }
        $this->assertTrue($exceptionTriggered);
    }

    public function testSetFetchMode(): void
    {
        $this->tdbmService->setFetchMode(TDBMService::MODE_CURSOR);
        $beans = $this->tdbmService->findObjects('contact', 'contact.id = :id', ['id' => 1], null, [], null, TDBMObject::class);

        $this->assertInstanceOf('\\TheCodingMachine\\TDBM\\ResultIterator', $beans);

        // In cursor mode, access by array causes an exception.
        $exceptionTriggered = false;
        try {
            $beans[0];
        } catch (TDBMInvalidOperationException $e) {
            $exceptionTriggered = true;
        }
        $this->assertTrue($exceptionTriggered);
    }

    /**
     *
     * @throws TDBMException
     */
    public function testInvalidSetFetchMode(): void
    {
        $this->expectException('TheCodingMachine\TDBM\TDBMException');
        $this->tdbmService->setFetchMode(99);
    }

    /**
     *
     * @throws TDBMException
     */
    public function testCursorModeException(): void
    {
        $this->expectException('TheCodingMachine\TDBM\TDBMException');
        $beans = $this->tdbmService->findObjects('contact', 'contact.id = :id', ['id' => 1], null, [], 99);

The assignment to $beans is dead and can be removed.

    }

    /**
     *
     * @throws TDBMException
     */
    public function testTableNameException(): void
    {
        $this->expectException('TheCodingMachine\TDBM\TDBMException');
        $beans = $this->tdbmService->findObjects('foo bar');

The assignment to $beans is dead and can be removed.

    }

    public function testLinkedTableFetch(): void
    {
        $beans = $this->tdbmService->findObjects('contact', 'contact.id = :id', ['id' => 1], null, ['country'], null, TDBMObject::class);
        $this->assertInstanceOf(ResultIterator::class, $beans);
    }

    public function testFindObject(): void
    {
        $bean = $this->tdbmService->findObject('contact', 'contact.id = :id', ['id' => -42], [], TDBMObject::class);
        $this->assertNull($bean);
    }

    /**
     *
     * @throws NoBeanFoundException
     */
    public function testFindObjectOrFail(): void
    {
        $this->expectException('TheCodingMachine\TDBM\NoBeanFoundException');
        $bean = $this->tdbmService->findObjectOrFail('contact', 'contact.id = :id', ['id' => -42], [], TDBMObject::class);

The assignment to $bean is dead and can be removed.

    }

    /**
     * @throws NoBeanFoundException
     */
    public function testFindObjectByPkException(): void
    {
        $this->expectException(NoBeanFoundException::class);
        $this->expectExceptionMessage("No result found for query on table 'contact' for 'id' = -42");
        $bean = $this->tdbmService->findObjectByPk('contact', ['id' => -42], [], false, TDBMObject::class);

The assignment to $bean is dead and can be removed.

    }

    /**
     * @throws DuplicateRowException
     */
    public function testFindObjectDuplicateRow(): void
    {
        $this->expectException(DuplicateRowException::class);

        $bean = $this->tdbmService->findObject('contact');

The assignment to $bean is dead and can be removed.

    }

    public function testFindObjectsByBean(): void
    {
        $countryBean = $this->tdbmService->findObject('country', 'id = :id', ['id' => 1], [], TDBMObject::class);

        $users = $this->tdbmService->findObjects('users', $countryBean, [], null, [], null, TDBMObject::class);

It seems like $countryBean can also be of type TheCodingMachine\TDBM\AbstractTDBMObject; however, parameter $filter of TheCodingMachine\TDBM\TDBMService::findObjects() does only seem to accept array|null|string, maybe add an additional type check?

        $this->assertCount(1, $users);
        $this->assertEquals('jean.dupont', $users[0]->getProperty('login', 'users'));
    }

    /**
     *
     * @throws TDBMException
     * @throws TDBMInvalidOperationException
     */
    public function testBeanWithoutStatus(): void
    {
        $this->expectException('TheCodingMachine\TDBM\TDBMException');
        $reflectionClass = new \ReflectionClass(TDBMObject::class);
        $object = $reflectionClass->newInstanceWithoutConstructor();
        $object->_getStatus();
    }

    public function testFindObjectsFromSql(): void
    {
        $roles = $this->tdbmService->findObjectsFromSql(
            'roles',
            'roles JOIN roles_rights ON roles.id = roles_rights.role_id JOIN rights ON rights.label = roles_rights.right_label',
            'rights.label = :right',
            array('right' => 'CAN_SING'),
            'roles.name DESC'
        );
        $this->assertCount(2, $roles);
        $this->assertInstanceOf(AbstractTDBMObject::class, $roles[0]);
    }

    /**
     *
     * @throws TDBMException
     */
    public function testFindObjectsFromSqlBadTableName(): void
    {
        $this->expectException(TDBMException::class);
        $this->tdbmService->findObjectsFromSql(
            '#{azerty',
            'roles JOIN roles_rights ON roles.id = roles_rights.role_id JOIN rights ON rights.label = roles_rights.right_label',
            'rights.label = :right',
            array('right' => 'CAN_SING'),
            'name DESC'
        );
    }

    /**
     *
     * @throws TDBMException
     */
    public function testFindObjectsFromSqlGroupBy(): void
    {
        $this->expectException(TDBMException::class);
        $roles = $this->tdbmService->findObjectsFromSql(
            'roles',
            'roles JOIN roles_rights ON roles.id = roles_rights.role_id JOIN rights ON rights.label = roles_rights.right_label',
            'rights.label = :right GROUP BY roles.name',
            array('right' => 'CAN_SING'),
            'name DESC'
        );
        $role = $roles[0];

The assignment to $role is dead and can be removed.

    }

    /**
     *
     * @throws TDBMException
     */
    public function testFindObjectsFromRawSqlBadTableName(): void
    {
        $this->expectException(TDBMException::class);
        $this->tdbmService->findObjectsFromRawSql(
            '#{azerty',
            'roles JOIN roles_rights ON roles.id = roles_rights.role_id JOIN rights ON rights.label = roles_rights.right_label WHERE rights.label = :right',
            array('right' => 'CAN_SING')
        );
    }

    public function testFindObjectFromSql(): void
    {
        $role = $this->tdbmService->findObjectFromSql(
            'roles',
            'roles JOIN roles_rights ON roles.id = roles_rights.role_id JOIN rights ON rights.label = roles_rights.right_label',
            'rights.label = :right AND name = :name',
            array('right' => 'CAN_SING', 'name' => 'Singers')
        );
        $this->assertInstanceOf(AbstractTDBMObject::class, $role);
    }

    /**
     * @throws DuplicateRowException
     */
    public function testFindObjectFromSqlException(): void
    {
        $this->expectException(DuplicateRowException::class);
        $this->expectExceptionMessage('Error while querying an object in table \'roles\': More than 1 row have been returned, but we should have received at most one for filter "rights.label = \'CAN_SING\'".');
        $this->tdbmService->findObjectFromSql(
            'roles',
            'roles JOIN roles_rights ON roles.id = roles_rights.role_id JOIN rights ON rights.label = roles_rights.right_label',
            'rights.label = :right',
            array('right' => 'CAN_SING')
        );
    }

    public function testFindObjectsFromSqlHierarchyDown(): void
    {
        $users = $this->tdbmService->findObjectsFromSql(
            'person',
            'person',
            'name LIKE :name OR name LIKE :name2',
            array('name' => 'Robert Marley', 'name2' => 'Bill Shakespeare'),
            null,
            null,
            TDBMObject::class
        );
        $this->assertCount(2, $users);
        $this->assertSame('robert.marley', $users[0]->getProperty('login', 'users'));
    }

    public function testFindObjectsFromSqlHierarchyUp(): void
    {
        $users = $this->tdbmService->findObjectsFromSql(
            'users',
            'users',
            'login LIKE :login OR login LIKE :login2',
            array('login' => 'robert.marley', 'login2' => 'bill.shakespeare'),
            'users.login DESC',
            null,
            TDBMObject::class
        );
        $this->assertCount(2, $users);
        $this->assertSame('Robert Marley', $users[0]->getProperty('name', 'person'));
    }

    public function testLogger(): void
    {
        $arrayLogger = new ArrayLogger();
        $tdbmService = new TDBMService(new Configuration('TheCodingMachine\\TDBM\\Test\\Dao\\Bean', 'TheCodingMachine\\TDBM\\Test\\Dao', 'TheCodingMachine\\TDBM\\Test\\ResultIterator', self::getConnection(), $this->getNamingStrategy(), null, null, $arrayLogger));

        $tdbmService->setLogLevel(LogLevel::DEBUG);
        $beans = $tdbmService->findObjects('contact', null, [], 'contact.id ASC', [], null, TDBMObject::class);
        $beans->first();

        $this->assertNotEmpty($arrayLogger->get());
    }

    public function testFindObjectsCountWithOneToManyLink(): void
    {
        $countries = $this->tdbmService->findObjects('country', "users.status = 'on' OR users.status = 'off'");

        $this->assertEquals(3, $countries->count());
    }

    public function testFindObjectsFromSqlCountWithOneToManyLink(): void
    {
        $countries = $this->tdbmService->findObjectsFromSql('country', 'country LEFT JOIN users ON country.id = users.country_id', "users.status = 'on' OR users.status = 'off'");

        $this->assertEquals(3, $countries->count());
    }

    public function testBuildFilterFromFilterBagIterator(): void
    {
        $tdbmService = new TDBMService(new Configuration('TheCodingMachine\\TDBM\\Test\\Dao\\Bean', 'TheCodingMachine\\TDBM\\Test\\Dao', 'TheCodingMachine\\TDBM\\Test\\ResultIterator', self::getConnection(), $this->getNamingStrategy(), null, null, new NullLogger()));

        [$sql, $parameters, $counter] = $tdbmService->buildFilterFromFilterBag(new \ArrayIterator(['id' => 1]), self::getConnection()->getDatabasePlatform());
        $this->assertEquals('(`id` = :tdbmparam1)', $sql);
        $this->assertEquals($parameters['tdbmparam1'], 1);
    }

    public function testFindObjectsMethodWithoutResultIteratorClass(): void
    {
        $this->expectException(TDBMInvalidArgumentException::class);
        $this->expectExceptionMessageRegExp('/^\$resultIteratorClass should be a `' . preg_quote(ResultIterator::class, '/') . '`. `(.*)` provided\.$/');
        $tdbmService = new TDBMService(new Configuration('TheCodingMachine\\TDBM\\Test\\Dao\\Bean', 'TheCodingMachine\\TDBM\\Test\\Dao', 'TheCodingMachine\\TDBM\\Test\\ResultIterator', self::getConnection(), $this->getNamingStrategy(), null, null, new NullLogger()));

        $tdbmService->findObjects('', null, [], null, [], null, null, self::class);
    }

    public function testFindObjectsFromSqlMethodWithoutResultIteratorClass(): void
    {
        $this->expectException(TDBMInvalidArgumentException::class);
        $this->expectExceptionMessageRegExp('/^\$resultIteratorClass should be a `' . preg_quote(ResultIterator::class, '/') . '`. `(.*)` provided\.$/');
        $tdbmService = new TDBMService(new Configuration('TheCodingMachine\\TDBM\\Test\\Dao\\Bean', 'TheCodingMachine\\TDBM\\Test\\Dao', 'TheCodingMachine\\TDBM\\Test\\ResultIterator', self::getConnection(), $this->getNamingStrategy(), null, null, new NullLogger()));

        $tdbmService->findObjectsFromSql('', '', null, [], null, null, null, self::class);
    }

    public function testFindObjectsFromRawSqlMethodWithoutResultIteratorClass(): void
    {
        $this->expectException(TDBMInvalidArgumentException::class);
        $this->expectExceptionMessageRegExp('/^\$resultIteratorClass should be a `' . preg_quote(ResultIterator::class, '/') . '`. `(.*)` provided\.$/');
        $tdbmService = new TDBMService(new Configuration('TheCodingMachine\\TDBM\\Test\\Dao\\Bean', 'TheCodingMachine\\TDBM\\Test\\Dao', 'TheCodingMachine\\TDBM\\Test\\ResultIterator', self::getConnection(), $this->getNamingStrategy(), null, null, new NullLogger()));

        $tdbmService->findObjectsFromRawSql('', '', [], null, null, null, self::class);
    }
}