ForeignKey::getUnquotedForeignColumns() - Code Metrics - Inspection of "Generate our own FK names and cache to avoid confl..." - thecodingmachine/tdbm - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#127)

unknown

created 2019-04-01 16:31 UTC

ForeignKey::getUnquotedForeignColumns() A

↳ Parent: ForeignKey

Complexity

Conditions	1
Paths	1

Size

Total Lines	3
Code Lines	1

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
eloc	1
dl	0
loc	3
rs	10
c	0
b	0
f	0
cc	1
nc	1
nop	0

<?php


namespace TheCodingMachine\TDBM\Schema;


use Doctrine\DBAL\Schema\ForeignKeyConstraint;

class ForeignKey
{
    public const FOREIGN_TABLE = 'foreignTable';
    public const LOCAL_COLUMNS = 'localColumns';
    public const FOREIGN_COLUMNS = 'foreignColumns';

    /**
     * @var array<string, string|array<string>>
     */
    private $foreignKey;

    /**
     * @param array<string, string|array<string>> $foreignKey
     */
    public function __construct(array $foreignKey)
    {
        $this->foreignKey = $foreignKey;
    }

    public static function createFromFk(ForeignKeyConstraint $fk): self
    {
        return new self([
            self::FOREIGN_TABLE => $fk->getForeignTableName(),
            self::LOCAL_COLUMNS => $fk->getUnquotedLocalColumns(),
            self::FOREIGN_COLUMNS => $fk->getUnquotedForeignColumns(),
        ]);
    }

    /**
     * @return array<string>
     */
    public function getUnquotedLocalColumns(): array
    {
        return $this->foreignKey[self::LOCAL_COLUMNS];

    }

    /**
     * @return array<string>
     */
    public function getUnquotedForeignColumns(): array
    {
        return $this->foreignKey[self::FOREIGN_COLUMNS];

    }

    public function getForeignTableName(): string
    {
        return $this->foreignKey[self::FOREIGN_TABLE];

    }

    public function getCacheKey(): string
    {
        return 'from__'.implode(',', $this->getUnquotedLocalColumns()) . '__to__table__' . $this->getForeignTableName() . '__columns__' . implode(',', $this->getUnquotedForeignColumns());
    }
}


1			<?php
2
3
4			namespace TheCodingMachine\TDBM\Schema;
5
6
7			use Doctrine\DBAL\Schema\ForeignKeyConstraint;
8
9			class ForeignKey
10			{
11			public const FOREIGN_TABLE = 'foreignTable';
12			public const LOCAL_COLUMNS = 'localColumns';
13			public const FOREIGN_COLUMNS = 'foreignColumns';
14
15			/**
16			* @var array<string, string\|array<string>>
17			*/
18			private $foreignKey;
19
20			/**
21			* @param array<string, string\|array<string>> $foreignKey
22			*/
23			public function __construct(array $foreignKey)
24			{
25			$this->foreignKey = $foreignKey;
26			}
27
28			public static function createFromFk(ForeignKeyConstraint $fk): self
29			{
30			return new self([
31			self::FOREIGN_TABLE => $fk->getForeignTableName(),
32			self::LOCAL_COLUMNS => $fk->getUnquotedLocalColumns(),
33			self::FOREIGN_COLUMNS => $fk->getUnquotedForeignColumns(),
34			]);
35			}
36
37			/**
38			* @return array<string>
39			*/
40			public function getUnquotedLocalColumns(): array
41			{
42			return $this->foreignKey[self::LOCAL_COLUMNS];
			0 ignored issues – show Bug Best Practice introduced 2019-04-01 16:37 UTC by Report Bug Copy Issue Report The expression `return $this->foreignKey[self::LOCAL_COLUMNS]` could return the type `string` which is incompatible with the type-hinted return `array`. Consider adding an additional type-check to rule them out. Loading history...
43			}
44
45			/**
46			* @return array<string>
47			*/
48			public function getUnquotedForeignColumns(): array
49			{
50			return $this->foreignKey[self::FOREIGN_COLUMNS];
			0 ignored issues – show Bug Best Practice introduced 2019-04-01 16:37 UTC by Report Bug Copy Issue Report The expression `return $this->foreignKey[self::FOREIGN_COLUMNS]` could return the type `string` which is incompatible with the type-hinted return `array`. Consider adding an additional type-check to rule them out. Loading history...
51			}
52
53			public function getForeignTableName(): string
54			{
55			return $this->foreignKey[self::FOREIGN_TABLE];
			0 ignored issues – show Bug Best Practice introduced 2019-04-01 16:37 UTC by Report Bug Copy Issue Report The expression `return $this->foreignKey[self::FOREIGN_TABLE]` could return the type `string[]` which is incompatible with the type-hinted return `string`. Consider adding an additional type-check to rule them out. Loading history...
56			}
57
58			public function getCacheKey(): string
59			{
60			return 'from__'.implode(',', $this->getUnquotedLocalColumns()) . '__to__table__' . $this->getForeignTableName() . '__columns__' . implode(',', $this->getUnquotedForeignColumns());
61			}
62			}
63

thecodingmachine / tdbm

Pull Request — master (#127)

ForeignKey::getUnquotedForeignColumns() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like