LevelFilter::log() - Code Metrics - Inspection of "Merge pull request #186 from moufmouf/symfony5-mas..." - thecodingmachine/tdbm - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 36c690...2340c9 )

by David

created 2019-11-25 14:20 UTC

LevelFilter::log() A

↳ Parent: LevelFilter

Complexity

Conditions	3
Paths	3

Size

Total Lines	16
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
eloc	9
c	1
b	0
f	0
dl	0
loc	16
rs	9.9666
cc	3
nc	3
nop	3

<?php


namespace TheCodingMachine\TDBM\Utils\Logs;

use Psr\Log\AbstractLogger;
use Psr\Log\InvalidArgumentException;
use Psr\Log\LoggerInterface;
use Psr\Log\LogLevel;
use function array_search;
use function sprintf;

class LevelFilter extends AbstractLogger
{
    /**
     * Logging levels from syslog protocol defined in RFC 5424
     *
     * @var string[] $levels Logging levels
     */
    private static $levels = array(
        LogLevel::EMERGENCY, // 0
        LogLevel::ALERT,     // 1
        LogLevel::CRITICAL,  // 2
        LogLevel::ERROR,     // 3
        LogLevel::WARNING,   // 4
        LogLevel::NOTICE,    // 5
        LogLevel::INFO,      // 6
        LogLevel::DEBUG      // 7
    );

    /**
     * @var int
     */
    private $logLevel;
    /**
     * @var LoggerInterface
     */
    private $logger;

    /**
     * @param LoggerInterface $logger
     * @param string $level \Psr\Log\LogLevel string
     */
    public function __construct(LoggerInterface $logger, $level)
    {
        $this->logger = $logger;

        $this->logLevel = array_search($level, self::$levels, true);
class Id
{
    public $id;

    public function __construct($id)
    {
        $this->id = $id;
    }

}

class Account
{
    /** @var  Id $id */
    public $id;
}

$account_id = false;

if (starsAreRight()) {
    $account_id = new Id(42);
}

$account = new Account();
if ($account instanceof Id)
{
    $account->id = $account_id;
}
        if ($this->logLevel === false) {
            throw new InvalidArgumentException(
                sprintf(
                    'Cannot use logging level "%s"',
                    $level
                )
            );
        }
    }

    /**
     * Logs with an arbitrary level.
     *
     * @param mixed  $level
     * @param string $message
     * @param array  $context
     *
     * @return void
     */
    public function log($level, $message, array $context = array())
    {
        $levelCode = array_search($level, self::$levels, true);
        if ($levelCode === false) {
            throw new InvalidArgumentException(
                sprintf(
                    'Cannot use unknown logging level "%s"',
                    $level
                )
            );
        }
        if ($levelCode > $this->logLevel) {
            return;
        }

        $this->logger->log($level, $message, $context);
    }
}


1			<?php
2
3
4			namespace TheCodingMachine\TDBM\Utils\Logs;
5
6			use Psr\Log\AbstractLogger;
7			use Psr\Log\InvalidArgumentException;
8			use Psr\Log\LoggerInterface;
9			use Psr\Log\LogLevel;
10			use function array_search;
11			use function sprintf;
12
13			class LevelFilter extends AbstractLogger
14			{
15			/**
16			* Logging levels from syslog protocol defined in RFC 5424
17			*
18			* @var string[] $levels Logging levels
19			*/
20			private static $levels = array(
21			LogLevel::EMERGENCY, // 0
22			LogLevel::ALERT, // 1
23			LogLevel::CRITICAL, // 2
24			LogLevel::ERROR, // 3
25			LogLevel::WARNING, // 4
26			LogLevel::NOTICE, // 5
27			LogLevel::INFO, // 6
28			LogLevel::DEBUG // 7
29			);
30
31			/**
32			* @var int
33			*/
34			private $logLevel;
35			/**
36			* @var LoggerInterface
37			*/
38			private $logger;
39
40			/**
41			* @param LoggerInterface $logger
42			* @param string $level \Psr\Log\LogLevel string
43			*/
44			public function __construct(LoggerInterface $logger, $level)
45			{
46			$this->logger = $logger;
47
48			$this->logLevel = array_search($level, self::$levels, true);
			0 ignored issues – show Documentation Bug introduced 2019-11-25 13:10 UTC by Report Bug Copy Issue Report It seems like `array_search($level, self::levels, true)` can also be of type `false` or `string`. However, the property `$logLevel` is declared as type `integer`. Maybe add an additional type check? Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a mixed type is assigned to a property that is type hinted more strictly. For example, imagine you have a variable `$accountId` that can either hold an Id object or false (if there is no account id yet). Your code now assigns that value to the `id` property of an instance of the `Account` class. This class holds a proper account, so the id value must no longer be false. Either this assignment is in error or a type check should be added for that assignment. class Id { public $id; public function __construct($id) { $this->id = $id; } } class Account { /** @var Id $id */ public $id; } $account_id = false; if (starsAreRight()) { $account_id = new Id(42); } $account = new Account(); if ($account instanceof Id) { $account->id = $account_id; } Loading history...
49			if ($this->logLevel === false) {
50			throw new InvalidArgumentException(
51			sprintf(
52			'Cannot use logging level "%s"',
53			$level
54			)
55			);
56			}
57			}
58
59			/**
60			* Logs with an arbitrary level.
61			*
62			* @param mixed $level
63			* @param string $message
64			* @param array $context
65			*
66			* @return void
67			*/
68			public function log($level, $message, array $context = array())
69			{
70			$levelCode = array_search($level, self::$levels, true);
71			if ($levelCode === false) {
72			throw new InvalidArgumentException(
73			sprintf(
74			'Cannot use unknown logging level "%s"',
75			$level
76			)
77			);
78			}
79			if ($levelCode > $this->logLevel) {
80			return;
81			}
82
83			$this->logger->log($level, $message, $context);
84			}
85			}
86

thecodingmachine / tdbm

Push — master ( 36c690...2340c9 )

LevelFilter::log() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like