TdbmFluidTableTest::testUuid() - Code Metrics - Inspection of "Adding useTrait and useTraitOnDao methods" - thecodingmachine/tdbm-fluid-schema-builder - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#15)

by David

created 2019-03-26 16:16 UTC

TdbmFluidTableTest::testUuid() A

↳ Parent: TdbmFluidTableTest

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	13
Ratio	100 %

Importance

Changes

Metric	Value
dl	13
loc	13
rs	9.8333
c	0
b	0
f	0
cc	1
nc	1
nop	0

<?php

namespace TheCodingMachine\FluidSchema;

use Doctrine\DBAL\Schema\Schema;
use Doctrine\DBAL\Types\Type;
use PHPUnit\Framework\TestCase;

class TdbmFluidTableTest extends TestCase
{
    public function testColumn()
    {
        $schema = new Schema();
        $fluid = new TdbmFluidSchema($schema);

        $posts = $fluid->table('posts');

        $column = $posts->column('foo');

        $this->assertTrue($schema->getTable('posts')->hasColumn('foo'));

        $this->assertSame($column, $posts->column('foo'), 'Failed asserting that the same instance is returned.');
    }

    public function testExistingColumn()
    {
        $schema = new Schema();
        $postsSchemaTable = $schema->createTable('posts');
        $postsSchemaTable->addColumn('foo', 'string');
        $fluid = new TdbmFluidSchema($schema);

        $posts = $fluid->table('posts');

        $posts->column('foo')->integer();

        $this->assertSame(Type::getType(Type::INTEGER), $schema->getTable('posts')->getColumn('foo')->getType());
    }

    public function testIndex()
    {
        $schema = new Schema();
        $fluid = new TdbmFluidSchema($schema);

        $posts = $fluid->table('posts');

        $posts->column('foo')->integer()->then()->index(['foo']);

        $this->assertCount(1, $schema->getTable('posts')->getIndexes());
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }

    public function testUnique()
    {
        $schema = new Schema();
        $fluid = new TdbmFluidSchema($schema);

        $posts = $fluid->table('posts');

        $posts->column('foo')->integer()->then()->unique(['foo']);

        $this->assertCount(1, $schema->getTable('posts')->getIndexes());
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }

    public function testPrimaryKey()

    {
        $schema = new Schema();
        $fluid = new TdbmFluidSchema($schema);

        $posts = $fluid->table('posts');

        $posts->column('id')->integer()->then()->primaryKey(['id'], 'pkname');

        $this->assertTrue($schema->getTable('posts')->hasPrimaryKey());
        $this->assertTrue($schema->getTable('posts')->hasIndex('pkname'));
    }

    public function testId()

    {
        $schema = new Schema();
        $fluid = new TdbmFluidSchema($schema);

        $posts = $fluid->table('posts');

        $posts->id();

        $this->assertTrue($schema->getTable('posts')->hasPrimaryKey());
        $this->assertTrue($schema->getTable('posts')->hasColumn('id'));
    }

    public function testUuid()

    {
        $schema = new Schema();
        $fluid = new TdbmFluidSchema($schema);

        $posts = $fluid->table('posts');

        $posts->uuid();

        $this->assertTrue($schema->getTable('posts')->hasPrimaryKey());
        $this->assertTrue($schema->getTable('posts')->hasColumn('uuid'));
        $this->assertSame("\n@UUID(\"v4\")", $schema->getTable('posts')->getColumn('uuid')->getComment());
    }

    public function testUuidBadType()
    {
        $schema = new Schema();
        $fluid = new TdbmFluidSchema($schema);

        $posts = $fluid->table('posts');

        $this->expectException(FluidSchemaException::class);
        $posts->uuid('v2');
    }

    public function testCustomBeanName()

    {
        $schema = new Schema();
        $fluid = new TdbmFluidSchema($schema);

        $posts = $fluid->table('posts');

        $posts->customBeanName('Article');

        $this->assertSame("\n@Bean(name = \"Article\")", $schema->getTable('posts')->getOptions()['comment']);
    }

    public function testImplementsInterface()

    {
        $schema = new Schema();
        $fluid = new TdbmFluidSchema($schema);

        $posts = $fluid->table('posts');

        $posts->implementsInterface('Foo\\Bar');
        $posts->implementsInterface('Foo\\Bar2');

        $this->assertSame("\n@AddInterface(name = \"Foo\\Bar\")\n@AddInterface(name = \"Foo\\Bar2\")", $schema->getTable('posts')->getOptions()['comment']);
    }

    public function testImplementsInterfaceOnDao()

    {
        $schema = new Schema();
        $fluid = new TdbmFluidSchema($schema);

        $posts = $fluid->table('posts');

        $posts->implementsInterfaceOnDao('Foo\\Bar');

        $this->assertSame("\n@AddInterfaceOnDao(name = \"Foo\\Bar\")", $schema->getTable('posts')->getOptions()['comment']);
    }

    public function testUseTrait()

    {
        $schema = new Schema();
        $fluid = new TdbmFluidSchema($schema);

        $posts = $fluid->table('posts');

        $posts->useTrait('Foo\\Bar');
        $posts->useTrait('Foo\\Bar2');

        $this->assertSame("\n@AddTrait(name = \"Foo\\Bar\", modifiers = {})\n@AddTrait(name = \"Foo\\Bar2\", modifiers = {})", $schema->getTable('posts')->getOptions()['comment']);
    }

    public function testUseTraitOnDao()

    {
        $schema = new Schema();
        $fluid = new TdbmFluidSchema($schema);

        $posts = $fluid->table('posts');

        $posts->useTraitOnDao('Foo\\Bar');

        $this->assertSame("\n@AddTraitOnDao(name = \"Foo\\Bar\", modifiers = {})", $schema->getTable('posts')->getOptions()['comment']);
    }

    public function testTimestamps()

    {
        if (defined('Doctrine\\DBAL\\Types\\Type::DATE_IMMUTABLE')) {
            $schema = new Schema();
            $fluid = new TdbmFluidSchema($schema);

            $posts = $fluid->table('posts');

            $posts->timestamps();

            $this->assertTrue($schema->getTable('posts')->hasColumn('created_at'));
            $this->assertTrue($schema->getTable('posts')->hasColumn('updated_at'));
        } else {
            $this->markTestSkipped("Only available from Doctrine DBAL 2.6");
        }
    }

    public function testInherits()

    {
        $schema = new Schema();
        $fluid = new TdbmFluidSchema($schema);

        $contacts = $fluid->table('contacts');
        $contacts->id();

        $fluid->table('users')->extends('contacts');

        $dbalColumn = $schema->getTable('users')->getColumn('id');

        $this->assertSame(Type::getType(Type::INTEGER), $dbalColumn->getType());
        $fks = $schema->getTable('users')->getForeignKeys();
        $this->assertCount(1, $fks);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $fk = array_pop($fks);
        $this->assertSame('users', $fk->getLocalTableName());
        $this->assertSame('contacts', $fk->getForeignTableName());
        $this->assertSame(['id'], $fk->getLocalColumns());
    }

    public function testGetDbalTable()
    {
        $schema = new Schema();
        $fluid = new TdbmFluidSchema($schema);

        $contacts = $fluid->table('contacts');
        $this->assertSame('contacts', $contacts->getDbalTable()->getName());
    }
}


1		<?php
2
3		namespace TheCodingMachine\FluidSchema;
4
5		use Doctrine\DBAL\Schema\Schema;
6		use Doctrine\DBAL\Types\Type;
7		use PHPUnit\Framework\TestCase;
8
9		class TdbmFluidTableTest extends TestCase
10		{
11		public function testColumn()
12		{
13		$schema = new Schema();
14		$fluid = new TdbmFluidSchema($schema);
15
16		$posts = $fluid->table('posts');
17
18		$column = $posts->column('foo');
19
20		$this->assertTrue($schema->getTable('posts')->hasColumn('foo'));
21
22		$this->assertSame($column, $posts->column('foo'), 'Failed asserting that the same instance is returned.');
23		}
24
25		public function testExistingColumn()
26		{
27		$schema = new Schema();
28		$postsSchemaTable = $schema->createTable('posts');
29		$postsSchemaTable->addColumn('foo', 'string');
30		$fluid = new TdbmFluidSchema($schema);
31
32		$posts = $fluid->table('posts');
33
34		$posts->column('foo')->integer();
35
36		$this->assertSame(Type::getType(Type::INTEGER), $schema->getTable('posts')->getColumn('foo')->getType());
37		}
38
39		public function testIndex()
40		{
41		$schema = new Schema();
42		$fluid = new TdbmFluidSchema($schema);
43
44		$posts = $fluid->table('posts');
45
46		$posts->column('foo')->integer()->then()->index(['foo']);
47
48		$this->assertCount(1, $schema->getTable('posts')->getIndexes());
		0 ignored issues – show Documentation introduced 2019-03-11 10:53 UTC by Report Bug Copy Issue Report `$schema->getTable('posts')->getIndexes()` is of type `array<integer,object<Doctrine\DBAL\Schema\Index>>`, but the function expects a `object<Countable>\|object...nit\Framework\iterable>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
49		}
50
51		public function testUnique()
52		{
53		$schema = new Schema();
54		$fluid = new TdbmFluidSchema($schema);
55
56		$posts = $fluid->table('posts');
57
58		$posts->column('foo')->integer()->then()->unique(['foo']);
59
60		$this->assertCount(1, $schema->getTable('posts')->getIndexes());
		0 ignored issues – show Documentation introduced 2019-03-11 10:53 UTC by Report Bug Copy Issue Report `$schema->getTable('posts')->getIndexes()` is of type `array<integer,object<Doctrine\DBAL\Schema\Index>>`, but the function expects a `object<Countable>\|object...nit\Framework\iterable>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
61		}
62
63	View Code Duplication	public function testPrimaryKey()
		0 ignored issues – show Duplication introduced 2019-03-11 10:53 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
64		{
65		$schema = new Schema();
66		$fluid = new TdbmFluidSchema($schema);
67
68		$posts = $fluid->table('posts');
69
70		$posts->column('id')->integer()->then()->primaryKey(['id'], 'pkname');
71
72		$this->assertTrue($schema->getTable('posts')->hasPrimaryKey());
73		$this->assertTrue($schema->getTable('posts')->hasIndex('pkname'));
74		}
75
76	View Code Duplication	public function testId()
		0 ignored issues – show Duplication introduced 2019-03-11 10:53 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
77		{
78		$schema = new Schema();
79		$fluid = new TdbmFluidSchema($schema);
80
81		$posts = $fluid->table('posts');
82
83		$posts->id();
84
85		$this->assertTrue($schema->getTable('posts')->hasPrimaryKey());
86		$this->assertTrue($schema->getTable('posts')->hasColumn('id'));
87		}
88
89	View Code Duplication	public function testUuid()
		0 ignored issues – show Duplication introduced 2019-03-11 10:53 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
90		{
91		$schema = new Schema();
92		$fluid = new TdbmFluidSchema($schema);
93
94		$posts = $fluid->table('posts');
95
96		$posts->uuid();
97
98		$this->assertTrue($schema->getTable('posts')->hasPrimaryKey());
99		$this->assertTrue($schema->getTable('posts')->hasColumn('uuid'));
100		$this->assertSame("\n@UUID(\"v4\")", $schema->getTable('posts')->getColumn('uuid')->getComment());
101		}
102
103		public function testUuidBadType()
104		{
105		$schema = new Schema();
106		$fluid = new TdbmFluidSchema($schema);
107
108		$posts = $fluid->table('posts');
109
110		$this->expectException(FluidSchemaException::class);
111		$posts->uuid('v2');
112		}
113
114	View Code Duplication	public function testCustomBeanName()
		0 ignored issues – show Duplication introduced 2019-03-11 10:53 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
115		{
116		$schema = new Schema();
117		$fluid = new TdbmFluidSchema($schema);
118
119		$posts = $fluid->table('posts');
120
121		$posts->customBeanName('Article');
122
123		$this->assertSame("\n@Bean(name = \"Article\")", $schema->getTable('posts')->getOptions()['comment']);
124		}
125
126	View Code Duplication	public function testImplementsInterface()
		0 ignored issues – show Duplication introduced 2019-03-26 10:01 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
127		{
128		$schema = new Schema();
129		$fluid = new TdbmFluidSchema($schema);
130
131		$posts = $fluid->table('posts');
132
133		$posts->implementsInterface('Foo\\Bar');
134		$posts->implementsInterface('Foo\\Bar2');
135
136		$this->assertSame("\n@AddInterface(name = \"Foo\\Bar\")\n@AddInterface(name = \"Foo\\Bar2\")", $schema->getTable('posts')->getOptions()['comment']);
137		}
138
139	View Code Duplication	public function testImplementsInterfaceOnDao()
		0 ignored issues – show Duplication introduced 2019-03-26 10:01 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
140		{
141		$schema = new Schema();
142		$fluid = new TdbmFluidSchema($schema);
143
144		$posts = $fluid->table('posts');
145
146		$posts->implementsInterfaceOnDao('Foo\\Bar');
147
148		$this->assertSame("\n@AddInterfaceOnDao(name = \"Foo\\Bar\")", $schema->getTable('posts')->getOptions()['comment']);
149		}
150
151	View Code Duplication	public function testUseTrait()
		0 ignored issues – show Duplication introduced 2019-03-26 16:18 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
152		{
153		$schema = new Schema();
154		$fluid = new TdbmFluidSchema($schema);
155
156		$posts = $fluid->table('posts');
157
158		$posts->useTrait('Foo\\Bar');
159		$posts->useTrait('Foo\\Bar2');
160
161		$this->assertSame("\n@AddTrait(name = \"Foo\\Bar\", modifiers = {})\n@AddTrait(name = \"Foo\\Bar2\", modifiers = {})", $schema->getTable('posts')->getOptions()['comment']);
162		}
163
164	View Code Duplication	public function testUseTraitOnDao()
		0 ignored issues – show Duplication introduced 2019-03-26 16:18 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
165		{
166		$schema = new Schema();
167		$fluid = new TdbmFluidSchema($schema);
168
169		$posts = $fluid->table('posts');
170
171		$posts->useTraitOnDao('Foo\\Bar');
172
173		$this->assertSame("\n@AddTraitOnDao(name = \"Foo\\Bar\", modifiers = {})", $schema->getTable('posts')->getOptions()['comment']);
174		}
175
176	View Code Duplication	public function testTimestamps()
		0 ignored issues – show Duplication introduced 2019-03-11 10:53 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
177		{
178		if (defined('Doctrine\\DBAL\\Types\\Type::DATE_IMMUTABLE')) {
179		$schema = new Schema();
180		$fluid = new TdbmFluidSchema($schema);
181
182		$posts = $fluid->table('posts');
183
184		$posts->timestamps();
185
186		$this->assertTrue($schema->getTable('posts')->hasColumn('created_at'));
187		$this->assertTrue($schema->getTable('posts')->hasColumn('updated_at'));
188		} else {
189		$this->markTestSkipped("Only available from Doctrine DBAL 2.6");
190		}
191		}
192
193	View Code Duplication	public function testInherits()
		0 ignored issues – show Duplication introduced 2019-03-11 10:53 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
194		{
195		$schema = new Schema();
196		$fluid = new TdbmFluidSchema($schema);
197
198		$contacts = $fluid->table('contacts');
199		$contacts->id();
200
201		$fluid->table('users')->extends('contacts');
202
203		$dbalColumn = $schema->getTable('users')->getColumn('id');
204
205		$this->assertSame(Type::getType(Type::INTEGER), $dbalColumn->getType());
206		$fks = $schema->getTable('users')->getForeignKeys();
207		$this->assertCount(1, $fks);
		0 ignored issues – show Documentation introduced 2019-03-11 10:53 UTC by Report Bug Copy Issue Report `$fks` is of type `array<integer,object<Doc...\ForeignKeyConstraint>>`, but the function expects a `object<Countable>\|object...nit\Framework\iterable>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
208		$fk = array_pop($fks);
209		$this->assertSame('users', $fk->getLocalTableName());
210		$this->assertSame('contacts', $fk->getForeignTableName());
211		$this->assertSame(['id'], $fk->getLocalColumns());
212		}
213
214		public function testGetDbalTable()
215		{
216		$schema = new Schema();
217		$fluid = new TdbmFluidSchema($schema);
218
219		$contacts = $fluid->table('contacts');
220		$this->assertSame('contacts', $contacts->getDbalTable()->getName());
221		}
222		}
223

thecodingmachine / tdbm-fluid-schema-builder

Pull Request — master (#15)

TdbmFluidTableTest::testUuid() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like