Complex classes like SwiftTwigMailTemplate often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use SwiftTwigMailTemplate, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 7 | class SwiftTwigMailTemplate implements SwiftMailTemplate |
||
| 8 | { |
||
| 9 | /** |
||
| 10 | * @var \Twig_Environment |
||
| 11 | */ |
||
| 12 | protected $twigEnvironment; |
||
| 13 | |||
| 14 | /** |
||
| 15 | * @var string |
||
| 16 | */ |
||
| 17 | protected $twigPath; |
||
| 18 | |||
| 19 | /** |
||
| 20 | * @var string|array |
||
| 21 | */ |
||
| 22 | protected $fromAddresses; |
||
| 23 | |||
| 24 | /** |
||
| 25 | * @var string |
||
| 26 | */ |
||
| 27 | protected $fromName = null; |
||
| 28 | |||
| 29 | /** |
||
| 30 | * @var string|array |
||
| 31 | */ |
||
| 32 | protected $toAddresses; |
||
| 33 | |||
| 34 | /** |
||
| 35 | * @var string |
||
| 36 | */ |
||
| 37 | protected $toName = null; |
||
| 38 | |||
| 39 | /** |
||
| 40 | * @var string|array |
||
| 41 | */ |
||
| 42 | protected $bccAddresses; |
||
| 43 | |||
| 44 | /** |
||
| 45 | * @var string |
||
| 46 | */ |
||
| 47 | protected $bccName = null; |
||
| 48 | |||
| 49 | /** |
||
| 50 | * @var string|array |
||
| 51 | */ |
||
| 52 | protected $ccAddresses; |
||
| 53 | |||
| 54 | /** |
||
| 55 | * @var string |
||
| 56 | */ |
||
| 57 | protected $ccName = null; |
||
| 58 | |||
| 59 | /** |
||
| 60 | * @var string|array |
||
| 61 | */ |
||
| 62 | protected $replyToAddresses; |
||
| 63 | |||
| 64 | /** |
||
| 65 | * @var string |
||
| 66 | */ |
||
| 67 | protected $replyToName = null; |
||
| 68 | |||
| 69 | /** |
||
| 70 | * @var int |
||
| 71 | */ |
||
| 72 | protected $maxLineLength = 1000; |
||
| 73 | |||
| 74 | /** |
||
| 75 | * @var int |
||
| 76 | */ |
||
| 77 | protected $priority; |
||
| 78 | |||
| 79 | /** |
||
| 80 | * @var string |
||
| 81 | */ |
||
| 82 | protected $readReceiptTo; |
||
| 83 | |||
| 84 | /** |
||
| 85 | * @var string |
||
| 86 | */ |
||
| 87 | protected $returnPath; |
||
| 88 | |||
| 89 | /** |
||
| 90 | * SwiftTwigMailGenerator constructor. |
||
| 91 | * |
||
| 92 | * @param \Twig_Environment $twig_Environment |
||
| 93 | * @param string $twigPath |
||
| 94 | */ |
||
| 95 | 4 | public function __construct(\Twig_Environment $twig_Environment, string $twigPath) |
|
| 100 | |||
| 101 | /** |
||
| 102 | * @param array $data |
||
| 103 | * |
||
| 104 | * @return \Swift_Message |
||
| 105 | */ |
||
| 106 | 4 | public function renderMail(array $data = []) :\Swift_Message |
|
| 167 | |||
| 168 | /** |
||
| 169 | * @param array|string $fromAddresses |
||
| 170 | */ |
||
| 171 | 1 | public function setFromAddresses($fromAddresses) |
|
| 175 | |||
| 176 | /** |
||
| 177 | * @param string $fromName |
||
| 178 | */ |
||
| 179 | 1 | public function setFromName($fromName) |
|
| 183 | |||
| 184 | /** |
||
| 185 | * @param array|string $toAddresses |
||
| 186 | */ |
||
| 187 | 1 | public function setToAddresses($toAddresses) |
|
| 191 | |||
| 192 | /** |
||
| 193 | * @param string $toName |
||
| 194 | */ |
||
| 195 | 1 | public function setToName($toName) |
|
| 199 | |||
| 200 | /** |
||
| 201 | * @param array|string $bccAddresses |
||
| 202 | */ |
||
| 203 | 1 | public function setBccAddresses($bccAddresses) |
|
| 207 | |||
| 208 | /** |
||
| 209 | * @param string $bccName |
||
| 210 | */ |
||
| 211 | 1 | public function setBccName($bccName) |
|
| 215 | |||
| 216 | /** |
||
| 217 | * @param array|string $ccAddresses |
||
| 218 | */ |
||
| 219 | 1 | public function setCcAddresses($ccAddresses) |
|
| 223 | |||
| 224 | /** |
||
| 225 | * @param string $ccName |
||
| 226 | */ |
||
| 227 | 1 | public function setCcName($ccName) |
|
| 231 | |||
| 232 | /** |
||
| 233 | * @param array|string $replyToAddresses |
||
| 234 | */ |
||
| 235 | 1 | public function setReplyToAddresses($replyToAddresses) |
|
| 239 | |||
| 240 | /** |
||
| 241 | * @param string $replyToName |
||
| 242 | */ |
||
| 243 | 1 | public function setReplyToName($replyToName) |
|
| 247 | |||
| 248 | /** |
||
| 249 | * @param int $maxLineLength |
||
| 250 | */ |
||
| 251 | 1 | public function setMaxLineLength($maxLineLength) |
|
| 255 | |||
| 256 | /** |
||
| 257 | * @param int $priority |
||
| 258 | */ |
||
| 259 | 1 | public function setPriority($priority) |
|
| 263 | |||
| 264 | /** |
||
| 265 | * @param string $readReceiptTo |
||
| 266 | */ |
||
| 267 | 1 | public function setReadReceiptTo($readReceiptTo) |
|
| 271 | |||
| 272 | /** |
||
| 273 | * @param string $returnPath |
||
| 274 | */ |
||
| 275 | 1 | public function setReturnPath($returnPath) |
|
| 279 | |||
| 280 | /** |
||
| 281 | * Removes the HTML tags from the text. |
||
| 282 | * |
||
| 283 | * @param string $s |
||
| 284 | * @param string $keep The list of tags to keep |
||
| 285 | * @param string $expand The list of tags to remove completely, along their content |
||
| 286 | */ |
||
| 287 | 1 | private function removeHtml(string $s, string $keep = '', string $expand = 'script|style|noframes|select|option') :string |
|
| 329 | |||
| 330 | /** |
||
| 331 | * @param string $s |
||
| 332 | * @param string $openTag |
||
| 333 | * @param string $closeTag |
||
| 334 | * |
||
| 335 | * @return mixed|string |
||
| 336 | */ |
||
| 337 | 1 | private function removeElement(string $s, string $openTag, string $closeTag) |
|
| 351 | |||
| 352 | /** |
||
| 353 | * @param string $s |
||
| 354 | * @param array $tagToKeep |
||
| 355 | * @param string $initial |
||
| 356 | * @param string $finalize |
||
| 357 | * |
||
| 358 | * @return string |
||
| 359 | */ |
||
| 360 | private function keepTag(string $s, array $tagToKeep, string $initial, string $finalize):string |
||
| 370 | } |
||
| 371 |
This check marks calls to methods that do not seem to exist on an object.
This is most likely the result of a method being renamed without all references to it being renamed likewise.