Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
8 | class SwiftTwigMailTemplate implements SwiftMailTemplate |
||
9 | { |
||
10 | /** |
||
11 | * @var \Twig_Environment |
||
12 | */ |
||
13 | protected $twigEnvironment; |
||
14 | |||
15 | /** |
||
16 | * @var string |
||
17 | */ |
||
18 | protected $twigPath; |
||
19 | |||
20 | /** |
||
21 | * @var string|array |
||
22 | */ |
||
23 | protected $fromAddresses; |
||
24 | |||
25 | /** |
||
26 | * @var string |
||
27 | */ |
||
28 | protected $fromName = null; |
||
29 | |||
30 | /** |
||
31 | * @var string|array |
||
32 | */ |
||
33 | protected $toAddresses; |
||
34 | |||
35 | /** |
||
36 | * @var string |
||
37 | */ |
||
38 | protected $toName = null; |
||
39 | |||
40 | /** |
||
41 | * @var string|array |
||
42 | */ |
||
43 | protected $bccAddresses; |
||
44 | |||
45 | /** |
||
46 | * @var string |
||
47 | */ |
||
48 | protected $bccName = null; |
||
49 | |||
50 | /** |
||
51 | * @var string|array |
||
52 | */ |
||
53 | protected $ccAddresses; |
||
54 | |||
55 | /** |
||
56 | * @var string |
||
57 | */ |
||
58 | protected $ccName = null; |
||
59 | |||
60 | /** |
||
61 | * @var string|array |
||
62 | */ |
||
63 | protected $replyToAddresses; |
||
64 | |||
65 | /** |
||
66 | * @var string |
||
67 | */ |
||
68 | protected $replyToName = null; |
||
69 | |||
70 | /** |
||
71 | * @var int |
||
72 | */ |
||
73 | protected $maxLineLength = 1000; |
||
74 | |||
75 | /** |
||
76 | * @var int |
||
77 | */ |
||
78 | protected $priority; |
||
79 | |||
80 | /** |
||
81 | * @var string |
||
82 | */ |
||
83 | protected $readReceiptTo; |
||
84 | |||
85 | /** |
||
86 | * @var string |
||
87 | */ |
||
88 | protected $returnPath; |
||
89 | |||
90 | /** |
||
91 | * SwiftTwigMailGenerator constructor. |
||
92 | * |
||
93 | * @param \Twig_Environment $twig_Environment |
||
94 | * @param string $twigPath |
||
95 | */ |
||
96 | public function __construct(\Twig_Environment $twig_Environment, string $twigPath) |
||
101 | |||
102 | /** |
||
103 | * @param array $data |
||
104 | * |
||
105 | * @return \Swift_Message |
||
106 | */ |
||
107 | public function renderMail(array $data = []) :\Swift_Message |
||
163 | |||
164 | /** |
||
165 | * @param array|string $fromAddresses |
||
166 | */ |
||
167 | public function setFromAddresses($fromAddresses) |
||
171 | |||
172 | /** |
||
173 | * @param string $fromName |
||
174 | */ |
||
175 | public function setFromName($fromName) |
||
179 | |||
180 | /** |
||
181 | * @param array|string $toAddresses |
||
182 | */ |
||
183 | public function setToAddresses($toAddresses) |
||
187 | |||
188 | /** |
||
189 | * @param string $toName |
||
190 | */ |
||
191 | public function setToName($toName) |
||
195 | |||
196 | /** |
||
197 | * @param array|string $bccAddresses |
||
198 | */ |
||
199 | public function setBccAddresses($bccAddresses) |
||
203 | |||
204 | /** |
||
205 | * @param string $bccName |
||
206 | */ |
||
207 | public function setBccName($bccName) |
||
211 | |||
212 | /** |
||
213 | * @param array|string $ccAddresses |
||
214 | */ |
||
215 | public function setCcAddresses($ccAddresses) |
||
219 | |||
220 | /** |
||
221 | * @param string $ccName |
||
222 | */ |
||
223 | public function setCcName($ccName) |
||
227 | |||
228 | /** |
||
229 | * @param array|string $replyToAddresses |
||
230 | */ |
||
231 | public function setReplyToAddresses($replyToAddresses) |
||
235 | |||
236 | /** |
||
237 | * @param string $replyToName |
||
238 | */ |
||
239 | public function setReplyToName($replyToName) |
||
243 | |||
244 | /** |
||
245 | * @param int $maxLineLength |
||
246 | */ |
||
247 | public function setMaxLineLength($maxLineLength) |
||
251 | |||
252 | /** |
||
253 | * @param int $priority |
||
254 | */ |
||
255 | public function setPriority($priority) |
||
259 | |||
260 | /** |
||
261 | * @param string $readReceiptTo |
||
262 | */ |
||
263 | public function setReadReceiptTo($readReceiptTo) |
||
267 | |||
268 | /** |
||
269 | * @param string $returnPath |
||
270 | */ |
||
271 | public function setReturnPath($returnPath) |
||
275 | |||
276 | /** |
||
277 | * Removes the HTML tags from the text. |
||
278 | * |
||
279 | * @param string $s |
||
280 | * @param string $keep The list of tags to keep |
||
281 | * @param string $expand The list of tags to remove completely, along their content |
||
282 | */ |
||
283 | private function removeHtml(string $s , string $keep = '' , string $expand = 'script|style|noframes|select|option') :string |
||
343 | } |
||
344 |
This check marks calls to methods that do not seem to exist on an object.
This is most likely the result of a method being renamed without all references to it being renamed likewise.