CommonAliasesServiceProvider::getFactories() - Code Metrics - thecodingmachine/service-provider-bridge-bundle - Measure and Improve Code Quality continuously with Scrutinizer

CommonAliasesServiceProvider::getFactories() A
last analyzed 2020-04-14 06:42 UTC

↳ Parent: CommonAliasesServiceProvider

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
nc	1
nop	0
dl	0
loc	8
rs	10
c	0
b	0
f	0

<?php


namespace TheCodingMachine\Interop\ServiceProviderBridgeBundle;

use Interop\Container\Factories\Alias;
use Interop\Container\ServiceProviderInterface;
use Psr\Cache\CacheItemPoolInterface;
use Psr\Log\LoggerInterface;
use Twig_Environment;

/**
 * Provides common aliases for Symfony services.
 * For instance : logger => Psr\Logger\LoggerInterface
 */
class CommonAliasesServiceProvider implements ServiceProviderInterface
{
    public function getFactories()
    {
        return [
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
            LoggerInterface::class => new Alias('logger'),
            CacheItemPoolInterface::class => new Alias('cache.app'),
            Twig_Environment::class => new Alias('twig')
        ];
    }

    public function getExtensions()
    {
        return [];
    }
}


1			<?php
2
3
4			namespace TheCodingMachine\Interop\ServiceProviderBridgeBundle;
5
6			use Interop\Container\Factories\Alias;
7			use Interop\Container\ServiceProviderInterface;
8			use Psr\Cache\CacheItemPoolInterface;
9			use Psr\Log\LoggerInterface;
10			use Twig_Environment;
11
12			/**
13			* Provides common aliases for Symfony services.
14			* For instance : logger => Psr\Logger\LoggerInterface
15			*/
16			class CommonAliasesServiceProvider implements ServiceProviderInterface
17			{
18			public function getFactories()
19			{
20			return [
			0 ignored issues – show Bug Best Practice introduced 2017-09-21 09:24 UTC by Report Bug Copy Issue Report The return type of `return array(\Psr\Log\Lo...ctories\Alias('twig'));` (`array<,Interop\Container\Factories\Alias>`) is incompatible with the return type declared by the interface `Interop\Container\Servic...Interface::getFactories` of type `callable[]`. If you return a value from a function or method, it should be a sub-type of the type that is given by the parent type f.e. an interface, or abstract method. This is more formally defined by the Lizkov substitution principle, and guarantees that classes that depend on the parent type can use any instance of a child type interchangably. This principle also belongs to the SOLID principles for object oriented design. Let’s take a look at an example: class Author { private $name; public function __construct($name) { $this->name = $name; } public function getName() { return $this->name; } } abstract class Post { public function getAuthor() { return 'Johannes'; } } class BlogPost extends Post { public function getAuthor() { return new Author('Johannes'); } } class ForumPost extends Post { / ... */ } function my_function(Post $post) { echo strtoupper($post->getAuthor()); } Our function `my_function` expects a `Post` object, and outputs the author of the post. The base class `Post` returns a simple string and outputting a simple string will work just fine. However, the child class `BlogPost` which is a sub-type of `Post` instead decided to return an `object`, and is therefore violating the SOLID principles. If a `BlogPost` were passed to `my_function`, PHP would not complain, but ultimately fail when executing the `strtoupper` call in its body. Loading history...
21			LoggerInterface::class => new Alias('logger'),
22			CacheItemPoolInterface::class => new Alias('cache.app'),
23			Twig_Environment::class => new Alias('twig')
24			];
25			}
26
27			public function getExtensions()
28			{
29			return [];
30			}
31			}
32

thecodingmachine / service-provider-bridge-bundle

CommonAliasesServiceProvider::getFactories() A last analyzed 2020-04-14 06:42 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

CommonAliasesServiceProvider::getFactories() A
last analyzed 2020-04-14 06:42 UTC