ForgotYourPasswordController - Code Metrics - Inspection of "Fixing installer and working on doc" - thecodingmachine/security.forgot-your-password - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — 1.0 ( 4b07bc...bb4e0d )

by David

created 2016-07-26 11:54 UTC

ForgotYourPasswordController A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	327
Duplicated Lines	7.03 %

Coupling/Cohesion

Components	1
Dependencies	12

Importance

Changes	3
Bugs	0	Features	0

Metric	Value
dl	23
loc	327
c	3
b	0
f	0
wmc	28
lcom	1
cbo	12
rs	10

14 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	10	1
A	setNoLeak()	0	4	1
A	setContinueUrl()	0	4	1
A	index()	0	4	1
A	displayMainForm()	0	16	3
A	jsonNotFoundResponse()	0	6	1
B	submit()	0	24	5
A	isJson()	0	4	1
A	jsonSentResponse()	0	7	1
A	displayMailSentScreen()	0	6	1
A	displayResetAccessPage()	0	14	2
C	resetAccess()	23	51	8
A	confirmResetAccess()	0	11	1
A	jsonTokenNotFoundResponse()	0	6	1

How to fix Duplicated Code

<?php

namespace Mouf\Security\Password;

use Mouf\Html\HtmlElement\HtmlBlock;
use Mouf\Html\Template\TemplateInterface;
use Mouf\Mvc\Splash\Annotations\Get;
use Mouf\Mvc\Splash\Annotations\Post;
use Mouf\Mvc\Splash\Annotations\URL;
use Mouf\Mvc\Splash\HtmlResponse;
use Mouf\Security\Password\Api\ForgotYourPasswordDao;
use Mouf\Security\Password\Api\PasswordStrengthCheck;
.
|-- OtherDir
|   |-- Bar.php
|   `-- Foo.php
`-- SomeDir
    `-- Foo.php
use Mouf\Security\UserService\UserService;
use Psr\Http\Message\ResponseInterface;
use Psr\Http\Message\ServerRequestInterface;
use Psr\Log\LoggerInterface;
use Twig_Environment;
use Mouf\Security\Password\Api\EmailNotFoundException;
use Zend\Diactoros\Response\JsonResponse;
use Zend\Diactoros\Response\RedirectResponse;

class ForgotYourPasswordController
{
    private $baseUrl = 'forgot';

    /**
     * The logger used by this controller.
     *
     * @var LoggerInterface
     */
    private $logger;

    /**
     * The template used by this controller.
     *
     * @var TemplateInterface
     */
    private $template;

    /**
     * The main content block of the page.
     *
     * @var HtmlBlock
     */
    private $content;

    /**
     * The Twig environment (used to render Twig templates).
     *
     * @var Twig_Environment
     */
    private $twig;

    /**
     * The service that will actually check the tokens.
     *
     * @var ForgotYourPasswordDao
     */
    private $forgotYourPasswordService;

    /**
     * The userservice to log people when a token is found.
     *
     * @var UserService
     */
    private $userService;

    /**
     * Enable this option if you want the "forgot your password screen" to NOT show the "email not found message" and always show the "an email has been sent" message.
     * This improves security because an attacker typing an email address of someone else cannot not if this user is registered or not in the application.
     *
     * At the same time, it decreases usability.
     *
     * @var bool
     */
    private $noLeak = false;

    /**
     * @var PasswordStrengthCheck
     */
    private $passwordStrengthCheck;

    /**
     * The URL to continue to when password has been changed.
     * Relative to the root path of the application.
     * Defaults to '/'.
     *
     * @var string
     */
    private $continueUrl = '/';

    /**
     * Controller's constructor.
     *
     * @param LoggerInterface   $logger   The logger
     * @param TemplateInterface $template The template used by this controller
     * @param HtmlBlock         $content  The main content block of the page
     * @param Twig_Environment  $twig     The Twig environment (used to render Twig templates)
     */
    public function __construct(LoggerInterface $logger, TemplateInterface $template, HtmlBlock $content, Twig_Environment $twig, ForgotYourPasswordService $forgotYourPasswordService, UserService $userService, PasswordStrengthCheck $passwordStrengthCheck)
    {
        $this->logger = $logger;
        $this->template = $template;
        $this->content = $content;
        $this->twig = $twig;
        $this->forgotYourPasswordService = $forgotYourPasswordService;

        $this->userService = $userService;
        $this->passwordStrengthCheck = $passwordStrengthCheck;
    }

    /**
     * Enable this option if you want the "forgot your password screen" to NOT show the "email not found message" and always show the "an email has been sent" message.
     * This improves security because an attacker typing an email address of someone else cannot not if this user is registered or not in the application.
     *
     * At the same time, it decreases usability.
     *
     * @param bool $noLeak
     */
    public function setNoLeak(bool $noLeak)
    {
        $this->noLeak = $noLeak;
    }

    /**
     * The URL to continue to when password has been changed.
     * Relative to the root path of the application.
     * Defaults to '/'.
     *
     * @param string $continueUrl
     */
    public function setContinueUrl(string $continueUrl)
    {
        $this->continueUrl = $continueUrl;
    }

    /**
     * Displays the screen to enter the email.
     *
     * @URL("{$this->baseUrl}/password")
     * @Get
     *
     * @param string|null $email
     *
     * @return ResponseInterface
     */
    public function index(string $email = null) : ResponseInterface
    {
        return $this->displayMainForm($email);
    }

    private function displayMainForm(string $email = null, bool $notFoundMessage = false) : ResponseInterface
    {
        $view = new ForgotYourPasswordView();
        if ($email) {
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
            $view->setEmail($email);
        }

        $view->setDisplayEmailNotFound($notFoundMessage);

        $code = $notFoundMessage ? 404 : 200;

        // Let's add the twig file to the template.
        $this->content->addHtmlElement($view, $code);


        return new HtmlResponse($this->template);
    }

    private function jsonNotFoundResponse() : ResponseInterface
    {
        return new JsonResponse([
            'error' => 'Email not found',
        ], 404);
    }

    /**
     * Displays the screen to enter the email.
     *
     * @URL("{$this->baseUrl}/password")
     * @Post
     *
     * @param string $email
     *
     * @return ResponseInterface
     */
    public function submit(string $email, ServerRequestInterface $request) : ResponseInterface
    {
        try {
            // Let's get the URL of the reset password
            $currentUrl = $request->getUri()->getPath();
            $url = substr($currentUrl, 0, strrpos($currentUrl, '/password')).'/reset';

            $this->forgotYourPasswordService->sendMail($email, $request->getUri()->withPath($url)->withQuery(''));

        } catch (EmailNotFoundException $exception) {
            if (!$this->noLeak) {
                if ($this->isJson($request)) {
                    return $this->jsonNotFoundResponse();
                } else {
                    return $this->displayMainForm($email, true);
                }
            }
        }

        if ($this->isJson($request)) {
            return $this->jsonSentResponse();
        } else {
            return new RedirectResponse(ROOT_URL.$this->baseUrl.'/mail_sent?email='.urlencode($email));
        }
    }

    private function isJson(ServerRequestInterface $request) : bool
    {
        return strpos($request->getHeaderLine('Accept'), 'json') !== false;
    }

    private function jsonSentResponse() : ResponseInterface
    {
        return new JsonResponse([
            'status' => 'ok',
            'message' => 'An email was sent to your mailbox.',
        ]);
    }

    /**
     * @URL("{$this->baseUrl}/mail_sent")
     * @Get()
     *
     * @param string $email
     *
     * @return ResponseInterface
     */
    public function displayMailSentScreen(string $email) : ResponseInterface
    {
        $this->content->addHtmlElement(new EmailSentView($email));

        return new HtmlResponse($this->template);
    }

    /**
     * @URL("{$this->baseUrl}/reset")
     * @Get()
     *
     * @param string $token
     *
     * @return ResponseInterface
     */
    public function displayResetAccessPage(string $token) : ResponseInterface
    {
        $isValid = $this->forgotYourPasswordService->checkToken($token);


        if (!$isValid) {
            $this->content->addHtmlElement(new TokenNotFoundView($token));

            return new HtmlResponse($this->template, 404);
        } else {
            $this->content->addHtmlElement(new ResetPasswordView($token, $this->passwordStrengthCheck->getPasswordRules()));

            return new HtmlResponse($this->template);
        }
    }

    /**
     * @URL("{$this->baseUrl}/reset")
     * @Post()
     *
     * @param string                 $token
     * @param ServerRequestInterface $request
     *
     * @return ResponseInterface
     */
    public function resetAccess(string $token, string $password, string $confirmpassword, ServerRequestInterface $request) : ResponseInterface
    {
        $isValidToken = $this->forgotYourPasswordService->checkToken($token);


        if (!$isValidToken) {
            if ($this->isJson($request)) {
                return $this->jsonTokenNotFoundResponse();
            } else {
                $this->content->addHtmlElement(new TokenNotFoundView($token));

                return new HtmlResponse($this->template, 404);
            }
        }

        if ($password !== $confirmpassword) {

            if ($this->isJson($request)) {
                return new JsonResponse([
                    'error' => 'Mismatching passwords',
                ], 400);
            } else {
                $view = new ResetPasswordView($token, $this->passwordStrengthCheck->getPasswordRules());
                $this->content->addHtmlElement($view->withDisplayMismatchPassword());

                return new HtmlResponse($this->template, 400);
            }
        }

        if ($this->passwordStrengthCheck->checkPasswordStrength($password) === false) {
            if ($this->isJson($request)) {

                return new JsonResponse([
                    'error' => 'Password strength too weak',
                    'rules' => $this->passwordStrengthCheck->getPasswordRules(),
                ], 400);
            } else {
                $view = new ResetPasswordView($token, $this->passwordStrengthCheck->getPasswordRules());
                $this->content->addHtmlElement($view->withDisplayPoorPassword());

                return new HtmlResponse($this->template, 400);
            }
        }

        $this->forgotYourPasswordService->useToken($token, $password);


        if ($this->isJson($request)) {
            return new JsonResponse([
                'status' => 'ok',
            ], 200);
        } else {
            return new RedirectResponse('reset_confirm');
        }
    }

    /**
     * @URL("{$this->baseUrl}/reset_confirm")
     * @Get()
     *
     * @param ServerRequestInterface $request
     *
     * @return ResponseInterface
     */
    public function confirmResetAccess(ServerRequestInterface $request) : ResponseInterface
    {
        $path = $request->getUri()->getPath();
        $path = substr($path, 0, strrpos($path, $this->baseUrl.'/reset'));
        $path .= ltrim($this->continueUrl, '/');

        $view = new ConfirmResetPasswordView($path);
        $this->content->addHtmlElement($view);

        return new HtmlResponse($this->template);
    }

    protected function jsonTokenNotFoundResponse() : ResponseInterface
    {
        return new JsonResponse([
            'error' => 'Token not found',
        ], 404);
    }
}


1		<?php
2
3		namespace Mouf\Security\Password;
4
5		use Mouf\Html\HtmlElement\HtmlBlock;
6		use Mouf\Html\Template\TemplateInterface;
7		use Mouf\Mvc\Splash\Annotations\Get;
8		use Mouf\Mvc\Splash\Annotations\Post;
9		use Mouf\Mvc\Splash\Annotations\URL;
10		use Mouf\Mvc\Splash\HtmlResponse;
11		use Mouf\Security\Password\Api\ForgotYourPasswordDao;
12		use Mouf\Security\Password\Api\PasswordStrengthCheck;
		0 ignored issues – show Bug introduced 2016-07-26 12:00 UTC by Report Bug Copy Issue Report This use statement conflicts with another class in this namespace, `Mouf\Security\Password\PasswordStrengthCheck`. Let’s assume that you have a directory layout like this: . \|-- OtherDir \| \|-- Bar.php \| `-- Foo.php `-- SomeDir `-- Foo.php and let’s assume the following content of `Bar.php`: // Bar.php namespace OtherDir; use SomeDir\Foo; // This now conflicts the class OtherDir\Foo If both files `OtherDir/Foo.php` and `SomeDir/Foo.php` are loaded in the same runtime, you will see a PHP error such as the following: PHP Fatal error: Cannot use SomeDir\Foo as Foo because the name is already in use in OtherDir/Foo.php However, as `OtherDir/Foo.php` does not necessarily have to be loaded and the error is only triggered if it is loaded before `OtherDir/Bar.php`, this problem might go unnoticed for a while. In order to prevent this error from surfacing, you must import the namespace with a different alias: // Bar.php namespace OtherDir; use SomeDir\Foo as SomeDirFoo; // There is no conflict anymore. Loading history...
13		use Mouf\Security\UserService\UserService;
14		use Psr\Http\Message\ResponseInterface;
15		use Psr\Http\Message\ServerRequestInterface;
16		use Psr\Log\LoggerInterface;
17		use Twig_Environment;
18		use Mouf\Security\Password\Api\EmailNotFoundException;
19		use Zend\Diactoros\Response\JsonResponse;
20		use Zend\Diactoros\Response\RedirectResponse;
21
22		class ForgotYourPasswordController
23		{
24		private $baseUrl = 'forgot';
25
26		/**
27		* The logger used by this controller.
28		*
29		* @var LoggerInterface
30		*/
31		private $logger;
32
33		/**
34		* The template used by this controller.
35		*
36		* @var TemplateInterface
37		*/
38		private $template;
39
40		/**
41		* The main content block of the page.
42		*
43		* @var HtmlBlock
44		*/
45		private $content;
46
47		/**
48		* The Twig environment (used to render Twig templates).
49		*
50		* @var Twig_Environment
51		*/
52		private $twig;
53
54		/**
55		* The service that will actually check the tokens.
56		*
57		* @var ForgotYourPasswordDao
58		*/
59		private $forgotYourPasswordService;
60
61		/**
62		* The userservice to log people when a token is found.
63		*
64		* @var UserService
65		*/
66		private $userService;
67
68		/**
69		* Enable this option if you want the "forgot your password screen" to NOT show the "email not found message" and always show the "an email has been sent" message.
70		* This improves security because an attacker typing an email address of someone else cannot not if this user is registered or not in the application.
71		*
72		* At the same time, it decreases usability.
73		*
74		* @var bool
75		*/
76		private $noLeak = false;
77
78		/**
79		* @var PasswordStrengthCheck
80		*/
81		private $passwordStrengthCheck;
82
83		/**
84		* The URL to continue to when password has been changed.
85		* Relative to the root path of the application.
86		* Defaults to '/'.
87		*
88		* @var string
89		*/
90		private $continueUrl = '/';
91
92		/**
93		* Controller's constructor.
94		*
95		* @param LoggerInterface $logger The logger
96		* @param TemplateInterface $template The template used by this controller
97		* @param HtmlBlock $content The main content block of the page
98		* @param Twig_Environment $twig The Twig environment (used to render Twig templates)
99		*/
100		public function __construct(LoggerInterface $logger, TemplateInterface $template, HtmlBlock $content, Twig_Environment $twig, ForgotYourPasswordService $forgotYourPasswordService, UserService $userService, PasswordStrengthCheck $passwordStrengthCheck)
101		{
102		$this->logger = $logger;
103		$this->template = $template;
104		$this->content = $content;
105		$this->twig = $twig;
106		$this->forgotYourPasswordService = $forgotYourPasswordService;
		0 ignored issues – show Documentation Bug introduced 2016-07-26 12:00 UTC by Report Bug Copy Issue Report It seems like `$forgotYourPasswordService` of type `object<Mouf\Security\Pas...gotYourPasswordService>` is incompatible with the declared type `object<Mouf\Security\Pas...\ForgotYourPasswordDao>` of property `$forgotYourPasswordService`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
107		$this->userService = $userService;
108		$this->passwordStrengthCheck = $passwordStrengthCheck;
109		}
110
111		/**
112		* Enable this option if you want the "forgot your password screen" to NOT show the "email not found message" and always show the "an email has been sent" message.
113		* This improves security because an attacker typing an email address of someone else cannot not if this user is registered or not in the application.
114		*
115		* At the same time, it decreases usability.
116		*
117		* @param bool $noLeak
118		*/
119		public function setNoLeak(bool $noLeak)
120		{
121		$this->noLeak = $noLeak;
122		}
123
124		/**
125		* The URL to continue to when password has been changed.
126		* Relative to the root path of the application.
127		* Defaults to '/'.
128		*
129		* @param string $continueUrl
130		*/
131		public function setContinueUrl(string $continueUrl)
132		{
133		$this->continueUrl = $continueUrl;
134		}
135
136		/**
137		* Displays the screen to enter the email.
138		*
139		* @URL("{$this->baseUrl}/password")
140		* @Get
141		*
142		* @param string\|null $email
143		*
144		* @return ResponseInterface
145		*/
146		public function index(string $email = null) : ResponseInterface
147		{
148		return $this->displayMainForm($email);
149		}
150
151		private function displayMainForm(string $email = null, bool $notFoundMessage = false) : ResponseInterface
152		{
153		$view = new ForgotYourPasswordView();
154		if ($email) {
		0 ignored issues – show Bug Best Practice introduced 2016-07-26 12:00 UTC by Report Bug Copy Issue Report The expression `$email` of type `null\|string` is loosely compared to `true`; this is ambiguous if the string can be empty. You might want to explicitly use `!== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history...
155		$view->setEmail($email);
156		}
157
158		$view->setDisplayEmailNotFound($notFoundMessage);
159
160		$code = $notFoundMessage ? 404 : 200;
161
162		// Let's add the twig file to the template.
163		$this->content->addHtmlElement($view, $code);
		0 ignored issues – show Unused Code introduced 2016-07-26 12:00 UTC by Report Bug Copy Issue Report The call to `HtmlBlock::addHtmlElement()` has too many arguments starting with `$code`. This check compares calls to functions or methods with their respective definitions. If the call has more arguments than are defined, it raises an issue. If a function is defined several times with a different number of parameters, the check may pick up the wrong definition and report false positives. One codebase where this has been known to happen is Wordpress. In this case you can add the `@ignore` PhpDoc annotation to the duplicate definition and it will be ignored. Loading history...
164
165		return new HtmlResponse($this->template);
166		}
167
168		private function jsonNotFoundResponse() : ResponseInterface
169		{
170		return new JsonResponse([
171		'error' => 'Email not found',
172		], 404);
173		}
174
175		/**
176		* Displays the screen to enter the email.
177		*
178		* @URL("{$this->baseUrl}/password")
179		* @Post
180		*
181		* @param string $email
182		*
183		* @return ResponseInterface
184		*/
185		public function submit(string $email, ServerRequestInterface $request) : ResponseInterface
186		{
187		try {
188		// Let's get the URL of the reset password
189		$currentUrl = $request->getUri()->getPath();
190		$url = substr($currentUrl, 0, strrpos($currentUrl, '/password')).'/reset';
191
192		$this->forgotYourPasswordService->sendMail($email, $request->getUri()->withPath($url)->withQuery(''));
		0 ignored issues – show Bug introduced 2016-07-26 12:00 UTC by Report Bug Copy Issue Report The method `sendMail()` does not seem to exist on `object<Mouf\Security\Pas...\ForgotYourPasswordDao>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
193		} catch (EmailNotFoundException $exception) {
194		if (!$this->noLeak) {
195		if ($this->isJson($request)) {
196		return $this->jsonNotFoundResponse();
197		} else {
198		return $this->displayMainForm($email, true);
199		}
200		}
201		}
202
203		if ($this->isJson($request)) {
204		return $this->jsonSentResponse();
205		} else {
206		return new RedirectResponse(ROOT_URL.$this->baseUrl.'/mail_sent?email='.urlencode($email));
207		}
208		}
209
210		private function isJson(ServerRequestInterface $request) : bool
211		{
212		return strpos($request->getHeaderLine('Accept'), 'json') !== false;
213		}
214
215		private function jsonSentResponse() : ResponseInterface
216		{
217		return new JsonResponse([
218		'status' => 'ok',
219		'message' => 'An email was sent to your mailbox.',
220		]);
221		}
222
223		/**
224		* @URL("{$this->baseUrl}/mail_sent")
225		* @Get()
226		*
227		* @param string $email
228		*
229		* @return ResponseInterface
230		*/
231		public function displayMailSentScreen(string $email) : ResponseInterface
232		{
233		$this->content->addHtmlElement(new EmailSentView($email));
234
235		return new HtmlResponse($this->template);
236		}
237
238		/**
239		* @URL("{$this->baseUrl}/reset")
240		* @Get()
241		*
242		* @param string $token
243		*
244		* @return ResponseInterface
245		*/
246		public function displayResetAccessPage(string $token) : ResponseInterface
247		{
248		$isValid = $this->forgotYourPasswordService->checkToken($token);
		0 ignored issues – show Bug introduced 2016-07-26 12:00 UTC by Report Bug Copy Issue Report The method `checkToken()` does not seem to exist on `object<Mouf\Security\Pas...\ForgotYourPasswordDao>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
249
250		if (!$isValid) {
251		$this->content->addHtmlElement(new TokenNotFoundView($token));
252
253		return new HtmlResponse($this->template, 404);
254		} else {
255		$this->content->addHtmlElement(new ResetPasswordView($token, $this->passwordStrengthCheck->getPasswordRules()));
256
257		return new HtmlResponse($this->template);
258		}
259		}
260
261		/**
262		* @URL("{$this->baseUrl}/reset")
263		* @Post()
264		*
265		* @param string $token
266		* @param ServerRequestInterface $request
267		*
268		* @return ResponseInterface
269		*/
270		public function resetAccess(string $token, string $password, string $confirmpassword, ServerRequestInterface $request) : ResponseInterface
271		{
272		$isValidToken = $this->forgotYourPasswordService->checkToken($token);
		0 ignored issues – show Bug introduced 2016-07-26 12:00 UTC by Report Bug Copy Issue Report The method `checkToken()` does not seem to exist on `object<Mouf\Security\Pas...\ForgotYourPasswordDao>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
273
274		if (!$isValidToken) {
275		if ($this->isJson($request)) {
276		return $this->jsonTokenNotFoundResponse();
277		} else {
278		$this->content->addHtmlElement(new TokenNotFoundView($token));
279
280		return new HtmlResponse($this->template, 404);
281		}
282		}
283
284	View Code Duplication	if ($password !== $confirmpassword) {
		0 ignored issues – show Duplication introduced 2016-07-26 12:00 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
285		if ($this->isJson($request)) {
286		return new JsonResponse([
287		'error' => 'Mismatching passwords',
288		], 400);
289		} else {
290		$view = new ResetPasswordView($token, $this->passwordStrengthCheck->getPasswordRules());
291		$this->content->addHtmlElement($view->withDisplayMismatchPassword());
292
293		return new HtmlResponse($this->template, 400);
294		}
295		}
296
297		if ($this->passwordStrengthCheck->checkPasswordStrength($password) === false) {
298	View Code Duplication	if ($this->isJson($request)) {
		0 ignored issues – show Duplication introduced 2016-07-26 12:00 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
299		return new JsonResponse([
300		'error' => 'Password strength too weak',
301		'rules' => $this->passwordStrengthCheck->getPasswordRules(),
302		], 400);
303		} else {
304		$view = new ResetPasswordView($token, $this->passwordStrengthCheck->getPasswordRules());
305		$this->content->addHtmlElement($view->withDisplayPoorPassword());
306
307		return new HtmlResponse($this->template, 400);
308		}
309		}
310
311		$this->forgotYourPasswordService->useToken($token, $password);
		0 ignored issues – show Bug introduced 2016-07-26 12:00 UTC by Report Bug Copy Issue Report The method `useToken()` does not seem to exist on `object<Mouf\Security\Pas...\ForgotYourPasswordDao>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
312
313		if ($this->isJson($request)) {
314		return new JsonResponse([
315		'status' => 'ok',
316		], 200);
317		} else {
318		return new RedirectResponse('reset_confirm');
319		}
320		}
321
322		/**
323		* @URL("{$this->baseUrl}/reset_confirm")
324		* @Get()
325		*
326		* @param ServerRequestInterface $request
327		*
328		* @return ResponseInterface
329		*/
330		public function confirmResetAccess(ServerRequestInterface $request) : ResponseInterface
331		{
332		$path = $request->getUri()->getPath();
333		$path = substr($path, 0, strrpos($path, $this->baseUrl.'/reset'));
334		$path .= ltrim($this->continueUrl, '/');
335
336		$view = new ConfirmResetPasswordView($path);
337		$this->content->addHtmlElement($view);
338
339		return new HtmlResponse($this->template);
340		}
341
342		protected function jsonTokenNotFoundResponse() : ResponseInterface
343		{
344		return new JsonResponse([
345		'error' => 'Token not found',
346		], 404);
347		}
348		}
349

thecodingmachine / security.forgot-your-password

Push — 1.0 ( 4b07bc...bb4e0d )

ForgotYourPasswordController A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

14 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like