Issues in SecurityRoleDao.php (1.0) - Issues in 1.0 - thecodingmachine/security.daos.tdbm - Measure and Improve Code Quality continuously with Scrutinizer

Issues (7)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/DAO/SecurityRoleDao.php (2 issues)

Labels

Severity

Major 2

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

/*
 * This file has been automatically generated by TDBM.
 * DO NOT edit this file, as it might be overwritten.
 * If you need to perform changes, edit the UserDao class instead!
 */

namespace Mouf\Security\DAO;

use Kls\Model\Bean\RolesRightBean;
use Mouf\Database\TDBM\TDBMService;
use Mouf\Database\TDBM\ResultIterator;
use Mouf\Security\Model\Role;
use Mouf\Security\Rights\RightsRegistry;
use Mouf\Security\RightsService\RightInterface;
use Mouf\Security\RightsService\RightsDaoInterface;
use Mouf\Security\UserManagement\Api\RoleDao;
use Mouf\Security\UserManagement\Api\RoleInterface;
use Mouf\Security\UserService\UserDaoInterface;
use Mouf\Security\UserService\UserInterface;

/**
 * This class provides a TDBM implementation of the RoleDao interface.
 */
class SecurityRoleDao implements RoleDao
{
    /**
     * @var TDBMService
     */
    protected $tdbmService;

    /**
     * @param TDBMService    $tdbmService    Sets the TDBM service used by this DAO.
     */
    public function __construct(TDBMService $tdbmService)
    {
        $this->tdbmService = $tdbmService;
    }


    /**
     * Returns the list of all roles known by the application.
     *
     * @return RoleInterface[]
     */
    public function getAllRoles()
    {
        return $this->find();
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
    }

    /**
     * @param UserInterface $user
     * @param RoleInterface[] $roles
     * @return void
     */
    public function setRoles(UserInterface $user, array $roles)
    {
        $user = $this->tdbmService->findObjectByPk('users', [
            'id' => $user->getId()
        ]);
        // FIXME: throw exception is $user is null

        $roleBeans = [];

        foreach ($roles as $role) {
            $roleBeans[] = $this->findRoleById($role->getId());
        }

        $user->setRoles($roleBeans);
        $this->tdbmService->save($user);
    }

    /**
     * @param UserInterface $user
     * @return RoleInterface[]
     */
    public function getRoles(UserInterface $user)
    {
        if ($user->getId() === null) {
            return [];
        }
        return $this->find([
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
            'users_roles.user_id' => $user->getId()
        ]);
    }

    /**
     * Get a list of RolesBean specified by its filters.
     *
     * @param mixed $filter                The filter bag (see TDBMService::findObjects for complete description)
     * @param array $parameters            The parameters associated with the filter
     * @param mixed $orderBy               The order string
     * @param array $additionalTablesFetch A list of additional tables to fetch (for performance improvement)
     * @param int   $mode                  Either TDBMService::MODE_ARRAY or TDBMService::MODE_CURSOR (for large datasets). Defaults to TDBMService::MODE_ARRAY.
     *
     * @return RolesRightBean[]|ResultIterator|ResultArray
     */
    private function find($filter = null, array $parameters = [], $orderBy = null, array $additionalTablesFetch = [], $mode = null)
    {
        return $this->tdbmService->findObjects('roles', $filter, $parameters, $orderBy, $additionalTablesFetch, $mode);
    }

    private function findRoleById($roleId) {
        return $this->tdbmService->findObjectByPk('roles', [
            'id' => $roleId
        ]);
    }

    /**
     * Fetches a role by ID.
     *
     * @param $roleId
     * @return RoleInterface
     */
    public function getRoleById($roleId) : RoleInterface
    {
        return self::castToRole($this->findRoleById($roleId));
    }

    public static function castToRole($roleBean) : RoleInterface
    {
        return new Role($roleBean->getId(), $roleBean->getLabel());
    }
}


1			<?php
2
3			/*
4			* This file has been automatically generated by TDBM.
5			* DO NOT edit this file, as it might be overwritten.
6			* If you need to perform changes, edit the UserDao class instead!
7			*/
8
9			namespace Mouf\Security\DAO;
10
11			use Kls\Model\Bean\RolesRightBean;
12			use Mouf\Database\TDBM\TDBMService;
13			use Mouf\Database\TDBM\ResultIterator;
14			use Mouf\Security\Model\Role;
15			use Mouf\Security\Rights\RightsRegistry;
16			use Mouf\Security\RightsService\RightInterface;
17			use Mouf\Security\RightsService\RightsDaoInterface;
18			use Mouf\Security\UserManagement\Api\RoleDao;
19			use Mouf\Security\UserManagement\Api\RoleInterface;
20			use Mouf\Security\UserService\UserDaoInterface;
21			use Mouf\Security\UserService\UserInterface;
22
23			/**
24			* This class provides a TDBM implementation of the RoleDao interface.
25			*/
26			class SecurityRoleDao implements RoleDao
27			{
28			/**
29			* @var TDBMService
30			*/
31			protected $tdbmService;
32
33			/**
34			* @param TDBMService $tdbmService Sets the TDBM service used by this DAO.
35			*/
36			public function __construct(TDBMService $tdbmService)
37			{
38			$this->tdbmService = $tdbmService;
39			}
40
41
42			/**
43			* Returns the list of all roles known by the application.
44			*
45			* @return RoleInterface[]
46			*/
47			public function getAllRoles()
48			{
49			return $this->find();
			0 ignored issues – show Bug Best Practice introduced 2016-08-09 16:46 UTC by Report Bug Copy Issue Report Show Similar Issues like this The return type of `return $this->find();` (`Kls\Model\Bean\RolesRigh...ecurity\DAO\ResultArray`) is incompatible with the return type declared by the interface `Mouf\Security\UserManage...pi\RoleDao::getAllRoles` of type `Mouf\Security\UserManagement\Api\RoleInterface[]`. If you return a value from a function or method, it should be a sub-type of the type that is given by the parent type f.e. an interface, or abstract method. This is more formally defined by the Lizkov substitution principle, and guarantees that classes that depend on the parent type can use any instance of a child type interchangably. This principle also belongs to the SOLID principles for object oriented design. Let’s take a look at an example: class Author { private $name; public function __construct($name) { $this->name = $name; } public function getName() { return $this->name; } } abstract class Post { public function getAuthor() { return 'Johannes'; } } class BlogPost extends Post { public function getAuthor() { return new Author('Johannes'); } } class ForumPost extends Post { /* ... */ } function my_function(Post $post) { echo strtoupper($post->getAuthor()); } Our function `my_function` expects a `Post` object, and outputs the author of the post. The base class `Post` returns a simple string and outputting a simple string will work just fine. However, the child class `BlogPost` which is a sub-type of `Post` instead decided to return an `object`, and is therefore violating the SOLID principles. If a `BlogPost` were passed to `my_function`, PHP would not complain, but ultimately fail when executing the `strtoupper` call in its body. Loading history...
50			}
51
52			/**
53			* @param UserInterface $user
54			* @param RoleInterface[] $roles
55			* @return void
56			*/
57			public function setRoles(UserInterface $user, array $roles)
58			{
59			$user = $this->tdbmService->findObjectByPk('users', [
60			'id' => $user->getId()
61			]);
62			// FIXME: throw exception is $user is null
63
64			$roleBeans = [];
65
66			foreach ($roles as $role) {
67			$roleBeans[] = $this->findRoleById($role->getId());
68			}
69
70			$user->setRoles($roleBeans);
71			$this->tdbmService->save($user);
72			}
73
74			/**
75			* @param UserInterface $user
76			* @return RoleInterface[]
77			*/
78			public function getRoles(UserInterface $user)
79			{
80			if ($user->getId() === null) {
81			return [];
82			}
83			return $this->find([
			0 ignored issues – show Bug Best Practice introduced 2016-08-09 16:46 UTC by Report Bug Copy Issue Report Show Similar Issues like this The return type of `return $this->find(array...d' => $user->getId()));` (`Kls\Model\Bean\RolesRigh...ecurity\DAO\ResultArray`) is incompatible with the return type declared by the interface `Mouf\Security\UserManagement\Api\RoleDao::getRoles` of type `Mouf\Security\UserManagement\Api\RoleInterface[]`. If you return a value from a function or method, it should be a sub-type of the type that is given by the parent type f.e. an interface, or abstract method. This is more formally defined by the Lizkov substitution principle, and guarantees that classes that depend on the parent type can use any instance of a child type interchangably. This principle also belongs to the SOLID principles for object oriented design. Let’s take a look at an example: class Author { private $name; public function __construct($name) { $this->name = $name; } public function getName() { return $this->name; } } abstract class Post { public function getAuthor() { return 'Johannes'; } } class BlogPost extends Post { public function getAuthor() { return new Author('Johannes'); } } class ForumPost extends Post { /* ... */ } function my_function(Post $post) { echo strtoupper($post->getAuthor()); } Our function `my_function` expects a `Post` object, and outputs the author of the post. The base class `Post` returns a simple string and outputting a simple string will work just fine. However, the child class `BlogPost` which is a sub-type of `Post` instead decided to return an `object`, and is therefore violating the SOLID principles. If a `BlogPost` were passed to `my_function`, PHP would not complain, but ultimately fail when executing the `strtoupper` call in its body. Loading history...
84			'users_roles.user_id' => $user->getId()
85			]);
86			}
87
88			/**
89			* Get a list of RolesBean specified by its filters.
90			*
91			* @param mixed $filter The filter bag (see TDBMService::findObjects for complete description)
92			* @param array $parameters The parameters associated with the filter
93			* @param mixed $orderBy The order string
94			* @param array $additionalTablesFetch A list of additional tables to fetch (for performance improvement)
95			* @param int $mode Either TDBMService::MODE_ARRAY or TDBMService::MODE_CURSOR (for large datasets). Defaults to TDBMService::MODE_ARRAY.
96			*
97			* @return RolesRightBean[]\|ResultIterator\|ResultArray
98			*/
99			private function find($filter = null, array $parameters = [], $orderBy = null, array $additionalTablesFetch = [], $mode = null)
100			{
101			return $this->tdbmService->findObjects('roles', $filter, $parameters, $orderBy, $additionalTablesFetch, $mode);
102			}
103
104			private function findRoleById($roleId) {
105			return $this->tdbmService->findObjectByPk('roles', [
106			'id' => $roleId
107			]);
108			}
109
110			/**
111			* Fetches a role by ID.
112			*
113			* @param $roleId
114			* @return RoleInterface
115			*/
116			public function getRoleById($roleId) : RoleInterface
117			{
118			return self::castToRole($this->findRoleById($roleId));
119			}
120
121			public static function castToRole($roleBean) : RoleInterface
122			{
123			return new Role($roleBean->getId(), $roleBean->getLabel());
124			}
125			}
126

thecodingmachine / security.daos.tdbm

Issues (7)

Security Analysis no request data

src/DAO/SecurityRoleDao.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like