MissingTypeHintInFunctionRule::getReflection() - Code Metrics - Inspection of "Switching to PHPStan parser" - thecodingmachine/phpstan-strict-rules - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#27)

by David

created 2018-07-03 16:22 UTC

MissingTypeHintInFunctionRule::getReflection() A

↳ Parent: MissingTypeHintInFunctionRule

Complexity

Conditions	3
Paths	4

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	14
rs	9.7998
c	0
b	0
f	0
nc	4
cc	3
nop	3

<?php


namespace TheCodingMachine\PHPStan\Rules\TypeHints;

use PHPStan\Analyser\Scope;
use PHPStan\Broker\Broker;
use PHPStan\Reflection\ParametersAcceptorSelector;
use PHPStan\Reflection\ParametersAcceptorWithPhpDocs;
use PHPStan\Reflection\Php\PhpParameterReflection;
use Roave\BetterReflection\Reflection\ReflectionFunction;
use Roave\BetterReflection\Reflection\ReflectionFunctionAbstract;
use Roave\BetterReflection\Reflection\ReflectionMethod;
use Roave\BetterReflection\Reflection\ReflectionParameter;
use PhpParser\Node;

class MissingTypeHintInFunctionRule extends AbstractMissingTypeHintRule
{
    public function getNodeType(): string
    {
        return Node\Stmt\Function_::class;
    }

    public function isReturnIgnored(Node $node): bool
    {
        return false;
    }

    protected function getReflection(Node\FunctionLike $function, Scope $scope, Broker $broker) : ParametersAcceptorWithPhpDocs
    {
        $functionName = $function->name->name;
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
        if (isset($function->namespacedName)) {
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
            $functionName = (string) $function->namespacedName;
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
        }
        $functionNameName = new Node\Name($functionName);
        if (!$broker->hasCustomFunction($functionNameName, null)) {
            throw new \RuntimeException("Cannot find function '$functionName'");
        }
        $functionReflection = $broker->getCustomFunction($functionNameName, null);
        /** @var \PHPStan\Reflection\ParametersAcceptorWithPhpDocs $parametersAcceptor */
        return ParametersAcceptorSelector::selectSingle($functionReflection->getVariants());
    }

    protected function shouldSkip(Node\FunctionLike $function, Scope $scope): bool
    {
        return false;
    }
}


1			<?php
2
3
4			namespace TheCodingMachine\PHPStan\Rules\TypeHints;
5
6			use PHPStan\Analyser\Scope;
7			use PHPStan\Broker\Broker;
8			use PHPStan\Reflection\ParametersAcceptorSelector;
9			use PHPStan\Reflection\ParametersAcceptorWithPhpDocs;
10			use PHPStan\Reflection\Php\PhpParameterReflection;
11			use Roave\BetterReflection\Reflection\ReflectionFunction;
12			use Roave\BetterReflection\Reflection\ReflectionFunctionAbstract;
13			use Roave\BetterReflection\Reflection\ReflectionMethod;
14			use Roave\BetterReflection\Reflection\ReflectionParameter;
15			use PhpParser\Node;
16
17			class MissingTypeHintInFunctionRule extends AbstractMissingTypeHintRule
18			{
19			public function getNodeType(): string
20			{
21			return Node\Stmt\Function_::class;
22			}
23
24			public function isReturnIgnored(Node $node): bool
25			{
26			return false;
27			}
28
29			protected function getReflection(Node\FunctionLike $function, Scope $scope, Broker $broker) : ParametersAcceptorWithPhpDocs
30			{
31			$functionName = $function->name->name;
			0 ignored issues – show Bug introduced 2018-07-03 16:33 UTC by Report Bug Copy Issue Report Accessing `name` on the interface `PhpParser\Node\FunctionLike` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
32			if (isset($function->namespacedName)) {
			0 ignored issues – show Bug introduced 2018-07-03 16:33 UTC by Report Bug Copy Issue Report Accessing `namespacedName` on the interface `PhpParser\Node\FunctionLike` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
33			$functionName = (string) $function->namespacedName;
			0 ignored issues – show Bug introduced 2018-07-03 16:33 UTC by Report Bug Copy Issue Report Accessing `namespacedName` on the interface `PhpParser\Node\FunctionLike` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
34			}
35			$functionNameName = new Node\Name($functionName);
36			if (!$broker->hasCustomFunction($functionNameName, null)) {
37			throw new \RuntimeException("Cannot find function '$functionName'");
38			}
39			$functionReflection = $broker->getCustomFunction($functionNameName, null);
40			/** @var \PHPStan\Reflection\ParametersAcceptorWithPhpDocs $parametersAcceptor */
41			return ParametersAcceptorSelector::selectSingle($functionReflection->getVariants());
42			}
43
44			protected function shouldSkip(Node\FunctionLike $function, Scope $scope): bool
45			{
46			return false;
47			}
48			}
49

thecodingmachine / phpstan-strict-rules

Pull Request — master (#27)

MissingTypeHintInFunctionRule::getReflection() A

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like