ClientTest - Code Metrics - Inspection of "Adding specific exception when creating the connec..." - thecodingmachine/oo-amqp-client - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — 1.0 (#5)

by Benoit

created 2017-01-16 18:07 UTC

ClientTest A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	121
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	9

Importance

Changes	5
Bugs	0	Features	0

Metric	Value
wmc	7
c	5
b	0
f	0
lcom	1
cbo	9
dl	0
loc	121
rs	10

5 Methods

Rating	Name	Size	Complexity
A	testExchange()	5	1
A	testQueue()	12	1
B	init()	44	3
A	testDeadLetterQueue()	19	1
A	testConnectionException()	5	1

<?php

namespace Mouf\AmqpClient\Objects;

use Mouf\AmqpClient\Client;
use Mouf\AmqpClient\Consumer;
use Mouf\AmqpClient\ConsumerService;
use PhpAmqpLib\Message\AMQPMessage;

class ClientTest extends \PHPUnit_Framework_TestCase
{
    /**
     * @var Client
     */
    private $client;
    private $exchange;
    /**
     * @var Queue
     */
    private $queue;
    /**
     * @var Exchange
     */
    private $deadLetterExchange;
    /**
     * @var Queue
     */
    private $deadLetterQueue;
    private $msgReceived;
    private $deadLetterMsgReceived;
    private $triggerException = false;

    protected function init($port = null)
    {
        global $rabbitmq_host;
function myFunction($a, $b) {
    // Do something
}
        global $rabbitmq_port;
function myFunction($a, $b) {
    // Do something
}
        global $rabbitmq_user;
function myFunction($a, $b) {
    // Do something
}
        global $rabbitmq_password;
function myFunction($a, $b) {
    // Do something
}

        if (!$port) {
          $port = $rabbitmq_port;
        }


        $this->client = new Client($rabbitmq_host, $port, $rabbitmq_user, $rabbitmq_password);
        $this->client->setPrefetchCount(1);

        $this->exchange = new Exchange($this->client, 'test_exchange', 'fanout');
        $this->queue = new Queue($this->client, 'test_queue', [
            new Consumer(function(AMQPMessage $msg) {
                $this->msgReceived = $msg;
                if ($this->triggerException) {
                    throw new \Exception('boom!');
                }
            })
        ]);
        $this->queue->setDurable(true);

        $binding = new Binding($this->exchange, $this->queue);
        $this->client->register($binding);


        $this->deadLetterExchange = new Exchange($this->client, 'test_dead_letter_exchange', 'fanout');

        $this->deadLetterQueue = new Queue($this->client, 'test_dead_letter_queue', [
            new Consumer(function(AMQPMessage $msg) {
                $this->deadLetterMsgReceived = $msg;
            })
        ]);
        $this->deadLetterQueue->setDurable(true);

        $this->queue->setDeadLetterExchange($this->deadLetterExchange);

        $binding = new Binding($this->deadLetterExchange, $this->deadLetterQueue);
        $this->client->register($binding);
    }

    public function testExchange()
    {
        $this->init();
        $this->exchange->publish(new Message('my message'), 'key');
    }

    /**
     * @depends testExchange
     */
    public function testQueue()
    {
        $this->init();

        $consumerService = new ConsumerService($this->client, [
            $this->queue
        ]);

        $consumerService->run(true);

        $this->assertEquals('my message', $this->msgReceived->getBody());
    }

    /**
     * @depends testExchange
     */
    public function testDeadLetterQueue()
    {
        $this->init();

        $this->exchange->publish(new Message('my other message'), 'key');

        $this->triggerException = true;

        $consumerService = new ConsumerService($this->client, [
            $this->queue,
            $this->deadLetterQueue
        ]);

        $consumerService->run(true);
        $consumerService->run(true);

        $this->assertEquals('my other message', $this->msgReceived->getBody());
        $this->assertEquals('my other message', $this->deadLetterMsgReceived->getBody());
    }
    /**
     * @expectedException \Mouf\AmqpClient\Exception\ConnectionException
     */
    public function testConnectionException()
    {
        $this->init(1242000042);
        $this->client->getChannel();
    }
}


1			<?php
2
3			namespace Mouf\AmqpClient\Objects;
4
5			use Mouf\AmqpClient\Client;
6			use Mouf\AmqpClient\Consumer;
7			use Mouf\AmqpClient\ConsumerService;
8			use PhpAmqpLib\Message\AMQPMessage;
9
10			class ClientTest extends \PHPUnit_Framework_TestCase
11			{
12			/**
13			* @var Client
14			*/
15			private $client;
16			private $exchange;
17			/**
18			* @var Queue
19			*/
20			private $queue;
21			/**
22			* @var Exchange
23			*/
24			private $deadLetterExchange;
25			/**
26			* @var Queue
27			*/
28			private $deadLetterQueue;
29			private $msgReceived;
30			private $deadLetterMsgReceived;
31			private $triggerException = false;
32
33			protected function init($port = null)
34			{
35			global $rabbitmq_host;
			0 ignored issues – show Compatibility Best Practice introduced 2016-07-07 16:27 UTC by Report Bug Copy Issue Report Use of `global` functionality is not recommended; it makes your code harder to test, and less reusable. Instead of relying on `global` state, we recommend one of these alternatives: 1. Pass all data via parameters function myFunction($a, $b) { // Do something } 2. Create a class that maintains your state class MyClass { private $a; private $b; public function __construct($a, $b) { $this->a = $a; $this->b = $b; } public function myFunction() { // Do something } } Loading history...
36			global $rabbitmq_port;
			0 ignored issues – show Compatibility Best Practice introduced 2016-07-07 16:27 UTC by Report Bug Copy Issue Report Use of `global` functionality is not recommended; it makes your code harder to test, and less reusable. Instead of relying on `global` state, we recommend one of these alternatives: 1. Pass all data via parameters function myFunction($a, $b) { // Do something } 2. Create a class that maintains your state class MyClass { private $a; private $b; public function __construct($a, $b) { $this->a = $a; $this->b = $b; } public function myFunction() { // Do something } } Loading history...
37			global $rabbitmq_user;
			0 ignored issues – show Compatibility Best Practice introduced 2016-07-07 16:27 UTC by Report Bug Copy Issue Report Use of `global` functionality is not recommended; it makes your code harder to test, and less reusable. Instead of relying on `global` state, we recommend one of these alternatives: 1. Pass all data via parameters function myFunction($a, $b) { // Do something } 2. Create a class that maintains your state class MyClass { private $a; private $b; public function __construct($a, $b) { $this->a = $a; $this->b = $b; } public function myFunction() { // Do something } } Loading history...
38			global $rabbitmq_password;
			0 ignored issues – show Compatibility Best Practice introduced 2016-07-07 16:27 UTC by Report Bug Copy Issue Report Use of `global` functionality is not recommended; it makes your code harder to test, and less reusable. Instead of relying on `global` state, we recommend one of these alternatives: 1. Pass all data via parameters function myFunction($a, $b) { // Do something } 2. Create a class that maintains your state class MyClass { private $a; private $b; public function __construct($a, $b) { $this->a = $a; $this->b = $b; } public function myFunction() { // Do something } } Loading history...
39
40			if (!$port) {
41			$port = $rabbitmq_port;
42			}
43
44
45			$this->client = new Client($rabbitmq_host, $port, $rabbitmq_user, $rabbitmq_password);
46			$this->client->setPrefetchCount(1);
47
48			$this->exchange = new Exchange($this->client, 'test_exchange', 'fanout');
49			$this->queue = new Queue($this->client, 'test_queue', [
50			new Consumer(function(AMQPMessage $msg) {
51			$this->msgReceived = $msg;
52			if ($this->triggerException) {
53			throw new \Exception('boom!');
54			}
55			})
56			]);
57			$this->queue->setDurable(true);
58
59			$binding = new Binding($this->exchange, $this->queue);
60			$this->client->register($binding);
61
62
63			$this->deadLetterExchange = new Exchange($this->client, 'test_dead_letter_exchange', 'fanout');
64
65			$this->deadLetterQueue = new Queue($this->client, 'test_dead_letter_queue', [
66			new Consumer(function(AMQPMessage $msg) {
67			$this->deadLetterMsgReceived = $msg;
68			})
69			]);
70			$this->deadLetterQueue->setDurable(true);
71
72			$this->queue->setDeadLetterExchange($this->deadLetterExchange);
73
74			$binding = new Binding($this->deadLetterExchange, $this->deadLetterQueue);
75			$this->client->register($binding);
76			}
77
78			public function testExchange()
79			{
80			$this->init();
81			$this->exchange->publish(new Message('my message'), 'key');
82			}
83
84			/**
85			* @depends testExchange
86			*/
87			public function testQueue()
88			{
89			$this->init();
90
91			$consumerService = new ConsumerService($this->client, [
92			$this->queue
93			]);
94
95			$consumerService->run(true);
96
97			$this->assertEquals('my message', $this->msgReceived->getBody());
98			}
99
100			/**
101			* @depends testExchange
102			*/
103			public function testDeadLetterQueue()
104			{
105			$this->init();
106
107			$this->exchange->publish(new Message('my other message'), 'key');
108
109			$this->triggerException = true;
110
111			$consumerService = new ConsumerService($this->client, [
112			$this->queue,
113			$this->deadLetterQueue
114			]);
115
116			$consumerService->run(true);
117			$consumerService->run(true);
118
119			$this->assertEquals('my other message', $this->msgReceived->getBody());
120			$this->assertEquals('my other message', $this->deadLetterMsgReceived->getBody());
121			}
122			/**
123			* @expectedException \Mouf\AmqpClient\Exception\ConnectionException
124			*/
125			public function testConnectionException()
126			{
127			$this->init(1242000042);
128			$this->client->getChannel();
129			}
130			}
131

thecodingmachine / oo-amqp-client

Pull Request — 1.0 (#5)

ClientTest A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

5 Methods

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

Duplication Side-by-Side

Filter issues like