Queue - Code Metrics - Inspection of "First running version with unit tests" - thecodingmachine/oo-amqp-client - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — 1.0 ( 96ad2d...e7718b )

by David

created 2016-07-07 16:20 UTC

Queue B

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	536
Duplicated Lines	1.31 %

Coupling/Cohesion

Components	1
Dependencies	3

Importance

Changes	10
Bugs	1	Features	3

Metric	Value
wmc	43
c	10
b	1
f	3
lcom	1
cbo	3
dl	7
loc	536
rs	8.3157

32 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	7	7	1
A	getName()	0	4	1
A	getPassive()	0	4	1
A	setPassive()	0	6	1
A	getDurable()	0	4	1
A	setDurable()	0	6	1
A	getExclusive()	0	4	1
A	setExclusive()	0	6	1
A	getAutoDelete()	0	4	1
A	setAutoDelete()	0	6	1
A	getNoWait()	0	4	1
A	setNoWait()	0	6	1
A	getArguments()	0	4	1
A	setArguments()	0	6	1
A	getTicket()	0	4	1
A	setTicket()	0	6	1
A	getDeadLetterQueue()	0	4	1
A	setDeadLetterQueue()	0	6	1
A	getConfirm()	0	4	1
A	setConfirm()	0	6	1
A	getConsumerCancelNotify()	0	4	1
A	setConsumerCancelNotify()	0	6	1
A	getAlternateExchange()	0	4	1
A	setAlternateExchange()	0	6	1
A	getTtl()	0	4	1
A	setTtl()	0	6	1
A	getMaxLength()	0	4	1
A	setMaxLength()	0	6	1
A	getMaxPriority()	0	4	1
A	setMaxPriority()	0	6	1
F	init()	0	37	11
A	consume()	0	19	2

How to fix Duplicated Code Complexity

Duplicated Code

Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.

Common duplication problems, and corresponding solutions are:

If you have the same expression in different places: Extract expression to a method
If you have the same method in different sub-classes: Extract method, and pull up field to the parent class
If you have the same code in unrelated classes: Consider extracting the code to a new class, and injecting that class

Complex Class

Tip: Before tackling complexity, make sure that you eliminate any duplication first. This often can reduce the size of classes significantly.

Complex classes like Queue often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.

Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.

While breaking up the class, it is a good idea to analyze how other classes use Queue, and based on these observations, apply Extract Interface, too.

<?php

namespace Mouf\AmqpClient\Objects;

use Mouf\AmqpClient\Client;
use Mouf\AmqpClient\RabbitMqObjectInterface;
use PhpAmqpLib\Channel\AMQPChannel;
use Mouf\AmqpClient\ConsumerInterface;
use PhpAmqpLib\Message\AMQPMessage;

/**
 * @author Marc
 */
class Queue implements RabbitMqObjectInterface
{
    /**
     * @var Client
     */
    private $client;

    /**
     * Queue name.
     *
     * @var string
     */
    private $name;

    /**
     * Passive.
     *
     * @var bool
     */
    private $passive = false;

    /**
     * Durable.
     *
     * @var bool
     */
    private $durable = false;

    /**
     * Exclusive.
     *
     * @var bool
     */
    private $exclusive = false;

    /**
     * Auto delete.
     *
     * @var bool
     */
    private $autoDelete = false;

    /**
     * No wait.
     *
     * @var bool
     */
    private $noWait = false;

    /**
     * Ticket.
     *
     * @var int
     */
    private $ticket = null;

    /**
     *R abbitMq specific parameter : x-dead-letter-exchange.
     *
     * @var Queue
     */
    private $deadLetterQueue = null;

    /**
     * RabbitMq specific parameter : confirm.
     *
     * @var int
     */
    private $confirm = null;

    /**
     * RabbitMq specific parameter : consumer_cancel_notify.
     *
     * @var bool
     */
    private $consumerCancelNotify = null;

    /**
     * RabbitMq specific parameter : alternate-exchange.
     *
     * @var Queue
     */
    private $alternateExchange = null;

    /**
     * RabbitMq specific parameter : x-message-ttl.
     *
     * @var int
     */
    private $ttl = null;

    /**
     * RabbitMq specific parameter : x-max-length.
     *
     * @var int
     */
    private $maxLength = null;

    /**
     * RabbitMq specific parameter : x-max-priority.
     *
     * @var int
     */
    private $maxPriority = null;

    /**
     * Parameter to initialize object only one time.
     *
     * @var bool
     */
    private $init = false;

    /**
     * Consumer list implement ConsumerInterface.
     *
     * @var array|null
     */
    private $consumers;

    /**
     * Set the source (Binding).
     *
     * @param Binding             $source
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     * @param string              $name
     * @param ConsumerInterface[] $consumers
     */
    public function __construct(Client $client, $name, array $consumers = [])

    {
        $this->client = $client;
        $this->client->register($this);
        $this->name = $name;
        $this->consumers = $consumers;
    }

    /**
     * Get queue name.
     *
     * @return string
     */
    public function getName()
    {
        return $this->name;
    }

    /**
     * Get passive.
     *
     * @return bool
     */
    public function getPassive()
    {
        return $this->passive;
    }

    /**
     * @param bool $passive
     *
     * @return Queue
     */
    public function setPassive($passive)
    {
        $this->passive = $passive;

        return $this;
    }

    /**
     * Get durable.
     *
     * @return bool
     */
    public function getDurable()
    {
        return $this->durable;
    }

    /**
     * Set durable.
     *
     * @param bool $durable
     *
     * @return Queue
     */
    public function setDurable($durable)
    {
        $this->durable = $durable;

        return $this;
    }

    /**
     * Get exclusive.
     *
     * @return bool
     */
    public function getExclusive()
    {
        return $this->exclusive;
    }

    /**
     * Set exclusive.
     *
     * @param bool $exclusive
     *
     * @return Queue
     */
    public function setExclusive($exclusive)
    {
        $this->exclusive = $exclusive;

        return $this;
    }

    /**
     * Get autoDelete.
     *
     * @return bool
     */
    public function getAutoDelete()
    {
        return $this->autoDelete;
    }

    /**
     * Set autoDelete.
     *
     * @param bool $autoDelete
     *
     * @return Queue
     */
    public function setAutoDelete($autoDelete)
    {
        $this->autoDelete = $autoDelete;

        return $this;
    }

    /**
     * Get noWait.
     *
     * @return bool
     */
    public function getNoWait()
    {
        return $this->noWait;
    }

    /**
     * Set noWait.
     *
     * @param bool $noWait
     *
     * @return Queue
     */
    public function setNoWait($noWait)
    {
        $this->noWait = $noWait;

        return $this;
    }

    /**
     * Get arguments.
     *
     * @return array|null
     */
    public function getArguments()
    {
        return $this->arguments;
class MyClass { }

$x = new MyClass();
$x->foo = true;
    }

    /**
     * Set arguments.
     *
     * @param array $arguments
     *
     * @return Queue
     */
    public function setArguments($arguments)
    {
        $this->arguments = $arguments;

        return $this;
    }

    /**
     * Get ticket.
     *
     * @return int
     */
    public function getTicket()
    {
        return $this->ticket;
    }

    /**
     * Set ticket.
     *
     * @param int $ticket
     *
     * @return Queue
     */
    public function setTicket($ticket)
    {
        $this->ticket = $ticket;

        return $this;
    }

    /**
     * Get RabbitMq specific parameter : dead letter queue.
     *
     * @return Queue
     */
    public function getDeadLetterQueue()
    {
        return $this->deadLetterQueue;
    }

    /**
     * Set RabbitMq specific parameter : dead letter queue.
     *
     * @param Queue $queue
     *
     * @return Queue
     */
    public function setDeadLetterQueue(Queue $queue)
    {
        $this->deadLetterQueue = $queue;

        return $this;
    }

    /**
     * Get RabbitMq specific parameter : confirm.
     *
     * @return int
     */
    public function getConfirm()
    {
        return $this->confirm;
    }

    /**
     * Set RabbitMq specific parameter : confirm.
     *
     * @param int $confirm
     *
     * @return Queue
     */
    public function setConfirm($confirm)
    {
        $this->confirm = $confirm;

        return $this;
    }

    /**
     * Get RabbitMq specific parameter : consumer_cancel_notify.
     *
     * @return bool
     */
    public function getConsumerCancelNotify()
    {
        return $this->consumerCancelNotify;
    }

    /**
     * Set RabbitMq specific parameter : consumer_cancel_notify.
     *
     * @param Queue $consumerCancelNotify
     *
     * @return Queue
     */
    public function setConsumerCancelNotify(Queue $consumerCancelNotify)
    {
        $this->consumerCancelNotify = $consumerCancelNotify;


        return $this;
    }

    /**
     * Get RabbitMq specific parameter : alternate_exchange.
     *
     * @return Queue
     */
    public function getAlternateExchange()
    {
        return $this->alternateExchange;
    }

    /**
     * Set RabbitMq specific parameter : alternate_exchange.
     *
     * @param Queue $alternateExchange
     *
     * @return Queue
     */
    public function setAlternateExchange(Queue $alternateExchange)
    {
        $this->alternateExchange = $alternateExchange;

        return $this;
    }

    /**
     * Get RabbitMq specific parameter : ttl.
     *
     * @return int
     */
    public function getTtl()
    {
        return $this->ttl;
    }

    /**
     * Set RabbitMq specific parameter : ttl.
     *
     * @param int $ttl
     *
     * @return Queue
     */
    public function setTtl($ttl)
    {
        $this->ttl = $ttl;

        return $this;
    }

    /**
     * Get RabbitMq specific parameter : max length.
     *
     * @return int
     */
    public function getMaxLength()
    {
        return $this->maxLength;
    }

    /**
     * Set RabbitMq specific parameter : max length.
     *
     * @param int $ttl
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     *
     * @return Queue
     */
    public function setMaxLength($maxLength)
    {
        $this->maxLength = $maxLength;

        return $this;
    }

    /**
     * Get RabbitMq specific parameter : max priority.
     *
     * @return int
     */
    public function getMaxPriority()
    {
        return $this->maxPriority;
    }

    /**
     * Set RabbitMq specific parameter : max priority.
     *
     * @param int $maxPriority
     *
     * @return Queue
     */
    public function setMaxPriority($maxPriority)
    {
        $this->maxPriority = $maxPriority;

        return $this;
    }

    public function init(AMQPChannel $amqpChannel)
    {
        if (!$this->init) {
            if ($this->deadLetterQueue) {
                $this->deadLetterQueue->init($amqpChannel);
            }

            $parameters = [];
            if ($this->alternateExchange !== null) {
                $parameters['alternate-exchange'] = $this->alternateExchange->getName();
            }
            if ($this->confirm !== null) {
                $parameters['confirm'] = $this->confirm;
            }
            if ($this->consumerCancelNotify !== null) {
                $parameters['consumer_cancel_notify'] = $this->consumerCancelNotify;
            }
            if ($this->deadLetterQueue !== null) {
                $parameters['x-dead-letter-exchange'] = $this->deadLetterQueue->getName();
            }
            if ($this->maxLength) {
                $parameters['x-max-length'] = $this->maxLength;
            }
            if ($this->maxPriority) {
                $parameters['x-max-priority'] = $this->maxPriority;
            }
            if ($this->ttl) {
                $parameters['x-message-ttl'] = $this->ttl;
            }

            if (!$parameters) {

                $parameters = null;
            }
            $amqpChannel->queue_declare($this->name, $this->passive, $this->durable, $this->exclusive, $this->autoDelete, $this->noWait, $parameters);
            $this->init = true;
        }
    }

    public function consume()
    {
        $channel = $this->client->getChannel();

        foreach ($this->consumers as $consumer) {
$collection = json_decode($data, true);
if ( ! is_array($collection)) {
    throw new \RuntimeException('$collection must be an array.');
}

foreach ($collection as $item) { /** ... */ }
            /* @var $consumer ConsumerInterface */
            $channel->basic_consume($this->name,
                                    $consumer->getConsumerTag(),
                                    $consumer->isNoLocal(),
                                    $consumer->isNoAck(),
                                    $consumer->isExclusive(),
                                    $consumer->isNoWait(),
                                    function (AMQPMessage $msg) use ($consumer) {
                                        $consumer->callback($msg);
                                    },
                                    $consumer->getTicket(),
                                    $consumer->getArguments());
        }
    }
}


1		<?php
2
3		namespace Mouf\AmqpClient\Objects;
4
5		use Mouf\AmqpClient\Client;
6		use Mouf\AmqpClient\RabbitMqObjectInterface;
7		use PhpAmqpLib\Channel\AMQPChannel;
8		use Mouf\AmqpClient\ConsumerInterface;
9		use PhpAmqpLib\Message\AMQPMessage;
10
11		/**
12		* @author Marc
13		*/
14		class Queue implements RabbitMqObjectInterface
15		{
16		/**
17		* @var Client
18		*/
19		private $client;
20
21		/**
22		* Queue name.
23		*
24		* @var string
25		*/
26		private $name;
27
28		/**
29		* Passive.
30		*
31		* @var bool
32		*/
33		private $passive = false;
34
35		/**
36		* Durable.
37		*
38		* @var bool
39		*/
40		private $durable = false;
41
42		/**
43		* Exclusive.
44		*
45		* @var bool
46		*/
47		private $exclusive = false;
48
49		/**
50		* Auto delete.
51		*
52		* @var bool
53		*/
54		private $autoDelete = false;
55
56		/**
57		* No wait.
58		*
59		* @var bool
60		*/
61		private $noWait = false;
62
63		/**
64		* Ticket.
65		*
66		* @var int
67		*/
68		private $ticket = null;
69
70		/**
71		*R abbitMq specific parameter : x-dead-letter-exchange.
72		*
73		* @var Queue
74		*/
75		private $deadLetterQueue = null;
76
77		/**
78		* RabbitMq specific parameter : confirm.
79		*
80		* @var int
81		*/
82		private $confirm = null;
83
84		/**
85		* RabbitMq specific parameter : consumer_cancel_notify.
86		*
87		* @var bool
88		*/
89		private $consumerCancelNotify = null;
90
91		/**
92		* RabbitMq specific parameter : alternate-exchange.
93		*
94		* @var Queue
95		*/
96		private $alternateExchange = null;
97
98		/**
99		* RabbitMq specific parameter : x-message-ttl.
100		*
101		* @var int
102		*/
103		private $ttl = null;
104
105		/**
106		* RabbitMq specific parameter : x-max-length.
107		*
108		* @var int
109		*/
110		private $maxLength = null;
111
112		/**
113		* RabbitMq specific parameter : x-max-priority.
114		*
115		* @var int
116		*/
117		private $maxPriority = null;
118
119		/**
120		* Parameter to initialize object only one time.
121		*
122		* @var bool
123		*/
124		private $init = false;
125
126		/**
127		* Consumer list implement ConsumerInterface.
128		*
129		* @var array\|null
130		*/
131		private $consumers;
132
133		/**
134		* Set the source (Binding).
135		*
136		* @param Binding $source
		0 ignored issues – show Bug introduced 2016-07-07 16:27 UTC by Report Bug Copy Issue Report There is no parameter named `$source`. Was it maybe removed? This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. Consider the following example. The parameter `$italy` is not defined by the method `finale(...)`. /** * @param array $germany * @param array $island * @param array $italy */ function finale($germany, $island) { return "2:1"; } The most likely cause is that the parameter was removed, but the annotation was not. Loading history...
137		* @param string $name
138		* @param ConsumerInterface[] $consumers
139		*/
140	View Code Duplication	public function __construct(Client $client, $name, array $consumers = [])
		0 ignored issues – show Duplication introduced 2016-07-07 16:27 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
141		{
142		$this->client = $client;
143		$this->client->register($this);
144		$this->name = $name;
145		$this->consumers = $consumers;
146		}
147
148		/**
149		* Get queue name.
150		*
151		* @return string
152		*/
153		public function getName()
154		{
155		return $this->name;
156		}
157
158		/**
159		* Get passive.
160		*
161		* @return bool
162		*/
163		public function getPassive()
164		{
165		return $this->passive;
166		}
167
168		/**
169		* @param bool $passive
170		*
171		* @return Queue
172		*/
173		public function setPassive($passive)
174		{
175		$this->passive = $passive;
176
177		return $this;
178		}
179
180		/**
181		* Get durable.
182		*
183		* @return bool
184		*/
185		public function getDurable()
186		{
187		return $this->durable;
188		}
189
190		/**
191		* Set durable.
192		*
193		* @param bool $durable
194		*
195		* @return Queue
196		*/
197		public function setDurable($durable)
198		{
199		$this->durable = $durable;
200
201		return $this;
202		}
203
204		/**
205		* Get exclusive.
206		*
207		* @return bool
208		*/
209		public function getExclusive()
210		{
211		return $this->exclusive;
212		}
213
214		/**
215		* Set exclusive.
216		*
217		* @param bool $exclusive
218		*
219		* @return Queue
220		*/
221		public function setExclusive($exclusive)
222		{
223		$this->exclusive = $exclusive;
224
225		return $this;
226		}
227
228		/**
229		* Get autoDelete.
230		*
231		* @return bool
232		*/
233		public function getAutoDelete()
234		{
235		return $this->autoDelete;
236		}
237
238		/**
239		* Set autoDelete.
240		*
241		* @param bool $autoDelete
242		*
243		* @return Queue
244		*/
245		public function setAutoDelete($autoDelete)
246		{
247		$this->autoDelete = $autoDelete;
248
249		return $this;
250		}
251
252		/**
253		* Get noWait.
254		*
255		* @return bool
256		*/
257		public function getNoWait()
258		{
259		return $this->noWait;
260		}
261
262		/**
263		* Set noWait.
264		*
265		* @param bool $noWait
266		*
267		* @return Queue
268		*/
269		public function setNoWait($noWait)
270		{
271		$this->noWait = $noWait;
272
273		return $this;
274		}
275
276		/**
277		* Get arguments.
278		*
279		* @return array\|null
280		*/
281		public function getArguments()
282		{
283		return $this->arguments;
		0 ignored issues – show Bug introduced 2016-07-07 14:17 UTC by Report Bug Copy Issue Report The property `arguments` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
284		}
285
286		/**
287		* Set arguments.
288		*
289		* @param array $arguments
290		*
291		* @return Queue
292		*/
293		public function setArguments($arguments)
294		{
295		$this->arguments = $arguments;
296
297		return $this;
298		}
299
300		/**
301		* Get ticket.
302		*
303		* @return int
304		*/
305		public function getTicket()
306		{
307		return $this->ticket;
308		}
309
310		/**
311		* Set ticket.
312		*
313		* @param int $ticket
314		*
315		* @return Queue
316		*/
317		public function setTicket($ticket)
318		{
319		$this->ticket = $ticket;
320
321		return $this;
322		}
323
324		/**
325		* Get RabbitMq specific parameter : dead letter queue.
326		*
327		* @return Queue
328		*/
329		public function getDeadLetterQueue()
330		{
331		return $this->deadLetterQueue;
332		}
333
334		/**
335		* Set RabbitMq specific parameter : dead letter queue.
336		*
337		* @param Queue $queue
338		*
339		* @return Queue
340		*/
341		public function setDeadLetterQueue(Queue $queue)
342		{
343		$this->deadLetterQueue = $queue;
344
345		return $this;
346		}
347
348		/**
349		* Get RabbitMq specific parameter : confirm.
350		*
351		* @return int
352		*/
353		public function getConfirm()
354		{
355		return $this->confirm;
356		}
357
358		/**
359		* Set RabbitMq specific parameter : confirm.
360		*
361		* @param int $confirm
362		*
363		* @return Queue
364		*/
365		public function setConfirm($confirm)
366		{
367		$this->confirm = $confirm;
368
369		return $this;
370		}
371
372		/**
373		* Get RabbitMq specific parameter : consumer_cancel_notify.
374		*
375		* @return bool
376		*/
377		public function getConsumerCancelNotify()
378		{
379		return $this->consumerCancelNotify;
380		}
381
382		/**
383		* Set RabbitMq specific parameter : consumer_cancel_notify.
384		*
385		* @param Queue $consumerCancelNotify
386		*
387		* @return Queue
388		*/
389		public function setConsumerCancelNotify(Queue $consumerCancelNotify)
390		{
391		$this->consumerCancelNotify = $consumerCancelNotify;
		0 ignored issues – show Documentation Bug introduced 2016-07-07 14:17 UTC by Report Bug Copy Issue Report It seems like `$consumerCancelNotify` of type `object<Mouf\AmqpClient\Objects\Queue>` is incompatible with the declared type `boolean` of property `$consumerCancelNotify`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
392
393		return $this;
394		}
395
396		/**
397		* Get RabbitMq specific parameter : alternate_exchange.
398		*
399		* @return Queue
400		*/
401		public function getAlternateExchange()
402		{
403		return $this->alternateExchange;
404		}
405
406		/**
407		* Set RabbitMq specific parameter : alternate_exchange.
408		*
409		* @param Queue $alternateExchange
410		*
411		* @return Queue
412		*/
413		public function setAlternateExchange(Queue $alternateExchange)
414		{
415		$this->alternateExchange = $alternateExchange;
416
417		return $this;
418		}
419
420		/**
421		* Get RabbitMq specific parameter : ttl.
422		*
423		* @return int
424		*/
425		public function getTtl()
426		{
427		return $this->ttl;
428		}
429
430		/**
431		* Set RabbitMq specific parameter : ttl.
432		*
433		* @param int $ttl
434		*
435		* @return Queue
436		*/
437		public function setTtl($ttl)
438		{
439		$this->ttl = $ttl;
440
441		return $this;
442		}
443
444		/**
445		* Get RabbitMq specific parameter : max length.
446		*
447		* @return int
448		*/
449		public function getMaxLength()
450		{
451		return $this->maxLength;
452		}
453
454		/**
455		* Set RabbitMq specific parameter : max length.
456		*
457		* @param int $ttl
		0 ignored issues – show Bug introduced 2016-07-07 14:17 UTC by Report Bug Copy Issue Report There is no parameter named `$ttl`. Was it maybe removed? This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. Consider the following example. The parameter `$italy` is not defined by the method `finale(...)`. /** * @param array $germany * @param array $island * @param array $italy */ function finale($germany, $island) { return "2:1"; } The most likely cause is that the parameter was removed, but the annotation was not. Loading history...
458		*
459		* @return Queue
460		*/
461		public function setMaxLength($maxLength)
462		{
463		$this->maxLength = $maxLength;
464
465		return $this;
466		}
467
468		/**
469		* Get RabbitMq specific parameter : max priority.
470		*
471		* @return int
472		*/
473		public function getMaxPriority()
474		{
475		return $this->maxPriority;
476		}
477
478		/**
479		* Set RabbitMq specific parameter : max priority.
480		*
481		* @param int $maxPriority
482		*
483		* @return Queue
484		*/
485		public function setMaxPriority($maxPriority)
486		{
487		$this->maxPriority = $maxPriority;
488
489		return $this;
490		}
491
492		public function init(AMQPChannel $amqpChannel)
493		{
494		if (!$this->init) {
495		if ($this->deadLetterQueue) {
496		$this->deadLetterQueue->init($amqpChannel);
497		}
498
499		$parameters = [];
500		if ($this->alternateExchange !== null) {
501		$parameters['alternate-exchange'] = $this->alternateExchange->getName();
502		}
503		if ($this->confirm !== null) {
504		$parameters['confirm'] = $this->confirm;
505		}
506		if ($this->consumerCancelNotify !== null) {
507		$parameters['consumer_cancel_notify'] = $this->consumerCancelNotify;
508		}
509		if ($this->deadLetterQueue !== null) {
510		$parameters['x-dead-letter-exchange'] = $this->deadLetterQueue->getName();
511		}
512		if ($this->maxLength) {
513		$parameters['x-max-length'] = $this->maxLength;
514		}
515		if ($this->maxPriority) {
516		$parameters['x-max-priority'] = $this->maxPriority;
517		}
518		if ($this->ttl) {
519		$parameters['x-message-ttl'] = $this->ttl;
520		}
521
522		if (!$parameters) {
		0 ignored issues – show Bug Best Practice introduced 2016-07-07 14:17 UTC by Report Bug Copy Issue Report The expression `$parameters` of type `array` is implicitly converted to a boolean; are you sure this is intended? If so, consider using `empty($expr)` instead to make it clear that you intend to check for an array without elements. This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent. Consider making the comparison explicit by using `empty(..)` or `! empty(...)` instead. Loading history...
523		$parameters = null;
524		}
525		$amqpChannel->queue_declare($this->name, $this->passive, $this->durable, $this->exclusive, $this->autoDelete, $this->noWait, $parameters);
526		$this->init = true;
527		}
528		}
529
530		public function consume()
531		{
532		$channel = $this->client->getChannel();
533
534		foreach ($this->consumers as $consumer) {
		0 ignored issues – show Bug introduced 2016-07-07 14:56 UTC by Report Bug Copy Issue Report The expression `$this->consumers` of type `array\|null` is not guaranteed to be traversable. How about adding an additional type check? There are different options of fixing this problem. If you want to be on the safe side, you can add an additional type-check: $collection = json_decode($data, true); if ( ! is_array($collection)) { throw new \RuntimeException('$collection must be an array.'); } foreach ($collection as $item) { /** ... / } If you are sure that the expression is traversable, you might want to add a doc comment cast* to improve IDE auto-completion and static analysis: /** @var array $collection / $collection = json_decode($data, true); foreach ($collection as $item) { /* .. / } Mark the issue as a false-positive*: Just hover the remove button, in the top-right corner of this issue for more options. Loading history...
535		/* @var $consumer ConsumerInterface */
536		$channel->basic_consume($this->name,
537		$consumer->getConsumerTag(),
538		$consumer->isNoLocal(),
539		$consumer->isNoAck(),
540		$consumer->isExclusive(),
541		$consumer->isNoWait(),
542		function (AMQPMessage $msg) use ($consumer) {
543		$consumer->callback($msg);
544		},
545		$consumer->getTicket(),
546		$consumer->getArguments());
547		}
548		}
549		}
550

thecodingmachine / oo-amqp-client