ExchangeTest::testExchange() - Code Metrics - Inspection of "Working on tests" - thecodingmachine/oo-amqp-client - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — 1.0 ( 3cba8a...ca5b13 )

by David

created 2016-07-07 13:51 UTC

ExchangeTest::testExchange() A

↳ Parent: ExchangeTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	14
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	14
rs	9.4285
cc	1
eloc	8
nc	1
nop	0

<?php


namespace Mouf\AmqpClient\Objects;


use Mouf\AmqpClient\Client;

class ExchangeTest extends \PHPUnit_Framework_TestCase
{
    public function testExchange()
    {
        global $rabbitmq_host;
function myFunction($a, $b) {
    // Do something
}
        global $rabbitmq_port;
function myFunction($a, $b) {
    // Do something
}
        global $rabbitmq_user;
function myFunction($a, $b) {
    // Do something
}
        global $rabbitmq_password;
function myFunction($a, $b) {
    // Do something
}

        $client = new Client($rabbitmq_host, $rabbitmq_port, $rabbitmq_user, $rabbitmq_password);
        $client->setPrefetchCount(1);

        $exchange = new Exchange('test_exchange', 'fanout');
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);


    }
}


Push — 1.0 ( 3cba8a...ca5b13 )

ExchangeTest::testExchange() A

Complexity

Size

Duplication

Importance

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1			<?php
2
3
4			namespace Mouf\AmqpClient\Objects;
5
6
7			use Mouf\AmqpClient\Client;
8
9			class ExchangeTest extends \PHPUnit_Framework_TestCase
10			{
11			public function testExchange()
12			{
13			global $rabbitmq_host;
			0 ignored issues – show Compatibility Best Practice introduced 2016-07-07 13:54 UTC by Report Bug Copy Issue Report Use of `global` functionality is not recommended; it makes your code harder to test, and less reusable. Instead of relying on `global` state, we recommend one of these alternatives: 1. Pass all data via parameters function myFunction($a, $b) { // Do something } 2. Create a class that maintains your state class MyClass { private $a; private $b; public function __construct($a, $b) { $this->a = $a; $this->b = $b; } public function myFunction() { // Do something } } Loading history...
14			global $rabbitmq_port;
			0 ignored issues – show Compatibility Best Practice introduced 2016-07-07 13:54 UTC by Report Bug Copy Issue Report Use of `global` functionality is not recommended; it makes your code harder to test, and less reusable. Instead of relying on `global` state, we recommend one of these alternatives: 1. Pass all data via parameters function myFunction($a, $b) { // Do something } 2. Create a class that maintains your state class MyClass { private $a; private $b; public function __construct($a, $b) { $this->a = $a; $this->b = $b; } public function myFunction() { // Do something } } Loading history...
15			global $rabbitmq_user;
			0 ignored issues – show Compatibility Best Practice introduced 2016-07-07 13:54 UTC by Report Bug Copy Issue Report Use of `global` functionality is not recommended; it makes your code harder to test, and less reusable. Instead of relying on `global` state, we recommend one of these alternatives: 1. Pass all data via parameters function myFunction($a, $b) { // Do something } 2. Create a class that maintains your state class MyClass { private $a; private $b; public function __construct($a, $b) { $this->a = $a; $this->b = $b; } public function myFunction() { // Do something } } Loading history...
16			global $rabbitmq_password;
			0 ignored issues – show Compatibility Best Practice introduced 2016-07-07 13:54 UTC by Report Bug Copy Issue Report Use of `global` functionality is not recommended; it makes your code harder to test, and less reusable. Instead of relying on `global` state, we recommend one of these alternatives: 1. Pass all data via parameters function myFunction($a, $b) { // Do something } 2. Create a class that maintains your state class MyClass { private $a; private $b; public function __construct($a, $b) { $this->a = $a; $this->b = $b; } public function myFunction() { // Do something } } Loading history...
17
18			$client = new Client($rabbitmq_host, $rabbitmq_port, $rabbitmq_user, $rabbitmq_password);
19			$client->setPrefetchCount(1);
20
21			$exchange = new Exchange('test_exchange', 'fanout');
			0 ignored issues – show Bug introduced 2016-07-07 13:54 UTC by Report Bug Copy Issue Report The call to `Exchange::__construct()` misses a required argument `$type`. This check looks for function calls that miss required arguments. Loading history... Documentation introduced 2016-07-07 13:54 UTC by Report Bug Copy Issue Report `'test_exchange'` is of type `string`, but the function expects a `object<Mouf\AmqpClient\Client>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history... Unused Code introduced 2016-07-07 13:54 UTC by Report Bug Copy Issue Report `$exchange` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
22
23
24			}
25			}
26

thecodingmachine / oo-amqp-client

Push — 1.0 ( 3cba8a...ca5b13 )

ExchangeTest::testExchange() A

Complexity

Size

Duplication

Importance

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

1. Pass all data via parameters

2. Create a class that maintains your state

Duplication Side-by-Side

Filter issues like