Mouf\AmqpClient\Commands\PublishCommand

Complexity

Total Complexity

6

Size/Duplication

Total Lines	60
Duplicated Lines	0 %

Coupling/Cohesion

Components	2
Dependencies	5

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	5	1
A	configure()	0	13	1
A	execute()	0	23	4

<?php

namespace Mouf\AmqpClient\Commands;

use Mouf\AmqpClient\Client;
use Mouf\AmqpClient\Objects\Message;
use Symfony\Component\Console\Command\Command;
use Symfony\Component\Console\Input\InputArgument;
use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Input\InputOption;
use Symfony\Component\Console\Output\OutputInterface;

class PublishCommand extends Command
{
    /**
     * @var Client
     */
    private $client;

    /**
     * @param Client $client
     */
    public function __construct(Client $client)
    {
        $this->client = $client;
        parent::__construct();
    }

    /**
     * {@inheritdoc}
     */
    protected function configure()
    {
        $this
            ->setName('amqp:publish')
            ->setDescription('Send a message on a AMQP (RabbitMQ) bus.')
            ->setHelp('Reads a message from STDIN and sends it on the bus to the given exchange.')
            ->addArgument('exchange', InputArgument::REQUIRED, 'the target exchange')
            ->addArgument('filename', InputArgument::OPTIONAL, 'the file to send on the bus (if not passed, data is read from STDIN)')
            ->addOption('routing_key', 'k', InputOption::VALUE_REQUIRED, 'the routing key of the message', 'key')
            ->addOption('mandatory', 'm', InputOption::VALUE_NONE, 'set the mandatory bit on the AMQP message')
            ->addOption('immediate', 'i', InputOption::VALUE_NONE, 'set the immediate bit on the AMQP message')
            ->addOption('ticket', 't', InputOption::VALUE_REQUIRED, 'set the ticket number');
    }

    /**
     * {@inheritdoc}
     */
    protected function execute(InputInterface $input, OutputInterface $output)
    {
        $channel = $this->client->getChannel();

        $filename = $input->getArgument('filename');

$filename is not used, you could remove the assignment.

        if ($filename = $input->getArgument('filename')) {
            $contents = file_get_contents($filename);
        } elseif (0 === ftell(STDIN)) {
            $contents = '';
            while (!feof(STDIN)) {
                $contents .= fread(STDIN, 1024);
            }
        } else {
            throw new \RuntimeException('Please provide a filename or pipe message to STDIN.');
        }

        $routingKey = $input->getOption('routing_key');
        $mandatory = $input->getOption('mandatory');
        $immediate = $input->getOption('immediate');
        $ticket = $input->getOption('ticket');

        $channel->basic_publish((new Message($contents))->toAMQPMessage(), $input->getArgument('exchange'), $routingKey, $mandatory, $immediate, $ticket);

It seems like $input->getArgument('exchange') targeting Symfony\Component\Console\Input\InputInterface::getArgument() can also be of type array<integer,string> or null; however, PhpAmqpLib\Channel\AMQPChannel::basic_publish() does only seem to accept string, maybe add an additional type check?

    }
}