SplashDefaultRouterTest::testRoute() - Code Metrics - Inspection of "Code cleanup and work on filters" - thecodingmachine/mvc.splash-common - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — fetcher_factories ( 40fc6e...10a56f )

by David

created 2016-05-23 17:02 UTC

SplashDefaultRouterTest::testRoute() B

↳ Parent: SplashDefaultRouterTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	46
Code Lines	30

Duplication

Lines	0
Ratio	0 %

Importance

Changes	4
Bugs	0	Features	0

Metric	Value
c	4
b	0
f	0
dl	0
loc	46
rs	8.9411
cc	1
eloc	30
nc	1
nop	0

<?php

namespace Mouf\Mvc\Splash\Routers;

use Doctrine\Common\Annotations\AnnotationReader;
use Doctrine\Common\Annotations\AnnotationRegistry;
use Mouf\Mvc\Splash\Controllers\HttpErrorsController;
use Mouf\Mvc\Splash\Exception\PageNotFoundException;
use Mouf\Mvc\Splash\Exception\SplashMissingParameterException;
use Mouf\Mvc\Splash\Fixtures\TestController2;
use Mouf\Mvc\Splash\Fixtures\TestFilteredController;
use Mouf\Mvc\Splash\Services\ControllerRegistry;
use Mouf\Mvc\Splash\Services\ParameterFetcherRegistry;
use Mouf\Mvc\Splash\Services\SplashUtils;
use Mouf\Mvc\Splash\Utils\SplashException;
use Mouf\Picotainer\Picotainer;
use Psr\Cache\CacheItemPoolInterface;
use Zend\Diactoros\Response\HtmlResponse;
use Zend\Diactoros\Response\JsonResponse;
use Zend\Diactoros\Response\RedirectResponse;
use Zend\Diactoros\ServerRequest;

class SplashDefaultRouterTest extends \PHPUnit_Framework_TestCase
{
    protected function setUp()
    {
        $loader = require __DIR__.'../../../../../../vendor/autoload.php';
        AnnotationRegistry::registerLoader(array($loader, 'loadClass'));
    }

    public function testRoute()
    {
        $container = new Picotainer([
            'controller' => function () {
                return new TestController2();
            },
        ]);
        $parameterFetcherRegistry = ParameterFetcherRegistry::buildDefaultControllerRegistry();
        $controllerRegistry = new ControllerRegistry($container, $parameterFetcherRegistry, new AnnotationReader(), ['controller']);
        $defaultRouter = new SplashDefaultRouter($container, [
            $controllerRegistry,
        ], $parameterFetcherRegistry);

        $request = new ServerRequest([], [], '/foo/var/bar', 'GET', 'php://input',
            [],
            [],
            ['id' => 42]
            );
        $response = new HtmlResponse('');
        $response = $defaultRouter($request, $response);
        $this->assertInstanceOf(JsonResponse::class, $response);
        /* @var $response JsonResponse */
        $decodedResponse = json_decode((string) $response->getBody(), true);
        $this->assertEquals(42, $decodedResponse['id']);
        $this->assertEquals('var', $decodedResponse['var']);
        $this->assertEquals(42, $decodedResponse['id2']);
        $this->assertEquals(42, $decodedResponse['opt']);

        // Now, let's test the redirect
        $request = new ServerRequest([], [], '/foo/var/bar/', 'GET', 'php://input',
            [],
            [],
            ['id' => 42]
        );
        $response = new HtmlResponse('');
        $response = $defaultRouter($request, $response);
        $this->assertInstanceOf(RedirectResponse::class, $response);
        $this->assertEquals('/foo/var/bar', $response->getHeader('Location')[0]);

        // Now, let's test the second kind of redirect
        $request = new ServerRequest([], [], '/controller', 'GET');
        $response = new HtmlResponse('');
        $response = $defaultRouter($request, $response);
        $this->assertInstanceOf(RedirectResponse::class, $response);
        $this->assertEquals('/controller/', $response->getHeader('Location')[0]);
    }

    public function testUnknownRoute()
    {
        $container = new Picotainer([
        ]);
        $parameterFetcherRegistry = ParameterFetcherRegistry::buildDefaultControllerRegistry();
        $defaultRouter = new SplashDefaultRouter($container, [], $parameterFetcherRegistry);

        $request = new ServerRequest([], [], '/foo', 'GET');
        $response = new HtmlResponse('');
        $response = $defaultRouter($request, $response, function () {
            return new HtmlResponse('Not found', 404);
        });
        $this->assertInstanceOf(HtmlResponse::class, $response);
        /* @var $response HtmlResponse */
        $this->assertEquals(404, $response->getStatusCode());
        $this->assertEquals('Not found', (string) $response->getBody());

        // Now, let's retry without a $out parameter and let's check we get an exception
        $this->expectException(PageNotFoundException::class);
        $response = $defaultRouter($request, $response);
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
    }

    public function testUnknownRouteWith404Handler()
    {
        $container = new Picotainer([
        ]);
        $parameterFetcherRegistry = ParameterFetcherRegistry::buildDefaultControllerRegistry();
        $defaultRouter = new SplashDefaultRouter($container, [], $parameterFetcherRegistry);
        $errorsController = HttpErrorsController::createDefault();
        $defaultRouter->setHttp404Handler($errorsController);

        $request = new ServerRequest([], [], '/foo', 'GET');
        $response = new HtmlResponse('');
        $response = $defaultRouter($request, $response);
        /* @var $response HtmlResponse */

        // Now, let's retry without a $out parameter and let's check we get an exception
        $response = $defaultRouter($request, $response);
        $this->assertEquals(404, $response->getStatusCode());
    }

    public function testRootUrlError()
    {
        $container = new Picotainer([
        ]);
        $parameterFetcherRegistry = ParameterFetcherRegistry::buildDefaultControllerRegistry();
        $defaultRouter = new SplashDefaultRouter($container, [], $parameterFetcherRegistry, null, null, SplashUtils::MODE_STRICT, true, '/baseUrl/');

        $request = new ServerRequest([], [], '/foo', 'GET');
        $response = new HtmlResponse('');
        $this->expectException(SplashException::class);
        $response = $defaultRouter($request, $response);
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
    }

    public function testMissingCompulsoryParameter()

    {
        $container = new Picotainer([
            'controller' => function () {
                return new TestController2();
            },
        ]);
        $parameterFetcherRegistry = ParameterFetcherRegistry::buildDefaultControllerRegistry();
        $controllerRegistry = new ControllerRegistry($container, $parameterFetcherRegistry, new AnnotationReader(), ['controller']);
        $defaultRouter = new SplashDefaultRouter($container, [
            $controllerRegistry,
        ], $parameterFetcherRegistry);

        // We need an ID parameter
        $request = new ServerRequest([], [], '/foo/var/bar', 'GET');
        $response = new HtmlResponse('');
        $this->expectException(SplashMissingParameterException::class);
        $response = $defaultRouter($request, $response);
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
    }

    public function testMissingCompulsoryParameterWithHandler()

    {
        $container = new Picotainer([
            'controller' => function () {
                return new TestController2();
            },
        ]);
        $parameterFetcherRegistry = ParameterFetcherRegistry::buildDefaultControllerRegistry();
        $controllerRegistry = new ControllerRegistry($container, $parameterFetcherRegistry, new AnnotationReader(), ['controller']);
        $defaultRouter = new SplashDefaultRouter($container, [
            $controllerRegistry,
        ], $parameterFetcherRegistry);

        $errorsController = HttpErrorsController::createDefault();
        $defaultRouter->setHttp400Handler($errorsController);

        // We need an ID parameter
        $request = new ServerRequest([], [], '/foo/var/bar', 'GET');
        $response = new HtmlResponse('');
        $response = $defaultRouter($request, $response);
        $this->assertEquals(400, $response->getStatusCode());
    }

    public function testExceptionWithHandler()

    {
        $container = new Picotainer([
            'controller' => function () {
                return new TestController2();
            },
        ]);
        $parameterFetcherRegistry = ParameterFetcherRegistry::buildDefaultControllerRegistry();
        $controllerRegistry = new ControllerRegistry($container, $parameterFetcherRegistry, new AnnotationReader(), ['controller']);
        $defaultRouter = new SplashDefaultRouter($container, [
            $controllerRegistry,
        ], $parameterFetcherRegistry);

        $errorsController = HttpErrorsController::createDefault();
        $defaultRouter->setHttp500Handler($errorsController);

        // We need an ID parameter
        $request = new ServerRequest([], [], '/controller/triggerException', 'GET');
        $response = new HtmlResponse('');
        $response = $defaultRouter($request, $response);
        $this->assertEquals(500, $response->getStatusCode());
    }

    public function testPurgeUrlCache()
    {
        $cache = $this->prophesize(CacheItemPoolInterface::class);
        $cache->deleteItem('splashUrlNodes')->shouldBeCalled();

        $container = new Picotainer([]);
        $parameterFetcherRegistry = ParameterFetcherRegistry::buildDefaultControllerRegistry();
        $defaultRouter = new SplashDefaultRouter($container, [], $parameterFetcherRegistry, $cache->reveal());
        $defaultRouter->purgeUrlsCache();
    }

    public function testFilters()

    {
        $container = new Picotainer([
            'controller' => function () {
                return new TestFilteredController();
            },
        ]);
        $parameterFetcherRegistry = ParameterFetcherRegistry::buildDefaultControllerRegistry();
        $controllerRegistry = new ControllerRegistry($container, $parameterFetcherRegistry, new AnnotationReader(), ['controller']);
        $defaultRouter = new SplashDefaultRouter($container, [
            $controllerRegistry,
        ], $parameterFetcherRegistry);

        $request = new ServerRequest([], [], '/foo', 'GET');
        $response = new HtmlResponse('');
        $response = $defaultRouter($request, $response);
        $this->assertEquals("42bar", (string) $response->getBody());
    }
}


1		<?php
2
3		namespace Mouf\Mvc\Splash\Routers;
4
5		use Doctrine\Common\Annotations\AnnotationReader;
6		use Doctrine\Common\Annotations\AnnotationRegistry;
7		use Mouf\Mvc\Splash\Controllers\HttpErrorsController;
8		use Mouf\Mvc\Splash\Exception\PageNotFoundException;
9		use Mouf\Mvc\Splash\Exception\SplashMissingParameterException;
10		use Mouf\Mvc\Splash\Fixtures\TestController2;
11		use Mouf\Mvc\Splash\Fixtures\TestFilteredController;
12		use Mouf\Mvc\Splash\Services\ControllerRegistry;
13		use Mouf\Mvc\Splash\Services\ParameterFetcherRegistry;
14		use Mouf\Mvc\Splash\Services\SplashUtils;
15		use Mouf\Mvc\Splash\Utils\SplashException;
16		use Mouf\Picotainer\Picotainer;
17		use Psr\Cache\CacheItemPoolInterface;
18		use Zend\Diactoros\Response\HtmlResponse;
19		use Zend\Diactoros\Response\JsonResponse;
20		use Zend\Diactoros\Response\RedirectResponse;
21		use Zend\Diactoros\ServerRequest;
22
23		class SplashDefaultRouterTest extends \PHPUnit_Framework_TestCase
24		{
25		protected function setUp()
26		{
27		$loader = require __DIR__.'../../../../../../vendor/autoload.php';
28		AnnotationRegistry::registerLoader(array($loader, 'loadClass'));
29		}
30
31		public function testRoute()
32		{
33		$container = new Picotainer([
34		'controller' => function () {
35		return new TestController2();
36		},
37		]);
38		$parameterFetcherRegistry = ParameterFetcherRegistry::buildDefaultControllerRegistry();
39		$controllerRegistry = new ControllerRegistry($container, $parameterFetcherRegistry, new AnnotationReader(), ['controller']);
40		$defaultRouter = new SplashDefaultRouter($container, [
41		$controllerRegistry,
42		], $parameterFetcherRegistry);
43
44		$request = new ServerRequest([], [], '/foo/var/bar', 'GET', 'php://input',
45		[],
46		[],
47		['id' => 42]
48		);
49		$response = new HtmlResponse('');
50		$response = $defaultRouter($request, $response);
51		$this->assertInstanceOf(JsonResponse::class, $response);
52		/* @var $response JsonResponse */
53		$decodedResponse = json_decode((string) $response->getBody(), true);
54		$this->assertEquals(42, $decodedResponse['id']);
55		$this->assertEquals('var', $decodedResponse['var']);
56		$this->assertEquals(42, $decodedResponse['id2']);
57		$this->assertEquals(42, $decodedResponse['opt']);
58
59		// Now, let's test the redirect
60		$request = new ServerRequest([], [], '/foo/var/bar/', 'GET', 'php://input',
61		[],
62		[],
63		['id' => 42]
64		);
65		$response = new HtmlResponse('');
66		$response = $defaultRouter($request, $response);
67		$this->assertInstanceOf(RedirectResponse::class, $response);
68		$this->assertEquals('/foo/var/bar', $response->getHeader('Location')[0]);
69
70		// Now, let's test the second kind of redirect
71		$request = new ServerRequest([], [], '/controller', 'GET');
72		$response = new HtmlResponse('');
73		$response = $defaultRouter($request, $response);
74		$this->assertInstanceOf(RedirectResponse::class, $response);
75		$this->assertEquals('/controller/', $response->getHeader('Location')[0]);
76		}
77
78		public function testUnknownRoute()
79		{
80		$container = new Picotainer([
81		]);
82		$parameterFetcherRegistry = ParameterFetcherRegistry::buildDefaultControllerRegistry();
83		$defaultRouter = new SplashDefaultRouter($container, [], $parameterFetcherRegistry);
84
85		$request = new ServerRequest([], [], '/foo', 'GET');
86		$response = new HtmlResponse('');
87		$response = $defaultRouter($request, $response, function () {
88		return new HtmlResponse('Not found', 404);
89		});
90		$this->assertInstanceOf(HtmlResponse::class, $response);
91		/* @var $response HtmlResponse */
92		$this->assertEquals(404, $response->getStatusCode());
93		$this->assertEquals('Not found', (string) $response->getBody());
94
95		// Now, let's retry without a $out parameter and let's check we get an exception
96		$this->expectException(PageNotFoundException::class);
97		$response = $defaultRouter($request, $response);
		0 ignored issues – show Unused Code introduced 2016-05-23 17:04 UTC by Report Bug Copy Issue Report `$response` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
98		}
99
100		public function testUnknownRouteWith404Handler()
101		{
102		$container = new Picotainer([
103		]);
104		$parameterFetcherRegistry = ParameterFetcherRegistry::buildDefaultControllerRegistry();
105		$defaultRouter = new SplashDefaultRouter($container, [], $parameterFetcherRegistry);
106		$errorsController = HttpErrorsController::createDefault();
107		$defaultRouter->setHttp404Handler($errorsController);
108
109		$request = new ServerRequest([], [], '/foo', 'GET');
110		$response = new HtmlResponse('');
111		$response = $defaultRouter($request, $response);
112		/* @var $response HtmlResponse */
113
114		// Now, let's retry without a $out parameter and let's check we get an exception
115		$response = $defaultRouter($request, $response);
116		$this->assertEquals(404, $response->getStatusCode());
117		}
118
119		public function testRootUrlError()
120		{
121		$container = new Picotainer([
122		]);
123		$parameterFetcherRegistry = ParameterFetcherRegistry::buildDefaultControllerRegistry();
124		$defaultRouter = new SplashDefaultRouter($container, [], $parameterFetcherRegistry, null, null, SplashUtils::MODE_STRICT, true, '/baseUrl/');
125
126		$request = new ServerRequest([], [], '/foo', 'GET');
127		$response = new HtmlResponse('');
128		$this->expectException(SplashException::class);
129		$response = $defaultRouter($request, $response);
		0 ignored issues – show Unused Code introduced 2016-05-23 15:41 UTC by Report Bug Copy Issue Report `$response` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
130		}
131
132	View Code Duplication	public function testMissingCompulsoryParameter()
		0 ignored issues – show Duplication introduced 2016-05-23 17:04 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
133		{
134		$container = new Picotainer([
135		'controller' => function () {
136		return new TestController2();
137		},
138		]);
139		$parameterFetcherRegistry = ParameterFetcherRegistry::buildDefaultControllerRegistry();
140		$controllerRegistry = new ControllerRegistry($container, $parameterFetcherRegistry, new AnnotationReader(), ['controller']);
141		$defaultRouter = new SplashDefaultRouter($container, [
142		$controllerRegistry,
143		], $parameterFetcherRegistry);
144
145		// We need an ID parameter
146		$request = new ServerRequest([], [], '/foo/var/bar', 'GET');
147		$response = new HtmlResponse('');
148		$this->expectException(SplashMissingParameterException::class);
149		$response = $defaultRouter($request, $response);
		0 ignored issues – show Unused Code introduced 2016-05-23 15:41 UTC by Report Bug Copy Issue Report `$response` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
150		}
151
152	View Code Duplication	public function testMissingCompulsoryParameterWithHandler()
		0 ignored issues – show Duplication introduced 2016-05-23 15:41 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
153		{
154		$container = new Picotainer([
155		'controller' => function () {
156		return new TestController2();
157		},
158		]);
159		$parameterFetcherRegistry = ParameterFetcherRegistry::buildDefaultControllerRegistry();
160		$controllerRegistry = new ControllerRegistry($container, $parameterFetcherRegistry, new AnnotationReader(), ['controller']);
161		$defaultRouter = new SplashDefaultRouter($container, [
162		$controllerRegistry,
163		], $parameterFetcherRegistry);
164
165		$errorsController = HttpErrorsController::createDefault();
166		$defaultRouter->setHttp400Handler($errorsController);
167
168		// We need an ID parameter
169		$request = new ServerRequest([], [], '/foo/var/bar', 'GET');
170		$response = new HtmlResponse('');
171		$response = $defaultRouter($request, $response);
172		$this->assertEquals(400, $response->getStatusCode());
173		}
174
175	View Code Duplication	public function testExceptionWithHandler()
		0 ignored issues – show Duplication introduced 2016-05-23 15:41 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
176		{
177		$container = new Picotainer([
178		'controller' => function () {
179		return new TestController2();
180		},
181		]);
182		$parameterFetcherRegistry = ParameterFetcherRegistry::buildDefaultControllerRegistry();
183		$controllerRegistry = new ControllerRegistry($container, $parameterFetcherRegistry, new AnnotationReader(), ['controller']);
184		$defaultRouter = new SplashDefaultRouter($container, [
185		$controllerRegistry,
186		], $parameterFetcherRegistry);
187
188		$errorsController = HttpErrorsController::createDefault();
189		$defaultRouter->setHttp500Handler($errorsController);
190
191		// We need an ID parameter
192		$request = new ServerRequest([], [], '/controller/triggerException', 'GET');
193		$response = new HtmlResponse('');
194		$response = $defaultRouter($request, $response);
195		$this->assertEquals(500, $response->getStatusCode());
196		}
197
198		public function testPurgeUrlCache()
199		{
200		$cache = $this->prophesize(CacheItemPoolInterface::class);
201		$cache->deleteItem('splashUrlNodes')->shouldBeCalled();
202
203		$container = new Picotainer([]);
204		$parameterFetcherRegistry = ParameterFetcherRegistry::buildDefaultControllerRegistry();
205		$defaultRouter = new SplashDefaultRouter($container, [], $parameterFetcherRegistry, $cache->reveal());
206		$defaultRouter->purgeUrlsCache();
207		}
208
209	View Code Duplication	public function testFilters()
		0 ignored issues – show Duplication introduced 2016-05-23 17:04 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
210		{
211		$container = new Picotainer([
212		'controller' => function () {
213		return new TestFilteredController();
214		},
215		]);
216		$parameterFetcherRegistry = ParameterFetcherRegistry::buildDefaultControllerRegistry();
217		$controllerRegistry = new ControllerRegistry($container, $parameterFetcherRegistry, new AnnotationReader(), ['controller']);
218		$defaultRouter = new SplashDefaultRouter($container, [
219		$controllerRegistry,
220		], $parameterFetcherRegistry);
221
222		$request = new ServerRequest([], [], '/foo', 'GET');
223		$response = new HtmlResponse('');
224		$response = $defaultRouter($request, $response);
225		$this->assertEquals("42bar", (string) $response->getBody());
226		}
227		}
228

thecodingmachine / mvc.splash-common

Push — fetcher_factories ( 40fc6e...10a56f )

SplashDefaultRouterTest::testRoute() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like