MetaHydrator\Parser\DateTimeParser

Complexity

Total Complexity

12

Size/Duplication

Total Lines	53
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes

0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	getFormat()	0	1	1
A	setFormat()	0	1	1
A	getIgnoreWarnings()	0	1	1
A	setIgnoreWarnings()	0	1	1
A	__construct()	0	6	1
C	parse()	0	22	7

<?php
namespace MetaHydrator\Parser;

use MetaHydrator\Exception\ParsingException;

/**
 * An implementation of ParserInterface used to reconstruct DateTime objects from a string
 */
class DateTimeParser extends AbstractParser
{
    /** @var null|string */
    private $format;
    public function getFormat() { return $this->format; }
    public function setFormat(string $format) { $this->format = $format; }

    /** @var bool */
    private $ignoreWarnings;
    public function getIgnoreWarnings() { return $this->ignoreWarnings; }
    public function setIgnoreWarnings(bool $ignoreWarnings) { $this->ignoreWarnings = $ignoreWarnings; }

    /**
     * DateTimeParser constructor.
     * @param string|null $format
     * @param bool $ignoreWarnings
     * @param string $errorMessage
     */
    public function __construct(string $format = null, bool $ignoreWarnings = false, string $errorMessage = "")
    {
        parent::__construct($errorMessage);
        $this->format = $format;
        $this->ignoreWarnings = $ignoreWarnings;
    }

    /**
     * @param mixed $rawValue
     * @return \DateTime
     * @throws ParsingException
     */
    public function parse($rawValue)
    {
        if ($rawValue === null || $rawValue === '') {
            return null;
        }

        if ($this->format) {

The expression $this->format of type null|string is loosely compared to true; this is ambiguous if the string can be empty. You might want to explicitly use !== null instead.

            $date = \DateTime::createFromFormat($this->format, $rawValue);

The expression \DateTime::createFromFormat($this->format, $rawValue); of type DateTime|false adds false to the return on line 59 which is incompatible with the return type documented by MetaHydrator\Parser\DateTimeParser::parse of type DateTime|null. It seems like you forgot to handle an error condition.

        } else {
            $date = new \DateTime($rawValue);
        }

        $errors = \DateTime::getLastErrors();
        if ($errors['error_count'] > 0) {
            $this->throw();
        }
        if (!$this->ignoreWarnings && $errors['warning_count'] > 0) {
            $this->throw();
        }

        return $date;
    }
}