SQLParser\Node\AbstractManyInstancesOperator

Complexity

Total Complexity

13

Size/Duplication

Total Lines	96
Duplicated Lines	28.13 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes	8
Bugs	0	Features	0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	getOperands()	0	4	1
A	setOperands()	0	7	2
A	toInstanceDescriptor()	7	7	1
A	toSql()	0	12	3
	getOperatorSymbol()	0	1	?
B	walk()	20	20	6

<?php

namespace SQLParser\Node;

use Doctrine\DBAL\Connection;
use Mouf\MoufManager;
use Mouf\MoufInstanceDescriptor;
use SQLParser\Node\Traverser\NodeTraverser;
use SQLParser\Node\Traverser\VisitorInterface;

/**
 * This class represents an operator with many operators (AND, OR...) in an SQL expression.
 *
 * @author David Négrier <d.negrier@thecodingmachine.com>
 */
abstract class AbstractManyInstancesOperator implements NodeInterface
{
    private $operands;

    public function getOperands()
    {
        return $this->operands;
    }

    /**
     * Sets the operands.
     *
     * @Important
     * //@param array<array<NodeInterface>> $operands
     *
     * @param array<NodeInterface> $operands
     */
    public function setOperands($operands)
    {
        if (!is_array($operands)) {
            $operands = array($operands);
        }
        $this->operands = $operands;
    }

    /**
     * Returns a Mouf instance descriptor describing this object.
     *
     * @param MoufManager $moufManager
     *
     * @return MoufInstanceDescriptor
     */
    public function toInstanceDescriptor(MoufManager $moufManager)

This method seems to be duplicated in your project.

    {
        $instanceDescriptor = $moufManager->createInstance(get_called_class());
        $instanceDescriptor->getProperty('operands')->setValue(NodeFactory::nodeToInstanceDescriptor($this->operands, $moufManager));

        return $instanceDescriptor;
    }

    /**
     * Renders the object as a SQL string.
     *
     * @param Connection $dbConnection
     * @param array      $parameters
     * @param number     $indent
     * @param int        $conditionsMode
     *
     * @return string
     */
    public function toSql(array $parameters = array(), Connection $dbConnection = null, $indent = 0, $conditionsMode = self::CONDITION_APPLY)
    {
        $sqlOperands = array();
        foreach ($this->operands as $operand) {
            $sql = NodeFactory::toSql($operand, $dbConnection, $parameters, ' ', true, $indent, $conditionsMode);
            if ($sql != null) {

It seems like you are loosely comparing $sql of type null|string against null; this is ambiguous if the string can be empty. Consider using a strict comparison !== instead.

                $sqlOperands[] = $sql;
            }
        }

        return implode("\n".str_repeat(' ', $indent).$this->getOperatorSymbol().' ', $sqlOperands);
    }

    /**
     * Walks the tree of nodes, calling the visitor passed in parameter.
     *
     * @param VisitorInterface $visitor
     */
    public function walk(VisitorInterface $visitor)

This method seems to be duplicated in your project.

    {
        $node = $this;
        $result = $visitor->enterNode($node);
        if ($result instanceof NodeInterface) {
            $node = $result;
        }
        if ($result !== NodeTraverser::DONT_TRAVERSE_CHILDREN) {
            foreach ($this->operands as $key => $operand) {
                $result2 = $operand->walk($visitor);
                if ($result2 === NodeTraverser::REMOVE_NODE) {
                    unset($this->operands[$key]);
                } elseif ($result2 instanceof NodeInterface) {
                    $this->operands[$key] = $result2;
                }
            }
        }

        return $visitor->leaveNode($node);
    }

    /**
     * Returns the symbol for this operator.
     *
     * @return string
     */
    abstract protected function getOperatorSymbol();
}